From 14ff890761a734cd3061f75777e2a10595ab6261 Mon Sep 17 00:00:00 2001 From: bchanot Date: Mon, 2 Nov 2026 19:49:38 +0100 Subject: [PATCH] chore(memory): V1-2.5 checkpoint, LRN on inert drawer and GoTrue MFA, journal --- .claude/memory/journal.md | 1 + .claude/memory/learnings.md | 10 ++++++++++ .claude/tasks/TODO.md | 4 ++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index d4cd87de..f6a4da70 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -510,3 +510,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp - 2026-11-02 V1-2.4 final graphic corrections (owner brief after external review): 01 sheet-name search only (UX item 4 withdrawn; no repo trace of earlier 'no zone search'), 06 distinct failed/unavailable titles, 03 whole horse at opening, 05 1 024 px not device, 04 vertex wording, complement « Accès non autorisé » board. 9adbd3a, f9fc13c. Verifier ECARTS(1) = zip not built yet; built after. Labels open. Checkpoint, no approval. - 2026-11-02 V1-2.4 owner arbitrations: BDR-095 (sheet-name search replaces BDR-094 zone item, distinct failed/unavailable titles, V1-2.7 lists on failure_outcome), board 05 whole horse at 768 px, 24 common labels + owner arbitrations ratified, object_conflict kept open (meaning = hash mismatch). Verifier ECARTS(2) → ECARTS(1) → CONFORME 21/21 incl. archive -3.zip. No global graphic approval. - 2026-11-02 V1-2.4 GRAPHICAL APPROVED by owner (BDR-096): 12 boards + « Accès non autorisé » page, no board regenerated; object_conflict FR, L20 EN, L32 EN ratified, L14 confirmed; L15 2nd sentence + code messages open, checked at integration. Recorded contract §16.5/§17.9, maquettes contract, REVUE.md, design README, TODO. Next: V1-2.5 prerequisites. +- 2026-11-02 V1-2.5 built + tested on sandbox (A-K): MFA proofs 10/10 no STOP, M7 admin reads + deprecated fingerprint (BDR-097/098), access layer, shell/step-up/MFA UI, admin, catalogue, e2e A0 A1 S1 P1. pgTAP 1941, unit 66/148/655, e2e:shell 108+6 skip, check:all green. Security PASS; verifier ECARTS(7)->ECARTS(1)->ECARTS(1)->CONFORME. Phone e2e flake root-caused (inert closing drawer). DEV untouched, no merge. Checkpoint. diff --git a/.claude/memory/learnings.md b/.claude/memory/learnings.md index d18b7353..891f4e4a 100644 --- a/.claude/memory/learnings.md +++ b/.claude/memory/learnings.md @@ -767,3 +767,13 @@ Supersedes [[LRN-100]]. **Application**: quote every heredoc delimiter (`<<'EOF'`, `<<'PYEOF'`) unless expansion is wanted, pass values as arguments; prefer Write/Edit for prose. Run commands with an absolute, verified directory (`git -C `, `pnpm --dir `, `[ "$(pwd -P)" = ]` before acting); never `cd X && cmd &`. Validate the environment before any side effect (target URL, key issuer, container name) inside the script itself, so its safety never depends on cwd. Put these rules in every sub-agent brief that may run shell commands, with the explicit ban on running scripts from other worktrees. Supersedes [[LRN-102]]. + +## LRN-111 — Closing modal drawer leaves page inert: e2e typing lost until dialog gone (2026-11-02) +**Context**: V1-2.5 e2e P1 at 375 px: search fill lost 2/4 full runs (8 cards, not 1). Test clicked drawer link, saw heading + first card, filled search at once. +**Pattern**: native `` showModal kept mounted through motion AnimatePresence exit → page behind inert ~200 ms; Playwright fill there goes nowhere, intermittently under load. Fix in test: after drawer link click, `expect(dialog).toHaveCount(0)` before typing. Proof: 1/16 red repro, 32/32 after. +**Apply**: any e2e acting right after closing a modal drawer/dialog waits for it gone; flaky "input ignored" → suspect inert from closing modal first. Keep failure snapshot (check:all e2e:ui wipes test-results). + +## LRN-112 — GoTrue v2.197 MFA: aal2 needed for password/email change; factor removal downgrades only its sessions (2026-11-02) +**Context**: V1-2.5 sandbox proofs on GoTrue v2.197.0 (mfa-behaviour.sandbox.ts, IDENTITY.md §4.1). +**Pattern**: once a TOTP factor verified: password change and recovery-link reset refused at aal1 (401 insufficient_aal) → reset/change UI must step up first; email change same. Removing verified factor downgrades only sessions last verified with that factor; their access token keeps aal2 claim until expiry (has_mfa true, has_aal2_session false). supabase-js `mfa.listFactors().totp` hides unverified factors → read `all`. +**Apply**: never assume aal from claim alone for sensitive RPCs (session row check); any password/email flow on MFA accounts needs a step-up path; factor lists show unverified ones. diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index d2f8ed79..6213b556 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -654,7 +654,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] C5 four historical test reductions recorded in `.claude/audits/2026-11-01-v1-2-floor-reductions.md`: none hides a security coverage (O22 mirror removal and client gate, server gate tested; one false positive) - [x] C6 gates on 3c141c9 (check:all, test-db 1898, test 87, verify-e2e 10/10, e2e:avatar 5/5, e2e:shell 86, DEV untouched); targeted review PASS, 3 LOWs fixed, MEDIUM CPU-contention timeout + 3 LOWs open for owner; verifier ECARTS(1) (STORAGE §6 DEV pairing) → fixed 093083d, delta verifier CONFORME · C7 V1-2.4 scope `.claude/tasks/contracts/2026-11-01-v1-2-4-wireframes-scope.md` - [x] V1-2.4 wireframes (editor, review, admin entry): GRAPHICAL APPROVED 2026-11-02 (BDR-096; detail under S below) - - [ ] V1-2.5 started 2026-11-02 (brief « Validation propriétaire V1-2.4 »; prerequisites checked on 994b04e, contract §17.10; owner answers BDR-097: M7 admin reads, working-copy action in V1-2.5, EN « Permission »). Contract `.claude/tasks/contracts/2026-11-02-v1-2-5-admin-catalogue.md`, plan `.claude/tasks/plans/2026-11-02-v1-2-5.md`; sandbox only, no DEV, no worker on DEV, no merge; STOP at the V1-2.5 checkpoint + - [ ] V1-2.5 BUILT + TESTED on the sandbox, CHECKPOINT pending owner (5db85ff); started 2026-11-02 (brief « Validation propriétaire V1-2.4 »; prerequisites checked on 994b04e, contract §17.10; owner answers BDR-097: M7 admin reads, working-copy action in V1-2.5, EN « Permission »). Contract `.claude/tasks/contracts/2026-11-02-v1-2-5-admin-catalogue.md`, plan `.claude/tasks/plans/2026-11-02-v1-2-5.md`; sandbox only, no DEV, no worker on DEV, no merge; STOP at the V1-2.5 checkpoint - [x] A GoTrue MFA behaviour on the sandbox (C1): 10/10, no STOP; reset and password change need aal2 once a factor is verified (IDENTITY §4.1) (78791bf) - [x] B M7 sheet_admin_reads + pgTAP 022 (40) + types; fresh + upgrade from M6: 1938 pass (b0a4cbe) - [x] C core op sheet.empty + wasm + ts-rs; rust:check 2384, core-wasm 66 (bbab0e6) @@ -665,7 +665,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] H sheets list, creation, overview, working copy (C5) - [x] I catalogue list, sheet page, version page (C8); deprecated fingerprint fixed in M7 (BDR-098); app 650 (0176b31) - [x] J e2e:shell A0 A1 S1 P1 + access + MFA + axe + viewports (C11): full suite 108 passed, 6 skipped by design - - [ ] K docs, check:all, fresh verifier + security, memory, checkpoint (C10-C12) + - [x] K docs, check:all, fresh verifier + security, memory, checkpoint (C10-C12): security PASS (MEDIUM + LOW fixed), verifier ECARTS(7) → three delta rounds → CONFORME on e39f69e; check:all green; e2e:shell 108 + 6 skipped on cea0f1c; phone flake root-caused - [ ] V1-2.5 catalogue, admin space, rights, species, MFA · V1-2.6 editor level 1 · V1-2.7 preview, review, publication UI · V1-2.8 equine working copy and review preparation · V1-2.9 FR/EN acceptance and closure (owner checkpoints V1-2.3, V1-2.4, V1-2.6, V1-2.7, V1-2.8, V1-2.9 + each DEV operation of contract §16.11) ## Release readiness track (owner 2026-10-25, distinct from the functional roadmap; nothing here authorises a release or exposure)