chore(memory): BLK-013, LRN-095, journal and RR-11 for the avatar e2e sandbox bugfix
This commit is contained in:
1 parent
d3dfd03213
commit
09655b2552
4 files changed
+23
No files matched your search
@@ -102,3 +102,10 @@ Friction: JSON copy (6371523) had no in-app restore (Home picker PDF only; devto
|
||||
Root cause: copy shipped without restore path (round trip never tested in app); `internal` from draft read treated as transient core failure, no memory of trapping input; guard scoped to one route; session replacement unguarded since MVP.
|
||||
Solution: 9bd9aca (BDR-056). Evidence: round trip identical (3 golden reports, slot + import); fuzz 37k draft.restore 0 traps, OOM only ~50 MB drafts (5 MB worst = 0.4-0.8 GB wasm). Verifier CONFORME 10/10, security PASS 2 LOW, check:all green.
|
||||
Status: resolved 2026-10-17. Residuals: GC finalizer throws "memory access out of bounds" after stack-overflow trap (console only, live instance unaffected 50/50), ≤ 3 dead instances retained (~13.5 MB typical, ~4.5 MB each) until reload; raw lone surrogate in archive text quarantines readable draft (unreachable, session.rs); copy lacks archive envelope; iOS Safari likely ignores beforeunload (dialog + copy are protection there); Retry clicked during ms-long recovery → reload screen; re-importing copy of trapping draft re-traps (spends recovery); copy near 16 MiB may OOM low-memory device; storage full + confirmed replace + reload restores replaced draft; `internal` may come from handle rebuild (Retry reopens).
|
||||
|
||||
## BLK-013 — e2e:avatar on develop reached DEV (keys via supabase status, worker on DEV net, purge queue drained) (2026-11-02)
|
||||
- **Status**: resolved
|
||||
Friction: develop `pnpm e2e:avatar` = scripts/avatar-e2e.sh could reach DEV: keys via `supabase status -o env`, worker on supabase_network_faunosteo against DEV Kong, suite wrote accounts + drained whole purge queue (`expeditePurges` unscoped), psql on supabase_db_faunosteo. Same family as sheet-assets incidents 2026-11-01.
|
||||
Real cause: runner and suite knew no authorised target; URL, keys, container from env or DEV defaults.
|
||||
Solution: 3a4614b ports V1-2 sandbox runner (`db-sandbox.sh avatar-e2e`: loopback gateway 127.0.0.1:57800, worker in 600 env file, constants unconditional) + guarded suite (fixed URL, container, key issuer `db-sandbox`, per-run accounts); DEV runner deleted. d3dfd03: clients refuse redirects (`noRedirectFetch`, `redirect: 'error'`). Proofs a-j strace, 2 × 5/5, log `.claude/audits/2026-11-02-avatar-e2e-sandbox-only.md`.
|
||||
Status: resolved for develop path after merge. NOT fixed in old checkouts: main checkout /home/bchanot/Documents/faunosteo (feature/v1-1-clients-animals) and worktree old-958228a still hold scripts/avatar-e2e.sh + old alias; `pnpm e2e:avatar` there targets DEV. Agents never run them; owner decides their fate.
|
||||
@@ -456,3 +456,6 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
|
||||
- Owner recette: 19 lines FR detailed, EN global + 4 at 375 px, isolation ok. RESP-01 global scroll = owner browser zoom (owner DEV measures). Real defect found on sandbox: long account e-mail widens dashboard cards (implicit grid track). Fix DashboardRoute + `e2e/shell/responsive.spec.ts` (fails on old code). LRN-094.
|
||||
- AVATAR-01 = class A: DEV worker stopped, row `uploaded` waits, message by design (STORAGE §4.4). Sandbox repro with temp gateway + worker on sandbox net: clean in 1.1 s. Side finding (pre-V1-1): full reload doesn't resume the waiting row, new save supersedes it. DEV read-only only.
|
||||
- Owner closure 2026-10-27: RESP-01 counter-check 6 PASS → closed; AVATAR-01 class A non-blocking, DEV worker stays off, Alice's waiting upload kept; AVATAR-02 ticket in TODO (no Gitea CLI). Pre-merge checkpoint, no merge.
|
||||
|
||||
## 2026-11-02
|
||||
- bugfix/avatar-e2e-sandbox-only: develop e2e:avatar → sandbox only (3a4614b, e8da0d9, d3dfd03). Proofs a-j strace with forged JWTs, 2 × 5/5, DEV untouched. Verifier CONFORME 10/10, security PASS ×2. BLK-013, LRN-095, TODO RR-11. Owner authorised merge into develop; worktree kept.
|
||||
@@ -651,3 +651,11 @@ Apply: SQL test touching a worker queue or shared bucket → neutralise or scope
|
||||
Context: V1-1 DEV acceptance RESP-01. Owner saw whole-page sideways scroll everywhere at 375 px (DevTools responsive). Sandbox sweep (Chromium mobile + desktop with scrollbars shown via `ignoreDefaultArgs: ['--hide-scrollbars']`, WebKit iPhone, Firefox; 280-430 px) found none at 375; owner then measured DEV with a console snippet (cw/sw + topmost offending boxes, classes only): no overflow without zoom → browser zoom was the cause. Same sweep with long account e-mails found a real defect: dashboard `grid gap-4 md:grid-cols-2` has no explicit column below md → implicit `auto` track = cards' min-content → `truncate` e-mail never truncates, cards past screen from ~31 chars at 320 px.
|
||||
Fix: `grid-cols-1` (minmax(0,1fr)) + e-mail wraps (`min-w-0 [overflow-wrap:anywhere]`). Test sweeps 320-430 + desktop with long values, proven failing on old code.
|
||||
Apply: overflow report → ask how observed (zoom, preset, device type), give owner a read-only console probe for DEV, reproduce with realistic max-length values on sandbox; a grid used as a single column on phones needs `grid-cols-1`, else one unbreakable value widens every card.
|
||||
|
||||
## LRN-095 — Port a safe runner verbatim; prove refusals with forged JWTs + strace; one-line gates.sh oracles (2026-11-02)
|
||||
Context: porting safe runner V1-2 → develop (bugfix/avatar-e2e-sandbox-only, 2026-11-02).
|
||||
Pattern 1: port by verbatim block extraction (`sed -n 'a,bp'` from reference worktree, by function name), oracle = python "chunk in file" per block + forbidden names absent; keeps protections intact, later merge rule = take reference file whole, check diff empty.
|
||||
Pattern 2: refusal proofs with FORGED unsigned JWTs (`base64url(header).base64url(payload).x`, iss varied), never DEV or sandbox secrets; strace `-f -e trace=connect,sendto,sendmsg` on bash/vitest binary (never via pnpm), curl positive control, one case per guard clause + mixed-issuer case; hostile DEV exports on positive run; watcher with filtered docker templates only (raw inspect leaks keys).
|
||||
Pattern 3: `gates.sh` CHECK = one line; heredoc / multi-line python is NOT parsed (silent NOT-MET "wanted PY"); use `python3 -I -c '…'`. Oracle wording must match doc wording ("names it" vs "invokes it").
|
||||
Pattern 4: `pkill -f <name>` kills own shell when the command line contains <name> (exit 144); use pid files or self-timed servers.
|
||||
Apply: any runner port, any "no IP connection" proof, any contract oracle.
|
||||
@@ -543,6 +543,11 @@ Inventory: `.claude/audits/2026-10-25-functional-inventory.md`. Each item: treat
|
||||
- [ ] RR-7 accessibility: WCAG target to set; dialog focus trap/restore (done V1-1.3, native modal dialog), close button 24 px, canvas zones keyboard-unreachable, axe test (done V1-1.3: e2e:ui, e2e:shell), D2/D5 Context7 items (RUST.md §10.14). Pre-existing serious axe findings let through by exact node in `apps/app/e2e/support/browser.ts` KNOWN_VIOLATIONS: LanguageSwitcher label-in-name (« FR » shown, « Passer en français » announced), top bar account link label-in-name (display name shown, « Mon compte » announced), DashboardRoute `dl` with a status row lacking dt/dd. Seen outside the scanned states: ObservationCard header `nested-interactive` + label-in-name (editor with an observation); moderate: duplicate `main` landmarks (App + routes), no h1 on Home
|
||||
- [ ] RR-8 mobile and end-to-end: real-browser e2e for sign-up, login, account, avatar, full editor flow, export, locale, mobile drawer (TEST_STRATEGY §1 `apps/app/e2e`); per-check device results (J1/J2 recorded as a whole)
|
||||
- [ ] RR-9 release 0.2.0 fate (Steps 3–6 on TS engines, 341 commits behind develop): ship, supersede, or rebase; sheet bundle default `none`
|
||||
- [ ] RR-11 sandbox-only e2e follow-ups (bugfix/avatar-e2e-sandbox-only 2026-11-02, BLK-013, LRN-095; audit `.claude/audits/2026-11-02-avatar-e2e-sandbox-only.md`):
|
||||
- [ ] V1-2 → develop merge: `scripts/db-sandbox.sh` conflicts (header, function block, dispatcher, sed range) → take V1-2's file whole, `git diff <V1-2 tip> -- scripts/db-sandbox.sh` empty; keep every protection (constants unconditional, `/dev/tcp` probe, `docker port` check, 600 worker env file); V1-2 adopts `noRedirectFetch` in the avatar suite (d3dfd03); doc lines reworded on develop → keep V1-2's text; registry IDs BLK-013 / LRN-095 collide with V1-2's numbering → renumber at integration
|
||||
- [ ] old checkouts still hold the DEV scripts (`scripts/avatar-e2e.sh`, old `sheet-assets-e2e.sh`): main checkout `/home/bchanot/Documents/faunosteo` (feature/v1-1-clients-animals, merged) and worktree `old-958228a`; `pnpm e2e:avatar` there targets DEV; agents never run them; owner decides (move main checkout to develop, `gitflow.sh delete`, worktree removal)
|
||||
- [ ] V1-2 session: rebuild `faunosteo_worker:dev` (`pnpm worker:image`, the tag now holds develop's build d841660a) and `pnpm db:sandbox up fresh` before its next sandbox run
|
||||
- [ ] residual LOW: every docker call follows `DOCKER_HOST` / context; `worker_env` read by the EXIT trap before assignment (`worker_env=` before `trap`); literal password of the two throwaway `up upgrade` accounts (db-sandbox.sh:182-184); gateway container less hardened than the worker (no `--cap-drop ALL` / `--read-only` / limits); shared container names across worktrees (a concurrent run is killed, fails closed); `NODE_USE_ENV_PROXY` proxy path (unset in every proof)
|
||||
- [ ] RR-10 census tools maintenance (LOW `#[ignore]` positions) and controlled oracle evolution on a new anatomical changeset
|
||||
|
||||
## Phase A — DONE (kept for reference)
|
||||
|
||||
Reference in new issue
Block a user