chore(contract): phase 4b final review [gated], answer 6-amended, PROOF corrections
This commit is contained in:
1 parent
a4d29ea9f2
commit
f620d8f894
2 files changed
+3
-2
No files matched your search
@@ -24,6 +24,7 @@ Brainstorm answers `[gated 2026-11-03]` (user: "oui" to recommendations 1-8):
|
||||
7. Consumers: /capitalize, /close and CAPITALIZE steps call it first; /commit-change calls it before dispatching commit-changer and passes the result; /hotfix stays silent unless the tool returns a new failure.
|
||||
8. The tool stays deferred like `route`; skills load it with `ToolSearch` once per session.
|
||||
2-amended `[gated 2026-11-04]` (noise gate, plan Task 7 step 3; user: option A): the distinctive line must hold an error-shaped word, matched case-insensitive on the redacted line by `error|fatal|cannot|can't|no such|not found|denied|failed|failure|unexpected|invalid|exception|traceback|panic|usage:|SC\d{4}|> \d+|assert`; a line without one is no line and the failure is dropped (same treatment as a letterless line). Measured on 14 days of transcripts (NOISE.md): 83 % noise on the shipped rule, every useful sample kept by the filter, 81 → 27 captures. Options B (no sub-agent capture) and C (ship as is) declined.
|
||||
6-amended `[gated 2026-11-04]` (final review I2; user: "corriger les trois"): the KEY=value name class admits digits (`OAUTH2_CLIENT_SECRET=`, `S3_SECRET=`, `TOKEN_V2=` redacted); a JWT (`eyJ…`.`eyJ…`.`sig`, three base64url parts) → `<redacted:jwt>`; `-u user:pass` / `--user user:pass`, `--password value` / `--password=value`, and `Authorization: (Basic|Bearer|token) value` → redacted. Oracles literal; secret-shaped fixtures built at runtime.
|
||||
|
||||
## ACCEPTANCE CRITERIA (seed, enriched at STEP 3 `[gated]`)
|
||||
1. A mod captures failures (scope decided at the brainstorm) as entries {normalized line, verbatim excerpt, command, tool, time}, redacted BEFORE storage, in a bounded store layout decided at the brainstorm (entries per session, bytes per entry, eviction of stale sessions, total under the 4 MiB `$.store` cap).
|
||||
@@ -70,6 +71,6 @@ STEP 3 gate `[gated 2026-11-04]` (user: "oui aux deux, lance"): plan r3 (`docs/s
|
||||
- .claude/tasks/TODO.md, .claude/tasks/plans/ (spike notes), docs/superpowers/{specs,plans} (transient)
|
||||
## PROOF (Task 9)
|
||||
- Step 0 (2026-11-04, user go): `~/.claude/memory.json` moved to `$CLAUDE_JOB_DIR/tmp/memory.json.off`; capture is on from the next session.
|
||||
- Step 1 headless (2026-11-04 12:08, `claude -p --model haiku`, live user settings, mod `memory@skills-dir`, scratch repo `$CLAUDE_JOB_DIR/tmp/proof9/repo.gYdo` on `feature/probe`, `GITFLOW_NO_PUSH=1`, fixture `.claude/memory/blockers.md` with one unrelated BLK): four tool calls as scripted (ToolSearch select, `ls /nonexistent-dir-xyz`, `git commit --allow-empty -m "fix: probe"`, `mcp__memory__memory_pending {}`), rc 0, cost $0.011. Answer: `memory_pending (project repo.gYdo, 1 session(s))` / `index: read blockers.md; skipped learnings.md (missing)` / `milestones (this session): - commit fix: probe (12:08)` / `failures: - NEW ×1 ls: cannot access '/nonexistent-dir-xyz': No such file or directory — command: ls /nonexistent-dir-xyz` + excerpt. Log: `$CLAUDE_JOB_DIR/tmp/proof9/out.jsonl`. The run leaves a `p:<tmp path>` key in the real store; the sweep ages it out (R3 conf 12).
|
||||
- Step 1 headless (2026-11-04 12:08, `claude -p --model haiku`, live user settings, mod `memory@skills-dir`, scratch repo `$CLAUDE_JOB_DIR/tmp/proof9/repo.gYdo` on `feature/probe`, `GITFLOW_NO_PUSH=1`, fixture `.claude/memory/blockers.md` with one unrelated BLK): four tool calls as scripted (ToolSearch select, `ls /nonexistent-dir-xyz`, `git commit --allow-empty -m "fix: probe"`, `mcp__memory__memory_pending {}`), rc 0, cost $0.011. Answer: `memory_pending (project repo.gYdo, 1 session(s))` / `index: read blockers.md; skipped learnings.md (missing)` / `milestones (this session): - commit fix: probe (12:08)` (UTC at the time; local time after final review M5) / `failures: - NEW ×1 ls: cannot access '/nonexistent-dir-xyz': No such file or directory — command: ls /nonexistent-dir-xyz` + excerpt. Log: `$CLAUDE_JOB_DIR/tmp/proof9/out.jsonl`. The run leaves a `p:<tmp path>` key (one session, ~1 KiB) in the real store; the 1 MiB sweep drops it only when the store is over the cap (final review M10 corrected R3 conf 12), harmless.
|
||||
- Step 3 interactive (user + model, R3 conf 5): pending — in a scratch repo on a feature branch the model runs `git commit --allow-empty -m "fix: probe"`, the user sends two composer prompts, the transcript grep expects exactly one `memory: commit fix: probe` on the first; then `/clear` and a `memory_pending` call lists the probe session `(earlier session)`.
|
||||
|
||||
@@ -254,6 +254,6 @@ Docs (rob 13, rob 15, simp 10): Task 8 adds `.claude/tasks/TODO.md` (4b ticked,
|
||||
|
||||
## RESULTS (Task 9)
|
||||
- Step 0 (2026-11-04, user go): `~/.claude/memory.json` moved to `$CLAUDE_JOB_DIR/tmp/memory.json.off`; capture is on from the next session.
|
||||
- Step 1 headless (2026-11-04 12:08, `claude -p --model haiku`, live user settings, mod `memory@skills-dir`, scratch repo `$CLAUDE_JOB_DIR/tmp/proof9/repo.gYdo` on `feature/probe`, `GITFLOW_NO_PUSH=1`, fixture `.claude/memory/blockers.md` with one unrelated BLK): four tool calls as scripted (ToolSearch select, `ls /nonexistent-dir-xyz`, `git commit --allow-empty -m "fix: probe"`, `mcp__memory__memory_pending {}`), rc 0, cost $0.011. Answer: `memory_pending (project repo.gYdo, 1 session(s))` / `index: read blockers.md; skipped learnings.md (missing)` / `milestones (this session): - commit fix: probe (12:08)` / `failures: - NEW ×1 ls: cannot access '/nonexistent-dir-xyz': No such file or directory — command: ls /nonexistent-dir-xyz` + excerpt. Log: `$CLAUDE_JOB_DIR/tmp/proof9/out.jsonl`. The run leaves a `p:<tmp path>` key in the real store; the sweep ages it out (R3 conf 12).
|
||||
- Step 1 headless (2026-11-04 12:08, `claude -p --model haiku`, live user settings, mod `memory@skills-dir`, scratch repo `$CLAUDE_JOB_DIR/tmp/proof9/repo.gYdo` on `feature/probe`, `GITFLOW_NO_PUSH=1`, fixture `.claude/memory/blockers.md` with one unrelated BLK): four tool calls as scripted (ToolSearch select, `ls /nonexistent-dir-xyz`, `git commit --allow-empty -m "fix: probe"`, `mcp__memory__memory_pending {}`), rc 0, cost $0.011. Answer: `memory_pending (project repo.gYdo, 1 session(s))` / `index: read blockers.md; skipped learnings.md (missing)` / `milestones (this session): - commit fix: probe (12:08)` / `failures: - NEW ×1 ls: cannot access '/nonexistent-dir-xyz': No such file or directory — command: ls /nonexistent-dir-xyz` + excerpt. Log: `$CLAUDE_JOB_DIR/tmp/proof9/out.jsonl`. The run leaves a `p:<tmp path>` key (one session, ~1 KiB) in the real store; the 1 MiB sweep drops it only when the store is over the cap (final review M10 corrected R3 conf 12), harmless.
|
||||
- Step 3 interactive (user + model, R3 conf 5): pending — in a scratch repo on a feature branch the model runs `git commit --allow-empty -m "fix: probe"`, the user sends two composer prompts, the transcript grep expects exactly one `memory: commit fix: probe` on the first; then `/clear` and a `memory_pending` call lists the probe session `(earlier session)`.
|
||||
|
||||
Reference in new issue
Block a user