chore(design): impeccable is the Build path, gate blocks on it instead of frontend-design

GATE-BLOCK swaps frontend-design for impeccable; Build line, gate prose, advisor rows follow. Detector rule count 45 to 61. BDR-119.
This commit is contained in:
bchanot committed 2026-10-16 18:19:29 +02:00
1 parent 218fc86494
commit f08efa3b9a
11 files changed
+47 -24

No files matched your search

+9
View File
@@ -136,6 +136,7 @@ rules:
| BDR-116 | 2026-10-11 | model-router first-use confirmation: tracked routing.json = source of phases + rows + decisions; engine dialog at first use; project exceptions in user scope keyed by normalized remote; model never writes; census tolerates a decided row | accepted |
| BDR-117 | 2026-10-12 | shared gstack helpers live in lib/gstack-removed.sh, not in a new lib | accepted |
| BDR-118 | 2026-10-12 | Rust default language for new projects / whole-project rewrites, always-on rule file | accepted |
| BDR-119 | 2026-10-16 | impeccable = Build path for all UI; GATE-BLOCK swaps frontend-design for impeccable | accepted |
---
@@ -1439,3 +1440,11 @@ Branch feature/user-writing-web-rules, UNMERGED (human gate).
- **Hooks**: interviewer FAILURE MODES row (language not stated → propose Rust), init-project founding-BDR table, project CLAUDE.md exception list.
- **Alternatives rejected**: section in CLAUDE.global.md (busts 320 budget); `paths:`-scoped rule (brainstorm is chat, never fires).
- **Refs**: commit ee76723, branch chore/rust-default. Links [[BDR-085]].
## BDR-119 — impeccable = Build path for all UI, frontend-design out of the gate [accepted] (2026-10-16)
- **Decision**: Build UI routes to impeccable (init, shape, new-work, craft floor, `impeccable detect`, fresh finish reviewer). `design.profile` GATE-BLOCK: impeccable in, frontend-design out. frontend-design stays installed + profile-listed: light path for a one-off visual w/o project context, never beside impeccable on same task.
- **Why**: impeccable 4.6 craft-floor + new-work carry frontend-design's anti-default list (eyebrow, numbering, identical cards, hero metric, cream/serif, scattered motion) and add direction roll, 61 deterministic rules, fresh reviewer, PRODUCT.md/DESIGN.md. Gate blocked on frontend-design (likely source of install prompt seen in another project, not traced). 2026-07-05 "complementary, keep both" call assumed frontend-design kept aesthetic direction; no longer true. Skill dist drifts untracked (pin = CLI only).
- **Gaps accepted**: tells only frontend-design names: middle-dot meta strings, arrow on buttons, short ALL-CAPS labels, tinted near-black. impeccable heavier: ~79k chars, init interview, mandatory seed roll on new world.
- **Alternatives rejected**: both in gate (conflict: frontend-design lets brief earn an eyebrow, impeccable bans it); uninstall frontend-design (loses light path); impeccable non-blocking (gate stays blind to the main tool).
- **Residual**: model-router has no impeccable row (frontend-design = `reflect`); census test pins the table, own change.
- **Refs**: branch chore/impeccable-build-path. Supersedes TODO 2026-07-05 call (no BDR). Links [[BDR-094]] [[BDR-025]] [[BDR-105]].
+3
View File
@@ -615,3 +615,6 @@ rules:
## 2026-10-15
- /bugfix model-router: Fable out of credits still routed (BLK-030). Live check: `complete()` on credit-less model never settles → probe w/ 8 s timeout (LRN-218). Plan r1 BLOCKERs (loop, cur probed) → r3 decide-then-probe. User: stand-in effort one notch up, `probe` key, explicit fable pins out of scope. bugfixer 497 tests, GATE 0 MET, verifier CONFORME 11/11, security PASS. Commit 2cccc43, docs P1-P5, merged to develop on user signal.
## 2026-10-16
- User asked if impeccable replaces frontend-design (install prompt in other project). Audit: yes for project UI, no for one-off visual. BDR-119: impeccable = Build path, GATE-BLOCK swap, doctrine Build line, advisor rows, rules 45 -> 61. frontend-design stays installed, light path. Branch chore/impeccable-build-path.
+11
View File
@@ -1,5 +1,16 @@
# TODO
## 2026-10-16 — impeccable = Build path for all UI (chore/impeccable-build-path)
User validated: frontend-design overlaps impeccable 4.6; gate still blocked on frontend-design. Supersedes the 2026-07-05 "complementary, keep both" call.
- [x] CLAUDE.global.md Build line: impeccable leads, frontend-design = light path only, rule count 45 -> 61
- [x] design.profile GATE-BLOCK: frontend-design out, impeccable in (frontend-design stays installed, profile-listed)
- [x] lib/design-gate.md: core-set prose + section 5 (impeccable now blocking, so only the PRODUCT.md check remains)
- [x] agents/plugin-advisor.md: frontend/design-system rows, package rows, two RULE blocks
- [x] 45 -> 61 detector rules: README, plugins.lock.json note, install-plugins.sh comment + echo
- [x] BDR-119 + CHANGELOG Unreleased + journal
- [x] make test: 1 red suite = known design-tool-gate precondition (21st CLI installed, see 2026-10-06 entry), shellcheck clean, impeccable resolves under skills/
- [ ] Residual (not done): model-router has no impeccable row (frontend-design has `reflect`); census test pins the table, own change.
## 2026-10-15 — short commit messages (feature/short-commit-messages)
- [x] `lib/commit-message.md`: lookup of a documented convention (README, CONTRIBUTING, CLAUDE.md, `.claude/` rules, commitlint, template), else 50 words max, medium technical level. Git log is not a convention.
- [x] Citers patched: commit-changer, bugfix STEP 6, feat STEP 5, hotfix STEP 4, client-handover-writer, CLAUDE.global.md (1 line, 320-line budget).
+1
View File
@@ -15,6 +15,7 @@ Format follows [Keep a Changelog](https://keepachangelog.com/) and this project
- **model-router cold-read caps**: both main-loop caps measure the cold read a switch costs, from a per-model record of main's last step, warm within the engine's prompt-cache TTL (`cache_ttl` 5m or 1h from main's model-switch events, 1 h before the first, kept across `/clear`; records cleared by `/clear` and `/route reload`), plus the submitted prompt the engine's usage may not count yet (code points / 3 of its text, context entries and a typed skill's body, added at the turn's first main step unless usage already grew by half of it; a `document` attachment blocks the switch for that step); `downgradeMaxTokens` (default 120000) joins `upgradeMaxTokens` (200000). A model-loaded helper skill inside a best-tier run moves effort only; main routed onto a model whose window the context outgrew returns to the session model. `/route show` prints `switch: on (downgrade, cap 120000 tokens cold, ttl 60 min)`, the status line shows ` · switch off` only when the switch is off, the skip line is logged once per cap crossing and the change toast names a cap hold. A built-in `general-purpose` agent that main spawns with no model while main sits below the session model starts on the session model instead of inheriting the lower one.
### Changed
- impeccable is the Build path for all UI: it replaces `frontend-design` on the design gate's `# GATE-BLOCK:` list and leads the Build line of the design doctrine. `frontend-design` stays installed as the light path for a one-off visual. Detector rule count corrected 45 to 61 (BDR-119).
- model-router `verbose: true` logs transitions only: one line when main changes model or effort (`model-router: main: fable/high → fable/xhigh (plan: route tool)`), one hand-off line per dispatch and one per later effort move of an agent, each with its cause; the per-step, "answered by", spawn, route-tool and skill-path lines are gone. An agent answering on a model other than the planned one is said once. A non-boolean `verbose` falls back to `false`, said once.
- `security-auditor` runs on the `judge` row (opus/xhigh) by a first-use decision; its frontmatter floor is aligned (`model: opus`).
- `lib/model-gate.md` calls the model-router `route` tool and takes its answer as the witness; with the mod off the gate stops and names `/route on`. The `model:` / `effort:` frontmatter of agents and skills is now the off-state floor, census-locked equal to the rows (`lib/tests/effort-routing.test.sh`; a row changed through the first-use dialog passes with a `WARN floor drift` line while its frontmatter still holds the shipped value). `analyzer` effort goes from high to xhigh. Built-in judgment dispatches carry an explicit `effort=`.
+6 -6
View File
@@ -289,12 +289,12 @@ Trigger = UI work: editing a component/style file (.tsx/.vue/.svelte/.css…)
or a design/UI request, not the word "design" alone. Single source for
design routing; the design-toolchain hook reinforces it.
- Trivial (≤2 files, one cosmetic value) → /hotfix, no toolchain.
- Build UI (component, page, redesign) → ui-ux-pro-max + frontend-design
(anti-slop) + 21st-ui-build (catalog + generation) + emil-design-eng
(polish) + design-motion-principles (motion) + design-html (static) +
site-motion (site-level scroll/page choreography, personal skill).
Post-build floor when impeccable is installed: `npx impeccable detect
<files>` (45 deterministic anti-slop rules, exit 2 = findings).
- Build UI (component, page, redesign) → impeccable (build path: init,
shape, new-work, craft floor, fresh finish reviewer) + ui-ux-pro-max +
21st-ui-build (catalog + generation) + emil-design-eng (polish) +
design-motion-principles (motion) + design-html (static) + site-motion.
Floor: `impeccable detect <files>` (61 rules, exit 2). frontend-design
only for a one-off visual with no project context, not beside impeccable.
- Design system / brand → design-consultation first, then the build tools.
- Review / audit → design-review + emil-design-eng + design-motion-principles
+ /impeccable audit|critique + `impeccable detect` floor.
+1 -1
View File
@@ -183,7 +183,7 @@ ctx7 login # optional: OAuth / API key for higher rate limits
| **21st.dev** | External CLI + skill pack | Component catalog and UI generation (`21st`), browser login, no API key. 7 skills in `skills-external/21st-*`, linked per profile (see the 21st.dev CLI section). | [npm: @21st-dev/cli](https://www.npmjs.com/package/@21st-dev/cli) |
| **Higgsfield** | External CLI + skill pack (off by default) | Image, video, audio and brand media generation, metered credits (see the Higgsfield CLI section). | [higgsfield-ai/skills](https://github.com/higgsfield-ai/skills) |
| **Semgrep** | Python CLI (pinned) | SAST engine behind the security gate (`security-auditor`). | [pypi: semgrep](https://pypi.org/project/semgrep/) |
| **Impeccable** | npm CLI + skill (pinned) | Deterministic anti-slop detector (`npx impeccable detect`, 45 rules) and the `/impeccable` design verbs. | [npm: impeccable](https://www.npmjs.com/package/impeccable) |
| **Impeccable** | npm CLI + skill (pinned) | Deterministic anti-slop detector (`npx impeccable detect`, 61 rules) and the `/impeccable` design verbs. | [npm: impeccable](https://www.npmjs.com/package/impeccable) |
| **Design skills** | Vendored | `emil-design-eng`, `frontend-design` (Anthropic example-skills), `design-motion-principles`: UI polish, anti-slop build, motion. | [emilkowalski/skill](https://github.com/emilkowalski/skill) · [kylezantos/design-motion-principles](https://github.com/kylezantos/design-motion-principles) |
| **agent-skills** | Vendored (commit-pinned) | `observability-and-instrumentation`, `deprecation-and-migration`, `ci-cd-and-automation`. | [addyosmani/agent-skills](https://github.com/addyosmani/agent-skills) |
| **MengTo scroll skills** | Vendored (commit-pinned) | Five scroll-choreography skills: `scroll-world-storytelling`, `build-threejs-scroll-worlds`, `scroll-scrubbed-visual-sequence`, `scroll-scrubbed-word-reveal`, `scroll-progress-timeline`. | [MengTo/Skills](https://github.com/MengTo/Skills) |
+7 -7
View File
@@ -135,10 +135,10 @@ ACTION REQUIRED? YES / NO
| Signal | Enable / Use | Disable / Skip | Notes |
|---|---|---|---|
| `frontend` | ui-ux-pro-max, frontend-design, design-motion-principles, impeccable | — | UI design + polish + motion. frontend-design = anti-AI-slop, design-motion-principles = motion/animation, impeccable = /impeccable verbs + deterministic detector (`npx impeccable detect`, 45 rules) — all external, symlinked |
| `frontend` | impeccable, ui-ux-pro-max, design-motion-principles | — | UI design + polish + motion. design-motion-principles = motion/animation, impeccable = the Build path: /impeccable verbs + deterministic detector (`npx impeccable detect`, 61 rules) — all external, symlinked |
| `mobile` (React Native/Expo/Flutter) | — | gstack (no browser QA), Docker N/A | ui-ux-pro-max optional |
| `monorepo` | per-package plugin recommendations | avoid recommending gstack for whole repo if only one package has browser QA | Specify which plugin applies to which package |
| `design-system` | ui-ux-pro-max, frontend-design, design-motion-principles, impeccable | — | Design tokens, theme, Storybook, motion; impeccable init persists the design context (DESIGN.md/PRODUCT.md) |
| `design-system` | impeccable, ui-ux-pro-max, design-motion-principles | — | Design tokens, theme, Storybook, motion; impeccable init persists the design context (DESIGN.md/PRODUCT.md) |
| `deploy` + `browser-qa` | gstack | — | Full-product workflow |
| `multi-session` | gsd v2 CLI | — | Run `gsd` in terminal, not CC plugin |
| `fast-libs` | context7 | — | Doc freshness critical |
@@ -189,12 +189,12 @@ When the plugin-advisor detects a `simple` or `hotfix` signal, suggest the appro
| Project type | Plugins ON | OFF | Passive cost |
|---|---|---|---|
| Backend API / microservice | (superpowers skills always on), context7 (if fast libs) | ui-ux-pro-max, gstack | ~0t |
| Frontend SPA / SSR | (superpowers skills always on), ui-ux-pro-max, frontend-design, design-motion-principles, context7 | gstack | ~600t |
| Full-stack SaaS | (superpowers skills always on), gstack, ui-ux-pro-max, frontend-design, design-motion-principles, context7 | — | ~3400t |
| Frontend SPA / SSR | (superpowers skills always on), ui-ux-pro-max, impeccable, design-motion-principles, context7 | gstack | ~600t |
| Full-stack SaaS | (superpowers skills always on), gstack, ui-ux-pro-max, impeccable, design-motion-principles, context7 | — | ~3400t |
| CLI tool / library | (superpowers skills always on) | all toggles | ~0t |
| Multi-session large feature | (superpowers skills always on) + gsd v2 CLI (external) | — | ~0t CC |
| Quick fix / hotfix | (superpowers skills always on) | all toggles | ~0t |
| Design system / component lib | (superpowers skills always on), ui-ux-pro-max, frontend-design, design-motion-principles | gstack, gsd | ~400t |
| Design system / component lib | (superpowers skills always on), ui-ux-pro-max, impeccable, design-motion-principles | gstack, gsd | ~400t |
| Fast-evolving libs (Next.js etc.) | (superpowers skills always on), context7 | — | ~200t |
| Enterprise multi-agent orchestration | (superpowers skills always on) + gsd v2 (external) | plugin-dev | ~0t CC |
@@ -219,7 +219,7 @@ RULE: IF "monorepo" signal detected:
RULE: IF "frontend" signal OR .tsx/.jsx count > 0:
→ ui-ux-pro-max ON if "design-system" signal (~400t)
→ frontend-design ON (external skill, 0t passive — symlink at ~/.claude/skills/frontend-design)
→ impeccable ON (external skill, 0t passive — ~/.claude/skills/impeccable)
→ design-motion-principles ON if anim-lib-installed or description mentions animation/motion (external, 0t passive)
RULE: IF "deploy" AND "browser-qa" signals:
@@ -261,7 +261,7 @@ RULE: IF `browser-qa` signal (e2e tests, Playwright/Cypress/Puppeteer in deps):
RULE: IF `design-system` signal (tokens, theme files, Storybook present):
→ ui-ux-pro-max ON (~400t)
→ frontend-design ON (external skill, 0t passive)
→ impeccable ON (external skill, 0t passive)
→ design-motion-principles ON (external skill, 0t passive)
→ WARN if all three OFF with this signal: significant design gap
+2 -2
View File
@@ -798,7 +798,7 @@ fi
echo ""
# ── Step 8d: Impeccable (design detector + skill + subagents) ──
# 45 deterministic detector rules (`impeccable detect`, exit 0/2), the
# 61 deterministic detector rules (`impeccable detect`, exit 0/2), the
# /impeccable skill (23 verbs) and 4 `impeccable-*` subagents.
#
# GLOBAL scope, no staging: the installer writes ~/.claude/skills/impeccable/
@@ -1313,7 +1313,7 @@ echo " 🔄 context7 CLI — ctx7 (npm global, standalone or MCP setup
echo " 🔄 graphifyy (CLI: graphify) — codebase knowledge graph (pipx, PreToolUse hook)"
echo " 🔄 emil-design-eng — UI polish, animations, component craft (curl → symlink)"
echo " 🔄 frontend-design — distinctive frontend interfaces, anti-AI-slop (anthropic-agent-skills)"
echo " 🔄 impeccable — /impeccable design verbs + 45-rule deterministic detector (npx impeccable detect)"
echo " 🔄 impeccable — /impeccable design verbs + 61-rule deterministic detector (npx impeccable detect)"
echo " 🔄 design-motion-principles — motion/animation design, 3-designer lens (kylezantos)"
echo " 🔄 agent-skills trio — observability-and-instrumentation, deprecation-and-migration, ci-cd-and-automation (curl → symlink, pinned commit)"
echo " 🔄 mengto scroll skills — scroll-world-storytelling, build-threejs-scroll-worlds, scroll-scrubbed-visual-sequence, scroll-scrubbed-word-reveal, scroll-progress-timeline (curl → symlink, pinned commit)"
+5 -6
View File
@@ -39,8 +39,8 @@ and if not, point at ONE command — `/profile design`.
Tier does NOT change WHAT gets checked. Every non-trivial design tier draws from
the one `design` profile — so the gate checks that profile's **design-core
tools** (the `# GATE-BLOCK:` allowlist in `design.profile`: ui-ux-pro-max,
frontend-design, emil-design-eng, design-motion-principles, design-html,
tools** (the `# GATE-BLOCK:` allowlist in `design.profile`: impeccable,
ui-ux-pro-max, emil-design-eng, design-motion-principles, design-html,
design-review, design-consultation, the `21st` CLI and `21st-ui-build` — the
canary for the whole 21st skill pack). The profile also bundles
browser/plan/shotgun tooling and graphify for convenience; those never trip the
@@ -171,10 +171,9 @@ that only `/impeccable init` writes. Without it the skill runs on invented
context, which is worse than not running it — and nothing else in the process
says so, because init has to happen in the agent chat, not in an installer.
**Fires when BOTH hold** — else stay silent:
1. impeccable symlink present under `skills/` (non-blocking external — not on the `# GATE-BLOCK:` list, so §3 never checks it).
2. The project has no `PRODUCT.md` at its root.
**Fires when** the project has no `PRODUCT.md` at its root, else stay
silent. impeccable itself is on the `# GATE-BLOCK:` list, so §3 has already
guaranteed it is installed by the time this runs.
Evaluate it on the same path as §4: after the toolchain resolves, never on the
INCOMPLETE stop path. One line, non-blocking:
+1 -1
View File
@@ -6,7 +6,7 @@
# below trip the design gate. The rest of this profile (browser/plan/shotgun
# tooling, graphify) is bundled for convenience but never blocks. Keep these
# lines in sync when adding/removing a core design tool.
# GATE-BLOCK: frontend-design ui-ux-pro-max emil-design-eng design-html
# GATE-BLOCK: impeccable ui-ux-pro-max emil-design-eng design-html
# GATE-BLOCK: design-motion-principles design-review design-consultation
# GATE-BLOCK: 21st 21st-ui-build
+1 -1
View File
@@ -89,6 +89,6 @@
"impeccable": {
"source": "npm:impeccable",
"version": "4.1.0",
"note": "Design anti-pattern detector (45 deterministic rules, CLI 'impeccable detect', exit 0/2) + /impeccable skill (23 verbs) + 4 impeccable-* subagents, by pbakaus. Pin = CLI version ONLY: the skill dist and the engine binary have their own release tracks, fetched by 'skills install' at install time, so this pin does not freeze audit output the way a semgrep pin does. It still gates the CLI deliberately (LRN-077 class). BEWARE: the pin rots — the CLI downloads its skill dist at install time and an older release's artifact disappears upstream (3.2.0 -> 'Download failed: invalid zip data', 2026-09-22, which left 'make plugin' printing a run-it-yourself warning). install-plugins.sh Step 8d and update-all.sh therefore fall back to @latest on a pin failure and warn to bump this version. Requires Node >= 24. Installed at --scope=global: lands in ~/.claude/skills/impeccable + ~/.claude/agents/impeccable-*.md, both symlinks into this repo, both gitignored."
"note": "Design anti-pattern detector (61 deterministic rules, CLI 'impeccable detect', exit 0/2) + /impeccable skill (23 verbs) + 4 impeccable-* subagents, by pbakaus. Pin = CLI version ONLY: the skill dist and the engine binary have their own release tracks, fetched by 'skills install' at install time, so this pin does not freeze audit output the way a semgrep pin does. It still gates the CLI deliberately (LRN-077 class). BEWARE: the pin rots — the CLI downloads its skill dist at install time and an older release's artifact disappears upstream (3.2.0 -> 'Download failed: invalid zip data', 2026-09-22, which left 'make plugin' printing a run-it-yourself warning). install-plugins.sh Step 8d and update-all.sh therefore fall back to @latest on a pin failure and warn to bump this version. Requires Node >= 24. Installed at --scope=global: lands in ~/.claude/skills/impeccable + ~/.claude/agents/impeccable-*.md, both symlinks into this repo, both gitignored."
}
}