chore(memory): LRN-288, BDR-146 residual closed, 4d TODO lines closed (H5)
This commit is contained in:
1 parent
7f5995b08c
commit
c8528a7bfc
7 files changed
+99
-7
No files matched your search
@@ -1562,6 +1562,7 @@ Supersedes [[BDR-030]].
|
||||
- **Alternatives rejected**: drop idle (user: tighten); index body (already done); add `promoted` to `_MEM_WORDS` (classifier change for annotation only).
|
||||
- **Residual**: metricsOf has no fix-date split, pre-fix rows keep 3rd-pick + idle actions in later FEEDBACK.md (TODO); tool-channel noisy entries not fixed by title rewrite (body spans).
|
||||
- **Reference**: feature/recall-gate1-fixes 7e87d77 + 39f9790; contract .claude/tasks/contracts/2026-11-12-recall-gate1-fixes-1830.md; plan r3; gates: 3 lenses (BLOCKER x3) + confirmation, GATE 0 MET, verifier ECARTS(2)→CONFORME x2, security PASS x2. See [[BDR-140]], [[EVAL-058]], [[BDR-100]].
|
||||
- **Status (2026-11-13)**: accepted, residual closed 9f9412a (block H5): precision/triggers/miss share post-fix only (cutoff = merge d3d5e6c 2026-11-12T19:53:59Z), actions wait for 20 post-fix asks, 3rd-pick signal retired, reminder waits for the post-fix sample
|
||||
|
||||
## BDR-147 — D1b: the session digest is the TODO source at start; Actionable section else first 3 items, overflow marker [accepted] (2026-11-12)
|
||||
- **Decision**: D1b: session digest = only TODO source at session start. `_digest_todo` reads `## Actionable` or `### Actionable` (`/^###? Actionable([ \t\r]|$)/`), section empty/absent → file's first 3 top-level `- [ ] ` items; headings + items inside `<!-- -->` ignored; `- todo: +N not shown, read .claude/tasks/TODO.md` marker when 800 cap drops todo lines (room reserved only on overflow). Seeds (init-project, capitalize:83 guarded, onboard STEP 9 fresh format) emit `## Actionable` + comment. CLAUDE.global.md Session start step 1 no longer orders a TODO.md Read (digest carries it; no digest → read it). Local repos migrated insert-only: empty `## Actionable` + comment under H1, `chore/todo-actionable` per repo.
|
||||
|
||||
@@ -746,3 +746,4 @@ rules:
|
||||
- /bugfix mods-strict-types (BLK-049): 17 TS sites narrowed for CLI 2.1.323 validate --strict, kits 288/640 unchanged, make test all green again. An analyzer corrected my premise (the 15 '.catch' lines are info, the TS errors fail strict). Other session's Fable 5.2 rename found uncommitted in this checkout: split out, ships as its own branch.
|
||||
- feature/fable-5-2 (user ask mid-run): fable alias → claude-fable-5-2 (ca1dc9f), rename done by another session in this checkout, split from BLK-049, id probed live, kit 640/0. Live CLI warns: deny Bash(git push * :**) matches as * wildcard (pre-existing, H item).
|
||||
- /bugfix safety-lows (block H4b): code-limits private state dir (mkdir -m 700 no -p + one find test), session-start runner timeout→gtimeout→perl alarm, pre-commit fails closed on git diff and filter errors (generator lib/gitflow.sh + both copies), memory.sh rewrap, claude-stub env log path (1f107c3). 4 rounds: generator was the hook source (decision a), GATE 2 MEDIUM stat/lstat race closed, lint regressions fixed. Residual: perl alarm kills the exec'd process only (TODO).
|
||||
- /bugfix feedback-followups (block H5, 4d follow-ups): post-fix split + 3rd pick retired + one-slot transcript cache + strict labels/state + key-set pins (9f9412a, docs). 3 challenge lenses FATAL on r1 (midnight cutoff, validator rejecting own rows, text-block extraction losing every join); 3 executor rounds (locals, at bound, legacy closed flag). RSS 279.8 → 267.7 MB on 16 records. tsc not done (no compiler, new dep), l:<root> kept (49.7 KB of 4 MiB), image prompts dropped (0 instances). LRN-288.
|
||||
@@ -2087,3 +2087,8 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s
|
||||
- **Context**: lib/memory.sh upgrade (block H2 2026-11-13); BUGS-FOUND "stale Index cell over a `**Statut** :` line" UNVERIFIED → real; 3 lenses + confirmation found the r1 fix would have reopened resolved blockers.
|
||||
- **Pattern**: a predicate like "does the Index win" lives at several sites (flush, Index-stated skip list, oracle); a fix at one site forks the predicate: the others keep the old answer and the oracle, built on the same predicate, goes blind. "Keep the body line" is wrong when the strict reader cannot read that line: the entry ends with NO status (= open). The fix = compute ONE effective status (strict word, else the v1 body word) once, feed every consumer, and WRITE the v1 word as the dated status so the strict reader can see it; keep `mem_want` first so an Index `superseded`/`deprecated` still wins; a mixed/unknown label = "" everywhere except excluded from the skip list so the existing refusal fires.
|
||||
- **Apply**: before changing a status rule, grep every consumer of the same predicate and a fixture per consumer (Index open + body resolved, Index resolved + body resolved, Index superseded + body accepted, mixed). Test oracles that count substrings shape the executor's code (a rename + `${!re}` indirection appeared to satisfy a count): count behaviours, not names.
|
||||
|
||||
## LRN-288 — Post-fix cutoff = the merge instant; derived gate flags recomputed on read; reader and writer validators round-trip (2026-11-13)
|
||||
- **Context**: block H5 2026-11-13: the BDR-146 residual fix (post-fix precision split) went through 3 lenses + confirmation + 3 executor rounds; every round found a defect only live data showed.
|
||||
- **Pattern**: a time cutoff for "after the fix" = the MERGE instant of the fix (git committer time of the merge), not the fix date at midnight (36 pre-fix rows sat between midnight and the merge). A gate derived from several marks must be recomputed on read, never trusted from a stored flag an older version wrote (a legacy `"closed":true` silenced the reminder for the new gate). Sample floors are counted in the unit the gate already uses (asks, not entries). A validator added on read must accept every row kind the writer emits (round-trip test over `rowsOf`), and the writer must not accept what the reader refuses (`at` 1e21).
|
||||
- **Apply**: measure on the live data before planning a metrics change (labels.tsv, store, transcripts read-only); pin the reader/writer round trip; derive closed/reached flags from their inputs.
|
||||
@@ -34,9 +34,9 @@ Shared rules for every phase:
|
||||
- **4c read side (built 2026-11-05 on feature/memory-recall, merged 2026-11-06 ddb04f4).** Two channels only: intent recall at `prompt.submit` for classifier labels design/analysis or the first coding prompt after idle (BM25 top-30 over title + lesson + body → haiku keeps ≤3, bounded 3 s, fail open) and tool-error 4-gram match (PostToolUse; a classic hook is acceptable if the mod ledger is not needed). Session digest (open BLK via the status parser, actionable TODO, last journal line) in `hooks/session-start.sh` on `source: startup|compact|clear` (native matchers; the mod's `session.compact` only skips); a SubagentStart twin if sub-agents need it. Injection = ID + title + lesson line; superseded never injected; budget ~1.5k chars per turn; once per context. Deferred: Read path triggers, Bash command triggers, "critical → deny once", Tier 1, cross-repo scope=global index, `memory_search` tool.
|
||||
- [x] 4c follow-up from the 4b live proof: `memory_pending` lists earlier-session milestones marked `(earlier session)` (done 78eff1c 2026-11-05, mods/memory/hooks/register.ts milestoneLines).
|
||||
- **4d feedback (4d.1-4d.3 built 2026-11-08 on feature/memory-feedback, BDR-140, merged 2026-11-08 dcb593a).** Mod logs `cands`+`ms`; bun reader `lib/memory-feedback/`; `/memory-feedback` skill; banner reminder; two gates (prompt 20 or 35 d, tool 10 or 35 d +1 extension). Plan r3 `docs/superpowers/plans/2026-11-06-memory-feedback.md` (purged at finish; git keeps it), contract `.claude/tasks/contracts/2026-11-06-memory-feedback-4d-1825.md`. 4d.4 (/prune-memory step D, BDR-100 promotion) stays conditional: built only when a gate reports a noisy entry or a promotion candidate.
|
||||
- [ ] metricsOf: split rows by the 2026-11-12 fix date and retire the 3rd-pick signal (pre-fix rows keep re-emitting the idle and cap actions; BDR-146 residual)
|
||||
- [ ] 4d follow-ups (final review + task reviews 2026-11-08, non-blocking): transcript cache holds every parsed file per run (~1 GB at steady state: process per (root, session, agent) and drop); image prompts (array content) become `lost` (counted); no boundary tests for the threshold actions (3rd pick, late, tool, miss, noisy/promotion, idle tie-break), eviction note, torn count, toolItem; `replyAfter` hides `seen.add` in a filter; no `tsc` type check on lib/memory-feedback; kit test pinning the exact field set of a prompt log record (IR11 is toMatchObject since 4d.1, so a future text field would pass); labels.ts minors (fromLine checks column count only, readState accepts non-object JSON, .bak keeps one state, misleading error on an entry label with a cause).
|
||||
- [ ] shortcut: the injection log lives under `l:<root>` store keys (about 28 KiB each, 200 records and 64 KiB at most); `sweepLogs` counts them with the `p:` keys and evicts the oldest log key (by its newest record, never the current root's) once the total nears the engine's 4 MiB store cap; upgrade = one global log key or a smaller per-root cap (`mods/memory/hooks/register.ts`).
|
||||
- [x] metricsOf split + 3rd pick retired: done 2026-11-13 (block H5, 9f9412a; cutoff = merge instant d3d5e6c)
|
||||
- [x] 4d follow-ups done 2026-11-13 (block H5, 9f9412a): one-slot transcript cache (RSS 279.8 → 267.7 MB on 16 records), boundary tests, eviction/torn/toolItem tests, replyAfter Map, key-set pins, labels.ts checks. NOT done, justified: `tsc` (no TypeScript compiler on the machine, adding one = a new dependency; the mods are type-checked by `claude plugin validate --strict` since BLK-049); image prompts (0 human array prompts in the 636 MB corpus, 115/115 hook attachments are string arrays, lost records stay visible)
|
||||
- [x] `l:<root>` shortcut kept, justified 2026-11-13: 6 `l:` + 7 `p:` keys = 49.7 KB of the 4 MiB cap (1.2 %), `sweepLogs` tested; no redesign without a measured need
|
||||
- [x] residual: the pre-existing `memory.sh check` call in `hooks/session-start.sh` is not time-bounded (the digest's `memory.sh index blocker` call is); upgrade = wrap it in `timeout 2`. Done 2026-11-06 d93f06c (SD16).
|
||||
- [x] BLK-043 hotfix merged 2026-11-06 (`bd5e661` main, `7e47bea` develop, back-merged into feature/memory-recall `3564e3e`, worktree removed).
|
||||
- [x] BLK-043 Part B: suite-wide `claude` PATH stub + final empty-log check in `lib/tests/session-digest.test.sh` (SD0/SD15, done 2026-11-06 via /hotfix; security PASS, MEDIUM folded into the shortcut below).
|
||||
|
||||
@@ -0,0 +1,41 @@
|
||||
# CONTRACT — bugs-found-prose (BUGS-FOUND agent/skill/doc items, block H6a)
|
||||
- date: 2026-11-13 | flow: bugfix | branch: bugfix/bugs-found-prose (off develop)
|
||||
- status: active
|
||||
|
||||
## REQUEST (verbatim — IMMUTABLE)
|
||||
Fix the BUGS-FOUND entries unfixed since 2026-11-09 that live in agent, skill, lib-prose and doc files: handover-doc-writer §6.1 status filter; handover STEP 10 paths not rooted on the PACKAGE root + space-split PROJECT line; handover/client-handover ROOT double-quoted literal + unquoted `-C <root>` remedy; plugin-advisor `embedded` from REQUEST keywords alone; plugin-gate accepts pack `extras`; onboard/plugin-advisor "pinned ctx7" wording; `make plugin` cwd-dependent remedy + undefined "A) fix plugins"; plugin-gate templates double quotes, linked-worktree apply-check path, PROJECT_ROOT = $HOME; "gstack ON/OFF" vocabulary in onboard/tour + unwrapped lines; stale graphify claims (.gitignore, plugins.lock.json, update-all.sh, install-plugins.sh labels/comment, LRN-154).
|
||||
|
||||
## CLARIFICATIONS
|
||||
- [gated 2026-11-13, orchestrator per user brief: the fix that answers each finding, no new design]
|
||||
1. handover-doc-writer §6.1: only BDRs whose current word (from `memory.sh -C "$ROOT" index decision`, the reader STEP 9 already uses) is accepted/implemented/proposed enter the vulgarized list; superseded/deprecated are left out (one sentence says so in the deliverable's method note).
|
||||
2. handover STEP 10 + every other git/file read in that agent: `git -C "$ROOT" …` / `"$ROOT/…"`; the PACKAGE carries the root on its own line `PROJECT_ROOT: <path>` read whole-line (spaces kept); client-handover-writer emits that line.
|
||||
3. ROOT assignment: the agents take the root from that whole line into a variable via a read (no pasted double-quoted literal), and every printed remedy quotes it: `memory.sh -C "<root>" status …`.
|
||||
4. plugin-advisor: `embedded` → `↻ SET : minimal` only from project-level signals (files, manifests), never REQUEST keywords alone; REQUEST keywords may only add a NOTE.
|
||||
5. plugin-gate.md: `extras` removed from the accepted advisor tokens (same reason as higgsfield: 21st-ai metered); the user can still `profile.sh enable extras` by hand.
|
||||
6. ctx7 wording: "installs ctx7 (latest, plugins.lock.json pins `latest`)" in onboard SKILL.md and plugin-advisor (no pin added).
|
||||
7. `make plugin` remedies: `make -C ~/Documents/claude plugin` is not portable: write "run `make plugin` in your claude-config checkout" (print-only); plugin-gate "A) fix plugins" defined as exactly that print.
|
||||
8. plugin-gate templates: tokens and `<PROJECT_ROOT>` in single quotes; the apply check compares the parent of `git rev-parse --git-common-dir` (what profile.sh writes) and refuses PROJECT_ROOT equal to `$HOME`.
|
||||
9. onboard SKILL.md:387-762 and tour SKILL.md:155 "gstack ON/OFF" → the packs vocabulary used since D3 (`pack gstack-dev on/off`, `profile.sh current`); rewrap plugin-check SKILL.md:17, plugin-gate.md:45, USAGE.md:182; USAGE.md:1022 transcript gains the ↻ glyph.
|
||||
10. graphify: .gitignore:54-56, plugins.lock.json:37, update-all.sh:310-312 (point at `make plugin`, no manual `graphify claude install`), install-plugins.sh:688/690/1269 labels and :694-695 comment say what the steps do now (the trap reverts the CLAUDE.md block and hook). LRN-154 gets a `memory.sh status` correction line in STEP 8 (registry append-only), not an edit.
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
1. Each of the 10 items changed in its file (read check by the verifier, item by item).
|
||||
CHECK: cd /home/bchanot/Documents/claude && git diff --stat develop -- agents/handover-doc-writer.md agents/client-handover-writer.md agents/plugin-advisor.md lib/plugin-gate.md skills/onboard/SKILL.md skills/tour/SKILL.md skills/plugin-check/SKILL.md USAGE.md .gitignore plugins.lock.json update-all.sh install-plugins.sh | tail -1 | grep -c '12 files changed'
|
||||
EXPECT: 1
|
||||
EVIDENCE: PENDING
|
||||
2. No "gstack ON/OFF" left in onboard/tour; no `extras` among plugin-gate's accepted tokens.
|
||||
CHECK: cd /home/bchanot/Documents/claude && echo $(grep -c 'gstack ON/OFF\|gstack ON\b' skills/onboard/SKILL.md skills/tour/SKILL.md | grep -vc ':0$')
|
||||
EXPECT: 0
|
||||
EVIDENCE: PENDING
|
||||
3. plugins.lock.json valid JSON; shellcheck clean on update-all.sh and install-plugins.sh changes (no new finding vs develop).
|
||||
CHECK: cd /home/bchanot/Documents/claude && jq . plugins.lock.json >/dev/null && echo JSON-OK
|
||||
EXPECT: JSON-OK
|
||||
EVIDENCE: PENDING
|
||||
4. Suites that read these files stay green: handover-memory-contract, doctrine-citers, skill-routing-census, curated-config-guard, portability-census.
|
||||
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test suite=lib/tests/handover-memory-contract.test.sh 2>&1 | tail -1
|
||||
EXPECT: all suites green
|
||||
EVIDENCE: PENDING
|
||||
5. make test green (manual, bun on PATH).
|
||||
|
||||
## FILE SCOPE
|
||||
agents/handover-doc-writer.md, agents/client-handover-writer.md, agents/plugin-advisor.md, lib/plugin-gate.md, skills/onboard/SKILL.md, skills/tour/SKILL.md, skills/plugin-check/SKILL.md, USAGE.md, .gitignore, plugins.lock.json, update-all.sh, install-plugins.sh. LRN-154 + BUGS-FOUND → STEP 8.
|
||||
@@ -0,0 +1,37 @@
|
||||
# CONTRACT — bugs-found-scripts (BUGS-FOUND script/test items, block H6b)
|
||||
- date: 2026-11-13 | flow: bugfix | branch: bugfix/bugs-found-scripts (off develop)
|
||||
- status: active
|
||||
|
||||
## REQUEST (verbatim — IMMUTABLE)
|
||||
Fix the BUGS-FOUND entries unfixed since 2026-11-09 that live in scripts and tests: lib/profile-state.jq newline in a settings value can forge a `plugin:<id>=on` line; skills/prune-memory/tests/run-deterministic.sh:13 unchecked mktemp; session-start digest blocker line fails open (print `- open: none` after a successful read); curated-config-guard does not lock the Step 7 `(cd "$REPO" && graphify claude install)` subshell; push-guard T42c passes if the probe jq write fails; deny_lost has no pipefail; T62F mktemp outside $WORK without trap. Plus the GATE 2 LOW of 2026-11-13: push-guard T63 presence check reads ask+deny, so a deny row demoted to ask still passes.
|
||||
|
||||
## CLARIFICATIONS
|
||||
- [gated 2026-11-13, orchestrator per user brief]
|
||||
1. profile-state.jq: every value printed into the plain text goes through one sanitizer (`gsub("[\n\r]"; " ")` or `@json` on free-text values) so no value can start a new line; plugin ids are printed only when they match the id shape `^[A-Za-z0-9._-]+@[A-Za-z0-9._-]+$`. Test: a settings fixture whose value holds `\nplugin:evil@x=on` shows no `evil` line (in the existing profile or session-banner suite).
|
||||
2. run-deterministic.sh: `SANDBOX="$(mktemp -d …)" || exit 1` and an empty-value guard; SKILL.md:34 rewrap ≤ 80 (cosmetic part of the same finding).
|
||||
3. session-start `_digest_blockers`: when the `index blocker` read succeeds with zero open rows, print `- open: none`; a failed or timed-out read prints `- open: unknown (memory.sh index failed)`. Test in session-digest.test.sh (both cases).
|
||||
4. curated-config-guard.test.sh: one lock asserting install-plugins.sh Step 7 still runs `graphify claude install` inside `(cd "$REPO" && …)` (fixed-string grep, flip-tested).
|
||||
5. push-guard T42c: assert the probe file exists and parses before using it (`jq -e . "$WORK/s-probe.json"` → check); deny_lost: `set -o pipefail` local to the function (or explicit rc checks) so a missing list or jq failure fails the check, flip-tested; T62F: settings copy under `$WORK` (cleaned by the suite trap).
|
||||
6. T63: split the presence list into a deny list checked against `.permissions.deny` only and an ask list checked against `.permissions.ask` only (rows assigned by where they sit in settings.json today).
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
1. Suites green: profile (or session-banner), session-digest, curated-config-guard, push-guard, prune-memory deterministic.
|
||||
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test suite=lib/tests/push-guard.test.sh 2>&1 | tail -1
|
||||
EXPECT: all suites green
|
||||
EVIDENCE: PENDING
|
||||
2. session-digest green with the two new cases.
|
||||
CHECK: cd /home/bchanot/Documents/claude && echo $(grep -c 'open: none' hooks/session-start.sh lib/tests/session-digest.test.sh | grep -c ':[1-9]')$(PATH=$HOME/.bun/bin:$PATH make test suite=lib/tests/session-digest.test.sh 2>&1 | tail -1)
|
||||
EXPECT: 2all suites green
|
||||
EVIDENCE: PENDING
|
||||
3. curated-config-guard and prune-memory suites green.
|
||||
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test suite="lib/tests/curated-config-guard.test.sh skills/prune-memory/tests/run-deterministic.sh" 2>&1 | tail -1
|
||||
EXPECT: all suites green
|
||||
EVIDENCE: PENDING
|
||||
4. Forged-line test present and green.
|
||||
CHECK: cd /home/bchanot/Documents/claude && grep -rlc 'evil@' lib/tests/*.sh | wc -l
|
||||
EXPECT: 1
|
||||
EVIDENCE: PENDING
|
||||
5. shellcheck -x clean on every changed .sh (no new directive); make test green (manual, bun on PATH).
|
||||
|
||||
## FILE SCOPE
|
||||
lib/profile-state.jq, lib/detect-plugins.sh (only if the sanitizer belongs there), hooks/session-start.sh (`_digest_blockers`), skills/prune-memory/tests/run-deterministic.sh, skills/prune-memory/SKILL.md (:34 rewrap), lib/tests/{session-digest,curated-config-guard,push-guard,profile or session-banner}.test.sh. BUGS-FOUND/TODO → STEP 8.
|
||||
@@ -8,27 +8,34 @@ metricsOf: split rows by the 2026-11-12 fix date and retire the 3rd-pick signal
|
||||
## CLARIFICATIONS
|
||||
- [gated 2026-11-13, challenge r1-r3; plan .claude/tasks/plans/2026-11-13-feedback-followups-1800.md § r2 + r3 FINAL] fix instant = merge d3d5e6c 2026-11-12T19:53:59Z; split scope and floor per r3; image prompts DROPPED (0 instances, measured); `tsc` not done (no compiler on the machine, a new dependency) and `l:<root>` shortcut kept (49.7 KB of 4 MiB measured): both closed in the TODO with those reasons; `.bak` one state accepted.
|
||||
|
||||
- [gated 2026-11-13, round 2 after GATE 1/2] (r2-1) `closed` = `promptAt && toolAt && postFixAt` so lib/memory-feedback-remind.sh keeps prompting until the post-fix sample is measured (BDR-146 gate 2), old state files without postFixAt read as not closed; (r2-2) `itemError` bounds `at` with `Number.isSafeInteger` so every appended row survives `fromLine(toLine(row))`; (r2-3) R11 and R14 split to ≤ 5 locals; (r2-4) tests: the floor withholds the missShare action below 20 post-fix asks while late/msP90 still fire; an ask with 2 entries counts once toward the floor; a pre-fix row still counts toward promote; the no-candidate `none` record key set pinned (no `ms`).
|
||||
|
||||
- [gated 2026-11-13, round 3] `readState` derives `closed` from promptAt && toolAt && postFixAt instead of trusting the stored flag (an old `"closed":true` without postFixAt reads open); the next apply rewrites the flag, so lib/memory-feedback-remind.sh resumes. FILE SCOPE += comments only in lib/memory-feedback-remind.sh:4-5 and lib/tests/memory-feedback-remind.test.sh:4 ("silent once all three gate marks are recorded"); transcripts.ts:133 comment → "first position kept; the value is derived from the key".
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
1. thirdPick retired, fix instant constant present.
|
||||
CHECK: cd /home/bchanot/Documents/claude && echo $(grep -c 'thirdPick' lib/memory-feedback/metrics.ts lib/memory-feedback/thresholds.ts | grep -c ':0$')$(grep -c "GATE1_FIX_AT = Date.parse('2026-11-12T19:53:59Z')" lib/memory-feedback/thresholds.ts)
|
||||
EXPECT: 21
|
||||
EVIDENCE: PENDING
|
||||
EVIDENCE: MET exit=0 marker-found :: 21
|
||||
2. memory-feedback suite green.
|
||||
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test suite=lib/tests/memory-feedback.test.sh 2>&1 | tail -1
|
||||
EXPECT: all suites green
|
||||
EVIDENCE: PENDING
|
||||
EVIDENCE: MET exit=0 marker-found :: all suites green
|
||||
3. New tests exist (post-fix floor, A,B,A torn read-once, every label kind, two IR11 key-set pins).
|
||||
CHECK: cd /home/bchanot/Documents/claude && echo $(grep -c 'GATE1_FIX_AT' lib/memory-feedback/metrics.test.ts | grep -c '^[1-9]')$(grep -c 'Skipped 1 torn' lib/memory-feedback/reader.test.ts | grep -c '^[1-9]')$(grep -c 'Object.keys' mods/memory/hooks/register.test.ts | grep -c '^[2-9]')
|
||||
EXPECT: 111
|
||||
EVIDENCE: PENDING
|
||||
EVIDENCE: MET exit=0 marker-found :: 111
|
||||
4. Memory kit green, strict validation green.
|
||||
CHECK: cd /home/bchanot/Documents/claude && claude plugin validate --strict mods/memory >/dev/null 2>&1 && PATH=$HOME/.bun/bin:$PATH make test suite=lib/tests/mods.test.sh 2>&1 | tail -1
|
||||
EXPECT: all suites green
|
||||
EVIDENCE: PENDING
|
||||
EVIDENCE: MET exit=0 marker-found :: all suites green
|
||||
5. The live labels.tsv still reads (worksheet on a COPY of ~/.claude/memory-feedback under mktemp, never the real dir).
|
||||
(manual 2026-11-13: reader on a HOME copy under mktemp, `bun reader.ts worksheet` rc 0, "16 records to label", live labels.tsv reads under the new checks; real dir untouched)
|
||||
(manual: executor runs the reader on a copy and quotes rc 0 + the head lines)
|
||||
6. Peak RSS of the reader before/after on a copy of the real population (manual, quoted).
|
||||
(manual 2026-11-13: HEAD 279812 kB / 0.35 s, tree 267724 kB / 0.22 s on 16 records; worksheet and items byte-identical)
|
||||
7. make test green (manual, bun on PATH); functions ≤ 25 logic lines / 5 params / 5 locals; lines ≤ 80.
|
||||
(manual: full `make test` run 2026-11-13 on round 2 → all suites green)
|
||||
|
||||
## FILE SCOPE
|
||||
lib/memory-feedback/{metrics,thresholds,transcripts,reader,labels}.ts and their .test.ts, mods/memory/hooks/register.test.ts. CHANGELOG/README → doc sync; TODO lines → STEP 8.
|
||||
Reference in new issue
Block a user