chore(audits): regroup two bugs-found-scripts items under their header

This commit is contained in:
bchanot committed 2026-11-15 21:59:32 +01:00
1 parent 074cdde409
commit 9e52f69c8f
1 file changed
+2 -2
+2 -2
View File
@@ -85,6 +85,8 @@
<!-- /bugfix bugs-found-scripts 2026-11-13 (9045a60): non-blocking gate findings, not BDR-125 -->
- lib/memory.sh:594-603 `memory_index` — skips a blockers.md that is not a regular file (`[ -f ] || continue`) and does not propagate the awk rc, so `index blocker` exits 0 on a registry it could not read and the session digest prints `- open: none` (SD9b/SD9c pin it). Fix direction: non-regular registry or unparsable `| BLK-` row → non-zero rc, the digest prints `unknown`. Severity: low. Discovered while: /bugfix bugs-found-scripts gates 1+2. FIXED 87aecc1 (BDR-125 gap A3).
- lib/profile-state.jq `clean` strips LF/CR only: ESC and other control chars pass (no terminal sink today); human mode (:67-75) prints values unsanitized (pre-existing). Severity: low. Discovered while: /bugfix bugs-found-scripts security gate. Not fixed.
- lib/tests/profile.test.sh:195 T28-nl-id-no-bare-on cannot fail (pre-fix tail is `=off`); the `clean` on pack keys has no biting assertion; lib/tests/session-digest.test.sh:245 comment still says "no digest". Severity: low. Discovered while: /bugfix bugs-found-scripts verifier. Not fixed.
<!-- /bugfix index-fail-closed 2026-11-15 (87aecc1): residuals of the fix, not BDR-125 -->
- lib/memory.sh `memory_index` and the digest — what still reads as not-open or absent: an empty or unknown status word on a BLK row counts as not open (game holds 14 such v1 rows, config 3, so flagging them would fire every session); an unclosed ``` fence hides every later entry with no banner line; `index` reads without the lock while `status`/`_mem_restore` truncate then write in place (memory.sh:262,319), so a racing digest can read an empty file; `[ -e ] || [ -L ] || return 0` (:609) reads a stat failure (I/O, LSM denial) as absent. Severity: low. Discovered while: /bugfix index-fail-closed plan challenge and security gate. Not fixed.
@@ -94,8 +96,6 @@
- lib/memory-commit.sh:99 runs `check --staged` on the index, then :118 `git commit -- <paths>` re-reads the working tree, and the memory lock is not held across the two: a registry write landing between them is committed unchecked. Fix direction: commit the checked index (no pathspec once scoped) or hold the lock across check and commit. Severity: low. Discovered while: /feat staged-next-id plan challenge (robustness r2). Not fixed.
- lib/memory.sh `_mem_removed_lines` refuses a `memory.sh upgrade` commit of a v1 file where a dialect heading (`### BLK-n`) sits below the first `## ` entry: its rewrite to `## ` counts as a removed line inside an entry, so mixed-dialect v1 registries cannot be upgraded through memory-commit. Same for /prune-memory's `heading level` fix on a v2 file. Severity: low. Discovered while: /feat staged-next-id executor (T8m fixture). Not fixed.
- lib/memory.sh `_mem_check_next_ids` assumes line order is chronological: a hand-inserted ID line above a new entry, or an ID line removed above the first entry, can refuse an entry `add` wrote correctly (named in the `_mem_next_id` comment). IDs at or above 2^53 lose precision in awk (same limit as `_mem_next_id`). Severity: low. Discovered while: /feat staged-next-id plan challenge. Not fixed.
- lib/profile-state.jq `clean` strips LF/CR only: ESC and other control chars pass (no terminal sink today); human mode (:67-75) prints values unsanitized (pre-existing). Severity: low. Discovered while: /bugfix bugs-found-scripts security gate. Not fixed.
- lib/tests/profile.test.sh:195 T28-nl-id-no-bare-on cannot fail (pre-fix tail is `=off`); the `clean` on pack keys has no biting assertion; lib/tests/session-digest.test.sh:245 comment still says "no digest". Severity: low. Discovered while: /bugfix bugs-found-scripts verifier. Not fixed.
<!-- /hotfix doctor-skilloverrides-residue 2026-11-14: non-blocking gate finding, not BDR-125 -->
- doctor.sh `warn`/`pass`/`fail` print through `echo -e`: jq's `\uXXXX` escapes in the residue diff (:153) come back as raw control bytes (ESC sequences) on the terminal. Source = the user's own tracked settings.json (no trust boundary). Fix direction: `printf '%s\n'` in the shared helpers. Severity: low. Discovered while: /hotfix doctor-skilloverrides-residue security gate. Not fixed.