chore(memory): LRN-295 advisor measurement, BDR-150 amended, run A journal
This commit is contained in:
1 parent
c1a0c32417
commit
78a694299b
6 files changed
+260
No files matched your search
@@ -1609,3 +1609,4 @@ Supersedes [[BDR-030]].
|
||||
- **Gates**: r1 3 lenses CONCERNS → r2 → re-challenge CONCERNS → r3; feater DONE 661 tests; GATE 0 MET; verifier CONFORME; security PASS (MEDIUM fixed: stored answer survives ask-tier off); commits 24b0f35, docs 42385d2.
|
||||
- **Refs**: amends [[BDR-123]], [[BDR-135]]; supersedes [[LRN-224]]; [[BLK-030]], [[BDR-077]] (Fable dispatch pins: separate run).
|
||||
- **Status (2026-11-17)**: accepted, completed: pins opus beebfe2 (gate row 'fixed at spawn' passes a pinned sub-agent), doctrine c3507ea (main loop calls advisor, sub-agents do not, absent advisor -> proceed, advice waives no gate)
|
||||
- **Status (2026-11-17)**: accepted, amended 6ef3069: main loop named call points (before a skill's plan, once per verify-secure run at first gate loop failing twice, before merge); plan-challenger/verifier/security-auditor at most one call before verdict, advice add-only (security: STEP 3 class severity, no class -> REPORTED LOW); other sub-agents do not
|
||||
@@ -774,3 +774,4 @@ rules:
|
||||
|
||||
## 2026-11-17
|
||||
- Advisor doctrine (c3507ea, docs): CLAUDE.global § Workflow + effort-shift § Advisor: main loop calls Fable advisor (approach, stuck, before done), sub-agents do not (they have tool listed: prose-only, residual), absent → proceed, advice waives no gate/cap/guard. Stale Fable prose → opus (effort-shift, challenge-plan, plan-challenger, tour). BDR-150 change complete: router 24b0f35, pins beebfe2, doctrine c3507ea.
|
||||
- Advisor call points run A (6ef3069): transcript count showed main loop 2 calls on Opus (409k/680k uncached) vs 18/20 opus sub-agents on Fable (~70k); doctrine now names main-loop points (plan, first gate loop failing twice, merge) + judgment agents once, advice add-only; 2 challenge rounds, gates found block E double count, fixed r5. Runs B, C next.
|
||||
@@ -2128,3 +2128,9 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s
|
||||
- **Context**: 2026-11-17 advisor doctrine (BDR-150, c3507ea). Plan assumed advisor = main-loop tool. Robustness challenger (typed sub-agent, tools Read/Grep/Glob/Bash) had `advisor` listed + system prompt saying call it before/after work; same for verifier, security-auditor, executors. Each call forwards that agent's full transcript to Fable outside router caps (server tool, hooks cannot see/refuse).
|
||||
- **Apply**: ask a dispatched agent what tools it has (or read its prompt) before writing a scope rule; prefer mechanical scope (settings/tool lists) over prose; when only prose exists, log as residual (BUGS-FOUND d292911).
|
||||
- **Reference**: CLAUDE.global.md § Workflow, lib/effort-shift.md § Advisor
|
||||
|
||||
## LRN-295 — Measure advisor calls from transcripts: per caller, model, uncached input (2026-11-17)
|
||||
- **Pattern**: measure advisor use from session transcripts, not from feel. Main transcript `~/.claude/projects/<proj>/<session>.jsonl`, sub-agents `<session>/subagents/*.jsonl` (+ `.meta.json` agentType). Call = content block `server_tool_use` name `advisor`; model + tokens = `message.usage.iterations[]` with `type=="advisor_message"`. Usage rows repeat once per content block: dedupe by `message.id`.
|
||||
- **Context**: 2026-11-17, user asked if advisor called when needed. Since /advisor (2026-11-16 16:19Z): main loop 2 calls, served by Opus (conversation kept old advisor), 409k + 680k input tokens, cache_read 0; 18/20 opus sub-agents 19 calls on Fable, median 70k (43k-119k), total 1.46M; 8 sonnet sub-agents 0. Data reversed "main loop only" (c3507ea) → 6ef3069 (judgment agents once, main loop named points).
|
||||
- **Apply**: before scoping who calls advisor, or judging cost: count per caller + model + uncached input; main-loop call in long session costs ~6-10 sub-agent calls. Run C (/memory-feedback advisor section) automates it.
|
||||
- **Reference**: lib/effort-shift.md § Advisor, BDR-150, LRN-294
|
||||
@@ -3,6 +3,12 @@
|
||||
## Open (reconciled 2026-11-12 before 3.0.0, /reconcile on the BDR-125 phases; full pass 2026-10-23)
|
||||
Done history before 2026-10-08 removed 2026-10-23 (git keeps it: `git log -p -- .claude/tasks/TODO.md`); decisions live in `.claude/memory/`.
|
||||
|
||||
### Advisor call points (user 2026-11-17: "oui 1 et 2, et le 3 aussi"; amends BDR-150)
|
||||
- [x] Run A DONE 6ef3069 (docs + memory below) /feat feature/advisor-call-points: CLAUDE.global § Workflow + lib/effort-shift.md § Advisor + plan-challenger/verifier/security-auditor one-call rule (contract .claude/tasks/contracts/2026-11-17-advisor-call-points-1130.md)
|
||||
- [ ] Run B /feat: inline advisor call lines at the step sites (plan step of skills/feat, bugfix, ship-feature; second-failure + cap sites in lib/verify-secure-loop.md; merge proposal), citing `lib/effort-shift.md § Advisor`
|
||||
- [ ] Run C /feat: advisor usage section in /memory-feedback (main loop vs sub-agents, model served, input tokens; dedupe usage rows by message.id, model from the `advisor_message` iteration)
|
||||
- [x] Stale citers after A: README/USAGE/CHANGELOG patched, BUGS-FOUND residual superseded + LOW logged, BDR-150 status, LRN-295 (LRN-294 kept: its lesson holds)
|
||||
|
||||
### BDR-125 close-out run (user 2026-11-12): no phase 0/0b/4a/1/5/2/4b/4c/4d line left in TODO or BUGS-FOUND
|
||||
Decisions at start (asked once): faunosteo memory v2 on `chore/memory-v2` off develop in a fresh worktree (split already on develop 7a75974, 11 rules); settings.json `npm -g` deny lines removed on the block E branch, classifier test = `npm install -g --dry-run cowsay`; 3.0.0 cut right after block A (/release-candidate), later blocks land under the next Unreleased; LRN-270 bisect = user-run interactive sessions, one `--settings` file per pack. Merge prompts (`gitflow finish` ask) = the human signal per block once gates are green.
|
||||
- [x] A merged 1b82a25 (routing `confirmed` row a2f352e)
|
||||
|
||||
@@ -0,0 +1,48 @@
|
||||
# CONTRACT — advisor-call-points, run A (BDR-150 amendment)
|
||||
- date: 2026-11-17 | flow: feat | branch: feature/advisor-call-points (off develop)
|
||||
- status: active
|
||||
- plan: .claude/tasks/plans/2026-11-17-advisor-call-points-1130.md (r4)
|
||||
|
||||
## REQUEST (verbatim — IMMUTABLE)
|
||||
User 2026-11-17, after the transcript count (main loop 2 advisor calls on Opus, 409k/680k uncached tokens; 18 of 20 opus sub-agents 19 calls on Fable, median 70k; sonnet 0 of 8), answering the three proposals: "oui 1 et 2, et le 3 aussi". Proposal 1: let the judgment agents (plan-challenger, verifier, security-auditor) call the advisor once, before their verdict; sonnet executors stay without; for the security-auditor, advice can add a finding or raise a severity, never clear a semgrep HIGH or CRITICAL. Proposal 2: name the main loop's call points in the skills rather than leave them to its judgment: before settling the approach (ahead of the plan of /feat, /bugfix, /ship-feature), at the second failure of a gate loop before re-dispatching or escalating, and before proposing the merge; the text lives in lib/effort-shift.md § Advisor, the skills cite it, the doctrine-citers census checks it. Proposal 3: count advisor calls per session (main loop vs sub-agents, model served).
|
||||
|
||||
## CLARIFICATIONS
|
||||
- [gated 2026-11-17] user: split in runs. Run A (this contract) = doctrine (CLAUDE.global.md, lib/effort-shift.md § Advisor) + the three judgment agents. Run B = inline call lines in skills/feat, skills/bugfix, skills/ship-feature, lib/verify-secure-loop.md. Run C = the counter.
|
||||
- [gated 2026-11-17] user: the counter (proposal 3) is a section of /memory-feedback (run C).
|
||||
- [internal 2026-11-17] gates round 1 (verifier CONFORME, security PASS) flagged block E: a raise double-counted in BLOCK(n), a no-class finding had no severity → block E r5 (plan), criterion 4 gains 'so it counts once' and 'REPORTED as LOW'.
|
||||
- [gated 2026-11-17] user: an advisor-added or -raised security finding takes the severity of the STEP 3 checklist class it matches; no matching class → REPORTED, non-blocking (block E r4).
|
||||
- [internal 2026-11-17] executor NEED-DECISION: block B line reworded to "(for work outside them, see the / triggers in CLAUDE.global.md § Workflow):" (census T3 read "§ Workflow names").
|
||||
- [internal 2026-11-17] re-challenge → plan r4 (section "r4 changes"): criterion 1 markers + 315 lines, criterion 2/4 markers, EVIDENCE: pending lines.
|
||||
- [internal 2026-11-17] challenge round 1 → plan r3 (section "r3 changes"): criteria re-scoped (criterion 2 counts STEP inside § Advisor only), blocks per r3.
|
||||
- [internal 2026-11-17] advisor review: blocks C-E carry "absent or erroring → proceed" (they read their agent file and CLAUDE.global.md, never lib/effort-shift.md); block E carries a grounding clause (added or raised finding cites a file:line read); "at most once" wording in both block A and B; no skill step numbers in block B.
|
||||
|
||||
## RELATED MEMORY
|
||||
- BDR-150 (accepted): amended here, "sub-agents do not" (c3507ea) becomes "the three judgment agents at most once"; "never routed or pinned" kept.
|
||||
- LRN-294: honored, scope set from observed tool lists, rest named a prose rule.
|
||||
- BDR-066 / LRN-083: loop decisions stay in the main loop; advice is input.
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
1. CLAUDE.global.md carries block A: the three-agent scope and the § Advisor pointer.
|
||||
CHECK: cd /home/bchanot/Documents/claude && echo "$({ grep -c 'and security-auditor at most once, before the verdict; other' CLAUDE.global.md || true; })/$({ grep -c 'sub-agents do not. Fable is never routed' CLAUDE.global.md || true; })/$({ grep -cF '`~/.claude/lib/effort-shift.md` § Advisor' CLAUDE.global.md || true; })/$(wc -l < CLAUDE.global.md)"
|
||||
EXPECT: 1/1/1/315
|
||||
EVIDENCE: MET exit=0 marker-found :: 1/1/1/315
|
||||
2. lib/effort-shift.md § Advisor carries block B, with no skill step number.
|
||||
CHECK: cd /home/bchanot/Documents/claude && sec() { sed -n '/^## Advisor/,/^## Never/p' lib/effort-shift.md; }; echo "$(grep -c '^## Advisor' lib/effort-shift.md)/$(sec | grep -c 'Main loop, at least at these points')/$(sec | grep -c 'once per verify-secure run, at the first gate loop')/$(sec | grep -c 'never enters an executor brief')/$(sec | grep -c 'once per dispatch, before their verdict')/$(sec | grep -c STEP)"
|
||||
EXPECT: 1/1/1/1/1/0
|
||||
EVIDENCE: MET exit=0 marker-found :: 1/1/1/1/1/0
|
||||
3. Each judgment agent carries its one-call rule with the proceed clause.
|
||||
CHECK: cd /home/bchanot/Documents/claude && for f in plan-challenger verifier security-auditor; do printf '%s/' "$({ grep -c 'Advisor (when listed): at most one call' agents/$f.md || true; })$({ grep -c 'erroring → proceed' agents/$f.md || true; })"; done; echo
|
||||
EXPECT: 11/11/11/
|
||||
EVIDENCE: MET exit=0 marker-found :: 11/11/11/
|
||||
4. Advice can only add: security-auditor routes and tags it, verifier and plan-challenger never clear.
|
||||
CHECK: cd /home/bchanot/Documents/claude && echo "$({ grep -c 'It never removes,' agents/security-auditor.md || true; })/$({ grep -c 'BLOCK(n) like any other' agents/security-auditor.md || true; })/$({ grep -c 'so it counts once' agents/security-auditor.md || true; })/$({ grep -c 'is REPORTED as LOW,' agents/security-auditor.md || true; })/$({ grep -c 'Advice alone never clears a' agents/verifier.md || true; })/$({ grep -c 'alone never drops or lowers one' agents/plan-challenger.md || true; })"
|
||||
EXPECT: 1/1/1/1/1/1
|
||||
EVIDENCE: MET exit=0 marker-found :: 1/1/1/1/1/1
|
||||
5. Full make test green (run with GATES_TIMEOUT=400).
|
||||
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test </dev/null 2>&1 | tail -1
|
||||
EXPECT: all suites green
|
||||
EVIDENCE: MET exit=0 marker-found :: all suites green
|
||||
6. Touched lines ≤ 80 columns; blocks applied verbatim from plan r4; no other wording changed in the five files (manual).
|
||||
|
||||
## FILE SCOPE
|
||||
CLAUDE.global.md (§ Workflow bullet ~:81-85), lib/effort-shift.md (§ Advisor body ~:103-110), agents/plan-challenger.md (§ RULES), agents/verifier.md (§ RULES), agents/security-auditor.md (§ RULES).
|
||||
@@ -0,0 +1,198 @@
|
||||
# PLAN — advisor call points, run A (r4 after re-challenge)
|
||||
Contract: .claude/tasks/contracts/2026-11-17-advisor-call-points-1130.md
|
||||
Branch: feature/advisor-call-points (off develop)
|
||||
|
||||
## Why
|
||||
User 2026-11-17 approved points 1 and 2 after transcript data: since /advisor
|
||||
(2026-11-16 16:19Z) the main loop called the advisor 2 times in 3 skill runs
|
||||
(served by Opus, 409k and 680k uncached input tokens each); 18 of 20 opus
|
||||
sub-agents called it (19 calls, Fable, median 70k tokens, 1.46M total); 0 of 8
|
||||
sonnet sub-agents. The doctrine of c3507ea ("main loop only") is inverted by the
|
||||
data on both use and cost. Reverses BDR-150's "sub-agents do not" for the three
|
||||
judgment agents.
|
||||
|
||||
## Files (5)
|
||||
1. CLAUDE.global.md § Workflow, lines 81-85: replace the whole "- Stronger model
|
||||
needed …" bullet with block A (verbatim; 8 lines, file 312 → 315, guard 320).
|
||||
2. lib/effort-shift.md § Advisor (lines 101-110): replace the section body
|
||||
(heading kept) with block B (verbatim). Nothing else in the file changes.
|
||||
3. agents/plan-challenger.md § RULES: append block C as the last bullet of the
|
||||
RULES list (before `## ORCHESTRATOR PROTOCOL`).
|
||||
4. agents/verifier.md § RULES: append block D as the last bullet of the RULES
|
||||
list (before `## ORCHESTRATOR PROTOCOL`).
|
||||
5. agents/security-auditor.md § RULES: append block E as the last bullet of the
|
||||
RULES list (before the next `## ` heading).
|
||||
|
||||
### Block A (CLAUDE.global.md)
|
||||
```
|
||||
- Stronger model needed (an approach to settle before building, a stuck
|
||||
problem, a long task before calling it done) → the main loop calls
|
||||
the advisor tool when it is listed (settings `advisorModel`, Fable,
|
||||
set by /advisor), at least at the points of
|
||||
`~/.claude/lib/effort-shift.md` § Advisor; plan-challenger, verifier
|
||||
and security-auditor at most once, before the verdict; other
|
||||
sub-agents do not. Fable is never routed or pinned: the router tops
|
||||
out at opus (BDR-150).
|
||||
```
|
||||
|
||||
### Block B (lib/effort-shift.md § Advisor body)
|
||||
```
|
||||
Fable runs as the advisor (settings `advisorModel`), never a route or pin
|
||||
target (BDR-150). It is a server tool: the router cannot see or refuse it.
|
||||
|
||||
Main loop, at least at these points (for work outside them, see the
|
||||
triggers in CLAUDE.global.md § Workflow):
|
||||
1. Before settling an approach: ahead of writing a skill's plan (`/feat`,
|
||||
`/bugfix`, `/ship-feature`).
|
||||
2. When stuck: once per verify-secure run, at the first gate loop to fail
|
||||
twice (floor, conformity, security, or a second structural failure),
|
||||
before re-dispatching or escalating. At a cap the STOP diagnosis
|
||||
reuses that advice and says it predates the last iteration. The
|
||||
advice stays in the main loop: it feeds the main loop's own decision
|
||||
(a contract micro-gate, an early escalation, the STOP diagnosis) and
|
||||
never enters an executor brief.
|
||||
3. Before proposing a merge (`gitflow finish`) or calling a long task
|
||||
done.
|
||||
|
||||
Sub-agents: plan-challenger, verifier and security-auditor call it at most
|
||||
once per dispatch, before their verdict; executors and every other
|
||||
sub-agent do not, even when the tool is listed.
|
||||
|
||||
Advisor absent or erroring (Fable out of credits, for example) → proceed
|
||||
as written. Advice is input, never consent: it waives no gate, cap or
|
||||
guard; at a loop cap it feeds the STOP diagnosis.
|
||||
```
|
||||
|
||||
### Block C (agents/plan-challenger.md)
|
||||
```
|
||||
- Advisor (when listed): at most one call, after drafting your findings
|
||||
and before the verdict, whatever the harness prompt schedules; absent
|
||||
or erroring → proceed. Advice may add or sharpen a finding. Advice
|
||||
alone never drops or lowers one: a change rests on your own re-read,
|
||||
cited at file:line.
|
||||
```
|
||||
|
||||
### Block D (agents/verifier.md)
|
||||
```
|
||||
- Advisor (when listed): at most one call, after STEP 4 and before
|
||||
STEP 5, whatever the harness prompt schedules; absent or
|
||||
erroring → proceed. Advice may send you back to a criterion: a
|
||||
resulting NOT-MET cites the file:line you read, ends with
|
||||
`(advisor-prompted)` and counts in STEP 5 like any other. Advice adds
|
||||
no gap outside the contract's criteria. Advice alone never clears a
|
||||
gap and is never evidence for a MET: any change rests on your own
|
||||
re-read or run (STEP 2).
|
||||
```
|
||||
|
||||
### Block E (agents/security-auditor.md)
|
||||
```
|
||||
- Advisor (when listed): at most one call, after STEP 4 and before
|
||||
STEP 5 and any REPORT write, whatever the harness prompt schedules;
|
||||
absent or erroring → proceed. Advice may add a finding or raise a
|
||||
severity, cited at a file:line you read. An added finding's rule/check
|
||||
is `advisor:<STEP 3 class>`; a raised one keeps its own line, its
|
||||
rule/check becoming `<rule>+advisor`, so it counts once. The severity
|
||||
is that STEP 3 class's, which overrides the STEP 2 mapping for that
|
||||
finding only; an added finding matching no class is REPORTED as LOW,
|
||||
and a raise matching no class changes nothing. It enters STEP 5's
|
||||
dedup and BLOCK(n) like any other, and PROOF ends with `; advisor <n>
|
||||
added/raised`. It never removes, lowers or waives a finding from
|
||||
semgrep, the checklist or STEP 4.
|
||||
```
|
||||
|
||||
## Edge cases
|
||||
- Each block's lines ≤ 80 columns (block A keeps the 2-space bullet indent).
|
||||
- Blocks C-E sit inside the RULES list, keeping its blank-line-between-bullets
|
||||
style if the list uses one.
|
||||
- No other wording in the five files changes (wiring points, Limits, ask-tier,
|
||||
`## Never` untouched).
|
||||
|
||||
## Tests
|
||||
No hermetic test asserts this prose (grep lib/tests: none). Oracles are the
|
||||
contract's grep criteria + full `make test`. The doctrine-citers census (T6,
|
||||
lib/tests/doctrine-citers.test.sh:213-214) also scans CLAUDE.global.md, so block
|
||||
A's `~/.claude/lib/effort-shift.md` § Advisor citation is checked once it sits
|
||||
on one line (the extractor is per line; r4 keeps it on one line), and block
|
||||
B's `CLAUDE.global.md § Workflow` citation too.
|
||||
|
||||
## Split (user 2026-11-17)
|
||||
- Run A (this plan): doctrine + three judgment agents, 5 files.
|
||||
- Run B: inline advisor call lines at the step sites (plan step of skills/feat,
|
||||
skills/bugfix, skills/ship-feature; second-failure and cap sites in
|
||||
lib/verify-secure-loop.md; the merge proposal), citing
|
||||
`lib/effort-shift.md § Advisor`.
|
||||
- Run C (point 3): advisor usage counter as a section of /memory-feedback
|
||||
(user choice); dedupe usage rows by message.id, model from the
|
||||
`advisor_message` iteration, main transcript vs subagents/*.jsonl.
|
||||
- Stale citers for doc-sync / capitalize: README, USAGE, CHANGELOG
|
||||
[Unreleased] advisor bullet, BUGS-FOUND d292911 residual, BDR-150 status,
|
||||
LRN-294.
|
||||
|
||||
## Disposition
|
||||
- amends BDR-150 (its "sub-agents do not" clause, c3507ea) by allowing the three
|
||||
judgment agents one call; keeps "never routed or pinned".
|
||||
- applies LRN-294 only partly: sub-agents get the tool, CLAUDE.global.md and a
|
||||
harness prompt asking for "at least once before … and once before declaring
|
||||
done"; blocks C-E say the one-call rule overrides it, but that is prose
|
||||
against a harness instruction: logged as a BUGS-FOUND residual at capitalize.
|
||||
- honors BDR-066/LRN-083: loop decisions stay in the main loop; advice is input.
|
||||
|
||||
## r3 changes (challenge round 1: correctness FATAL(2), robustness CONCERNS(3), simplicity CONCERNS(1))
|
||||
- C1 BLOCKER oracle: contract criterion 2 counts STEP inside § Advisor only.
|
||||
- C2 BLOCKER + R5: block E routes an advisor-added/raised finding into STEP 5's
|
||||
merge and BLOCK(n), tagged `advisor-added` / `advisor-raised from <sev>` in
|
||||
<why>; REPORT written after the advisor call (R6).
|
||||
- R3: block D mirrors E (never clears NOT-MET, UNVERIFIABLE, FLOOR, out-of-scope;
|
||||
may add a gap at file:line); C5: MET evidence defers to STEP 2.
|
||||
- R4: block C "may add or sharpen, never drop or lower".
|
||||
- S1 + C4: block A minimal: keeps its generic triggers, points to
|
||||
`~/.claude/lib/effort-shift.md` § Advisor, no copied list.
|
||||
- S4 + R1 + C8: block B = the approved points only. One stuck call per loop at
|
||||
its second failure (structural failures included), the cap reuses it; "any
|
||||
non-trivial change" dropped; done + merge one point.
|
||||
- R2: second-failure advice stays in the main loop, never enters an executor
|
||||
brief (verify-secure-loop "nothing else" briefs kept).
|
||||
- S2: cost sentence and sub-agent evidence sentence moved out of block B (the
|
||||
rationale goes to the BDR-150 amendment).
|
||||
- R6 + C7: blocks C-E say "whatever the harness prompt schedules"; block B names
|
||||
the residual.
|
||||
- C6: main-loop calls served by Opus are explained by the /advisor output in
|
||||
this conversation ("keeps Opus until /clear"); doctrine names the advisor by
|
||||
`advisorModel`.
|
||||
- S3 rejected in part: the advice-specific clauses in C and D stay, because
|
||||
R3/R4 need them (they now carry new rules, not repeats).
|
||||
|
||||
## r4 changes (re-challenge: correctness CONCERNS(3), robustness CONCERNS(3), simplicity CONCERNS(1); no third round, these go to the CHALLENGE SUMMARY)
|
||||
- RC1/RR1: block A keeps "`~/.claude/lib/effort-shift.md` § Advisor" on one
|
||||
line so the per-line census extractor sees it; criterion 1 greps it.
|
||||
- RC2: contract criteria 1-5 carry `EVIDENCE: pending` (gates.sh ERROR otherwise).
|
||||
- RC3/RR2/RS2: block D: advice can only send the verifier back to a criterion;
|
||||
a resulting NOT-MET is tagged `(advisor-prompted)` and counts in STEP 5; no
|
||||
gap outside the criteria; advice alone never clears; no copied gap list.
|
||||
- RR3/RC5/RC6/RS3/RR8: block E: rule/check `advisor:<STEP 3 class>` or
|
||||
`<rule>+advisor`; severity = the matching STEP 3 class (overrides the STEP 2
|
||||
mapping for that finding only); no matching class → REPORTED, non-blocking
|
||||
(so one opinion cannot BLOCK, hence no /hotfix revert on opinion alone);
|
||||
PROOF gets `; advisor <n> added/raised`.
|
||||
- RR4: calls placed late: verifier/auditor after STEP 4 before STEP 5;
|
||||
challenger after drafting findings.
|
||||
- RS1/RR5/RC4: "advice alone never drops/lowers/clears": a change rests on the
|
||||
agent's own re-read, cited.
|
||||
- RR6: main loop stuck call once per verify-secure run; the STOP says the
|
||||
advice predates the last iteration.
|
||||
- RC7: block B points are a floor ("at least"), CLAUDE.global.md § Workflow
|
||||
triggers cover work outside them.
|
||||
- RS4: block B residual sentence dropped (BUGS-FOUND carries it); "whatever the
|
||||
harness prompt schedules" kept (one verifier made 2 calls on 2026-11-16).
|
||||
- RR7: live-install note: ~/.claude/CLAUDE.md and ~/.claude/agents are symlinks
|
||||
into this repo, so the edits apply to every session as soon as written,
|
||||
including this run's own verifier and security-auditor. Rollback:
|
||||
`git restore` of the five files on the branch.
|
||||
- Execution NEED-DECISION (internal, 2026-11-17): census read "§ Workflow
|
||||
names" as heading "Workflow names" (T3 DANGLING). Block B line reworded so the
|
||||
citation ends at "§ Workflow)". Agent RULES bullets sit tight under the
|
||||
previous bullet (the lists are tight), accepted.
|
||||
- Gate findings (security PASS + verifier CONFORME, 2026-11-17): block E r5.
|
||||
A raise keeps its own line (rule/check `<rule>+advisor`) so STEP 5 dedup counts
|
||||
it once; an added no-class finding is REPORTED as LOW; a raise with no class
|
||||
changes nothing.
|
||||
Reference in new issue
Block a user