chore(memory): H6a journal, LRN-154 correction
This commit is contained in:
1 parent
55574edc2a
commit
20448395f3
3 files changed
+20
-4
No files matched your search
@@ -747,3 +747,4 @@ rules:
|
||||
- feature/fable-5-2 (user ask mid-run): fable alias → claude-fable-5-2 (ca1dc9f), rename done by another session in this checkout, split from BLK-049, id probed live, kit 640/0. Live CLI warns: deny Bash(git push * :**) matches as * wildcard (pre-existing, H item).
|
||||
- /bugfix safety-lows (block H4b): code-limits private state dir (mkdir -m 700 no -p + one find test), session-start runner timeout→gtimeout→perl alarm, pre-commit fails closed on git diff and filter errors (generator lib/gitflow.sh + both copies), memory.sh rewrap, claude-stub env log path (1f107c3). 4 rounds: generator was the hook source (decision a), GATE 2 MEDIUM stat/lstat race closed, lint regressions fixed. Residual: perl alarm kills the exec'd process only (TODO).
|
||||
- /bugfix feedback-followups (block H5, 4d follow-ups): post-fix split + 3rd pick retired + one-slot transcript cache + strict labels/state + key-set pins (9f9412a, docs). 3 challenge lenses FATAL on r1 (midnight cutoff, validator rejecting own rows, text-block extraction losing every join); 3 executor rounds (locals, at bound, legacy closed flag). RSS 279.8 → 267.7 MB on 16 records. tsc not done (no compiler, new dep), l:<root> kept (49.7 KB of 4 MiB), image prompts dropped (0 instances). LRN-288.
|
||||
- /bugfix bugs-found-prose (block H6a): 10 prose BUGS-FOUND items closed (77041e5): handover rooting + PROJECT_ROOT line + BDR status filter, plugin-gate quoting/unsafe-root/common-dir/$HOME (+ profile.sh refusal T27), advisor rules, packs vocabulary, graphify labels. 4 rounds; GATE 2 MEDIUM single-quote break-out closed by the unsafe-root rule. D1b and dead-entry items closed; 5 pre-existing findings logged. LRN-154 corrected.
|
||||
@@ -1380,6 +1380,7 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s
|
||||
- **Future application**: untracking any generated file — know regeneration command BEFORE merging, `ls` the path right after `finish`. If nothing regenerates it, keep it tracked.
|
||||
- **graphify specifics**: `graphify install --platform claude` copies the skill and touches nothing else. `graphify claude install` is a different command — it writes the CLAUDE.md section and the `.claude/settings.json` hooks, rewrites both guarded configs, and does NOT copy the skill. Confusing the two wastes a recovery attempt.
|
||||
- **Reference**: `CLAUDE.md` machine-owned section, commit 80ccdaf. Links [[BDR-090]].
|
||||
- **Status (2026-11-13)**: superseded in part 2026-11-13 (77041e5): graphifyy 0.9.67 'graphify install --platform claude' appends a # graphify block to ~/.claude/CLAUDE.md and a hook; install-plugins.sh's EXIT trap reverts both; 'touches nothing else' is wrong
|
||||
|
||||
## LRN-155 — `permissions.ask` under auto mode: the probe beats the doc
|
||||
- **Date**: 2026-09-16
|
||||
|
||||
@@ -18,24 +18,38 @@ Fix the BUGS-FOUND entries unfixed since 2026-11-09 that live in agent, skill, l
|
||||
9. onboard SKILL.md:387-762 and tour SKILL.md:155 "gstack ON/OFF" → the packs vocabulary used since D3 (`pack gstack-dev on/off`, `profile.sh current`); rewrap plugin-check SKILL.md:17, plugin-gate.md:45, USAGE.md:182; USAGE.md:1022 transcript gains the ↻ glyph.
|
||||
10. graphify: .gitignore:54-56, plugins.lock.json:37, update-all.sh:310-312 (point at `make plugin`, no manual `graphify claude install`), install-plugins.sh:688/690/1269 labels and :694-695 comment say what the steps do now (the trap reverts the CLAUDE.md block and hook). LRN-154 gets a `memory.sh status` correction line in STEP 8 (registry append-only), not an edit.
|
||||
|
||||
- [gated 2026-11-13, round 2: GATE 1 ECARTS(2) + GATE 2 MEDIUM/LOWs] FILE SCOPE += lib/tests/session-banner.test.sh (SB10 locks follow item 8: lock `diff '<profile>'` single-quoted and `--git-common-dir`), lib/profile.sh + lib/tests/profile.test.sh (deterministic refusal: `find_root`/`require_project_root` reject a root that resolves (`cd -P`) to `$HOME`, test included), skills/init-project/SKILL.md:43, skills/ship-feature/SKILL.md:27 (the "A) fix plugins" citers get the print-only definition).
|
||||
R2-a plugin-gate + plugin-check: before any template, a PROJECT_ROOT holding `'` or a newline or control char is never substituted: print the commands and run nothing (one rule sentence); refusal text at :75-76 names the three causes (no git root, linked worktree/submodule, $HOME).
|
||||
R2-b handover-doc-writer: the ROOT read block opens EVERY Bash call that uses $ROOT (say so once), uses `"${ROOT:?}"` at each use; :158-159 commits read rooted with `git -C "${ROOT:?}"`; draft/audit paths rooted (`"${ROOT:?}/.audit/…"`) in both agents; a root holding a newline or control char → `STATUS: BLOCKED` (client-handover-writer checks before writing the PACKAGE).
|
||||
R2-c client-handover-writer remedy: `memory.sh -C '<root>' status …` single-quoted, plus the same "root holding `'` → print with a warning, never run" rule.
|
||||
R2-d item 9 residue: plugin-gate.md:46 ≤ 80, tour SKILL.md:155 ≤ 80, onboard :673/:682/:706 consistent (the design-review fallback condition and its note name the SAME pack, the one the L3b probe at :610-611 actually reads, or add the gstack-design probe there), onboard :549-550 qualified `make plugin`, plugin-advisor :265-266 drops `extras` from pack values, USAGE.md:179 ≤ 80.
|
||||
R2-e handover §6.1: decisions with an empty status word are listed separately as "status unreadable (n)" in the method sentence, not silently dropped; the sentence sits at the close of §6.1 (no method-note section exists).
|
||||
|
||||
- [gated 2026-11-13, round 2 executor deviation accepted] the $HOME refusal sits in `require_project_root` (every mutating command); `find_root` still answers $HOME for read-only `current`/`diff`.
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
1. Each of the 10 items changed in its file (read check by the verifier, item by item).
|
||||
CHECK: cd /home/bchanot/Documents/claude && git diff --stat develop -- agents/handover-doc-writer.md agents/client-handover-writer.md agents/plugin-advisor.md lib/plugin-gate.md skills/onboard/SKILL.md skills/tour/SKILL.md skills/plugin-check/SKILL.md USAGE.md .gitignore plugins.lock.json update-all.sh install-plugins.sh | tail -1 | grep -c '12 files changed'
|
||||
EXPECT: 1
|
||||
EVIDENCE: PENDING
|
||||
EVIDENCE: MET exit=0 marker-found :: 1
|
||||
2. No "gstack ON/OFF" left in onboard/tour; no `extras` among plugin-gate's accepted tokens.
|
||||
CHECK: cd /home/bchanot/Documents/claude && echo $(grep -c 'gstack ON/OFF\|gstack ON\b' skills/onboard/SKILL.md skills/tour/SKILL.md | grep -vc ':0$')
|
||||
EXPECT: 0
|
||||
EVIDENCE: PENDING
|
||||
EVIDENCE: MET exit=0 marker-found :: 0
|
||||
3. plugins.lock.json valid JSON; shellcheck clean on update-all.sh and install-plugins.sh changes (no new finding vs develop).
|
||||
CHECK: cd /home/bchanot/Documents/claude && jq . plugins.lock.json >/dev/null && echo JSON-OK
|
||||
EXPECT: JSON-OK
|
||||
EVIDENCE: PENDING
|
||||
EVIDENCE: MET exit=0 marker-found :: JSON-OK
|
||||
4. Suites that read these files stay green: handover-memory-contract, doctrine-citers, skill-routing-census, curated-config-guard, portability-census.
|
||||
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test suite=lib/tests/handover-memory-contract.test.sh 2>&1 | tail -1
|
||||
EXPECT: all suites green
|
||||
EVIDENCE: PENDING
|
||||
EVIDENCE: MET exit=0 marker-found :: all suites green
|
||||
6. session-banner and profile suites green.
|
||||
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test suite="lib/tests/session-banner.test.sh lib/tests/profile.test.sh" 2>&1 | tail -1
|
||||
EXPECT: all suites green
|
||||
EVIDENCE: MET exit=0 marker-found :: all suites green
|
||||
5. make test green (manual, bun on PATH).
|
||||
(manual: full run by the round-2 executor 2026-11-13 → "SUITE: all GREEN / all suites green")
|
||||
|
||||
## FILE SCOPE
|
||||
agents/handover-doc-writer.md, agents/client-handover-writer.md, agents/plugin-advisor.md, lib/plugin-gate.md, skills/onboard/SKILL.md, skills/tour/SKILL.md, skills/plugin-check/SKILL.md, USAGE.md, .gitignore, plugins.lock.json, update-all.sh, install-plugins.sh. LRN-154 + BUGS-FOUND → STEP 8.
|
||||
Reference in new issue
Block a user