Files
claude_mac/.claude/audits/BUGS-FOUND.md
T

30 KiB

BUGS-FOUND

  • lib/toggle-external.sh:350 (pre-cleanup numbering; usage(), now near :370) — usage() prints header lines 3-26 only (sed -n '3,26p'); the managed-tool list continues to line 32, so --help omits 8 of the 14 tools. Severity: low (help text only). Discovered while: code-clean run 2026-10-12 (B5 audit). Not fixed (cleanup and bugfix are separate concerns). FIXED 2026-10-12 (inline on chore/code-clean, no /bugfix pipeline): usage() now prints lines 3 .. closing banner (sed -n '3,/^# ====/p' | sed '$d'), no numeric range; --help shows all 14 tools (36 lines).
  • hooks/session-start.sh:200-217 + lib/detect-plugins.sh:49-52 (detect_uiux_pro_max) — the banner "ALWAYS ON" row and the ui-ux-pro-max toggle row read user-scope settings.json / plugin cache, not the effective profile (profile.sh current --plain, BDR-134 single source of truth): a dev or minimal project shows ui-ux-pro-max on; pr-review-toolkit on in max/audit is not shown. Severity: low (banner only). Discovered while: code-clean 2026-11-09 (phase 5 sweep). Not fixed. FIXED 2026-11-10 (/bugfix, bugfix/banner-effective-profile): new list_on_plugins (lib/detect-plugins.sh) = effective profile for the ids lib/profiles manages, user-scope true for the others; the ✅ row reads it (model-router now shown, user choice) and detect_uiux_pro_max = cache AND enabled; pipefail-safe for doctor.sh; test lib/tests/session-banner.test.sh SB1-SB8.
  • hooks/session-start.sh:177-183 + agents/plugin-advisor.md:193,197,211,226,233,263 vs doctor.sh:520-526 — passive-cost constants disagree (banner/advisor: gstack 2750, ui-ux-pro-max 400, context7 200, graphify 300; doctor dropped gstack/context7/graphify 2026-09-28 as double counting, ui-ux-pro-max 670); agents/status-reporter.md:26-30 names doctor as source of truth. Severity: low (estimates). Discovered while: code-clean 2026-11-09. Not fixed. FIXED 2026-11-10 (/bugfix, bugfix/passive-cost-source, split by the user): stale hand figures removed from the banner (💰 budget row + _plugin_costs + now-dead detect_plan deleted), plugin-advisor and status-reporter (cost → make doctor); doctor keeps its measured ui-ux 670; tests SB9/SB10, detect-plan.test.sh renamed hook-recursion-guard.test.sh. Measured-cost API = TODO feature.
  • hooks/session-start.sh:404-408 (_digest_journal) — greps ^- without skipping HTML comments; templates/memory/journal.md:19-21 holds - <line …> bullets inside <!-- -->, so a template-born project prints "- journal: <line 3-5 max>" in the session digest until its first journal write. Fix template and digest together. Severity: low. Discovered while: code-clean 2026-11-09 (phase 4 sweep). Not fixed. FIXED 2026-11-09 (/hotfix, bugfix/digest-journal-comment): the digest skips HTML comment blocks (opener anchored at line start, CommonMark rule; an inline <!-- in a bullet stays text), test SD18; the template stays byte-identical (copied by onboarder/init-project/memory.sh), so fixing the template was not needed.
  • agents/status-reporter.md:35 + agents/plugin-probe.md:22-23,69 — report installed (cache) or user-scope claude plugin list state as "active"; the per-project state is the PROFILE line (current --plain). Severity: low. Discovered while: code-clean 2026-11-09. Not fixed. FIXED 2026-11-10 (/bugfix, bugfix/banner-effective-profile): status-reporter takes Plugins ON: from list_on_plugins + pack-*=on (cache = installed only); plugin-probe comment and plugin-advisor INPUT name PROFILE as the per-project source (PLUGINS = installed).
  • agents/handover-doc-writer.md:77-84 — parses registry statuses by hand ("open vs resolved"), the class behind the BLK-032..034 false-open (BDR-129). A fix must read memory.sh -C <project> index on v2 registries and keep the ## Index read on v1 registries never upgraded (memory.sh index ignores a v1 Index; memory.sh:21-23). Severity: medium (client deliverable). Discovered while: code-clean 2026-11-09. Not fixed. FIXED 2026-11-11 (/bugfix, bugfix/handover-memory-status): new reconcile_blk_classify (lib/reconcile.sh: strict word on v2, single-word status label on v1 via _mem_v1_word, never the ## Index; closed omitted, prose/mixed/closed/### entries = unreadable); STEP 9 rooted on the PACKAGE root; SYNTH REPORT fenced with a mandatory MEMORY: line, relayed to the user and into the 9.7 report; test lib/tests/handover-memory-contract.test.sh HM1-HM3 runs the shipped STEP 9 block. The request's "keep the v1 Index read" was dropped after challenge round 1 (the Index drifts, BDR-129, LRN-055).
  • agents/handover-doc-writer.md §6.1 — vulgarizes BDRs with no status filter: a superseded or deprecated decision can read as current in the client deliverable. Severity: medium (client deliverable). Discovered while: /bugfix G5 challenge round 1. Not fixed. FIXED 2026-11-13 (77041e5, block H6a): §6.1 lists accepted/implemented/proposed only, superseded/deprecated left out, empty status counted as unreadable in the closing sentence.
  • lib/memory.sh upgrade (mem_want, _mem_verdict_diff skips Index-stated IDs) — may take a stale v1 ## Index cell over a **Statut** : body line. UNVERIFIED: check before recommending upgrade on v1 repos (faunosteo). Severity: medium if real (wrong status written into the body). Discovered while: /bugfix G5 challenge round 1. Not fixed. FIXED 2026-11-13 (/bugfix, bugfix/memory-sh-residuals d8e62c1): VERIFIED real (a **Statut** : label is unreadable by the strict reader, so the Index cell was written); one effective status (strict word, else the v1 body word) feeds flush, Index-stated and the oracle; the body word is written as the dated upgrade line; Index superseded/deprecated still wins; fixtures ix1-ix7.
  • agents/handover-doc-writer.md STEP 10 and other paths — git log and file reads are cwd-relative, not rooted on the PACKAGE root; the PACKAGE PROJECT: line is space-separated, so a root containing a space mis-parses (the G5 orchestrator check only catches it when blockers.md exists). Severity: low. Discovered while: /bugfix G5 challenge round 1. Not fixed. FIXED 2026-11-13 (77041e5): whole-line PROJECT_ROOT in the PACKAGE, every git/file read and the draft path rooted on "${ROOT:?}".
  • lib/memory.sh memory_legacy_status default range (## ID to the next ## BLK-) — on a v1 registry a ### BLK- entry after a ## BLK- entry feeds its status line to the ## entry: a resolved ### entry can close the open ## entry above it, which then leaves the handover §5 (the ### ID itself is flagged unreadable). Severity: low (rare dialect, flagged indirectly). Discovered while: /bugfix G5 verifier. Not fixed. FIXED 2026-11-13 (d8e62c1): one awk reader, the range ends at the next heading of another entry of the prefix at any level; T15-probed-openset.
  • agents/handover-doc-writer.md:83 + agents/client-handover-writer.md:1201-1202 — ROOT="<PROJECT root from the PACKAGE>" pastes the root into a double-quoted literal, and the printed remedy memory.sh -C <root> status … leaves <root> unquoted: a root with ", $(…), a backtick or a space breaks the line or splits the path. Value is the operator's own git rev-parse --show-toplevel, not registry data. Severity: low. Discovered while: /bugfix G5 security gate. Not fixed. FIXED 2026-11-13 (77041e5): ROOT read through a quoted heredoc with a one-line pre-paste rule, control-char root BLOCKED, remedy single-quoted with a ' rule.
  • lib/profile-state.jq (jq -r output read by lib/detect-plugins.sh list_on_plugins / detect_gstack) — a settings value carrying a newline can forge a plugin:<id>=on line in the PROFILE_PLAIN text, so the banner or status shows a plugin ON that is not. Display-only, pre-existing for detect_gstack. Severity: low. Discovered while: /bugfix G1+G4 security gate 2026-11-10. Not fixed. FIXED 2026-11-13 (9045a60): clean turns LF/CR into a space on every free-text value (profile, flag, model, mcp-off, connector, pack key); plugin: lines print only ids matching \A[A-Za-z0-9._-]+@[A-Za-z0-9._-]+\z; tests T28-forge, T28-nl-id.
  • agents/plugin-advisor.md embedded RULE (~:217) — the embedded signal can come from REQUEST keywords alone ("driver", "kernel", :58) and maps to ↻ SET : minimal, against the gated rule "minimal reachable from project-level signals only" (only DISABLE is limited to project signals, :124-126). Gate confirmation limits it. Severity: medium (gated decision not fully enforced). Discovered while: /feat D3 verifier 2026-11-11. Not fixed. FIXED 2026-11-13 (77041e5): SET minimal needs a project-level probe; REQUEST keywords alone give a NOTE.
  • lib/plugin-gate.md:49-51 — pack extras accepted from an advisor token, but pack-extras bundles 21st-ai (credit-metered generate/iterate), same reason as the higgsfield exclusion; no advisor rule emits it. Severity: medium. Discovered while: /feat D3 security gate. Not fixed. FIXED 2026-11-13 (77041e5): extras never accepted from an advisor token (manual profile.sh enable extras only).
  • skills/onboard/SKILL.md:255 + agents/plugin-advisor.md:289 — say make plugin installs a pinned ctx7; plugins.lock.json pins "latest" (install-plugins.sh:573-574). Fix the wording or pin ctx7. Severity: low. Discovered while: /feat D3 security gate. Not fixed. FIXED 2026-11-13 (77041e5): wording says ctx7 latest (plugins.lock.json pins latest).
  • agents/plugin-advisor.md:281 BLOCK "Superpowers skills missing → make plugin" + lib/plugin-gate.md:61 "A) fix plugins" undefined — cwd-dependent make plugin in an onboarded foreign repo; qualify with the claude-config repo or make it print-only. Severity: low. Discovered while: /feat D3 security gate. Not fixed. FIXED 2026-11-13 (77041e5): print-only "run make plugin in your claude-config checkout"; "A) fix plugins" defined the same in plugin-gate, init-project, ship-feature.
  • lib/plugin-gate.md templates — tokens and "<PROJECT_ROOT>" sit in double quotes ($() / backticks still expand; protection = the prose closed-list check); linked worktree: the apply check compares --show-toplevel but profile.sh writes at the parent of --git-common-dir (confirmed path ≠ written path, same repo); PROJECT_ROOT = $HOME as a git repo passes the check and find_root writes ~/.claude/settings.local.json. Severity: low (defense in depth). Discovered while: /feat D3 security gates. Not fixed. FIXED 2026-11-13 (77041e5): single quotes, unsafe roots printed never run, apply check vs parent of --git-common-dir, $HOME refused (and deterministically in profile.sh require_project_root, T27).
  • skills/onboard/SKILL.md:387-762 and skills/tour/SKILL.md:155 — still "gstack ON/OFF" (packs vocabulary elsewhere since D3); cosmetic: unwrapped lines skills/plugin-check/SKILL.md:17, lib/plugin-gate.md:45, USAGE.md:182, USAGE.md:1022 transcript without the ↻ glyph. Severity: low. Discovered while: /feat D3 verifier. Not fixed. FIXED 2026-11-13 (77041e5): packs vocabulary (pack gstack-dev/design/browser), gstack-design probe added, lines rewrapped, USAGE transcript glyph.
  • Registry dialects the classifier cannot read: game is format: 2 but written in the date: … · status: dialect (decision statuses unreadable), faunosteo uses closed / active words, v1 date dialects give no 90-day proposed candidate. /prune-memory shows them on the info-only [Status unreadable] line; a dialect migration (memory.sh upgrade or a one-shot rewrite per project) is not designed. Severity: medium (prune finds no candidate on those projects). Discovered while: /feat D4 challenge round 1. Not fixed. RESOLVED 2026-11-14 (BDR-125 close-out J), no code change: the migration path exists. v1 files: memory.sh upgrade (faunosteo done on chore/memory-v2 530af1b, its closed/active words upgraded, user merges). v2-headed files in the v1 date: … · status: dialect (game: 80+ BDRs, many mixed/prose lines): /prune-memory STEP 2 [Status unreadable] lists the IDs and the user gives each word (memory.sh status <ID> "<word>"); a judgment per entry, never an automatic rewrite. game run left to the user (another session has uncommitted work open there, a parallel rewrite of decisions.md would collide). 90-day proposed candidates on v1 date dialects: accepted limit (no date = no candidate, STEP 1.A says so).
  • skills/prune-memory STEP 4 — status drift check (Index vs body, title word vs status word) dropped from D4 as an ungated new gate. Severity: low. Discovered while: /feat D4 challenge round 2. Not fixed. WONTFIX 2026-11-14 (BDR-125 close-out J): BDR-129 makes the Index never a status source and the title never a status, so an Index/body or title/status drift changes no decision of any reader; memory.sh check already guards the structure. A new gate without a consumer is not added.
  • lib/memory.sh:657 memory_legacy_status reads MEM_LEGACY_RE from the environment: an ambient export MEM_LEGACY_RE also widens memory.sh upgrade's <end> readers (_mem_legacy_open, _mem_explicit_status, _mem_repair_one, the last one decides a v1 closure write). Fails closed on a bad regex. Fix: explicit 4th positional argument, drop the env read. Severity: low. Discovered while: /feat D4 security gate. Not fixed. FIXED 2026-11-13 (d8e62c1): selector = 3rd positional, env read gone, _MEM_LEGACY_BDR_RE in memory.sh; T15-env-selector-ignored.
  • lib/memory.sh memory_legacy_status <end> range on v1 decisions: the last BDR entry runs to EOF, so a ## Index or other ## section after it would be read by the widened selector (none on disk today). Severity: low. Discovered while: /feat D4 verifier. Not fixed. FIXED 2026-11-13 (d8e62c1), PARTIAL: the range stops at ## Index (the on-disk case); a trailing non-Index ## section is still read, kept so an in-entry ## Update stays readable by the lexical reader (oracle disagreement detection).
  • skills/prune-memory/tests/run-deterministic.sh:13 — SANDBOX="$(mktemp -d …)" unchecked under set -uo pipefail (no -e): a mktemp failure leaves SANDBOX empty and RED-9 targets /red9a, /home9 (fails for a non-root user; trap rm -rf "" deletes nothing). Pre-existing, RED-9 extends it. Fix: || exit 1. Cosmetic: skills/prune-memory/SKILL.md:34 ~96 chars unwrapped. Severity: low. Discovered while: /feat D4 security gate + verifier. Not fixed. FIXED 2026-11-13 (9045a60): mktemp -d … || exit 1 plus an empty-value guard before the trap.
  • hooks/session-start.sh:329-333 _digest_todo reads only a ### Actionable heading (this repo only); init-project and onboard TODOs never show in the digest. Tracked as TODO D1b (user 2026-11-12). Severity: medium. Discovered while: /feat D1 challenge round 1. Not fixed. FIXED 2026-11-12 (block D, feature/digest-todo-fallback 1124758, BDR-147): Actionable ##/### else the file's first items.
  • hooks/session-start.sh digest blocker line fails open: a failed or timed-out memory.sh index blocker (timeout 2, stderr dropped) prints no - open: line, same as zero open blockers. Fix: print - open: none after a successful read. Severity: low. Discovered while: /feat D1 challenge round 2. Not fixed. FIXED 2026-11-13 (9045a60): a failed or timed-out read prints - open: unknown (memory.sh index failed), a successful read with no open row - open: none; SD9a/SD9d/SD12. Residual logged below (index rc 0 on an unreadable registry).
  • Stale graphify claims outside the D6 scope: .gitignore:54-56 ("written into the repo by graphify claude install"), plugins.lock.json:37 (bare graphify install && graphify claude install recipe), update-all.sh:310-312 (re-run graphify claude install MANUALLY, no trap, cwd-dependent → point at make plugin), install-plugins.sh:688/690/1269 labels ("dependencies", "Claude Code integration", "PreToolUse hook" for steps the trap reverts), install-plugins.sh:694-695 LRN-071 comment now gates only graphify install, guard comment vs rule duplication. LRN-154 (learnings.md:1381) still says graphify install --platform claude "touches nothing else". Severity: low. Discovered while: /feat D6 challenge + gates. Not fixed. FIXED 2026-11-13 (77041e5): .gitignore, plugins.lock.json, update-all.sh (points at make plugin), install-plugins.sh labels/comment match the trap; LRN-154 corrected by a status line.
  • lib/tests/curated-config-guard.test.sh does not lock the Step 7 (cd "$REPO" && graphify claude install) subshell; a later edit dropping it passes make test. Severity: low. Discovered while: /feat D6 challenge round 2. Not fixed. FIXED 2026-11-13 (9045a60): T7 fixed-string lock on the subshell line.
  • install-plugins.sh Step 7 hook window (pre-existing): graphify claude install hooks sit live in $REPO/.claude/settings.json until the EXIT trap; a SIGKILL skips the trap. Severity: low. Discovered while: /feat D6 security gate. Not fixed.
  • lib/tests/push-guard.test.sh T42c — passes even if the $WORK/s-probe.json jq write fails (empty slurp makes every base entry look lost); weakens what T42c proves, not the lock. Severity: low. Discovered while: /feat dead-deny security gate. Not fixed. FIXED 2026-11-13 (9045a60): T42c-probe-written asserts the probe parses (jq -e .).
  • lib/tests/push-guard.test.sh deny_lost — no pipefail: a missing list file or jq failure empties lost (T42 green); mitigated by T42c (red) and T40. Severity: low. Discovered while: /feat dead-deny security gate. Not fixed. FIXED 2026-11-13 (9045a60): explicit PIPESTATUS checks (pipefail would be masked by grep rc 1 on an empty list); a failed stage prints deny_lost: pipeline failed; T42f.
  • Dead-entry premise (Write(glob) deny never blocks Write; mixed * :* / * -v /:* forms never match) rests on one live probe 2026-10-23 (journal); nothing re-proves it if Claude Code permission semantics change. Severity: low. Discovered while: /feat dead-deny security gate. Not fixed. RESOLVED 2026-11-13 by live evidence: Claude Code 2.1.323 warns that Bash(git push * :**) (mid-pattern :*) matches as a * wildcard; the kept deny row is live and matches remote :ref deletes; the removed * :* forms were wildcards too, so the live :** row is the one that holds.
  • lib/tests/push-guard.test.sh:421-424 T62F (pre-existing) — mktemp settings copy outside $WORK, removed only on the normal path (no trap). Severity: low. Discovered while: /feat dead-deny security gate. Not fixed. FIXED 2026-11-13 (9045a60): copy under $WORK, cleaned by the suite trap.
  • skills/tour/SKILL.md:244,246 (run) and :249,287 (printed) — git -C "<abs project>" double-quoted path template: a path holding $(…), a backtick or " expands. Same class fixed in plugin-gate. Severity: medium. Discovered while: /bugfix H6a security gate 2026-11-13. Not fixed.
  • agents/handover-doc-writer.md:790-797 render mode — PROJECT_NAME, CLIENT_NAME, PROJECT_URL, OUTPUT_MD reach the renderer call with no quoting rule (PROJECT.name from package.json, CLIENT_NAME free text). Severity: medium. Discovered while: /bugfix H6a security gate. Not fixed.
  • agents/handover-doc-writer.md:208,210,757,758 — fixed temp names /tmp/refs.txt, /tmp/ids.txt (use mktemp). Severity: low. Discovered while: /bugfix H6a security gate. Not fixed.
  • skills/onboard/SKILL.md:427,612 — unquoted $HOME in an executed probe line (:614 fixed). Severity: low. Discovered while: /bugfix H6a security gate. Not fixed.
  • lib/profile.sh:68-72,85 — a root ABOVE a symlinked $HOME is caught by a string compare only (is_home covers exactly $HOME). Severity: low. Discovered while: /bugfix H6a security gate. Not fixed.
  • lib/memory.sh:594-603 memory_index — skips a blockers.md that is not a regular file ([ -f ] || continue) and does not propagate the awk rc, so index blocker exits 0 on a registry it could not read and the session digest prints - open: none (SD9b/SD9c pin it). Fix direction: non-regular registry or unparsable | BLK- row → non-zero rc, the digest prints unknown. Severity: low. Discovered while: /bugfix bugs-found-scripts gates 1+2. FIXED 87aecc1 (BDR-125 gap A3).
  • lib/profile-state.jq clean strips LF/CR only: ESC and other control chars pass (no terminal sink today); human mode (:67-75) prints values unsanitized (pre-existing). Severity: low. Discovered while: /bugfix bugs-found-scripts security gate. Not fixed.
  • lib/tests/profile.test.sh:195 T28-nl-id-no-bare-on cannot fail (pre-fix tail is =off); the clean on pack keys has no biting assertion; lib/tests/session-digest.test.sh:245 comment still says "no digest". Severity: low. Discovered while: /bugfix bugs-found-scripts verifier. Not fixed.
  • lib/memory.sh memory_index and the digest — what still reads as not-open or absent: an empty or unknown status word on a BLK row counts as not open (game holds 14 such v1 rows, config 3, so flagging them would fire every session); an unclosed ``` fence hides every later entry with no banner line; index reads without the lock while status/_mem_restore truncate then write in place (memory.sh:262,319), so a racing digest can read an empty file; [ -e ] || [ -L ] || return 0 (:609) reads a stat failure (I/O, LSM denial) as absent. Severity: low. Discovered while: /bugfix index-fail-closed plan challenge and security gate. Not fixed.
  • hooks/session-start.sh:358-377 _digest_todo / _digest_journal run awk on TODO.md and journal.md with no regular-file check and no timeout: a FIFO there hangs session start. agents/handover-doc-writer.md:105 reports a non-regular blockers.md as no-file. _memory_digest (:420) prints no digest at all when .claude/memory is not a directory. Severity: low. Discovered while: /bugfix index-fail-closed security gate and verifier. Not fixed.
  • lib/memory-commit.sh:99 runs check --staged on the index, then :118 git commit -- <paths> re-reads the working tree, and the memory lock is not held across the two: a registry write landing between them is committed unchecked. Fix direction: commit the checked index (no pathspec once scoped) or hold the lock across check and commit. Severity: low. Discovered while: /feat staged-next-id plan challenge (robustness r2). Not fixed.
  • lib/memory.sh _mem_removed_lines refuses a memory.sh upgrade commit of a v1 file where a dialect heading (### BLK-n) sits below the first ## entry: its rewrite to ## counts as a removed line inside an entry, so mixed-dialect v1 registries cannot be upgraded through memory-commit. Same for /prune-memory's heading level fix on a v2 file. Severity: low. Discovered while: /feat staged-next-id executor (T8m fixture). Not fixed.
  • lib/memory.sh _mem_check_next_ids assumes line order is chronological: a hand-inserted ID line above a new entry, or an ID line removed above the first entry, can refuse an entry add wrote correctly (named in the _mem_next_id comment). IDs at or above 2^53 lose precision in awk (same limit as _mem_next_id). Severity: low. Discovered while: /feat staged-next-id plan challenge. Not fixed.
  • settings.json autoMode.hard_deny[6] mod off-switch clause is a closed list: it does not name removing the skills/<name> symlink, a same-name dev copy shadowing a mod (--plugin-dir, ~/.claude/dev-mods/<session>/), the memory mod's partial "recall": false, or /route off typed inside a skill run (the "Passing a gate" entry only bars /route outside a run). Its closing "The user maintains these files by hand" may now read as covering every edit to ~/.claude/<mod>.json, including ordinary routing overrides (classifier over-refusal, unmeasured). profile.sh disable reaches only model-router@skills-dir (memory is not a managed id). Severity: low. Discovered while: /hotfix hard-deny-mod-off security gate and doc audit. Not fixed.
  • mods/model-router/hooks/register.ts write guard: if the config load keeps throwing, no hook latches in-session (Skill and skill.prompt await ensureConfig first), so main-loop code writes stay held until a sub-agent writes; no throw source known today. The next.called replay branch is pinned only indirectly (the kit hides the downstream error). Severity: low. Discovered while: /feat guard-fail-closed plan challenge and security gate. Not fixed.
  • mods/model-router (BDR-150 shipped tiers): an opus outage spawns best/big agents on the held opus (frontmatter floor; the gates fail, verify-secure retries then escalates; they used to move up to Fable); a single opus outage makes sonnet stand in for best and big with the effort notch; a fable-baseline session (native /model Everywhere) is demoted per downgradeCall caps and sessionPin pins general-purpose spawns to fable; a skill row answering opus + xhigh in the Change dialog lands on run-holding plan. isStandIn and tierWord still read a stored tierChoice === 'big' directly. Severity: low. Discovered while: /feat router-no-fable challenges and executor. Accepted, not fixed.
  • lib/model-gate.md fixed at spawn row: inside a sub-agent the gate proceeds whatever model the child really runs on (the route answer names no id); fix direction: print the spawn id from agentModels in routedText ("fixed at spawn: ") and keep the id check. The repo-wide fable census (lib/tests/model-routing.test.sh) uses git grep (tracked files only) and the regex model ?[:=] ?"fable" (misses single quotes and unquoted frontmatter); skills/tour runner inherits the session model by design (BDR-084), so a hand-picked Fable session runs it on Fable. Severity: low. Discovered while: /feat fable-pins-to-opus security gate and verifier. Not fixed.
  • CLAUDE.global.md § Workflow + lib/effort-shift.md § Advisor: "sub-agents do not" call the advisor is prose only; sub-agents get the advisor tool listed and the harness prompt tells them to call it (seen live in this run's challengers and gates), each call forwarding that agent's whole transcript to Fable outside the router's caps (cost, BLK-030 credits). Fix direction: a mechanical scope (advisorModel for the main session only, if the CLI allows it), else accept. Severity: low. Discovered while: /feat advisor-doctrine plan challenge and security gate. Not fixed. SUPERSEDED 2026-11-17 (6ef3069, /feat advisor-call-points): plan-challenger, verifier, security-auditor now may call it at most once before the verdict; other sub-agents do not. Residual kept: still prose only, and the harness prompt asks sub-agents for "at least once before … and once before declaring done" (a verifier made 2 calls on 2026-11-16), against "at most one call". Severity: low.
  • agents/security-auditor.md:166 (advisor bullet) — "overrides the STEP 2 mapping for that finding only" has no direction: read alone, an advisor "raise" into a lower STEP 3 class could take a semgrep HIGH out of BLOCK(n); only the closing "never removes, lowers or waives" stops it. Fix direction: "overrides it upward only". Severity: low. Discovered while: /feat advisor-call-points security gate r5 (advisor-sourced LOW). Not fixed.
  • agents/verifier.md + agents/security-auditor.md advisor bullets — not scoped to dispatch (analyzer's is, 58a5273); lib/verify-secure-loop.md:54,:96 still allow "or load agents/.md" inline, where the gate's own call would be a main-loop call and void the stuck-call unit "no main-loop advisor call since GATE 0 first ran". No skill takes the inline path today. Fix direction: "when dispatched" in both bullets. Severity: low. Discovered while: /feat advisor-points-b1 re-challenge. Not fixed.
  • agents/plan-challenger.md ORCHESTRATOR PROTOCOL (~:111-112, :133-135) — mirror of lib/challenge-plan.md lacks the main-loop "Advisor first" step and the CHALLENGE SUMMARY Advisor: row (58a5273); the 12 skills' own summary templates also lack the row (lib rule says append it anyway). Fix direction: patch the mirror, optionally add the row to the templates. Severity: low. Discovered while: /feat advisor-points-b1 re-challenge. Not fixed.
  • doctor.sh warn/pass/fail print through echo -e: jq's \uXXXX escapes in the residue diff (:153) come back as raw control bytes (ESC sequences) on the terminal. Source = the user's own tracked settings.json (no trust boundary). Fix direction: printf '%s\n' in the shared helpers. Severity: low. Discovered while: /hotfix doctor-skilloverrides-residue security gate. Not fixed.
  • hooks/session-start.sh perl runner sends KILL to the group at the deadline (timeout sends TERM): a WRITER later put under _SS_TMO would skip memory.sh's INT/TERM/HUP restore trap and leave memory.lock until the 30 s steal. Today's three callers are readers (check, index blocker, feedback remind). Severity: low. Discovered while: /bugfix perl-timeout-group security gate. Not fixed.