forked from bchanot/claude
14 KiB
14 KiB
BUGS-FOUND
- lib/toggle-external.sh:350 (pre-cleanup numbering;
usage(), now near :370) — usage() prints header lines 3-26 only (sed -n '3,26p'); the managed-tool list continues to line 32, so--helpomits 8 of the 14 tools. Severity: low (help text only). Discovered while: code-clean run 2026-10-12 (B5 audit). Not fixed (cleanup and bugfix are separate concerns). FIXED 2026-10-12 (inline on chore/code-clean, no /bugfix pipeline): usage() now prints lines 3 .. closing banner (sed -n '3,/^# ====/p' | sed '$d'), no numeric range; --help shows all 14 tools (36 lines).
- hooks/session-start.sh:200-217 + lib/detect-plugins.sh:49-52 (
detect_uiux_pro_max) — the banner "ALWAYS ON" row and the ui-ux-pro-max toggle row read user-scope settings.json / plugin cache, not the effective profile (profile.sh current --plain, BDR-134 single source of truth): a dev or minimal project shows ui-ux-pro-max on; pr-review-toolkit on in max/audit is not shown. Severity: low (banner only). Discovered while: code-clean 2026-11-09 (phase 5 sweep). Not fixed. FIXED 2026-11-10 (/bugfix, bugfix/banner-effective-profile): newlist_on_plugins(lib/detect-plugins.sh) = effective profile for the ids lib/profiles manages, user-scope true for the others; the ✅ row reads it (model-router now shown, user choice) anddetect_uiux_pro_max= cache AND enabled; pipefail-safe for doctor.sh; test lib/tests/session-banner.test.sh SB1-SB8. - hooks/session-start.sh:177-183 + agents/plugin-advisor.md:193,197,211,226,233,263 vs doctor.sh:520-526 — passive-cost constants disagree (banner/advisor: gstack 2750, ui-ux-pro-max 400, context7 200, graphify 300; doctor dropped gstack/context7/graphify 2026-09-28 as double counting, ui-ux-pro-max 670); agents/status-reporter.md:26-30 names doctor as source of truth. Severity: low (estimates). Discovered while: code-clean 2026-11-09. Not fixed.
FIXED 2026-11-10 (/bugfix, bugfix/passive-cost-source, split by the user): stale hand figures removed from the banner (💰 budget row +
_plugin_costs+ now-deaddetect_plandeleted), plugin-advisor and status-reporter (cost →make doctor); doctor keeps its measured ui-ux 670; tests SB9/SB10, detect-plan.test.sh renamed hook-recursion-guard.test.sh. Measured-cost API = TODO feature. - hooks/session-start.sh:404-408 (
_digest_journal) — greps^-without skipping HTML comments; templates/memory/journal.md:19-21 holds- <line …>bullets inside<!-- -->, so a template-born project prints "- journal: <line 3-5 max>" in the session digest until its first journal write. Fix template and digest together. Severity: low. Discovered while: code-clean 2026-11-09 (phase 4 sweep). Not fixed. FIXED 2026-11-09 (/hotfix, bugfix/digest-journal-comment): the digest skips HTML comment blocks (opener anchored at line start, CommonMark rule; an inline<!--in a bullet stays text), test SD18; the template stays byte-identical (copied by onboarder/init-project/memory.sh), so fixing the template was not needed. - agents/status-reporter.md:35 + agents/plugin-probe.md:22-23,69 — report installed (cache) or user-scope
claude plugin liststate as "active"; the per-project state is the PROFILE line (current --plain). Severity: low. Discovered while: code-clean 2026-11-09. Not fixed. FIXED 2026-11-10 (/bugfix, bugfix/banner-effective-profile): status-reporter takesPlugins ON:fromlist_on_plugins+pack-*=on(cache = installed only); plugin-probe comment and plugin-advisor INPUT name PROFILE as the per-project source (PLUGINS = installed). - agents/handover-doc-writer.md:77-84 — parses registry statuses by hand ("open vs resolved"), the class behind the BLK-032..034 false-open (BDR-129). A fix must read
memory.sh -C <project> indexon v2 registries and keep the## Indexread on v1 registries never upgraded (memory.sh indexignores a v1 Index; memory.sh:21-23). Severity: medium (client deliverable). Discovered while: code-clean 2026-11-09. Not fixed. FIXED 2026-11-11 (/bugfix, bugfix/handover-memory-status): newreconcile_blk_classify(lib/reconcile.sh: strict word on v2, single-word status label on v1 via_mem_v1_word, never the## Index; closed omitted, prose/mixed/closed/###entries = unreadable); STEP 9 rooted on the PACKAGE root; SYNTH REPORT fenced with a mandatoryMEMORY:line, relayed to the user and into the 9.7 report; test lib/tests/handover-memory-contract.test.sh HM1-HM3 runs the shipped STEP 9 block. The request's "keep the v1 Index read" was dropped after challenge round 1 (the Index drifts, BDR-129, LRN-055).
- agents/handover-doc-writer.md §6.1 — vulgarizes BDRs with no status filter: a superseded or deprecated decision can read as current in the client deliverable. Severity: medium (client deliverable). Discovered while: /bugfix G5 challenge round 1. Not fixed.
- lib/memory.sh
upgrade(mem_want,_mem_verdict_diffskips Index-stated IDs) — may take a stale v1## Indexcell over a**Statut** :body line. UNVERIFIED: check before recommendingupgradeon v1 repos (faunosteo). Severity: medium if real (wrong status written into the body). Discovered while: /bugfix G5 challenge round 1. Not fixed. - agents/handover-doc-writer.md STEP 10 and other paths —
git logand file reads are cwd-relative, not rooted on the PACKAGE root; the PACKAGEPROJECT:line is space-separated, so a root containing a space mis-parses (the G5 orchestrator check only catches it when blockers.md exists). Severity: low. Discovered while: /bugfix G5 challenge round 1. Not fixed. - lib/memory.sh
memory_legacy_statusdefault range (## IDto the next## BLK-) — on a v1 registry a### BLK-entry after a## BLK-entry feeds its status line to the##entry: a resolved###entry can close the open##entry above it, which then leaves the handover §5 (the###ID itself is flagged unreadable). Severity: low (rare dialect, flagged indirectly). Discovered while: /bugfix G5 verifier. Not fixed. - agents/handover-doc-writer.md:83 + agents/client-handover-writer.md:1201-1202 —
ROOT="<PROJECT root from the PACKAGE>"pastes the root into a double-quoted literal, and the printed remedymemory.sh -C <root> status …leaves<root>unquoted: a root with",$(…), a backtick or a space breaks the line or splits the path. Value is the operator's owngit rev-parse --show-toplevel, not registry data. Severity: low. Discovered while: /bugfix G5 security gate. Not fixed. - lib/profile-state.jq (
jq -routput read by lib/detect-plugins.shlist_on_plugins/detect_gstack) — a settings value carrying a newline can forge aplugin:<id>=online in the PROFILE_PLAIN text, so the banner or status shows a plugin ON that is not. Display-only, pre-existing for detect_gstack. Severity: low. Discovered while: /bugfix G1+G4 security gate 2026-11-10. Not fixed.
- agents/plugin-advisor.md embedded RULE (~:217) — the
embeddedsignal can come from REQUEST keywords alone ("driver", "kernel", :58) and maps to↻ SET : minimal, against the gated rule "minimal reachable from project-level signals only" (only DISABLE is limited to project signals, :124-126). Gate confirmation limits it. Severity: medium (gated decision not fully enforced). Discovered while: /feat D3 verifier 2026-11-11. Not fixed. - lib/plugin-gate.md:49-51 — pack
extrasaccepted from an advisor token, but pack-extras bundles 21st-ai (credit-metered generate/iterate), same reason as the higgsfield exclusion; no advisor rule emits it. Severity: medium. Discovered while: /feat D3 security gate. Not fixed. - skills/onboard/SKILL.md:255 + agents/plugin-advisor.md:289 — say
make plugininstalls a pinned ctx7; plugins.lock.json pins "latest" (install-plugins.sh:573-574). Fix the wording or pin ctx7. Severity: low. Discovered while: /feat D3 security gate. Not fixed. - agents/plugin-advisor.md:281 BLOCK "Superpowers skills missing → make plugin" + lib/plugin-gate.md:61 "A) fix plugins" undefined — cwd-dependent
make pluginin an onboarded foreign repo; qualify with the claude-config repo or make it print-only. Severity: low. Discovered while: /feat D3 security gate. Not fixed. - lib/plugin-gate.md templates — tokens and
"<PROJECT_ROOT>"sit in double quotes ($()/ backticks still expand; protection = the prose closed-list check); linked worktree: the apply check compares--show-toplevelbut profile.sh writes at the parent of--git-common-dir(confirmed path ≠ written path, same repo); PROJECT_ROOT = $HOME as a git repo passes the check and find_root writes~/.claude/settings.local.json. Severity: low (defense in depth). Discovered while: /feat D3 security gates. Not fixed. - skills/onboard/SKILL.md:387-762 and skills/tour/SKILL.md:155 — still "gstack ON/OFF" (packs vocabulary elsewhere since D3); cosmetic: unwrapped lines skills/plugin-check/SKILL.md:17, lib/plugin-gate.md:45, USAGE.md:182, USAGE.md:1022 transcript without the ↻ glyph. Severity: low. Discovered while: /feat D3 verifier. Not fixed.
- Registry dialects the classifier cannot read: game is
format: 2but written in thedate: … · status:dialect (decision statuses unreadable), faunosteo usesclosed/activewords, v1 date dialects give no 90-dayproposedcandidate. /prune-memory shows them on the info-only[Status unreadable]line; a dialect migration (memory.sh upgrade or a one-shot rewrite per project) is not designed. Severity: medium (prune finds no candidate on those projects). Discovered while: /feat D4 challenge round 1. Not fixed. - skills/prune-memory STEP 4 — status drift check (Index vs body, title word vs status word) dropped from D4 as an ungated new gate. Severity: low. Discovered while: /feat D4 challenge round 2. Not fixed.
- lib/memory.sh:657
memory_legacy_statusreadsMEM_LEGACY_REfrom the environment: an ambientexport MEM_LEGACY_REalso widensmemory.sh upgrade's<end>readers (_mem_legacy_open,_mem_explicit_status,_mem_repair_one, the last one decides a v1 closure write). Fails closed on a bad regex. Fix: explicit 4th positional argument, drop the env read. Severity: low. Discovered while: /feat D4 security gate. Not fixed. - lib/memory.sh
memory_legacy_status<end>range on v1 decisions: the last BDR entry runs to EOF, so a## Indexor other##section after it would be read by the widened selector (none on disk today). Severity: low. Discovered while: /feat D4 verifier. Not fixed. - skills/prune-memory/tests/run-deterministic.sh:13 —
SANDBOX="$(mktemp -d …)"unchecked underset -uo pipefail(no-e): a mktemp failure leaves SANDBOX empty and RED-9 targets/red9a,/home9(fails for a non-root user; traprm -rf ""deletes nothing). Pre-existing, RED-9 extends it. Fix:|| exit 1. Cosmetic: skills/prune-memory/SKILL.md:34 ~96 chars unwrapped. Severity: low. Discovered while: /feat D4 security gate + verifier. Not fixed.
- hooks/session-start.sh:329-333
_digest_todoreads only a### Actionableheading (this repo only); init-project and onboard TODOs never show in the digest. Tracked as TODO D1b (user 2026-11-12). Severity: medium. Discovered while: /feat D1 challenge round 1. Not fixed. - hooks/session-start.sh digest blocker line fails open: a failed or timed-out
memory.sh index blocker(timeout 2, stderr dropped) prints no- open:line, same as zero open blockers. Fix: print- open: noneafter a successful read. Severity: low. Discovered while: /feat D1 challenge round 2. Not fixed. - Stale graphify claims outside the D6 scope: .gitignore:54-56 ("written into the repo by
graphify claude install"), plugins.lock.json:37 (baregraphify install && graphify claude installrecipe), update-all.sh:310-312 (re-rungraphify claude installMANUALLY, no trap, cwd-dependent → point atmake plugin), install-plugins.sh:688/690/1269 labels ("dependencies", "Claude Code integration", "PreToolUse hook" for steps the trap reverts), install-plugins.sh:694-695 LRN-071 comment now gates onlygraphify install, guard comment vs rule duplication. LRN-154 (learnings.md:1381) still saysgraphify install --platform claude"touches nothing else". Severity: low. Discovered while: /feat D6 challenge + gates. Not fixed. - lib/tests/curated-config-guard.test.sh does not lock the Step 7
(cd "$REPO" && graphify claude install)subshell; a later edit dropping it passes make test. Severity: low. Discovered while: /feat D6 challenge round 2. Not fixed. - install-plugins.sh Step 7 hook window (pre-existing):
graphify claude installhooks sit live in $REPO/.claude/settings.json until the EXIT trap; a SIGKILL skips the trap. Severity: low. Discovered while: /feat D6 security gate. Not fixed.
- lib/tests/push-guard.test.sh T42c — passes even if the
$WORK/s-probe.jsonjq write fails (empty slurp makes every base entry look lost); weakens what T42c proves, not the lock. Severity: low. Discovered while: /feat dead-deny security gate. Not fixed. - lib/tests/push-guard.test.sh deny_lost — no pipefail: a missing list file or jq failure empties
lost(T42 green); mitigated by T42c (red) and T40. Severity: low. Discovered while: /feat dead-deny security gate. Not fixed. - Dead-entry premise (Write(glob) deny never blocks Write; mixed
* :*/* -v /:*forms never match) rests on one live probe 2026-10-23 (journal); nothing re-proves it if Claude Code permission semantics change. Severity: low. Discovered while: /feat dead-deny security gate. Not fixed. - lib/tests/push-guard.test.sh:421-424 T62F (pre-existing) —
mktempsettings copy outside$WORK, removed only on the normal path (no trap). Severity: low. Discovered while: /feat dead-deny security gate. Not fixed.