chore(memory): BDR-140 + LRN-267, LRN-268 — ship memory feedback 4d

This commit is contained in:
bchanot committed 2026-11-08 19:20:26 +01:00
1 parent b44b19fa4a
commit f93546ded1
4 files changed
+28 -2

No files matched your search

+10
View File
@@ -1512,3 +1512,13 @@ Supersedes [[BDR-030]].
- **Why**: `.claude/**` let project config read by every session (rules, settings) land on protected base unreviewed; `--name-only` printed only rename destination → `git mv .claude/rules/x .claude/tasks/x` hid deletion. Allowlist = exactly side-car paths skills commit (memory-commit, deploy-commit, /tour audits): no skill flow taxed. Develop history: 1 commit (858e7a7, `.claude/settings.json`) would now need branch.
- **Alternatives rejected**: keep `.claude/**` (BDR-045 status quo, leak stays); also exempt `.claude/settings.json` (user picked no: config = reviewed change); size/heuristic narrowing (BDR-045 (D), fuzzy).
- **Residual**: hook fails open if `git diff --cached` errors (pre-existing; Gitea protection backstop). Partly revises [[BDR-045]] (exemption narrowed, aiguillage unchanged). See [[LRN-084]].
## BDR-140 — Phase 4d memory feedback: offline reader, local labels, two gates, fixed thresholds, /memory-feedback [accepted] (2026-11-08)
- **Date**: 2026-11-08
- **Status**: accepted
- **Decision**: phase 4d feedback = offline reader, no runtime cited flag. Mod logs `cands` + `ms` on prompt records (4d.1). Bun reader `lib/memory-feedback/` (labels, metrics, thresholds, transcripts, reader CLI worksheet|apply|sample) joins `l:<root>` log to transcript attachments; redacted text only in scratchpad worksheet; `~/.claude/memory-feedback/` (0700/0600) keeps labels.tsv (append-only + .bak, repo tag `basename#sha1[0:6]`), state.json (gate verdict first-reached times, closed flag), FEEDBACK.md. Two independent gates: prompt 20 labelled asks or 35 d; tool 10 or 35 d, one 35-d extension then closed. Thresholds r1 table in `thresholds.ts` only. Skill `/memory-feedback` (reflect row), user-invoked; banner reminder `lib/memory-feedback-remind.sh` (5+ d, store changed, silent when closed / recall off). Gate verdict recorded once (NEW line) as EVAL in this repo only (-C).
- **Why**: transcripts live 7 d (BDR-057) → weekly reminder, not raised retention; labels carry client repo names → local, never in git; log alone cannot show usefulness or misses → join + Claude labels + user spot check (LRN-168); tool channel ~3 records/14 d → own gate.
- **Alternatives rejected**: raise cleanupPeriodDays (reverses secret hygiene); cron job (machinery, background claude); labels committed (client names on Gitea); one joint gate (prompt waits on rare tool channel); Stop-hook cited flag (BDR-125).
- **Deviations from spec (user-gated 2026-11-07)**: reader in lib/ not mods/ (plugin validate/test scope); miss causes no-overlap|overlap only; labels.tsv without cited; noisy/promotion lines carry repo tag.
- **Reference**: feature/memory-feedback 21483dc..b44b19f; contract .claude/tasks/contracts/2026-11-06-memory-feedback-4d-1825.md. See [[BDR-125]], [[BDR-137]], [[BDR-100]].