chore(memory): settings deny hotfix journal, TODO, contract

This commit is contained in:
bchanot committed 2026-10-23 19:31:27 +02:00
1 parent ac23cc6d2e
commit d5c897f622
3 files changed
+27

No files matched your search

+3
View File
@@ -12,6 +12,9 @@ Done history before 2026-10-08 removed 2026-10-23 (git keeps it: `git log -p --
- [ ] post-run-D residuals (gates, 2026-10-07): settings.json soft_deny names only `gitflow.autopush false` → add "or an unparseable value" (restriction only, settings run); capitalize STEP 6: manual mode with `ahead` = 0 (user pushed by hand between merge and read) matches no closing line, and the 5C `ahead` = 0 bullet still says "(auto-push mode did it)"; release-executor:86 line > 80 cols; push-guard header line 4 > 80 cols (pre-existing); unpushed-guard Stop silence now also covers a missing lib (SessionStart names it) — accepted
- [ ] gitflow LOW leftovers (run B, rest done in run D 472cccb): `--end-of-options`/`--` on refname args and `printf %q` in copy-paste hints; `gitflow_delete`: check `_gitflow_checkout_containing_base` rc (lib/gitflow.sh:270) before `--unset-upstream`
- [ ] docker host-root mount spellings uncovered by deny (security gate 2026-10-23, pre-existing): `--volume /:/x`, `-v=/:/x`, `--mount type=bind,source=/,...`; prove each with a harmless analogue (`--settings` one-rule file) before adding
- [ ] 6 dead deny entries (`Bash(docker run * -v /:*)`, `Bash(git push * :*)`, 4 `Write(...)`) kept by the push-guard T41/T42 non-weakening lock; drop them with a justified-removal list in T42 at the next release (working forms added 2026-10-23)
### Release 3.0.0
- [ ] MIGRATION.md "Upgrading to 3.0.0" (CHANGELOG Unreleased says breaking: typed `/effort-*` removed; only the 2.0.0 section exists)
- [ ] routing.json `confirmed` (15 agents, 11 phases, 3 skills) ships to every clone (by design: decisions travel); revisit at the 3.0.0 cut
@@ -0,0 +1,23 @@
# CONTRACT — settings-deny-patterns
- date: 2026-10-23 | flow: hotfix | branch: bugfix/settings-deny-patterns
- status: active
## REQUEST (verbatim — IMMUTABLE)
oui traite le je ferais la questions suivante ensuite
(context: CLI startup warns 6 settings.json deny rules are ineffective; headless tests proved `Bash(docker run * -v /:*)` and `Bash(git push * :*)` never match, `Write(...)` deny never blocks the Write tool, `Edit(...)` does.)
## CLARIFICATIONS
- [gated 2026-10-23] Additive fix (user pick): add working forms beside the old ones; the push-guard.test.sh T41/T42 non-weakening lock stays untouched, so the 6 dead entries stay and their startup warnings persist.
## ACCEPTANCE CRITERIA
1. settings.json permissions.deny contains `Bash(docker run * -v /:/*)` and `Bash(git push * :**)`, JSON valid, no entry removed.
CHECK: cd /home/bchanot/Documents/claude && jq -e '.permissions.deny | (index("Bash(docker run * -v /:/*)") and index("Bash(git push * :**)") and index("Bash(docker run * -v /:*)") and index("Bash(git push * :*)"))' settings.json >/dev/null && echo DENY-ADDED
EXPECT: DENY-ADDED
EVIDENCE: pending
2. make test green.
CHECK: cd /home/bchanot/Documents/claude && make test 2>&1 | tail -1
EXPECT: all suites green
EVIDENCE: pending
## FILE SCOPE
settings.json