From d48939e2295ab6596ed4263561487f3929ca3697 Mon Sep 17 00:00:00 2001 From: bchanot Date: Sat, 21 Nov 2026 21:14:49 +0100 Subject: [PATCH] =?UTF-8?q?chore(memory):=20journal=20=E2=80=94=20feat=20d?= =?UTF-8?q?eferred-citers=20=C2=B7=20TODO=20+0=20/=20-0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .claude/memory/journal.md | 1 + .../2026-11-21-deferred-citers-2108.md | 30 +++++++++ .../plans/2026-11-21-deferred-citers-2108.md | 61 +++++++++++++++++++ 3 files changed, 92 insertions(+) create mode 100644 .claude/tasks/contracts/2026-11-21-deferred-citers-2108.md create mode 100644 .claude/tasks/plans/2026-11-21-deferred-citers-2108.md diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index 2be9054..8596904 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -798,3 +798,4 @@ rules: - BDR-125 phases audit 2026-11-21: all phases shipped, residual blocks done, F faunosteo verified done on its develop (530af1b, fa41bc2e); TODO F closed. Only open phase-adjacent: release (develop 235 ahead of main v3.0.0). - /hotfix doctor-model-default: doctor passes on opus[1m], tracked default per user 2026-11-21 (BDR-125 status amended). - /hotfix deferred-stop: [deferred] point stops run once at end of challenge step (keep/cut/reopen, answers bind via contract [gated] + later CONSTRAINTS, /hotfix asks itself, no re-challenge after cut/reopen unless asked). r2 confirmation 5 MAJORs deferred → user answered batch (rule dogfooded). TODO decision closed. +- /feat deferred-citers (first placed-decision challenge skip): feat/bugfix/hotfix point at challenge-plan § OUTPUT deferred stop. Gates first pass (MET, CONFORME, PASS). Docs a732c6c (README/USAGE/CHANGELOG). diff --git a/.claude/tasks/contracts/2026-11-21-deferred-citers-2108.md b/.claude/tasks/contracts/2026-11-21-deferred-citers-2108.md new file mode 100644 index 0000000..cc850b2 --- /dev/null +++ b/.claude/tasks/contracts/2026-11-21-deferred-citers-2108.md @@ -0,0 +1,30 @@ +# CONTRACT — deferred-citers +- date: 2026-11-21 | flow: feat | branch: bugfix/doctor-model-default +- status: active +- run-base: 828f3284dcca3f3949c88b9613e29123be1401da + +## REQUEST (verbatim — IMMUTABLE) +Patch des citers de la règle [deferred] (ca65852), décision utilisateur 2026-11-21 "Patch now" : skills/feat/SKILL.md:135-136, skills/bugfix/SKILL.md:140-141, skills/hotfix/SKILL.md:102-109 repointés vers lib/challenge-plan.md § OUTPUT (un point [deferred] arrête le run une fois à la fin de l'étape de challenge : garder / couper / rouvrir ; /hotfix pose la question lui-même ; l'escalade hotfix → /bugfix reste pour un BLOCKER non différé qui montre le fix faux). + +## CLARIFICATIONS +none — request complete. Challenge: skipped (placed decision: deferred-stop rule ca65852, challenged in its run and answered by the user 2026-11-21). + +## ACCEPTANCE CRITERIA +1. feat and bugfix challenge steps stop once on any `[deferred]` point (keep / cut / reopen) citing `lib/challenge-plan.md` § OUTPUT; the old "surfacing any deferred BLOCKER in the STEP 1 pass B batch" and "folding any deferred BLOCKER into the STEP 3 approval gate" are gone. + CHECK: for f in skills/feat/SKILL.md skills/bugfix/SKILL.md; do grep -q '^`\[deferred\]` point (keep / cut / reopen, `lib/challenge-plan.md` § OUTPUT).$' $f || exit 1; done; [ "$(grep -c 'pass B batch\|STEP 3 approval gate' skills/feat/SKILL.md skills/bugfix/SKILL.md | awk -F: '{s+=$2} END{print s}')" -eq 0 ] && echo FB_OK + EXPECT: FB_OK + EVIDENCE: MET exit=0 marker-found :: FB_OK +2. hotfix STEP 1.8: a `[deferred]` point is asked by /hotfix itself (keep / cut / reopen, § OUTPUT); the BLOCKER-shows-the-fix-wrong escalation to /bugfix stays. + CHECK: f=skills/hotfix/SKILL.md; grep -q '^A `\[deferred\]` point: /hotfix asks keep / cut / reopen itself$' $f && grep -q '^(`lib/challenge-plan.md` § OUTPUT). A BLOCKER that shows the fix is wrong' $f && grep -q 'escalate to `/bugfix`' $f && echo HF_OK + EXPECT: HF_OK + EVIDENCE: MET exit=0 marker-found :: HF_OK +3. Only the three skill files change (5 removed lines) and the locking suites stay green (census resolves the three new § OUTPUT citations). + CHECK: [ "$(git diff --name-only 828f3284dcca3f3949c88b9613e29123be1401da -- skills | wc -l)" -eq 3 ] && [ "$(git diff --numstat 828f3284dcca3f3949c88b9613e29123be1401da -- skills | awk '{d+=$2} END{print d+0}')" -eq 5 ] && make test suite="lib/tests/doctrine-citers.test.sh lib/tests/plan-challenger.test.sh lib/tests/loops-light.test.sh" 2>&1 | tail -1 + EXPECT: all suites green + EVIDENCE: MET exit=0 marker-found :: all suites green + +## FILE SCOPE +- skills/feat/SKILL.md +- skills/bugfix/SKILL.md +- skills/hotfix/SKILL.md +- this contract and .claude/tasks/plans/2026-11-21-deferred-citers-2108.md (run artifacts) diff --git a/.claude/tasks/plans/2026-11-21-deferred-citers-2108.md b/.claude/tasks/plans/2026-11-21-deferred-citers-2108.md new file mode 100644 index 0000000..3eae9e9 --- /dev/null +++ b/.claude/tasks/plans/2026-11-21-deferred-citers-2108.md @@ -0,0 +1,61 @@ +# PLAN — deferred-citers (/feat, 2026-11-21 21:08) + +Contract: `.claude/tasks/contracts/2026-11-21-deferred-citers-2108.md`. Base 828f328. + +Challenge: skipped (placed decision: deferred-stop rule ca65852, user 2026-11-21). The three conditions hold: the text only repoints three citers at the rule; the rule was challenged in the run that wrote it and the user answered its deferred points; /feat runs lib/verify-secure-loop.md after its dispatch. The skip discharges the plan advisor point. + +PLAN: + [ ] skills/feat/SKILL.md:135-136: "surfacing any deferred BLOCKER in the STEP 1 pass B batch" → "and stop once on any `[deferred]` point (keep / cut / reopen, `lib/challenge-plan.md` § OUTPUT)". + [ ] skills/bugfix/SKILL.md:140-141: same repoint (was "folding any deferred BLOCKER into the STEP 3 approval gate"). + [ ] skills/hotfix/SKILL.md:105-106: insert "A `[deferred]` point: /hotfix asks keep / cut / reopen itself (`lib/challenge-plan.md` § OUTPUT)." before the BLOCKER-escalation sentence, which stays. + +Disposition: honors BDR-151 lever 3 (placed-decision skip) and the ca65852 rule; LRN-297 (rule restated at the act site). + +## EXACT DIFF (against 828f328) + +```diff +diff --git a/skills/bugfix/SKILL.md b/skills/bugfix/SKILL.md +index 223e7cd..fea2981 100644 +--- a/skills/bugfix/SKILL.md ++++ b/skills/bugfix/SKILL.md +@@ -137,8 +137,8 @@ dispositions. Three blind challengers attack it (correctness = is the root cause + right; robustness = blast radius / regressions; simplicity = is the fix minimal); + RE-THINK every aspect a BLOCKER lands, re-challenge once if the plan materially + changed. STEP 3.5 writes the contract from the REVISED plan. Print a CHALLENGE SUMMARY +-(BLOCKERs addressed / deferred / lenses returned / advisor), folding any +-deferred BLOCKER into the STEP 3 approval gate. ++(BLOCKERs addressed / deferred / lenses returned / advisor), and stop once on any ++`[deferred]` point (keep / cut / reopen, `lib/challenge-plan.md` § OUTPUT). + + ## STEP 3.5 — CONTRACT + +diff --git a/skills/feat/SKILL.md b/skills/feat/SKILL.md +index 9f6ffcb..35ab68a 100644 +--- a/skills/feat/SKILL.md ++++ b/skills/feat/SKILL.md +@@ -132,8 +132,8 @@ Persist it to `.claude/tasks/plans/--.md`, then run + Three blind challengers attack it; RE-THINK every aspect a BLOCKER lands (a named + plan change, or `[deferred]`), re-challenge once if the plan materially changed. The + STEP 3 executor receives the REVISED plan. Before dispatch, print a CHALLENGE SUMMARY +-(BLOCKERs addressed / deferred / lenses returned / advisor), surfacing any +-deferred BLOCKER in the STEP 1 pass B batch. ++(BLOCKERs addressed / deferred / lenses returned / advisor), and stop once on any ++`[deferred]` point (keep / cut / reopen, `lib/challenge-plan.md` § OUTPUT). + + ## STEP 2 — BRANCH + +diff --git a/skills/hotfix/SKILL.md b/skills/hotfix/SKILL.md +index 2c7b62e..de1d556 100644 +--- a/skills/hotfix/SKILL.md ++++ b/skills/hotfix/SKILL.md +@@ -103,7 +103,8 @@ contract's acceptance criteria. Three blind challengers attack the fix; the main + loop RE-THINKS any aspect a BLOCKER lands (a named change to the fix, or + `[deferred]`) and re-challenges once if it materially changed. Print a + CHALLENGE SUMMARY (BLOCKERs addressed / deferred / lenses returned / advisor). +-A BLOCKER that shows the fix is wrong or incomplete means this was never ++A `[deferred]` point: /hotfix asks keep / cut / reopen itself ++(`lib/challenge-plan.md` § OUTPUT). A BLOCKER that shows the fix is wrong or incomplete means this was never + a hotfix — escalate to `/bugfix` (its STEP 3b runs the same phase under the full + verify+secure loop). + +```