From b120ba50b6f579a65b1d6a1f190ed1fd3e9e957c Mon Sep 17 00:00:00 2001 From: bchanot Date: Thu, 19 Nov 2026 13:58:59 +0100 Subject: [PATCH] chore(audits): BUGS-FOUND:134 fixed 9814720, two DEGRADED minors logged --- .claude/audits/BUGS-FOUND.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.claude/audits/BUGS-FOUND.md b/.claude/audits/BUGS-FOUND.md index 6f4ed31..21a9081 100644 --- a/.claude/audits/BUGS-FOUND.md +++ b/.claude/audits/BUGS-FOUND.md @@ -132,4 +132,9 @@ - lib/verify-secure-loop.md:111,:126-128 + agents/security-auditor.md:184,:190-192 — teach parsing DEGRADED off the `SECURITY — VERDICT:` line, but the auditor prints `VERDICT: PASS` on a DEGRADED scan and DEGRADED only on its `TOOL:` line (agents/security-auditor.md:133-134). A reader checking the VERDICT line misses it. feat/bugfix skip text now names the TOOL line at the site (51f343f). Fix direction: say DEGRADED shows on the TOOL line beside a PASS, in both. Severity: low. Discovered while: /ship-feature advisor-points-b3 STEP 6 opus review. + FIXED 2026-11-19 (9814720, /bugfix degraded-tool-line): the three readers (+ hotfix) read the `TOOL:` line inside the PASS bullet, the VERDICT-line `DEGRADED` value is gone, a PASS without `TOOL:` is structural; lib/effort-shift.md item 3 names the line; loops-light locks it. - Run B3 residuals (plan purged at finish, recorded here): (a) the challenge route line pairs `mcp__model-router__route` with the server-side advisor call, unverified in this repo (lib/effort-shift.md: the router cannot see the advisor tool; pairing only saves a request). (b) skills/{feat,bugfix} end line prints the diff stat even on a skip (cost one cheap command, nothing reads it). (c) lib/effort-shift.md item 3 "Two skips only" sentence ~65 words; feat/bugfix end-line first sentence ~60 words (prose length, oracle-safe splits exist). (d) contract 2026-11-18-advisor-points-b3-1056 criterion 9 says the exempt rows "run as wide as the rows beside them"; they run wider (Advisor rows 125-132 cols vs 77-96), wording only. Severity: low. Discovered while: /ship-feature advisor-points-b3 STEP 2b/STEP 6. + + +- A DEGRADED scan that BLOCKs and hits the cap: the STOP/escalation text (lib/verify-secure-loop.md, agents/security-auditor.md) does not name the missing semgrep or `make plugin`, so the human sees a checklist-only BLOCK without the remedy. Severity: low. Discovered while: /bugfix degraded-tool-line STEP 3b. +- DEGRADED is read by word presence on the `TOOL:` line: a garbled `TOOL:` line (no `semgrep `, no DEGRADED) reads as a full scan. Fix direction: allowlist `TOOL: semgrep ` as the only full-scan shape, anything else DEGRADED or structural. Severity: low. Discovered while: same.