forked from bchanot/claude
chore(memory): BDR-116 amendment, LRN-216, EVAL-047, TODO + journal, router-downgrade-cap contract + plan
This commit is contained in:
1 parent
e8186409df
commit
ab963e97dc
7 files changed
+304
No files matched your search
@@ -1422,6 +1422,8 @@ Branch feature/user-writing-web-rules, UNMERGED (human gate).
|
||||
- **Gates**: plan r1 → r3 (simplicity CONCERNS(4), robustness FATAL(6) BLOCKER unbounded await, correctness CONCERNS(4); confirmation robustness CONCERNS(4)); feater DONE (423) + 1 round (trim, argumentHint, repeated undefined: 428, each mutation-proven); GATE 0 MET; verifier ECARTS(2) coverage → CONFORME on #2; security PASS (0 findings; LOW accepted: pasted text can steer one turn's effort up, README says so). Abort paths judged by reading (`[gated]` clarification). Residual: `smallModelBusy` checks `cfg.models.haiku` while classify uses the engine's default small model (mismatch only when the two differ). Live AC9 open.
|
||||
- **Refs**: contract `.claude/tasks/contracts/2026-10-11-model-router-w4b-classifier-1858.md`, plan r3 same slug. Links [[EVAL-045]], [[LRN-210]].
|
||||
|
||||
- **Amendment (2026-10-13, feature/router-downgrade-cap, commit 2ce203a, user decision)**: W4-B "EFFORT ONLY" clause superseded. Classifier writes full phase route; main may move DOWN on a guess, never above session model (`wantedModel` ranks vs `sessionModel`, not `cur`: breaker fallback sonnet→opus, never haiku); `ultrathink` floor model beats guess. `mainModelSwitch` default **true**, fail-closed picker (non-boolean → off + log). Caps measure COLD READ (LRN-216): `coldRead(M) = tokens − served[M].tokens` within `CACHE_TTL_MS` 1 h, else whole context; `downgradeMaxTokens` 120000 (user delegated value), `upgradeMaxTokens` 200000 same measure; served record written EVERY main step, dropped by `/clear` + `/route reload`, stale (context < record) = cold. No return bypass (warm return cheap by construction). Model-loaded helper skill inside best-tier run → effort only (`belowRun`). Window outgrown (haiku 200k) → back to session model. `/effort` typed between turns drops guess for that turn only (`engineBase` per turn). Rejected: user `/model` suspends classifier (baseline moves, guess follows; `/route classify off` pins) — trade-off accepted; raw context-size cap (r1: refused cheap re-down to warm sonnet, forced cold fable read); engine-model return bypass (premise false after N sonnet turns). Residuals TODO 2026-10-13: unrowed agent `parentModel` inheritance on demoted turn, `session.usage` lag vs new prompt, TTL const. Gates: 3 lenses CONCERNS (10 MAJOR) → r2; confirmation FATAL(7) BLOCKER → r3; feater DONE 450 tests; verifier CONFORME 10/10 first pass; security PASS. Links [[LRN-216]], [[EVAL-047]], [[LRN-204]].
|
||||
|
||||
## BDR-117 — shared gstack helpers live in lib/gstack-removed.sh, not in a new lib [accepted] (2026-10-12)
|
||||
- **Decision**: C5 /refactor 2026-10-12. profile.sh + toggle-external.sh duplicated gstack_skills + park/unpark moves. Host gstack_skills/gstack_parked_names/gstack_park/gstack_unpark in lib/gstack-removed.sh; each takes dirs as args, no caller globals; plain-statement call only (errexit, [[LRN-215]]).
|
||||
- **Why**: only sourced file 5 fixture suites copy next to both scripts; new lib = every fixture breaks.
|
||||
|
||||
@@ -425,3 +425,8 @@ Dogfood: 3 blind lenses attacked the v1 plan for the plan-challenge feature itse
|
||||
- **Method**: correctness FATAL(6), robustness FATAL(5), simplicity CONCERNS(5), confirmation CONCERNS(2). Independent re-check of the executor: `make test` 47 green, shellcheck 0, hook `$pattern` sha256 identical old/new, old vs new google_seo.py no-arg run byte-identical (stdout, stderr, rc).
|
||||
- **Anomaly**: r1 wrong on 5 points (directive placement, logic-line counter ignored the error-handling exclusion → 1 false positive + 3 reclassified, B18 half false: 2 of 4 sites already `local`, C1 move would silently void T19, `|| return $?` rule inverted). Executor denied once (`rm -rf` on a variable path), used a fresh dir, reported it. Scope file's BUG TO LOG block came out empty (regex cut at the heading) — executor fell back to the plan. Two golden gaps left open by executor (gstack-absent warning, pack_hints with stubbed CLI).
|
||||
- **Action**: keep the confirmation pass after a material rewrite (it caught 2 MAJOR the first round missed). Scope writer: assert every section non-empty before dispatch. Links [[LRN-213]], [[LRN-214]], [[LRN-215]].
|
||||
|
||||
## EVAL-047 — model-router downgrade cap: 3 lenses CONCERNS, confirmation pass FATAL(7); the 4th blind read found the BLOCKER the author + 3 lenses missed
|
||||
- **Method**: /feat. r1 (author): context-size cap + engine-model return bypass + classifier full route. 3 blind lenses on r1: simplicity CONCERNS(3), correctness CONCERNS(4), robustness CONCERNS(3), 10 MAJOR, 0 BLOCKER, convergent (cold-read measure, classifier upgrade leak, bypass useless, test list incomplete, helper-skill demotion, haiku window). r2 written. ONE confirmation challenger on r2: FATAL(7) — BLOCKER served record only on routed steps (session model's cache invisible), + 6 MAJOR (test (d) `turnModel` survives `/route clear`, guess vs `cur` + breaker → haiku, floor hidden by guess tier, `pickSwitch` fails OPEN, compaction floor-at-0, `engineBase` process-wide kill). r3 → feater DONE first pass, 450 tests, verifier CONFORME 10/10 first pass, security PASS.
|
||||
- **Anomalies**: author's r2 introduced 1 BLOCKER + 6 MAJOR while fixing r1 — a material rewrite is a NEW plan, the confirmation pass is not optional. `pickSwitch` "fail closed" was wrong by name: falls back to seeded default (now true). Verifier noticed 2 stale texts outside criteria (label comment, route tool description) — fixed by hand pre-commit (minor, justified). Doc-sync SIGNIFICANT: 13 patches, 3 docs stated the old default as a promise.
|
||||
- **Action**: keep the single confirmation pass mandatory after any r2 that changes the mechanism (not just wording); when a plan says "fail closed", name the picker and its fallback value in the plan; TODO residuals (parentModel inheritance, usage lag, TTL const) carried, not dropped. Links [[BDR-116]], [[LRN-216]], [[EVAL-045]].
|
||||
@@ -607,3 +607,6 @@ rules:
|
||||
- /code-clean whole repo on chore/code-clean (gitflow start, pushed). Plan r1→r3: 3 lenses + confirmation, C1 (gitflow-test.sh move) deferred ×2 lenses, B18 half false, C3 needed stderr oracle, errexit rule inverted. User approved all 14 non-deferred items. code-cleaner DONE: A1 import, B1-B4 lint/hook regex (sha identical), B5/B7/B9/B11 splits, B18-B20, C2 suite wired, C3 hoist. make test 47 green, shellcheck 0, verified independently. 1 bug logged (usage() 3-26 truncation). No commit. LRN-213/214/215, EVAL-046. Next (user: "capitalize all then correct bugs with what has been skipped"): usage() fix inline, C4/C5 via /refactor; C1 + B13-B17 left (blocked / no-change by design).
|
||||
- Follow-up (same branch, no commit): usage() bug fixed inline (`sed -n '3,/^# ====/p' | sed '$d'`, --help 36 lines, 14 tools). /refactor → refactorer: C4 `tool_kind`/`tool_source` single roster (exact-match loop, not the `*" $x "*` idiom: multi-word arg stayed unknown), `disable_*` split mirrors `enable_*`; C5 shared `gstack_skills/parked_names/park/unpark` in lib/gstack-removed.sh (already copied by all 5 fixtures; new sourced lib would break them). 496-run golden capture identical except `${name:?}` diagnostic line ref for an empty `gstack__` dir. Verified: make test 47 green, shellcheck 0. Left: C1 (T19 lock), B13-B17 (no change), `name` leak in enable_pack. Commit split suggested: cleanup / usage fix / C4-C5.
|
||||
- Rust default-language rule (user ask). `rules/default-language.md` always-on (no `paths:`), CLAUDE.global.md at 317/320 → BDR-085 exception path. Hooks: interviewer FAILURE MODES row, init-project BDR table, project CLAUDE.md exception list. Branch chore/rust-default, doctrine-citers green. BDR-118 pending user approval.
|
||||
|
||||
## 2026-10-13
|
||||
- model-router /feat `downgradeMaxTokens` (user: switch on by default, classifier may switch model early, back up to fable on reflection). Plan r1 context-size cap → challenge: cap must measure COLD READ (LRN-204), bypass dropped, classifier down-only vs session model; confirmation pass FATAL(7), BLOCKER served-record-on-routed-steps-only → r3. feater DONE 450 tests, verifier CONFORME 10/10, security PASS, commit 2ce203a on feature/router-downgrade-cap. Doc-sync + BDR/LRN/EVAL pending.
|
||||
@@ -1801,3 +1801,7 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s
|
||||
## LRN-215 — helper extracted from a `set -e` function must be called as a plain statement; `helper || …` / `if helper` switches errexit OFF inside it
|
||||
- **Context**: code-clean B5/B7/B9 split enable_tool / enable_skill / cmd_show out of `set -euo pipefail` scripts. r2 executor rule said `|| return $?`; confirmation lens: that form disables errexit inside the helper, so a failed `mv` (toggle-external.sh:273) would print `ok …` rc 0 instead of aborting — a path no golden capture sees. Plain call keeps `return 1` → errexit in caller → exit 1 as today.
|
||||
- **Apply**: split rule for -e scripts: plain calls only, never `||`, `&&`, `if`, `!` around an extracted helper. Golden capture (stdout + stderr + rc + fixture tree) before/after for every moved arm when the suite discards output. Links [[LRN-214]], [[EVAL-046]].
|
||||
|
||||
## LRN-216 — Capping a main-loop model switch = cap the COLD READ (context − target's warm prefix), never the context size; the warm record must be written on EVERY main step
|
||||
- **Context**: model-router downgrade cap 2026-10-13. r1 compared context size to cap → after N coding turns sonnet warm, fable cold; context crosses cap → next coding turn starts on fable (cold) and cheap re-down refused = worst outcome. r2 fixed measure, but wrote `served` only on routed steps → unrouted steps on session model invisible → return to fable refused above 200k (confirmation pass BLOCKER). Per-model prefix cache (LRN-204): cost of switch INTO M = tokens − tokens at M's last step if within TTL, else all; context smaller than record = history rewritten (compaction) = cold.
|
||||
- **Apply**: any "switch model when cheap" logic: (1) keep `{at, tokens}` per model id, written at every step of the loop whatever the routing; (2) cost = delta vs that record within TTL, whole context otherwise or when record > current; (3) unknown size = blocked; (4) no special-case "return to session model" bypass, the measure covers it. A guess-sourced route ranks vs the SESSION model, not the current one, or a breaker fallback walks down to the cheapest tier. Links [[BDR-116]], [[LRN-204]], [[EVAL-047]].
|
||||
Reference in new issue
Block a user