From ac23cc6d2e5717f477f3e68f7862db7e75982b7f Mon Sep 17 00:00:00 2001 From: bchanot Date: Fri, 23 Oct 2026 19:31:26 +0200 Subject: [PATCH 1/2] fix(settings): deny forms that actually match root mounts and refspec deletes --- settings.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/settings.json b/settings.json index 3b15231..f619f5e 100644 --- a/settings.json +++ b/settings.json @@ -265,11 +265,13 @@ "Bash(docker * /var/run/docker.sock*)", "Bash(docker run -v /:*)", "Bash(docker run * -v /:*)", + "Bash(docker run * -v /:/*)", "Bash(git push --delete *)", "Bash(git push * --delete *)", "Bash(git push --mirror*)", "Bash(git push * --mirror*)", "Bash(git push * :*)", + "Bash(git push * :**)", "Bash(git push --force-with-lease*)", "Bash(git push * --force-with-lease*)", "Bash(git branch -D *)", From d5c897f6221152acba2a9c2b59ab4400909eb84b Mon Sep 17 00:00:00 2001 From: bchanot Date: Fri, 23 Oct 2026 19:31:27 +0200 Subject: [PATCH 2/2] chore(memory): settings deny hotfix journal, TODO, contract --- .claude/memory/journal.md | 1 + .claude/tasks/TODO.md | 3 +++ .../2026-10-23-settings-deny-patterns-1927.md | 23 +++++++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 .claude/tasks/contracts/2026-10-23-settings-deny-patterns-1927.md diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index cadfbec..7ac3f68 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -643,3 +643,4 @@ rules: - Remote bugfix/mods-validate-advisory delete blocked by auto-mode classifier → user runs `git push origin --delete`. routing.json audit confirm committed eb4771e. - /feat C (feature/router-keyword-cap): r1 cap in wantedModel killed by 3 BLOCKERs → r2 effort-only routes at writers + derived orchestrate (user pick), confirmation SOLID. 786ee13, verifier CONFORME 1st pass (1st died 429 Fable), auditor PASS, docs d2d590f. BLK-032 resolved, LRN-226, EVAL-048. Merge on user go. - /reconcile TODO (chore/todo-reconcile): 2190 → ~200 lines. Done history pre-10-08 dropped (git archive), 46 open → 35 grouped (actionable, release 3.0.0, docs, user, blocked, live checks, optional, parked, known limits). Done: P16, P43, Linux run, Makefile help; obsolete: effort-pins items, fable live check; 5 hidden prose follow-ups lifted. BLK-018 status line: decide at 3.0.0. Engine gap: `reconcile_blk_open` ignores header `[resolved]` tag (BLK-032..034 false open). +- Rules check (user: facts not guesses): fresh `claude -p` in empty dir quoted always-on rules + global CLAUDE.md verbatim, negative control ABSENT; path-scoped web-security/rest-api ABSENT before, present after Read of src/api/user.ts. /hotfix settings deny: `* :*` and `* -v /:*` mixed forms never match (proven RAN), `Write(...)` deny never blocks Write tool, `Edit(...)` does; added `-v /:/*` + ` :**` (proven DENIED), additive per T41/T42 lock. Gate 429 on Fable twice (LRN-224). make test green, auditor PASS. diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 3640011..a236b08 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -12,6 +12,9 @@ Done history before 2026-10-08 removed 2026-10-23 (git keeps it: `git log -p -- - [ ] post-run-D residuals (gates, 2026-10-07): settings.json soft_deny names only `gitflow.autopush false` → add "or an unparseable value" (restriction only, settings run); capitalize STEP 6: manual mode with `ahead` = 0 (user pushed by hand between merge and read) matches no closing line, and the 5C `ahead` = 0 bullet still says "(auto-push mode did it)"; release-executor:86 line > 80 cols; push-guard header line 4 > 80 cols (pre-existing); unpushed-guard Stop silence now also covers a missing lib (SessionStart names it) — accepted - [ ] gitflow LOW leftovers (run B, rest done in run D 472cccb): `--end-of-options`/`--` on refname args and `printf %q` in copy-paste hints; `gitflow_delete`: check `_gitflow_checkout_containing_base` rc (lib/gitflow.sh:270) before `--unset-upstream` +- [ ] docker host-root mount spellings uncovered by deny (security gate 2026-10-23, pre-existing): `--volume /:/x`, `-v=/:/x`, `--mount type=bind,source=/,...`; prove each with a harmless analogue (`--settings` one-rule file) before adding +- [ ] 6 dead deny entries (`Bash(docker run * -v /:*)`, `Bash(git push * :*)`, 4 `Write(...)`) kept by the push-guard T41/T42 non-weakening lock; drop them with a justified-removal list in T42 at the next release (working forms added 2026-10-23) + ### Release 3.0.0 - [ ] MIGRATION.md "Upgrading to 3.0.0" (CHANGELOG Unreleased says breaking: typed `/effort-*` removed; only the 2.0.0 section exists) - [ ] routing.json `confirmed` (15 agents, 11 phases, 3 skills) ships to every clone (by design: decisions travel); revisit at the 3.0.0 cut diff --git a/.claude/tasks/contracts/2026-10-23-settings-deny-patterns-1927.md b/.claude/tasks/contracts/2026-10-23-settings-deny-patterns-1927.md new file mode 100644 index 0000000..9aec3e6 --- /dev/null +++ b/.claude/tasks/contracts/2026-10-23-settings-deny-patterns-1927.md @@ -0,0 +1,23 @@ +# CONTRACT — settings-deny-patterns +- date: 2026-10-23 | flow: hotfix | branch: bugfix/settings-deny-patterns +- status: active + +## REQUEST (verbatim — IMMUTABLE) +oui traite le je ferais la questions suivante ensuite +(context: CLI startup warns 6 settings.json deny rules are ineffective; headless tests proved `Bash(docker run * -v /:*)` and `Bash(git push * :*)` never match, `Write(...)` deny never blocks the Write tool, `Edit(...)` does.) + +## CLARIFICATIONS +- [gated 2026-10-23] Additive fix (user pick): add working forms beside the old ones; the push-guard.test.sh T41/T42 non-weakening lock stays untouched, so the 6 dead entries stay and their startup warnings persist. + +## ACCEPTANCE CRITERIA +1. settings.json permissions.deny contains `Bash(docker run * -v /:/*)` and `Bash(git push * :**)`, JSON valid, no entry removed. + CHECK: cd /home/bchanot/Documents/claude && jq -e '.permissions.deny | (index("Bash(docker run * -v /:/*)") and index("Bash(git push * :**)") and index("Bash(docker run * -v /:*)") and index("Bash(git push * :*)"))' settings.json >/dev/null && echo DENY-ADDED + EXPECT: DENY-ADDED + EVIDENCE: pending +2. make test green. + CHECK: cd /home/bchanot/Documents/claude && make test 2>&1 | tail -1 + EXPECT: all suites green + EVIDENCE: pending + +## FILE SCOPE +settings.json