feat(guardrails): propose, apply accepted fixes, re-pass to prove them

After the report the skill proposes fixes (plan phase), stops for the
user's acceptance, applies accepted ones via bugfixer and the
verify-secure gates, then re-scans. scan.py gains --assert-absent
(contract oracle, positive control) and --baseline (no new hit).
This commit is contained in:
bchanot committed 2026-10-18 19:04:13 +02:00
1 parent b17de15c22
commit 73c25d759e
14 files changed
+382 -29

No files matched your search

+129 -7
View File
@@ -3,10 +3,17 @@
Reads a project tree as data and never executes it. Exit codes:
0 no FAIL, 1 at least one FAIL, 2 usage error.
Two check modes replace the report and its exit code:
--assert-absent RULE:path,... exit 0 and print GUARDRAILS-CLEAR only when
none of these FAIL/WARN pairs remain (a fix contract's oracle);
--baseline before.json compare with an earlier --json run, exit 0 and
print GUARDRAILS-NO-NEW only when no FAIL/WARN hit appeared.
"""
import argparse
import json
import sys
from collections import Counter
from dataclasses import dataclass
from pathlib import Path
@@ -22,6 +29,15 @@ DOMAINS = {
"functions": functions,
}
SEVERITY_RANK = {"FAIL": 0, "WARN": 1, "MANUAL": 2}
RULE_DOMAINS = {
"API": "api", "HOST": "hosting", "A11Y": "a11y", "SB": "supabase",
"MSG": "messaging", "FN": "functions",
}
MANUAL_RULES = {
"HOST-WAF-DDOS", "HOST-SPEND-CAP", "SB-RLS-LIVE", "FN-CAP-UNVERIFIED",
"FN-BUDGET-STOP",
}
GATED = ("FAIL", "WARN")
@dataclass(frozen=True)
@@ -41,6 +57,12 @@ def parse_args(argv):
"--exclude", default="",
help="comma list of relative paths to skip (copies, vendored code)")
parser.add_argument("--json", action="store_true", help="JSON output")
parser.add_argument(
"--assert-absent", default="", metavar="RULE:path,...",
help="contract oracle: pass only when these pairs are gone")
parser.add_argument(
"--baseline", default="", metavar="JSON",
help="earlier --json run: report fixed, remaining and new hits")
return parser.parse_args(argv)
@@ -101,24 +123,124 @@ def render_json(project, result):
}, indent=2)
def _usage_error(path, names):
unknown = [n for n in names if n not in DOMAINS]
def _rule_domain(rule):
return RULE_DOMAINS.get(rule.split("-", 1)[0])
def _pairs(value):
"""'RULE:path,RULE:path' -> [(rule, path)]; a missing path stays ''."""
return [tuple(p.strip() for p in item.partition(":")[::2])
for item in _split(value)]
def _assert_error(value):
for rule, path in _pairs(value):
if not path or not _rule_domain(rule):
return f"bad --assert-absent item {rule}:{path}, want RULE:path"
if rule in MANUAL_RULES:
return f"{rule} is MANUAL: no static scan can prove it fixed"
return ""
def _hits(findings):
return Counter((f.rule, f.path) for f in findings if f.severity in GATED)
def _load_baseline(path):
data = json.loads(Path(path).read_text(encoding="utf-8"))
return Counter((f["rule"], f["path"]) for f in data["findings"]
if f["severity"] in GATED)
def _baseline_error(path):
if not path:
return ""
try:
_load_baseline(path)
except (OSError, ValueError, KeyError, TypeError) as exc:
return f"unreadable baseline {path}: {exc}"
return ""
def _usage_error(args):
unknown = [n for n in _split(args.domain) if n not in DOMAINS]
if unknown:
return f"unknown domain {unknown}"
return "" if Path(path).is_dir() else f"not a directory: {path}"
if not Path(args.path).is_dir():
return f"not a directory: {args.path}"
return _assert_error(args.assert_absent) or _baseline_error(args.baseline)
def _pair_status(hits, applicable, pair):
rule, path = pair
if _rule_domain(rule) not in applicable:
return False, f" CONTROL {rule} {path}: domain not scanned, " \
"absence proves nothing"
if hits[pair]:
plural = "s" if hits[pair] > 1 else ""
return False, f" PRESENT {rule} {path} ({hits[pair]} hit{plural})"
return True, f" CLEAR {rule} {path}"
def assert_absent(project, result, pairs):
"""Positive control first: an empty tree or an unscanned domain fails."""
rows = [_pair_status(_hits(result.findings), result.applicable, p)
for p in pairs]
lines = [text for _, text in rows]
if not project.files:
lines.insert(0, " CONTROL no file scanned, absence proves nothing")
ok = bool(project.files) and all(passed for passed, _ in rows)
return ok, lines + ([f"GUARDRAILS-CLEAR {len(pairs)}"] if ok else [])
def _moved(more, less):
"""Pairs where `more` holds extra hits over `less`, with the surplus."""
return [(key, more[key] - less[key]) for key in sorted(more)
if more[key] > less[key]]
def _rows(tag, moved, sign):
return [f" {tag:<5} {rule} {path} ({sign}{n})"
for (rule, path), n in moved]
def baseline_report(before, result):
after = _hits(result.findings)
fixed, new = _moved(before, after), _moved(after, before)
summary = (f"baseline: {sum(n for _, n in fixed)} fixed, "
f"{sum((before & after).values())} remaining, "
f"{sum(n for _, n in new)} new")
lines = _rows("FIXED", fixed, "-") + _rows("NEW", new, "+") + [summary]
return not new, lines + ([] if new else ["GUARDRAILS-NO-NEW"])
def _check_modes(project, result, args):
checks = []
if args.assert_absent:
checks.append(
assert_absent(project, result, _pairs(args.assert_absent)))
if args.baseline:
checks.append(
baseline_report(_load_baseline(args.baseline), result))
return checks
def _scan(args):
project = Project(Path(args.path), _split(args.exclude))
result = run_checks(project, _split(args.domain))
render = render_json if args.json else render_text
print(render(project, result))
return 1 if any(f.severity == "FAIL" for f in result.findings) else 0
checks = _check_modes(project, result, args)
if not checks:
render = render_json if args.json else render_text
print(render(project, result))
return 1 if any(f.severity == "FAIL" for f in result.findings) else 0
for _, lines in checks:
print("\n".join(lines))
return 0 if all(ok for ok, _ in checks) else 1
def main(argv):
args = parse_args(argv)
error = _usage_error(args.path, _split(args.domain))
error = _usage_error(args)
if error:
print(f"usage error: {error}", file=sys.stderr)
return 2