fix(guardrails): bound DATA_ATTR, SCRIPT_SRC, TRACE_MARKERS and the comment blankers, SENSITIVE_KEY aligned with the spec, 5xx map SKIPPED, base64 inline maps only, RecursionError and supabase shape guarded, large .map head read

This commit is contained in:
bchanot committed 2026-10-19 01:19:40 +02:00
1 parent 0de2e8a48a
commit 5643e9dbd4
7 files changed
+82 -15

No files matched your search

+20 -2
View File
@@ -63,6 +63,7 @@ class H(BaseHTTPRequestHandler):
b'<script src="/clean.js"></script>'
b'<script src=/inline.js></script>'
b'<script src="/biginline.js"></script>'
b'<script src="/err.js"></script>'
b'<script src="https://cdn.invalid/x.js"></script>'
b'</html>')
if path == "/app.js":
@@ -77,6 +78,13 @@ class H(BaseHTTPRequestHandler):
if path == "/biginline.js":
return self._send(200, b"console.log(4);\n//# sourceMappingURL="
b"data:application/json;base64," + b"A" * 20000)
if path == "/err.js":
return self._send(200, b"console.log(5);\n//# sourceMappingURL=err.js.map\n")
if path == "/err.js.map":
return self._send(503, b"")
if path == "/api/session":
return self._send(200, b'{"id": 2, "token": "t", "profile": {"private": false}}',
{"Content-Type": "application/json"})
if path == "/boom":
return self._send(500, b"Traceback (most recent call last):\n"
b' File "app.py", line 12, in handler\n')
@@ -176,7 +184,8 @@ check "a write method in the plan exits 2" "$?" 2
echo "== exposure probes"
cat > "$WORK/exposure.json" <<EOF
{"base_url": "$BASE",
"routes": [{"path": "/api/me"}, {"path": "/api/guarded"}, {"path": "/api/private"}],
"routes": [{"path": "/api/me"}, {"path": "/api/guarded"}, {"path": "/api/private"},
{"path": "/api/session"}],
"exposure": {"error_routes": ["/boom"]}}
EOF
OUT="$(probe --authorized "$WORK/exposure.json")"
@@ -197,7 +206,13 @@ check "the random 404 path is CLOSED" \
check "sensitive keys in a JSON response are OPEN" \
"$(verdict "$OUT" 'fields:/api/me')" OPEN
check "the sensitive key names are listed, never the values" \
"$(printf '%s\n' "$OUT" | grep -A1 'fields:/api/me' | grep -c 'api_key, password_hash$')" 1
"$(printf '%s\n' "$OUT" | grep -A1 'fields:/api/me' | grep -c 'api_key, next_page_token, password_hash$')" 1
check "a bare token key is OPEN, a bare private key is not" \
"$(verdict "$OUT" 'fields:/api/session')" OPEN
check "the session key list is token only" \
"$(printf '%s\n' "$OUT" | grep -A1 'fields:/api/session' | grep -c 'token$')" 1
check "a 503 map answer is SKIPPED" \
"$(verdict "$OUT" 'sourcemap:/err.js')" SKIPPED
check "fields on a 401 is SKIPPED, never CLOSED" \
"$(verdict "$OUT" 'fields:/api/guarded')" SKIPPED
check "fields on a non-JSON body is SKIPPED" \
@@ -244,6 +259,9 @@ printf '{"base_url": "%s", "supabase": {"url": "%s", "cross_user_paths": "/x"}}\
"$BASE" "$BASE" > "$WORK/badcu.json"
probe --authorized "$WORK/badcu.json" >/dev/null 2>&1
check "a string cross_user_paths exits 2" "$?" 2
printf '{"base_url": "%s", "supabase": 5}\n' "$BASE" > "$WORK/badsb.json"
probe --authorized "$WORK/badsb.json" >/dev/null 2>&1
check "a non-object supabase block exits 2" "$?" 2
cat > "$WORK/lower.json" <<EOF
{"base_url": "$BASE", "cors": true, "cors_path": "/lower"}
EOF
+30 -1
View File
@@ -202,7 +202,7 @@ mutant sourcemap-webpack-warn WARN EXP-SOURCEMAP-PUBLIC \
mutant sourcemap-public-dir FAIL EXP-SOURCEMAP-PUBLIC \
"mkdir -p public/assets; printf '%s\n' '{\"version\":3,\"sources\":[\"src/app.ts\"],\"mappings\":\"AAAA\"}' > public/assets/app.js.map"
mutant sourcemap-large-map FAIL EXP-SOURCEMAP-PUBLIC \
"mkdir -p public; head -c 1100000 /dev/zero | tr '\\0' a > public/app.js.map"
"mkdir -p public; { printf '%s' '{\"version\":3,\"sources\":[\"src/app.ts\"],\"mappings\":\"'; head -c 1100000 /dev/zero | tr '\\0' A; printf '%s\n' '\"}'; } > public/app.js.map"
mutant hydrated-sensitive WARN EXP-HYDRATED-SENSITIVE \
"printf '%s\n' 'export async function getServerSideProps() { return { props: { accessToken: process.env.CRM_TOKEN } }; }' > src/pages/account.tsx"
mutant markup-comment WARN EXP-MARKUP-COMMENT \
@@ -241,6 +241,8 @@ benign() { # benign <label> <snippet>: a legitimate pattern raises nothing
check "$label raises no FAIL or WARN" \
"$(printf '%s\n' "$out" | grep -c ' 0 FAIL, 0 WARN')" 1
}
benign large-level-map \
"mkdir -p public/levels; head -c 1100000 /dev/zero | tr '\\0' x > public/levels/big.map"
benign helper-under-api \
"mkdir -p src/pages/api/helpers; printf '%s\n' 'export const fmt = () => 1;' > src/pages/api/helpers/format.ts"
benign mailer-test-file \
@@ -462,6 +464,33 @@ out=$(scan "$WORK/linked")
check "symlinked directory is not followed" \
"$(printf '%s\n' "$out" | grep -c '(0 files)')" 1
echo "== regex timing"
FAST="$(cd "$ROOT" && python3 -B - <<'PY'
import importlib.util, sys, time
sys.path.insert(0, "skills/guardrails/scripts")
from checks import common, exposure
spec = importlib.util.spec_from_file_location(
"probe", "skills/guardrails/scripts/probe.py")
probe = importlib.util.module_from_spec(spec)
spec.loader.exec_module(probe)
cases = [
(exposure.DATA_ATTR, "data-secret" * 20000),
(common.MARKUP_COMMENT, "<!--" * 50000),
(common.SQL_COMMENT, "/*" * 100000),
(probe.SCRIPT_SRC, "<script " * 25000),
(probe.TRACE_MARKERS, b"at a ( " * 28000),
]
slow = 0
for pattern, text in cases:
start = time.perf_counter()
pattern.search(text)
slow += time.perf_counter() - start >= 1.0
print("REGEX-FAST" if not slow else "REGEX-SLOW")
PY
)"
check "adversarial inputs finish each regex under one second" \
"$(printf '%s\n' "$FAST" | grep -c 'REGEX-FAST')" 1
echo "---"
echo "passed: $PASS failed: $FAIL"
[ "$FAIL" -eq 0 ]