diff --git a/hooks/session-start.sh b/hooks/session-start.sh index 79a0b3e..127bd02 100644 --- a/hooks/session-start.sh +++ b/hooks/session-start.sh @@ -5,6 +5,24 @@ # git fetch for the version/update check near the end. # ============================================================ +# ── Session source (memory digest gate) ── +# stdin carries the hook JSON. Read it first, before any child can eat it. +# Digest on startup | clear | compact, and on an empty source from a manual +# terminal run; never on resume. Without timeout or jq the source is +# unknowable: digest only when stdin is a terminal, never from a hook. +_ss_digest=0 +if command -v timeout >/dev/null 2>&1 && command -v jq >/dev/null 2>&1; then + _ss_source="" + if [ ! -t 0 ]; then + _ss_in=$(timeout 1 cat 2>/dev/null) + _ss_source=$(printf '%s' "$_ss_in" | jq -r '.source // empty' 2>/dev/null) + fi + case "$_ss_source" in ""|startup|clear|compact) _ss_digest=1 ;; esac + unset _ss_in _ss_source +elif [ -t 0 ]; then + _ss_digest=1 +fi + # ── Quick health check (filesystem only, no subprocesses) ── BROKEN=() for f in CLAUDE.md settings.json agents skills rules; do @@ -324,5 +342,78 @@ graphify (graphify-out/graph.json present): EOF fi unset _gx_root +# ── memory digest ── +# Cut a line at 160 chars with an ellipsis; a cut that split a multibyte +# char (non-UTF-8 locale) loses trailing chars until iconv accepts it. +_digest_cut() { + local v=$1 + [ "${#v}" -le 160 ] && { printf '%s' "$v"; return; } + v="${v:0:159}" + if command -v iconv >/dev/null 2>&1; then + while [ -n "$v" ] && ! printf '%s' "$v" | iconv -f UTF-8 -t UTF-8 >/dev/null 2>&1; do + v="${v%?}" + done + fi + printf '%s…' "$v" +} + +# Open BLK (≤ 3 listed, the rest counted) and upstream count, as digest lines. +_digest_blockers() { # + local row line rest status title open=0 upstream=0 more="" + while IFS= read -r row; do + [[ "$row" == "| BLK-"* ]] || continue + line="${row#| }"; line="${line% |}" + rest="${line#* | }"; rest="${rest#* | }" + [[ "$rest" == *" | "* ]] || continue + status="${rest##* | }"; title="${rest% | *}" + case "$status" in + open) open=$((open + 1)) + [ "$open" -le 3 ] && echo "- open: ${line%% | *} $title" ;; + upstream) upstream=$((upstream + 1)) ;; + esac + done < <(bash "$2" -C "$1" index blocker 2>/dev/null) + [ "$open" -gt 3 ] && more="+$((open - 3)) more" + [ "$upstream" -gt 0 ] && more="${more:+$more, }+${upstream} upstream" + [ -n "$more" ] && echo "- open: $more" +} + +_digest_todo() { # → first 3 unchecked Actionable items + awk '/^### Actionable/ { on = 1; next } /^#/ { on = 0 } + on && sub(/^- \[ \] /, "") && n++ < 3 { print "- todo: " $0 }' \ + "$1/.claude/tasks/TODO.md" +} + +_digest_journal() { # → last journal bullet + local last + last=$(grep '^- ' "$1/.claude/memory/journal.md" | tail -1) + [ -n "$last" ] && echo "- journal: ${last#- }" +} + +# The block: header + lines, whole lines dropped from the end until ≤ 800. +# Built in a variable and printed once, so a failure mid-way prints nothing. +_memory_digest() { # + local root=$1 lib line block="" lines=() + lib="$(dirname "${BASH_SOURCE[0]}")/../lib/memory.sh" + [ -d "$root/.claude/memory" ] || return 0 + [ -f "$lib" ] && while IFS= read -r line; do lines+=("$line"); done \ + < <(_digest_blockers "$root" "$lib") + while IFS= read -r line; do lines+=("$line"); done < <(_digest_todo "$root") + while IFS= read -r line; do lines+=("$line"); done < <(_digest_journal "$root") + [ "${#lines[@]}" -gt 0 ] || return 0 + block="memory digest:" + for line in "${lines[@]}"; do + line=$(_digest_cut "$line") + [ $((${#block} + ${#line} + 1)) -le 800 ] || break + block+=$'\n'"$line" + done + printf '%s\n' "$block" +} +if [ "$_ss_digest" = 1 ]; then + _ss_root=$(git rev-parse --show-toplevel 2>/dev/null) || _ss_root=$PWD + ( _memory_digest "$_ss_root" ) 2>/dev/null || true + unset _ss_root +fi +unset _ss_digest + echo "" unset TOKEN_WARN PROFILE_PLAIN diff --git a/lib/tests/session-digest.test.sh b/lib/tests/session-digest.test.sh new file mode 100644 index 0000000..3a653c1 --- /dev/null +++ b/lib/tests/session-digest.test.sh @@ -0,0 +1,141 @@ +#!/usr/bin/env bash +# lib/tests/session-digest.test.sh — memory digest at the end of the +# session-start banner (phase 4c, Task 7). Fixture projects under mktemp -d. +set -u +ROOT="$(cd "$(dirname "$0")/../.." && pwd)" +SS="$ROOT/hooks/session-start.sh" +WORK="$(mktemp -d)"; trap 'rm -rf "$WORK"' EXIT +export SESSION_START_OFFLINE=1 +pass=0; fail=0 +check() { if [ "$2" = "$3" ]; then pass=$((pass+1)); else fail=$((fail+1)); + printf 'FAIL %s: got[%s] want[%s]\n' "$1" "$2" "$3"; fi; } + +# mkproj -> path with an empty memory dir +mkproj() { + mkdir -p "$WORK/$1/.claude/memory" "$WORK/$1/.claude/tasks" + echo "$WORK/$1" +} +# blk : append a BLK entry +blk() { + printf '\n## BLK-%03d — %s [%s]\n\n- **Date**: 2026-11-0%d\n' \ + "$2" "$4" "$3" "$(( $2 % 9 + 1 ))" >> "$1/.claude/memory/blockers.md" +} +# run <proj> <stdin-file|-> [script]: the banner +run() { + local in=${2:--} + if [ "$in" = - ]; then + (cd "$1" && bash "${3:-$SS}" </dev/null 2>/dev/null) + else + (cd "$1" && bash "${3:-$SS}" <"$in" 2>/dev/null) + fi +} +digest() { sed -n '/^memory digest:/,$p' | sed '$d'; } +printf '{"source":"startup"}' > "$WORK/startup.json" +printf '{"source":"resume"}' > "$WORK/resume.json" +printf '{"source":"clear"}' > "$WORK/clear.json" +printf '{"source":"compact"}' > "$WORK/compact.json" + +# SD1: 1 open + 2 upstream, 4 todo items, a journal +p=$(mkproj sd1) +blk "$p" 1 open "Bing API unusable" +blk "$p" 2 upstream "Up one"; blk "$p" 3 upstream "Up two" +printf '### Actionable\n- [ ] one\n- [x] done\n- [ ] two\n- [ ] three\n- [ ] four\n\n### Later\n- [ ] nope\n' \ + > "$p/.claude/tasks/TODO.md" +printf '## 2026-11-04\n- first line\n- 2026-11-04: last line\n' > "$p/.claude/memory/journal.md" +want='memory digest: +- open: BLK-001 Bing API unusable +- open: +2 upstream +- todo: one +- todo: two +- todo: three +- journal: 2026-11-04: last line' +check SD1-startup "$(run "$p" "$WORK/startup.json" | digest)" "$want" +check SD1b-clear "$(run "$p" "$WORK/clear.json" | digest)" "$want" +check SD1c-compact "$(run "$p" "$WORK/compact.json" | digest)" "$want" +check SD1d-banner-first "$(run "$p" "$WORK/startup.json" | head -2 | tail -1 | cut -c1-3)" "┌─ " + +# SD2: resume -> none +check SD2-resume "$(run "$p" "$WORK/resume.json" | grep -c 'memory digest:')" 0 + +# SD3: empty stdin -> digest, exit 0 +run "$p" - >/dev/null; rc=$? +check SD3-empty-source "$(run "$p" - | grep -c 'memory digest:')/$rc" 1/0 + +# SD4: no .claude/memory -> no block +mkdir -p "$WORK/sd4" +check SD4-no-memory "$(run "$WORK/sd4" - | grep -c 'memory digest:')" 0 + +# SD5: TODO without ### Actionable -> no todo line (others stay) +p=$(mkproj sd5) +blk "$p" 1 open "Only blocker" +printf '### Backlog\n- [ ] hidden\n' > "$p/.claude/tasks/TODO.md" +check SD5-no-actionable "$(run "$p" - | digest)" 'memory digest: +- open: BLK-001 Only blocker' + +# SD6: a 400-char journal line with an em dash, cut at 160, valid UTF-8 +p=$(mkproj sd6) +long=$(printf 'a — %.0s' $(seq 1 130)) +printf '## d\n- %s\n' "$long" > "$p/.claude/memory/journal.md" +for loc in C.UTF-8 C; do + out=$(cd "$p" && LC_ALL=$loc bash "$SS" </dev/null 2>/dev/null | digest | tail -1) + ok=$(printf '%s' "$out" | iconv -f UTF-8 -t UTF-8 >/dev/null 2>&1 && echo valid || echo invalid) + check "SD6-valid-utf8-$loc" "$ok" valid + check "SD6-ellipsis-$loc" "${out: -1}" "…" +done +out=$(cd "$p" && LC_ALL=C.UTF-8 bash "$SS" </dev/null 2>/dev/null | digest | tail -1) +check SD6-len-160 "${#out}" 160 + +# SD7: 10 open BLK with long titles, long todos and journal -> whole lines, <= 800 +p=$(mkproj sd7) +lt=$(printf 'title%.0s ' $(seq 1 40)) +for i in 1 2 3 4 5 6 7 8 9 10; do blk "$p" "$i" open "$lt"; done +printf '### Actionable\n- [ ] %s\n- [ ] %s\n- [ ] %s\n' "$lt" "$lt" "$lt" > "$p/.claude/tasks/TODO.md" +printf '## d\n- %s\n' "$lt$lt" > "$p/.claude/memory/journal.md" +out=$(run "$p" - | digest) +check SD7-le-800 "$([ "${#out}" -le 800 ] && echo yes || echo no)" yes +check SD7-header "$(printf '%s' "$out" | head -1)" 'memory digest:' +check SD7-whole-lines "$(printf '%s\n' "$out" | tail -n +2 | grep -vc '^- \(open: BLK-\|open: +\|todo: \|journal: \)')" 0 +check SD7-dropped-from-end "$(printf '%s' "$out" | grep -c 'journal:')" 0 +check SD7-lines-le-160 "$(printf '%s\n' "$out" | awk 'length($0) > 160' | wc -l | tr -d ' ')" 0 + +# SD9: copy of the script beside a failing / malformed lib; blockers dir +mkdir -p "$WORK/sd9/hooks" "$WORK/sd9/lib" +cp "$SS" "$WORK/sd9/hooks/session-start.sh" +for f in "$ROOT"/lib/*; do + [ "$(basename "$f")" = memory.sh ] || ln -s "$f" "$WORK/sd9/lib/" +done +S9="$WORK/sd9/hooks/session-start.sh" +p=$(mkproj sd9) +blk "$p" 1 open "Never shown" +printf '#!/usr/bin/env bash\nexit 2\n' > "$WORK/sd9/lib/memory.sh" +out=$(run "$p" - "$S9"); rc=$? +check SD9a-exit2-rc "$rc" 0 +check SD9a-banner "$(printf '%s' "$out" | grep -c 'make doctor')" 1 +check SD9a-no-digest "$(printf '%s' "$out" | grep -c 'memory digest:')" 0 +printf '#!/usr/bin/env bash\nprintf "| BLK-1 |\\n| BLK-2 | x\\n| BLK-3 | d | t | weird |\\ngarbage\\n"\n' \ + > "$WORK/sd9/lib/memory.sh" +out=$(run "$p" - "$S9"); rc=$? +check SD9b-malformed-rc "$rc" 0 +check SD9b-banner "$(printf '%s' "$out" | grep -c 'make doctor')" 1 +check SD9b-no-digest "$(printf '%s' "$out" | grep -c 'memory digest:')" 0 +p=$(mkproj sd9d); mkdir "$p/.claude/memory/blockers.md" +out=$(run "$p" -); rc=$? +check SD9c-dir-rc "$rc" 0 +check SD9c-banner "$(printf '%s' "$out" | grep -c 'make doctor')" 1 +check SD9c-no-digest "$(printf '%s' "$out" | grep -c 'memory digest:')" 0 + +# SD10: PATH without jq, piped resume -> no digest, banner intact +bin="$WORK/nojq"; mkdir -p "$bin" +for c in bash git cat sed awk grep tail head cut dirname readlink wc tr \ + sort uniq timeout iconv env date basename mktemp find ls cp rm mkdir \ + cmp stat id uname tee printf; do + src=$(command -v "$c" 2>/dev/null) && ln -sf "$src" "$bin/$c" +done +p=$(mkproj sd10); blk "$p" 1 open "Hidden" +out=$(cd "$p" && PATH="$bin" bash "$SS" <"$WORK/resume.json" 2>/dev/null) +check SD10-no-jq-no-digest "$(printf '%s' "$out" | grep -c 'memory digest:')" 0 +check SD10-no-jq-banner "$(printf '%s' "$out" | grep -c 'make doctor')" 1 +check SD10-jq-really-absent "$(PATH="$bin" command -v jq | wc -l | tr -d ' ')" 0 + +printf 'session-digest: %d passed, %d failed\n' "$pass" "$fail" +[ "$fail" -eq 0 ]