forked from bchanot/claude
feat(memory): intent recall at the prompt, once per context
This commit is contained in:
1 parent
acbfd71327
commit
3bb2eafb0c
2 files changed
+609
-17
No files matched your search
@@ -1,6 +1,6 @@
|
|||||||
import { test, expect, mock } from 'claude-code/testing'
|
import { test, expect, mock } from 'claude-code/testing'
|
||||||
import type { Engine, MockClock } from 'claude-code/testing'
|
import type { Engine, MockClock } from 'claude-code/testing'
|
||||||
import type { On } from 'claude-code'
|
import type { On, EngineInterface as Api } from 'claude-code'
|
||||||
import type { Entry, Kind } from './register'
|
import type { Entry, Kind } from './register'
|
||||||
import {
|
import {
|
||||||
cap, tail, redact, normalize, failureLine, sessionOf, addFailure,
|
cap, tail, redact, normalize, failureLine, sessionOf, addFailure,
|
||||||
@@ -9,7 +9,8 @@ import {
|
|||||||
parseIds, recallLine, recallBlock, failureKey,
|
parseIds, recallLine, recallBlock, failureKey,
|
||||||
segments, suiteKeyOf, commitLabel, finishLabel,
|
segments, suiteKeyOf, commitLabel, finishLabel,
|
||||||
newState, switchOf, claim, onContextStart, resetContext, endContext,
|
newState, switchOf, claim, onContextStart, resetContext, endContext,
|
||||||
appendLog, loadLog, RECALL_CAP,
|
appendLog, loadLog, RECALL_CAP, isTrigger, promptContext,
|
||||||
|
DESIGN_RULE, ANALYSIS_RULE, HAIKU, RERANK_MS, IDLE_MS,
|
||||||
} from './register'
|
} from './register'
|
||||||
import type { LogRecord } from './register'
|
import type { LogRecord } from './register'
|
||||||
|
|
||||||
@@ -31,6 +32,15 @@ const INDEX_OUT = [
|
|||||||
/** How the process bottom answers: a stdout, or a way to fail. */
|
/** How the process bottom answers: a stdout, or a way to fail. */
|
||||||
type Proc = { stdout: string } | 'throw' | 'exit2' | 'hang'
|
type Proc = { stdout: string } | 'throw' | 'exit2' | 'hang'
|
||||||
|
|
||||||
|
/** How the model bottom answers: a text, a non-answer, or a failure. */
|
||||||
|
type Model = { text: string } | 'unanswered' | 'throw' | 'hang'
|
||||||
|
|
||||||
|
/** What the model bottom was asked. */
|
||||||
|
type Ask = {
|
||||||
|
model: string; prompt: string; effort: unknown
|
||||||
|
maxTokens: unknown; timeoutMs: unknown
|
||||||
|
}
|
||||||
|
|
||||||
type World = {
|
type World = {
|
||||||
home: string | undefined // what env.get answers for HOME
|
home: string | undefined // what env.get answers for HOME
|
||||||
switchText: string | undefined // ~/.claude/memory.json (undefined: absent)
|
switchText: string | undefined // ~/.claude/memory.json (undefined: absent)
|
||||||
@@ -52,6 +62,8 @@ type World = {
|
|||||||
runs: string[][] // every process.run argv
|
runs: string[][] // every process.run argv
|
||||||
gets: number // store.get calls
|
gets: number // store.get calls
|
||||||
getsFail: boolean // store.get throws
|
getsFail: boolean // store.get throws
|
||||||
|
model: Model // what `model.complete` does now
|
||||||
|
asks: Ask[] // every model.complete call
|
||||||
}
|
}
|
||||||
|
|
||||||
type Opts = {
|
type Opts = {
|
||||||
@@ -100,7 +112,7 @@ async function boot($: Engine, on: On, o: Opts = {}): Promise<World> {
|
|||||||
statFails: new Set(o.statFails ?? []),
|
statFails: new Set(o.statFails ?? []),
|
||||||
existsFails: new Set(o.existsFails ?? []),
|
existsFails: new Set(o.existsFails ?? []),
|
||||||
proc: { stdout: INDEX_OUT }, runs: [], home: HOME,
|
proc: { stdout: INDEX_OUT }, runs: [], home: HOME,
|
||||||
gets: 0, getsFail: false,
|
gets: 0, getsFail: false, model: { text: 'none' }, asks: [],
|
||||||
}
|
}
|
||||||
handStore(on, w, o.storeFails ?? false)
|
handStore(on, w, o.storeFails ?? false)
|
||||||
on('tool.register', (_a, e) => {
|
on('tool.register', (_a, e) => {
|
||||||
@@ -147,6 +159,19 @@ async function boot($: Engine, on: On, o: Opts = {}): Promise<World> {
|
|||||||
return { value: { ...done, stderr: '', isStdoutTruncated: false,
|
return { value: { ...done, stderr: '', isStdoutTruncated: false,
|
||||||
isStderrTruncated: false } }
|
isStderrTruncated: false } }
|
||||||
})
|
})
|
||||||
|
on('model.complete', async (_a, e) => {
|
||||||
|
const x = e as unknown as Ask
|
||||||
|
w.asks.push({ model: x.model, prompt: x.prompt, effort: x.effort,
|
||||||
|
maxTokens: x.maxTokens, timeoutMs: x.timeoutMs })
|
||||||
|
if (w.model === 'throw') throw new Error('api down')
|
||||||
|
if (w.model === 'hang') await new Promise(() => undefined)
|
||||||
|
const usage = { input_tokens: 0, output_tokens: 0 }
|
||||||
|
const done = w.model === 'unanswered'
|
||||||
|
? { isAnswered: false, reason: 'api-error', status: 500,
|
||||||
|
error: 'server_error', usage }
|
||||||
|
: { isAnswered: true, text: w.model.text, usage }
|
||||||
|
return { value: done } as never
|
||||||
|
})
|
||||||
on('session.root', () => {
|
on('session.root', () => {
|
||||||
if (w.rootFails) throw new Error('no root')
|
if (w.rootFails) throw new Error('no root')
|
||||||
return { value: w.root }
|
return { value: w.root }
|
||||||
@@ -2148,3 +2173,394 @@ test('LG4: loadLog drops malformed records; project key untouched',
|
|||||||
expect(await loadLog(storeApi(w), ROOT)).toEqual([REC(1)])
|
expect(await loadLog(storeApi(w), ROOT)).toEqual([REC(1)])
|
||||||
expect(w.kv.has(`p:${ROOT}`)).toBe(false)
|
expect(w.kv.has(`p:${ROOT}`)).toBe(false)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
// ---- intent recall at the prompt ---------------------------------------
|
||||||
|
|
||||||
|
const DECISIONS = `${REG}/decisions.md`
|
||||||
|
const entryText = (id: string, title: string, label: string, lesson: string) =>
|
||||||
|
`## ${id} \u2014 ${title}\n- **Status**: open\n- **${label}**: ${lesson}\n`
|
||||||
|
const rowsOut = (rows: [string, string][]) => [
|
||||||
|
'.claude/memory/x.md', '', '| ID | Date | Title | Status |',
|
||||||
|
'|---|---|---|---|',
|
||||||
|
...rows.map(([id, title]) => `| ${id} | 2026-01-01 | ${title} | open |`), '',
|
||||||
|
].join('\n')
|
||||||
|
|
||||||
|
const BLK1_LINE = 'BLK-001 mod design \u2014 Keep the suite small and ' +
|
||||||
|
'concevoir the mod first.'
|
||||||
|
const BLK1 = entryText('BLK-001', 'mod design', 'Solution',
|
||||||
|
'Keep the suite small and concevoir the mod first.')
|
||||||
|
const LRN2 = entryText('LRN-002', 'design notes', 'Pattern',
|
||||||
|
'Write design notes before coding.')
|
||||||
|
const REC_FILES = { [BLK]: BLK1, [LRN]: LRN2 }
|
||||||
|
const REC_INDEX = rowsOut([['BLK-001', 'mod design'],
|
||||||
|
['LRN-002', 'design notes']])
|
||||||
|
|
||||||
|
const GO = 'on va concevoir la suite du mod'
|
||||||
|
const DESIGN = 'design the mod suite please'
|
||||||
|
const NOTES = 'write notes about the mod now'
|
||||||
|
|
||||||
|
/** Boots the notes world with recall fixtures; the model picks BLK-001. */
|
||||||
|
async function bootRecall($: Engine, on: On, o: Opts = {}) {
|
||||||
|
const r = await bootNotes($, on, { files: REC_FILES, ...o })
|
||||||
|
r.w.proc = { stdout: REC_INDEX }
|
||||||
|
r.w.model = { text: 'BLK-001' }
|
||||||
|
return r
|
||||||
|
}
|
||||||
|
|
||||||
|
const start = ($: Engine, source = 'startup') => $.classic.SessionStart({
|
||||||
|
hook_event_name: 'SessionStart', transcript_path: '/t', cwd: ROOT,
|
||||||
|
session_id: 's1', source,
|
||||||
|
} as never)
|
||||||
|
|
||||||
|
const say = ($: Engine, text: string, turnId?: string) => $.prompt.submit({
|
||||||
|
text, wait: turnId !== undefined, origin: { kind: 'composer' },
|
||||||
|
...(turnId === undefined ? {} : { turnId }),
|
||||||
|
})
|
||||||
|
|
||||||
|
const BLOCK1 = `memory recall:\n${BLK1_LINE}`
|
||||||
|
|
||||||
|
test('IR1: the first prompt of a context asks and injects the block',
|
||||||
|
async ($, on) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
await say($, GO)
|
||||||
|
expect(w.asks).toHaveLength(1)
|
||||||
|
expect(w.asks[0]).toMatchObject({ model: 'claude-haiku-5-5',
|
||||||
|
effort: 'low', maxTokens: 64, timeoutMs: 3000 })
|
||||||
|
expect(w.asks[0]?.prompt).toContain('BLK-001 | mod design | ')
|
||||||
|
expect(seen).toEqual([[BLOCK1]])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR2 IR3: an ordinary prompt 1 min later is silent, 31 min asks',
|
||||||
|
async ($, on) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
await say($, GO)
|
||||||
|
await w.clock.advance(60000)
|
||||||
|
await say($, NOTES)
|
||||||
|
expect(w.asks).toHaveLength(1)
|
||||||
|
expect(seen[1]).toBeUndefined()
|
||||||
|
await w.clock.advance(1860000)
|
||||||
|
await say($, NOTES)
|
||||||
|
expect(w.asks).toHaveLength(2)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR4: slash, mid-turn, sdk and short prompts never ask', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
await say($, '/feat add design notes')
|
||||||
|
await say($, DESIGN, 'u1')
|
||||||
|
await $.prompt.submit({ text: DESIGN, wait: false, origin: { kind: 'sdk' } })
|
||||||
|
await say($, 'design note')
|
||||||
|
expect(w.asks).toEqual([])
|
||||||
|
expect(seen.every(c => c === undefined)).toBe(true)
|
||||||
|
await say($, DESIGN)
|
||||||
|
expect(w.asks).toHaveLength(1)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR5: an ID that is not a candidate is never injected', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
w.model = { text: 'BDR-999, BLK-001' }
|
||||||
|
await start($)
|
||||||
|
await say($, GO)
|
||||||
|
expect(seen).toEqual([[BLOCK1]])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR5b: none, an unanswered call and a throw add nothing', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
for (const m of [{ text: 'none' }, 'unanswered', 'throw'] as Model[]) {
|
||||||
|
w.model = m
|
||||||
|
await say($, DESIGN)
|
||||||
|
}
|
||||||
|
expect(w.asks).toHaveLength(3)
|
||||||
|
expect(seen.every(c => c === undefined)).toBe(true)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR5c: a call that never settles passes after RERANK_MS', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
w.model = 'hang'
|
||||||
|
await start($)
|
||||||
|
const p = say($, DESIGN)
|
||||||
|
await w.clock.advance(RERANK_MS)
|
||||||
|
await p
|
||||||
|
expect(w.asks).toHaveLength(1)
|
||||||
|
expect(seen).toEqual([undefined])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR6: compact starts a new context, resume does not', async ($, on) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
await say($, GO)
|
||||||
|
await start($, 'compact')
|
||||||
|
await say($, GO)
|
||||||
|
expect(w.asks).toHaveLength(2)
|
||||||
|
expect(seen).toEqual([[BLOCK1], [BLOCK1]])
|
||||||
|
await start($, 'resume')
|
||||||
|
await say($, NOTES)
|
||||||
|
expect(w.asks).toHaveLength(2)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR7: BLK-001 is injected once, later asks never list it', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
for (let i = 0; i < 3; i++) await say($, DESIGN)
|
||||||
|
expect(w.asks).toHaveLength(3)
|
||||||
|
expect(w.asks[1]?.prompt).not.toContain('BLK-001')
|
||||||
|
expect(w.asks[2]?.prompt).not.toContain('BLK-001')
|
||||||
|
expect(seen).toEqual([[BLOCK1], undefined, undefined])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR8: every candidate already seen means no ask at all', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w } = await bootRecall($, on, { files: { [BLK]: BLK1 } })
|
||||||
|
await start($)
|
||||||
|
await say($, DESIGN)
|
||||||
|
await say($, DESIGN)
|
||||||
|
expect(w.asks).toHaveLength(1)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR9: "recall": false asks nothing, the note still attaches', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on,
|
||||||
|
{ switchText: '{"enabled": true, "recall": false}' })
|
||||||
|
await start($)
|
||||||
|
await run($, w, 'git commit -m "fix: y"')
|
||||||
|
await say($, DESIGN)
|
||||||
|
expect(w.asks).toEqual([])
|
||||||
|
expect(seen[0]).toHaveLength(1)
|
||||||
|
expect(seen[0]?.[0]).toContain('memory: commit fix: y')
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR9b: a non-boolean "recall" logs one line, recall stays on', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on,
|
||||||
|
{ switchText: '{"recall": "no"}' })
|
||||||
|
await start($)
|
||||||
|
await say($, GO)
|
||||||
|
expect(seen).toEqual([[BLOCK1]])
|
||||||
|
expect(w.logs).toEqual([
|
||||||
|
'memory: ~/.claude/memory.json has no boolean "recall", recall stays on',
|
||||||
|
])
|
||||||
|
})
|
||||||
|
|
||||||
|
for (const proc of ['throw', 'exit2'] as const) {
|
||||||
|
test(`IR10: status reader ${proc}: no ask, prompt unchanged`, async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
w.proc = proc
|
||||||
|
await start($)
|
||||||
|
await say($, GO)
|
||||||
|
expect(w.asks).toEqual([])
|
||||||
|
expect(seen).toEqual([undefined])
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
test('IR11: an injection leaves one log record; 205 keep 200', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
await say($, GO)
|
||||||
|
expect(await loadLog(storeApi(w), ROOT)).toEqual([
|
||||||
|
{ at: 1000, session: 's1', agent: 'main', channel: 'prompt',
|
||||||
|
ids: ['BLK-001'] },
|
||||||
|
])
|
||||||
|
for (let i = 0; i < 204; i++) {
|
||||||
|
await start($, 'clear')
|
||||||
|
await say($, GO)
|
||||||
|
}
|
||||||
|
expect(await loadLog(storeApi(w), ROOT)).toHaveLength(200)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('IR12: a pending milestone and a trigger give [note, block]', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w, seen } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
await run($, w, 'git commit -m "fix: y"')
|
||||||
|
await say($, GO)
|
||||||
|
expect(seen).toHaveLength(1)
|
||||||
|
expect(seen[0]?.[0]).toContain('memory: commit fix: y')
|
||||||
|
expect(seen[0]?.[1]).toBe(BLOCK1)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('registries load once per prompt for the note and the recall', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
await run($, w, 'git commit -m "fix: y"')
|
||||||
|
const before = w.runs.length
|
||||||
|
await say($, GO)
|
||||||
|
expect(w.runs.length - before).toBe(1)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('RP1: 3 failed reranks in a row pause it 15 min, a success resets',
|
||||||
|
async ($, on) => {
|
||||||
|
const { w } = await bootRecall($, on)
|
||||||
|
w.model = 'unanswered'
|
||||||
|
await start($)
|
||||||
|
for (let i = 0; i < 4; i++) await say($, DESIGN)
|
||||||
|
expect(w.asks).toHaveLength(3)
|
||||||
|
await w.clock.advance(900000)
|
||||||
|
await say($, DESIGN)
|
||||||
|
expect(w.asks).toHaveLength(4)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('RP2: a success between failures keeps the pause away', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const { w } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
for (const m of ['unanswered', 'unanswered', { text: 'none' },
|
||||||
|
'unanswered', 'unanswered', 'unanswered'] as Model[]) {
|
||||||
|
w.model = m
|
||||||
|
await say($, DESIGN)
|
||||||
|
}
|
||||||
|
expect(w.asks).toHaveLength(6)
|
||||||
|
await say($, DESIGN)
|
||||||
|
expect(w.asks).toHaveLength(6)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('RP3: timeouts and throws count like failures', async ($, on) => {
|
||||||
|
const { w } = await bootRecall($, on)
|
||||||
|
await start($)
|
||||||
|
w.model = 'throw'
|
||||||
|
await say($, DESIGN)
|
||||||
|
await say($, DESIGN)
|
||||||
|
w.model = 'hang'
|
||||||
|
const p = say($, DESIGN)
|
||||||
|
await w.clock.advance(RERANK_MS)
|
||||||
|
await p
|
||||||
|
await say($, DESIGN)
|
||||||
|
expect(w.asks).toHaveLength(3)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('TIMErules: both rules on 64 KiB of letters, under 50 ms', () => {
|
||||||
|
const text = 'a'.repeat(65536)
|
||||||
|
const t0 = now()
|
||||||
|
expect(DESIGN_RULE.test(text)).toBe(false)
|
||||||
|
expect(ANALYSIS_RULE.test(text)).toBe(false)
|
||||||
|
expect(isTrigger(text, false, 0)).toBe(false)
|
||||||
|
expect(now() - t0).toBeLessThan(50)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('isTrigger: rules, fresh, idle, slash and length', () => {
|
||||||
|
expect(isTrigger('please review this module', false, 0)).toBe(true)
|
||||||
|
expect(isTrigger('on va concevoir la suite', false, 0)).toBe(false)
|
||||||
|
expect(isTrigger('on va concevoir la suite', true, 0)).toBe(true)
|
||||||
|
expect(isTrigger('on va concevoir la suite', false, IDLE_MS)).toBe(true)
|
||||||
|
expect(isTrigger('/feat design the thing', true, IDLE_MS)).toBe(false)
|
||||||
|
expect(isTrigger('design note', true, 0)).toBe(false)
|
||||||
|
expect(isTrigger('un-design-ed thing here', false, 0)).toBe(false)
|
||||||
|
expect(HAIKU).toBe('claude-haiku-5-5')
|
||||||
|
})
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The few calls promptContext makes, over the world: the test's own `$` has
|
||||||
|
* no session.root, and a hook's `$` is refused outside its module.
|
||||||
|
*/
|
||||||
|
const fakeApi = (w: World): Api => ({
|
||||||
|
session: { root: async () => w.root, id: async () => w.id },
|
||||||
|
clock: { now: async () => w.clock.now(),
|
||||||
|
sleep: () => new Promise<void>(() => undefined) },
|
||||||
|
env: { get: async () => w.home },
|
||||||
|
fs: {
|
||||||
|
stat: async (p: string) => {
|
||||||
|
const text = w.files.get(p)
|
||||||
|
if (text === undefined) throw new Error('ENOENT')
|
||||||
|
return { kind: 'file', size: text?.length ?? 0 }
|
||||||
|
},
|
||||||
|
read: async (p: string) => w.files.get(p) ?? '',
|
||||||
|
exists: async (p: string) => w.files.has(p),
|
||||||
|
},
|
||||||
|
process: { run: async () => ({ exitCode: 0,
|
||||||
|
stdout: (w.proc as { stdout: string }).stdout }) },
|
||||||
|
model: { complete: async (a: Ask) => {
|
||||||
|
w.asks.push(a)
|
||||||
|
return { isAnswered: true, text: (w.model as { text: string }).text }
|
||||||
|
} },
|
||||||
|
store: storeApi(w).store,
|
||||||
|
ui: { log: () => undefined },
|
||||||
|
}) as unknown as Api
|
||||||
|
|
||||||
|
/** A state past the switch read, so promptContext skips the tool setup. */
|
||||||
|
const switchedOn = () => Object.assign(newState(), {
|
||||||
|
enabled: true, recall: true })
|
||||||
|
|
||||||
|
/** A recall entry whose line is 381 characters: 90 title, 280 lesson. */
|
||||||
|
const longEntry = (n: number) => {
|
||||||
|
const field = 'alpha '.repeat(50).slice(0, 279) + '.'
|
||||||
|
return entryText(`BLK-00${n}`, 't'.repeat(89) + n, 'Solution', field)
|
||||||
|
}
|
||||||
|
|
||||||
|
test('SP1: an ordinary prompt resets the main key spent budget', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const ids = ['BLK-001', 'BLK-002', 'BLK-003']
|
||||||
|
const w = await boot($, on, { files: {
|
||||||
|
[BLK]: [1, 2, 3].map(longEntry).join('\n') } })
|
||||||
|
const api = () => fakeApi(w)
|
||||||
|
w.proc = { stdout: rowsOut(ids.map(id =>
|
||||||
|
[id, 't'.repeat(89) + id.slice(-1)])) }
|
||||||
|
w.model = { text: ids.join(', ') }
|
||||||
|
const st = switchedOn()
|
||||||
|
const e = (text: string) => ({ text, origin: { kind: 'composer' } })
|
||||||
|
onContextStart(st, 's1')
|
||||||
|
const [block] = await promptContext(api(), st, e('design alpha now'))
|
||||||
|
expect(block?.length).toBe(1160) // 14 header + 3 x (381 line + 1)
|
||||||
|
expect(st.spent.get('s1:main')).toBe(1160)
|
||||||
|
expect(await promptContext(api(), st, e('nothing special at all')))
|
||||||
|
.toEqual([])
|
||||||
|
expect(st.spent.has('s1:main')).toBe(false)
|
||||||
|
// a 400-char line fits after the reset; 1160 + 400 > 1500 would not
|
||||||
|
expect(claim(st, 's1:main', ['KNOWN-1'], [400])).toEqual(['KNOWN-1'])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('SP2: a prompt without a known last prompt is not idle', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const w = await boot($, on, { files: REC_FILES })
|
||||||
|
w.proc = { stdout: REC_INDEX }
|
||||||
|
const api = () => fakeApi(w)
|
||||||
|
const st = switchedOn()
|
||||||
|
const e = { text: NOTES, origin: { kind: 'composer' } }
|
||||||
|
expect(await promptContext(api(), st, e)).toEqual([])
|
||||||
|
expect(w.asks).toEqual([])
|
||||||
|
expect(st.lastPrompt.get('s1')).toBe(1000)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('CL4: a missing cost refuses the id, it is not free', () => {
|
||||||
|
const st = newState()
|
||||||
|
expect(claim(st, 'k', ['A-1', 'B-2'], [10])).toEqual(['A-1'])
|
||||||
|
expect(st.seen.get('k')?.has('B-2')).toBe(false)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('LG5: two appends fired together keep both records', async (
|
||||||
|
$, on,
|
||||||
|
) => {
|
||||||
|
const w = await boot($, on)
|
||||||
|
const st = newState()
|
||||||
|
const api = storeApi(w)
|
||||||
|
await Promise.all([
|
||||||
|
appendLog(api, st, ROOT, REC(1)),
|
||||||
|
appendLog(api, st, ROOT, REC(2)),
|
||||||
|
])
|
||||||
|
expect((w.kv.get(`l:${ROOT}`) as LogRecord[]).map(r => r.at))
|
||||||
|
.toEqual([1, 2])
|
||||||
|
})
|
||||||
+190
-14
@@ -17,6 +17,7 @@ type State = {
|
|||||||
spent: Map<string, number> // context key -> chars injected
|
spent: Map<string, number> // context key -> chars injected
|
||||||
fresh: Set<string> // sessions whose next qualifying prompt starts a context
|
fresh: Set<string> // sessions whose next qualifying prompt starts a context
|
||||||
lastPrompt: Map<string, number> // session id -> time of its last prompt
|
lastPrompt: Map<string, number> // session id -> time of its last prompt
|
||||||
|
rerank: { fails: number; until: number } // failures in a row, pause end
|
||||||
}
|
}
|
||||||
|
|
||||||
export const IDLE_MS = 1800000
|
export const IDLE_MS = 1800000
|
||||||
@@ -724,9 +725,11 @@ export function recallLine(e: Entry): string {
|
|||||||
return e.lesson === '' ? head : `${head} — ${e.lesson}`
|
return e.lesson === '' ? head : `${head} — ${e.lesson}`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const RECALL_HEADER = 'memory recall:'
|
||||||
|
|
||||||
/** The injected block; a line that would pass `max` characters is dropped. */
|
/** The injected block; a line that would pass `max` characters is dropped. */
|
||||||
export function recallBlock(lines: string[], max: number): string {
|
export function recallBlock(lines: string[], max: number): string {
|
||||||
const header = 'memory recall:'
|
const header = RECALL_HEADER
|
||||||
let block = header
|
let block = header
|
||||||
for (const line of lines) {
|
for (const line of lines) {
|
||||||
if (block.length + 1 + line.length <= max) block += `\n${line}`
|
if (block.length + 1 + line.length <= max) block += `\n${line}`
|
||||||
@@ -906,6 +909,8 @@ export type LogRecord = {
|
|||||||
ids: string[]
|
ids: string[]
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// shortcut: one `l:<root>` key per project, so no cap across roots; upgrade
|
||||||
|
// path: one global log key, or a sweep of the `l:` keys by age.
|
||||||
const LOG_PREFIX = 'l:'
|
const LOG_PREFIX = 'l:'
|
||||||
const MAX_LOG = 200
|
const MAX_LOG = 200
|
||||||
const MAX_LOG_BYTES = 65536
|
const MAX_LOG_BYTES = 65536
|
||||||
@@ -1049,6 +1054,7 @@ export function newState(): State {
|
|||||||
spent: new Map(),
|
spent: new Map(),
|
||||||
fresh: new Set(),
|
fresh: new Set(),
|
||||||
lastPrompt: new Map(),
|
lastPrompt: new Map(),
|
||||||
|
rerank: { fails: 0, until: 0 },
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1181,8 +1187,9 @@ export function claim(
|
|||||||
let spent = st.spent.get(key) ?? 0
|
let spent = st.spent.get(key) ?? 0
|
||||||
const taken: string[] = []
|
const taken: string[] = []
|
||||||
ids.forEach((id, i) => {
|
ids.forEach((id, i) => {
|
||||||
const cost = chars[i] ?? 0
|
const cost = chars[i]
|
||||||
if (seen.has(id) || spent + cost > RECALL_CAP) return
|
// a missing cost refuses the id: unknown is not free
|
||||||
|
if (cost === undefined || seen.has(id) || spent + cost > RECALL_CAP) return
|
||||||
seen.add(id)
|
seen.add(id)
|
||||||
spent += cost
|
spent += cost
|
||||||
taken.push(id)
|
taken.push(id)
|
||||||
@@ -1398,33 +1405,202 @@ function registerBash(on: On, st: State): void {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/** Failures of the current session no registry entry knows. */
|
/** Failures of the current session no registry entry knows. */
|
||||||
async function newFailureCount($: Api, st: State, at: Where): Promise<number> {
|
async function newFailureCount(
|
||||||
|
$: Api,
|
||||||
|
st: State,
|
||||||
|
at: Where,
|
||||||
|
index: Map<string, string>,
|
||||||
|
): Promise<number> {
|
||||||
await st.writes
|
await st.writes
|
||||||
const p = await loadProject($, at.root)
|
const p = await loadProject($, at.root)
|
||||||
const { index } = await loadRegistries($, at.root, FAILURE_FILES)
|
|
||||||
const cur = p.sessions.find(s => s.id === at.id)
|
const cur = p.sessions.find(s => s.id === at.id)
|
||||||
return (cur?.failures ?? []).filter(isFailure)
|
return (cur?.failures ?? []).filter(isFailure)
|
||||||
.filter(f => matchOf(index, f.key) === undefined).length
|
.filter(f => matchOf(index, f.key) === undefined).length
|
||||||
}
|
}
|
||||||
|
|
||||||
/** The note for the oldest unnoted milestone; clears what it covers. */
|
/** The note for the oldest unnoted milestone; clears what it covers. */
|
||||||
async function noteFor($: Api, st: State, at: Where): Promise<string> {
|
async function noteFor(
|
||||||
|
$: Api,
|
||||||
|
st: State,
|
||||||
|
at: Where,
|
||||||
|
rx: Registries,
|
||||||
|
): Promise<string> {
|
||||||
const first = st.pending[0] ?? ''
|
const first = st.pending[0] ?? ''
|
||||||
st.pending = []
|
st.pending = []
|
||||||
const n = await newFailureCount($, st, at)
|
const n = await newFailureCount($, st, at, rx.index)
|
||||||
return `memory: ${first} \u2014 ${n} new failure mode(s) this session;` +
|
return `memory: ${first} \u2014 ${n} new failure mode(s) this session;` +
|
||||||
' /capitalize when ready.'
|
' /capitalize when ready.'
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// The default prompt rules of the model router (mods/model-router, commit
|
||||||
|
// 9bbd1d5): a prompt that designs or analyses asks for recall.
|
||||||
|
const WORD_BEFORE = '(?<![\\p{L}\\p{N}-])'
|
||||||
|
const WORD_AFTER = '(?![\\p{L}\\p{N}-])'
|
||||||
|
const wordRule = (words: string) =>
|
||||||
|
new RegExp(`${WORD_BEFORE}(${words})${WORD_AFTER}`, 'iu')
|
||||||
|
|
||||||
|
export const DESIGN_RULE = wordRule(
|
||||||
|
'plan|planifie|planning|brainstorm|architecture|con[c\\u00e7]ois|design',
|
||||||
|
)
|
||||||
|
export const ANALYSIS_RULE = wordRule(
|
||||||
|
'pourquoi|why|explique|explain|analyse|analyze|comprendre|understand|' +
|
||||||
|
'review|audit',
|
||||||
|
)
|
||||||
|
|
||||||
|
const MIN_PROMPT = 12 // code points
|
||||||
|
const MAX_CANDS = 30
|
||||||
|
const RERANK_FAILS = 3 // failed reranks in a row that pause it
|
||||||
|
const RERANK_PAUSE_MS = 900000
|
||||||
|
|
||||||
|
/** True when a prompt may ask for recall: fresh context, idle, or a rule. */
|
||||||
|
export function isTrigger(
|
||||||
|
text: string,
|
||||||
|
fresh: boolean,
|
||||||
|
idleMs: number,
|
||||||
|
): boolean {
|
||||||
|
if (text.startsWith('/') || Array.from(text).length < MIN_PROMPT) {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
const asked = cap(text, MAX_REGEX_INPUT)
|
||||||
|
return fresh || idleMs >= IDLE_MS ||
|
||||||
|
DESIGN_RULE.test(asked) || ANALYSIS_RULE.test(asked)
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Counts a rerank: the third failure in a row pauses it for 15 min. */
|
||||||
|
function countRerank(st: State, ok: boolean, now: number): void {
|
||||||
|
if (ok) {
|
||||||
|
st.rerank.fails = 0
|
||||||
|
return
|
||||||
|
}
|
||||||
|
st.rerank.fails += 1
|
||||||
|
if (st.rerank.fails < RERANK_FAILS) return
|
||||||
|
st.rerank = { fails: 0, until: now + RERANK_PAUSE_MS }
|
||||||
|
}
|
||||||
|
|
||||||
|
/** The haiku answer, or undefined: failed, unanswered, late or paused. */
|
||||||
|
async function askRerank(
|
||||||
|
$: Api,
|
||||||
|
st: State,
|
||||||
|
text: string,
|
||||||
|
cands: Entry[],
|
||||||
|
): Promise<string | undefined> {
|
||||||
|
const now = await $.clock.now()
|
||||||
|
if (now < st.rerank.until) return undefined
|
||||||
|
const ask = {
|
||||||
|
model: HAIKU,
|
||||||
|
prompt: rerankPrompt(text, cands),
|
||||||
|
effort: 'low' as const,
|
||||||
|
maxTokens: 64,
|
||||||
|
timeoutMs: RERANK_MS,
|
||||||
|
}
|
||||||
|
const call = $.model.complete(ask).catch((): undefined => undefined)
|
||||||
|
const late = $.clock.sleep(RERANK_MS).then((): undefined => undefined)
|
||||||
|
const out = await Promise.race([call, late])
|
||||||
|
const answer = out?.isAnswered === true ? out.text : undefined
|
||||||
|
countRerank(st, answer !== undefined, now)
|
||||||
|
return answer
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Live entries of the context not injected yet, best BM25 first. */
|
||||||
|
function candidatesFor(
|
||||||
|
st: State,
|
||||||
|
key: string,
|
||||||
|
rx: Registries,
|
||||||
|
text: string,
|
||||||
|
): Entry[] {
|
||||||
|
const { status } = rx
|
||||||
|
if (status === undefined) return []
|
||||||
|
const seen = st.seen.get(key)
|
||||||
|
const open = rx.entries.filter(e => isLive(status, e.id) && !seen?.has(e.id))
|
||||||
|
return bm25Rank(open, text, MAX_CANDS)
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The recall block for a prompt: BM25 candidates, haiku picks, the ledger
|
||||||
|
* claim, the log. '' when nothing is to be injected.
|
||||||
|
*/
|
||||||
|
async function recallFor(
|
||||||
|
$: Api,
|
||||||
|
st: State,
|
||||||
|
at: Where,
|
||||||
|
text: string,
|
||||||
|
rx: Registries,
|
||||||
|
): Promise<string> {
|
||||||
|
const key = contextKey(at.id, undefined)
|
||||||
|
const cands = candidatesFor(st, key, rx, text)
|
||||||
|
if (cands.length === 0) return ''
|
||||||
|
const answer = await askRerank($, st, text, cands)
|
||||||
|
const byId = new Map(cands.map(c => [c.id, c]))
|
||||||
|
const picked = parseIds(answer ?? '', cands, MAX_PICKS)
|
||||||
|
.flatMap(id => byId.get(id) ?? [])
|
||||||
|
const when = await $.clock.now()
|
||||||
|
// the header is charged to the first line of the block
|
||||||
|
const costs = picked.map((e, i) =>
|
||||||
|
recallLine(e).length + 1 + (i === 0 ? RECALL_HEADER.length : 0))
|
||||||
|
const taken = claim(st, key, picked.map(e => e.id), costs)
|
||||||
|
const block = recallBlock(
|
||||||
|
picked.filter(e => taken.includes(e.id)).map(recallLine), RECALL_CAP)
|
||||||
|
if (block === '') return ''
|
||||||
|
const record = { at: when, session: at.id, agent: 'main', ids: taken }
|
||||||
|
await appendLog($, st, at.root, { ...record, channel: 'prompt' })
|
||||||
|
.catch(() => undefined)
|
||||||
|
return block
|
||||||
|
}
|
||||||
|
|
||||||
|
const ALL_FILES = ['decisions.md', ...FAILURE_FILES]
|
||||||
|
|
||||||
|
/** The contexts a prompt adds: the 4b note, then the recall block. */
|
||||||
|
async function additions(
|
||||||
|
$: Api,
|
||||||
|
st: State,
|
||||||
|
at: Where,
|
||||||
|
text: string,
|
||||||
|
wantRecall: boolean,
|
||||||
|
): Promise<string[]> {
|
||||||
|
const rx = await loadRegistries($, at.root, ALL_FILES)
|
||||||
|
const note = st.pending.length > 0 ? await noteFor($, st, at, rx) : ''
|
||||||
|
const block = wantRecall
|
||||||
|
? await recallFor($, st, at, text, rx).catch(() => '')
|
||||||
|
: ''
|
||||||
|
return [note, block].filter(part => part !== '')
|
||||||
|
}
|
||||||
|
|
||||||
|
type PromptIn = {
|
||||||
|
text: string
|
||||||
|
turnId?: string | undefined
|
||||||
|
origin: { kind: string }
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The contexts to append to a composer prompt; [] for any other prompt. A
|
||||||
|
* new prompt starts a new turn: the main key's `spent` budget resets.
|
||||||
|
*/
|
||||||
|
export async function promptContext(
|
||||||
|
$: Api,
|
||||||
|
st: State,
|
||||||
|
e: PromptIn,
|
||||||
|
): Promise<string[]> {
|
||||||
|
if (!(await ensureEnabled($, st))) return []
|
||||||
|
if (e.origin.kind !== 'composer' || e.turnId !== undefined) return []
|
||||||
|
const at = { root: await $.session.root(), id: await $.session.id() }
|
||||||
|
if (at.root === '') return []
|
||||||
|
const now = await $.clock.now()
|
||||||
|
const last = st.lastPrompt.get(at.id)
|
||||||
|
const idle = last === undefined ? 0 : now - last // unknown: not idle
|
||||||
|
st.lastPrompt.set(at.id, now)
|
||||||
|
st.spent.delete(contextKey(at.id, undefined))
|
||||||
|
const wantRecall = (await ensureRecall($, st)) &&
|
||||||
|
isTrigger(e.text, st.fresh.has(at.id), idle)
|
||||||
|
if (wantRecall) st.fresh.delete(at.id)
|
||||||
|
if (!wantRecall && st.pending.length === 0) return []
|
||||||
|
return additions($, st, at, e.text, wantRecall)
|
||||||
|
}
|
||||||
|
|
||||||
function registerPrompt(on: On, st: State): void {
|
function registerPrompt(on: On, st: State): void {
|
||||||
on('prompt.submit', async ($, e, next) => {
|
on('prompt.submit', async ($, e, next) => {
|
||||||
if (!(await ensureEnabled($, st))) return next(e)
|
const added = await promptContext($, st, e)
|
||||||
const mine = e.origin.kind === 'composer' && e.turnId === undefined
|
if (added.length === 0) return next(e)
|
||||||
if (!mine || st.pending.length === 0) return next(e)
|
return next({ ...e, context: [...(e.context ?? []), ...added] })
|
||||||
const at = { root: await $.session.root(), id: await $.session.id() }
|
|
||||||
if (at.root === '') return next(e)
|
|
||||||
const note = await noteFor($, st, at)
|
|
||||||
return next({ ...e, context: [...(e.context ?? []), note] })
|
|
||||||
}).catch(($, e, next) => {
|
}).catch(($, e, next) => {
|
||||||
warnOnce(st, $, 'prompt.submit', next.error.kind)
|
warnOnce(st, $, 'prompt.submit', next.error.kind)
|
||||||
return next(e)
|
return next(e)
|
||||||
|
|||||||
Reference in new issue
Block a user