forked from bchanot/claude
Merge feature/advisor-points-b3 into develop
This commit is contained in:
commit
366f1f63bd
22 files changed
+147
-38
No files matched your search
@@ -112,12 +112,15 @@
|
|||||||
FIXED 2026-11-17 (24354d9): verifier, security-auditor and plan-challenger read "Advisor, when dispatched as a sub-agent". Residual kept: lib/verify-secure-loop.md:57-58, :106-107 still offer "or load agents/<x>.md" inline (unused today).
|
FIXED 2026-11-17 (24354d9): verifier, security-auditor and plan-challenger read "Advisor, when dispatched as a sub-agent". Residual kept: lib/verify-secure-loop.md:57-58, :106-107 still offer "or load agents/<x>.md" inline (unused today).
|
||||||
- agents/plan-challenger.md ORCHESTRATOR PROTOCOL (~:111-112, :133-135) — mirror of lib/challenge-plan.md lacks the main-loop "Advisor first" step and the CHALLENGE SUMMARY `Advisor:` row (58a5273); the 12 skills' own summary templates also lack the row (lib rule says append it anyway). Fix direction: patch the mirror, optionally add the row to the templates. Severity: low. Discovered while: /feat advisor-points-b1 re-challenge. Not fixed.
|
- agents/plan-challenger.md ORCHESTRATOR PROTOCOL (~:111-112, :133-135) — mirror of lib/challenge-plan.md lacks the main-loop "Advisor first" step and the CHALLENGE SUMMARY `Advisor:` row (58a5273); the 12 skills' own summary templates also lack the row (lib rule says append it anyway). Fix direction: patch the mirror, optionally add the row to the templates. Severity: low. Discovered while: /feat advisor-points-b1 re-challenge. Not fixed.
|
||||||
FIXED 2026-11-17 (24354d9): the mirror gains ADVISOR FIRST (pointer to the lib, its guards) and the `Advisor:` row. Residual kept: the 12 skills' own CHALLENGE SUMMARY templates still lack the row.
|
FIXED 2026-11-17 (24354d9): the mirror gains ADVISOR FIRST (pointer to the lib, its guards) and the `Advisor:` row. Residual kept: the 12 skills' own CHALLENGE SUMMARY templates still lack the row.
|
||||||
|
FIXED 2026-11-18 (2b7aeb8, run B3): the 12 callers' CHALLENGE SUMMARY templates carry the `Advisor` row (9 block rows, 3 one-line summaries).
|
||||||
|
|
||||||
<!-- /ship-feature advisor-points-b2 2026-11-17 (f48343e, 24354d9, 6022b9d): review residuals, not fixed in the run -->
|
<!-- /ship-feature advisor-points-b2 2026-11-17 (f48343e, 24354d9, 6022b9d): review residuals, not fixed in the run -->
|
||||||
- skills/tour/SKILL.md STEP 0b item 2 — in fan-out the end-of-run advisor call sees only the runners' one-line rows (no diff, no report section), and a `RUNNER FAILED` row can hide fixes already committed, so "when any row reports a fix" can skip the call. Fix direction: read each REPORT's new section (or `git -C <p> diff --stat develop..<branch>`) before the call. Severity: low. Discovered while: /ship-feature advisor-points-b2 STEP 6 review.
|
- skills/tour/SKILL.md STEP 0b item 2 — in fan-out the end-of-run advisor call sees only the runners' one-line rows (no diff, no report section), and a `RUNNER FAILED` row can hide fixes already committed, so "when any row reports a fix" can skip the call. Fix direction: read each REPORT's new section (or `git -C <p> diff --stat develop..<branch>`) before the call. Severity: low. Discovered while: /ship-feature advisor-points-b2 STEP 6 review.
|
||||||
- lib/effort-shift.md § Advisor item 3 + lib/verify-secure-loop.md stuck unit — after a fix the end call drives, the re-run gates find a main-loop call "since GATE 0 first ran", so the stuck call is already spent on that re-gate; the budget is plausible but unstated. Wording: "the six flows that run the gates" unnamed; "a later proposal" fits finish flows only; in feat/bugfix the doc and memory commits after the call always make "predates the newer commits" true; item 3 and the CHANGELOG say "the end step" of feat and bugfix, where the call sits at their commit step (STEP 5 / STEP 6), before doc sync and capitalize (the skill lines are placed right). Severity: low. Discovered while: /ship-feature advisor-points-b2 SDD final review and STEP 6 review.
|
- lib/effort-shift.md § Advisor item 3 + lib/verify-secure-loop.md stuck unit — after a fix the end call drives, the re-run gates find a main-loop call "since GATE 0 first ran", so the stuck call is already spent on that re-gate; the budget is plausible but unstated. Wording: "the six flows that run the gates" unnamed; "a later proposal" fits finish flows only; in feat/bugfix the doc and memory commits after the call always make "predates the newer commits" true; item 3 and the CHANGELOG say "the end step" of feat and bugfix, where the call sits at their commit step (STEP 5 / STEP 6), before doc sync and capitalize (the skill lines are placed right). Severity: low. Discovered while: /ship-feature advisor-points-b2 SDD final review and STEP 6 review.
|
||||||
|
PARTLY FIXED 2026-11-18 (2b7aeb8, run B3): item 3 names the six gate flows, puts feat/bugfix at their commit step, and replaces "predates the newer commits" with "names any code commit made after it (doc and memory commits excepted)". Open: the stuck-budget half.
|
||||||
- skills/release-candidate/SKILL.md STEP 4 — the end call's `route(phase="reflect")` has no route back, so STEP 5 (finish and tag) runs at reflect against an apply/low row. Severity: low (cost). Discovered while: same.
|
- skills/release-candidate/SKILL.md STEP 4 — the end call's `route(phase="reflect")` has no route back, so STEP 5 (finish and tag) runs at reflect against an apply/low row. Severity: low (cost). Discovered while: same.
|
||||||
- skills/{feat,bugfix,audit-delta,tour}/SKILL.md summary templates — FEAT/BUGFIX/AUDIT-DELTA/TOUR COMPLETE have no `Advisor:` field (only the prose asks for the line), and the end call has no "not called (absent | error | skipped)" wording like the CHALLENGE SUMMARY row. Severity: low. Discovered while: same.
|
- skills/{feat,bugfix,audit-delta,tour}/SKILL.md summary templates — FEAT/BUGFIX/AUDIT-DELTA/TOUR COMPLETE have no `Advisor:` field (only the prose asks for the line), and the end call has no "not called (absent | error | skipped)" wording like the CHALLENGE SUMMARY row. Severity: low. Discovered while: same.
|
||||||
|
PARTLY FIXED 2026-11-18 (2b7aeb8, run B3): FEAT and BUGFIX COMPLETE carry `ADVISOR : <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>`. Open: audit-delta and tour.
|
||||||
- skills/{ship-feature,init-project}/SKILL.md — the end call runs after STEP 6/10 code review, capitalize and doc sync; a fix it drives re-runs the gates but neither the code review nor the doc sync. Severity: low. Discovered while: same.
|
- skills/{ship-feature,init-project}/SKILL.md — the end call runs after STEP 6/10 code review, capitalize and doc sync; a fix it drives re-runs the gates but neither the code review nor the doc sync. Severity: low. Discovered while: same.
|
||||||
- agents/security-auditor.md STEP 5 dedup keys on (file:line, rule/check): an advisor-added `advisor:<class>` finding on a semgrep line counts twice in BLOCK(n) (pre-existing); "An added or applied finding" reads oddly; PROOF suffix for n=0 unspecified. Severity: low. Discovered while: same.
|
- agents/security-auditor.md STEP 5 dedup keys on (file:line, rule/check): an advisor-added `advisor:<class>` finding on a semgrep line counts twice in BLOCK(n) (pre-existing); "An added or applied finding" reads oddly; PROOF suffix for n=0 unspecified. Severity: low. Discovered while: same.
|
||||||
|
|
||||||
@@ -126,3 +129,7 @@
|
|||||||
|
|
||||||
<!-- /bugfix perl-timeout-group 2026-11-14 (490ad83): non-blocking gate findings, not BDR-125 -->
|
<!-- /bugfix perl-timeout-group 2026-11-14 (490ad83): non-blocking gate findings, not BDR-125 -->
|
||||||
- hooks/session-start.sh perl runner sends KILL to the group at the deadline (timeout sends TERM): a WRITER later put under `_SS_TMO` would skip memory.sh's INT/TERM/HUP restore trap and leave `memory.lock` until the 30 s steal. Today's three callers are readers (check, index blocker, feedback remind). Severity: low. Discovered while: /bugfix perl-timeout-group security gate. Not fixed.
|
- hooks/session-start.sh perl runner sends KILL to the group at the deadline (timeout sends TERM): a WRITER later put under `_SS_TMO` would skip memory.sh's INT/TERM/HUP restore trap and leave `memory.lock` until the 30 s steal. Today's three callers are readers (check, index blocker, feedback remind). Severity: low. Discovered while: /bugfix perl-timeout-group security gate. Not fixed.
|
||||||
|
|
||||||
|
<!-- /ship-feature advisor-points-b3 2026-11-18 (2b7aeb8, 51f343f): STEP 6 review root fix, not in the run's file scope -->
|
||||||
|
- lib/verify-secure-loop.md:111,:126-128 + agents/security-auditor.md:184,:190-192 — teach parsing DEGRADED off the `SECURITY — VERDICT:` line, but the auditor prints `VERDICT: PASS` on a DEGRADED scan and DEGRADED only on its `TOOL:` line (agents/security-auditor.md:133-134). A reader checking the VERDICT line misses it. feat/bugfix skip text now names the TOOL line at the site (51f343f). Fix direction: say DEGRADED shows on the TOOL line beside a PASS, in both. Severity: low. Discovered while: /ship-feature advisor-points-b3 STEP 6 opus review.
|
||||||
|
- Run B3 residuals (plan purged at finish, recorded here): (a) the challenge route line pairs `mcp__model-router__route` with the server-side advisor call, unverified in this repo (lib/effort-shift.md: the router cannot see the advisor tool; pairing only saves a request). (b) skills/{feat,bugfix} end line prints the diff stat even on a skip (cost one cheap command, nothing reads it). (c) lib/effort-shift.md item 3 "Two skips only" sentence ~65 words; feat/bugfix end-line first sentence ~60 words (prose length, oracle-safe splits exist). (d) contract 2026-11-18-advisor-points-b3-1056 criterion 9 says the exempt rows "run as wide as the rows beside them"; they run wider (Advisor rows 125-132 cols vs 77-96), wording only. Severity: low. Discovered while: /ship-feature advisor-points-b3 STEP 2b/STEP 6.
|
||||||
@@ -1612,3 +1612,4 @@ Supersedes [[BDR-030]].
|
|||||||
- **Status (2026-11-17)**: accepted, amended 6ef3069: main loop named call points (before a skill's plan, once per verify-secure run at first gate loop failing twice, before merge); plan-challenger/verifier/security-auditor at most one call before verdict, advice add-only (security: STEP 3 class severity, no class -> REPORTED LOW); other sub-agents do not
|
- **Status (2026-11-17)**: accepted, amended 6ef3069: main loop named call points (before a skill's plan, once per verify-secure run at first gate loop failing twice, before merge); plan-challenger/verifier/security-auditor at most one call before verdict, advice add-only (security: STEP 3 class severity, no class -> REPORTED LOW); other sub-agents do not
|
||||||
- **Status (2026-11-17)**: accepted, amended 58a5273: plan point in lib/challenge-plan.md (on written plan before challengers, once per skill run, Advisor: row in CHALLENGE SUMMARY, no attribution in plan); stuck lines inline in verify-secure-loop (main-loop calls only since GATE 0); dispatched analyzer joins; trigger before recommending doctrine/architecture/public-interface change
|
- **Status (2026-11-17)**: accepted, amended 58a5273: plan point in lib/challenge-plan.md (on written plan before challengers, once per skill run, Advisor: row in CHALLENGE SUMMARY, no attribution in plan); stuck lines inline in verify-secure-loop (main-loop calls only since GATE 0); dispatched analyzer joins; trigger before recommending doctrine/architecture/public-interface change
|
||||||
- **Status (2026-11-17)**: accepted, amended 6022b9d: B2 stuck trigger in 6 gate skills (points to verify-secure-loop); end-of-run call before done/merge in feat, bugfix, ship-feature, init-project, a11y, guardrails, audit-delta+tour (fix applied only), release-candidate STEP 4; own budget; gate flows print diff stat, fix back through gates; verifier/security-auditor/plan-challenger advise only when dispatched; auditor raise upward only; plan-challenger protocol mirror. Commits f48343e 24354d9 6022b9d
|
- **Status (2026-11-17)**: accepted, amended 6022b9d: B2 stuck trigger in 6 gate skills (points to verify-secure-loop); end-of-run call before done/merge in feat, bugfix, ship-feature, init-project, a11y, guardrails, audit-delta+tour (fix applied only), release-candidate STEP 4; own budget; gate flows print diff stat, fix back through gates; verifier/security-auditor/plan-challenger advise only when dispatched; auditor raise upward only; plan-challenger protocol mirror. Commits f48343e 24354d9 6022b9d
|
||||||
|
- **Status (2026-11-18)**: accepted, amended 51f343f: B3: challenge route rides first lib/challenge-plan.md call; summary Advisor row in 12 callers; feat/bugfix skip end call when GATE 0 MET + verifier CONFORME + security PASS (not DEGRADED, TOOL line) first attempt, ADVISOR field shows skip; item 3 reuse clause names later code commits
|
||||||
@@ -780,3 +780,4 @@ rules:
|
|||||||
|
|
||||||
## 2026-11-18
|
## 2026-11-18
|
||||||
- gates.sh hotfix c25a7ea (bugfix/gates-label-timeout): digit label not `N. text` = parse error; 2nd CHECK/EXPECT/EVIDENCE on one criterion = error (indented/bullet/bold labels gave same false MET, advisor caught it); no-criteria die names first parse error; default timeout 120 -> 600. GATE 0 MET 5/5 incl full make test at default, security PASS, 3 challengers SOLID. ABANDON-id aliasing + verify-secure-loop cause list -> TODO.
|
- gates.sh hotfix c25a7ea (bugfix/gates-label-timeout): digit label not `N. text` = parse error; 2nd CHECK/EXPECT/EVIDENCE on one criterion = error (indented/bullet/bold labels gave same false MET, advisor caught it); no-criteria die names first parse error; default timeout 120 -> 600. GATE 0 MET 5/5 incl full make test at default, security PASS, 3 challengers SOLID. ABANDON-id aliasing + verify-secure-loop cause list -> TODO.
|
||||||
|
- Advisor run B3 (/ship-feature, 2b7aeb8 51f343f): 12 callers route rides first challenge-plan call + summary Advisor row; feat/bugfix skip end call on strict clean gates (MET, CONFORME, PASS not DEGRADED, first attempt), ADVISOR field; item 3 commit step + reuse names later code commits. 3 lenses + re-challenge (3 MAJOR fixed), opus STEP 6 caught DEGRADED on TOOL line (LRN-300). Gates clean x2.
|
||||||
@@ -2157,3 +2157,8 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s
|
|||||||
**Context**: gates.sh hotfix c25a7ea (2026-11-17). LRN-284 named `1b.` label: parser drops it as prose, cursor `_CUR` still on previous criterion, stray CHECK/EXPECT overwrite its oracle → false MET. First plan: reject `^[0-9]` non-`N. text` lines. Advisor + scratch fixtures: indented ` 2.`, `- `, `**2.**` labels gave same false MET.
|
**Context**: gates.sh hotfix c25a7ea (2026-11-17). LRN-284 named `1b.` label: parser drops it as prose, cursor `_CUR` still on previous criterion, stray CHECK/EXPECT overwrite its oracle → false MET. First plan: reject `^[0-9]` non-`N. text` lines. Advisor + scratch fixtures: indented ` 2.`, `- `, `**2.**` labels gave same false MET.
|
||||||
**Pattern**: line parser with current-record cursor → close overwrite at sink: refuse second write of already-set field (`_set_attr` guard), not enumerate bad label shapes at source. Source-side rule only names the common shape (better error message).
|
**Pattern**: line parser with current-record cursor → close overwrite at sink: refuse second write of already-set field (`_set_attr` guard), not enumerate bad label shapes at source. Source-side rule only names the common shape (better error message).
|
||||||
**Apply**: any cursor parser (contract ledger, registry, config sections). Before fixing a reported bad input shape, fixture sibling shapes (indent, bullet, bold) against the same sink; scan existing data for repeated fields first so guard changes no past verdict.
|
**Apply**: any cursor parser (contract ledger, registry, config sections). Before fixing a reported bad input shape, fixture sibling shapes (indent, bullet, bold) against the same sink; scan existing data for repeated fields first so guard changes no past verdict.
|
||||||
|
|
||||||
|
## LRN-300 — Rule keyed on a gate verdict names the line its qualifier prints on (2026-11-18)
|
||||||
|
**Context**: advisor run B3 (2b7aeb8, 51f343f). feat/bugfix skip end-of-run advisor call when security PASS "(not DEGRADED)". security-auditor prints `SECURITY — VERDICT: PASS` on DEGRADED scan; DEGRADED only on `TOOL:` line (agents/security-auditor.md OUTPUT), while lib/verify-secure-loop.md teaches reading DEGRADED off VERDICT line → reader checks wrong line, wrong skip. 3 lenses + re-challenge missed it; opus STEP 6 caught it.
|
||||||
|
**Pattern**: rule keyed on gate verdict must name the line its qualifier prints on. Agent OUTPUT format = source of truth, not the doctrine paraphrasing it.
|
||||||
|
**Apply**: before writing a condition on an agent's verdict, grep that agent's OUTPUT block for where each qualifier prints; state the line at the site.
|
||||||
@@ -7,9 +7,11 @@ Done history before 2026-10-08 removed 2026-10-23 (git keeps it: `git log -p --
|
|||||||
- [x] Run A DONE 6ef3069, merged fc2d84d (docs 09277f5, audits c1a0c32, memory 78a6942) /feat feature/advisor-call-points: CLAUDE.global § Workflow + lib/effort-shift.md § Advisor + plan-challenger/verifier/security-auditor one-call rule (contract .claude/tasks/contracts/2026-11-17-advisor-call-points-1130.md)
|
- [x] Run A DONE 6ef3069, merged fc2d84d (docs 09277f5, audits c1a0c32, memory 78a6942) /feat feature/advisor-call-points: CLAUDE.global § Workflow + lib/effort-shift.md § Advisor + plan-challenger/verifier/security-auditor one-call rule (contract .claude/tasks/contracts/2026-11-17-advisor-call-points-1130.md)
|
||||||
- [x] Run B1 DONE 58a5273, merged eb1f594 (docs 47e5ee8, audits 9033b4a, memory d55f491) /feat feature/advisor-points-b1 (user 2026-11-17 "oui a, b et c"): (a) main-loop plan point in lib/challenge-plan.md (before first dispatch), (b) analyzer joins judgment agents (CLAUDE.global, effort-shift, agents/analyzer.md), (c) trigger "before recommending a change to the doctrine, the architecture or a public interface", stuck call lines in lib/verify-secure-loop.md (contract .claude/tasks/contracts/2026-11-17-advisor-points-b1-1500.md)
|
- [x] Run B1 DONE 58a5273, merged eb1f594 (docs 47e5ee8, audits 9033b4a, memory d55f491) /feat feature/advisor-points-b1 (user 2026-11-17 "oui a, b et c"): (a) main-loop plan point in lib/challenge-plan.md (before first dispatch), (b) analyzer joins judgment agents (CLAUDE.global, effort-shift, agents/analyzer.md), (c) trigger "before recommending a change to the doctrine, the architecture or a public interface", stuck call lines in lib/verify-secure-loop.md (contract .claude/tasks/contracts/2026-11-17-advisor-points-b1-1500.md)
|
||||||
- [x] Run B2 DONE f48343e + 24354d9 + 6022b9d, merged 6c4d24f (docs 5bc64f4, audits bfcf21a 0ceaa58, memory 9917ade) /ship-feature feature/advisor-points-b2 (user 2026-11-17): stuck line in the 6 gate skills; end-of-run call at each flow's own end step (feat, bugfix, ship-feature, init-project, a11y, guardrails, audit-delta + tour when a fix was applied, release-candidate STEP 4), lib/capitalize-commit.md untouched; verifier/security-auditor/plan-challenger advise only when dispatched; auditor raise upward only; plan-challenger protocol mirror; effort-shift item 3 + blank line (contract .claude/tasks/contracts/2026-11-17-advisor-points-b2-1634.md; BUGS-FOUND :109-111 fixed, B2 review residuals logged)
|
- [x] Run B2 DONE f48343e + 24354d9 + 6022b9d, merged 6c4d24f (docs 5bc64f4, audits bfcf21a 0ceaa58, memory 9917ade) /ship-feature feature/advisor-points-b2 (user 2026-11-17): stuck line in the 6 gate skills; end-of-run call at each flow's own end step (feat, bugfix, ship-feature, init-project, a11y, guardrails, audit-delta + tour when a fix was applied, release-candidate STEP 4), lib/capitalize-commit.md untouched; verifier/security-auditor/plan-challenger advise only when dispatched; auditor raise upward only; plan-challenger protocol mirror; effort-shift item 3 + blank line (contract .claude/tasks/contracts/2026-11-17-advisor-points-b2-1634.md; BUGS-FOUND :109-111 fixed, B2 review residuals logged)
|
||||||
- [ ] The 12 skills send their reflect route with the challenger dispatch, after the advisor call now (low; moved out of B2 by the user 2026-11-17)
|
- [x] DONE 2b7aeb8 (run B3, /ship-feature feature/advisor-points-b3): route line now "send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due" in the 12 callers. Was: The 12 skills send their reflect route with the challenger dispatch, after the advisor call now (low; moved out of B2 by the user 2026-11-17)
|
||||||
- [ ] Decide: feat/bugfix end-of-run advisor call has no skip (audit-delta/tour skip when no fix was applied); nominal /feat or /bugfix = 2 main-loop advisor calls (plan + end), ~0.6-1.4M uncached tokens late in a session; ship-feature STEP 6 opus review and the end call review the same branch back to back (B2 STEP 6 review, user decision)
|
- [x] DECIDED user 2026-11-18 "skip when gates clean" (strict), DONE 2b7aeb8 + 51f343f (run B3). Was: Decide: feat/bugfix end-of-run advisor call has no skip (audit-delta/tour skip when no fix was applied); nominal /feat or /bugfix = 2 main-loop advisor calls (plan + end), ~0.6-1.4M uncached tokens late in a session; ship-feature STEP 6 opus review and the end call review the same branch back to back (B2 STEP 6 review, user decision)
|
||||||
- [x] After B1 DONE (doc commit + BDR-150 status + LRN-296): README/USAGE/CHANGELOG say "before writing a skill's plan (/feat, /bugfix, /ship-feature)" and list 3 agents → doc-sync; BDR-150 status line
|
- [x] After B1 DONE (doc commit + BDR-150 status + LRN-296): README/USAGE/CHANGELOG say "before writing a skill's plan (/feat, /bugfix, /ship-feature)" and list 3 agents → doc-sync; BDR-150 status line
|
||||||
|
- [ ] loops-light lock on the feat/bugfix skip sentence ("each on its first attempt", "(not DEGRADED)"): B3 contract CHECKs are one-shot (robustness challenger, run B3)
|
||||||
|
- [ ] a11y:201, guardrails:278, ship-feature:325, init-project:361 end lines: restate item 3's merge-reuse clause ("reuses the last run's answer, or its skip, and names any code commit made after it"); item 3 loads only via the lib (B3 final review, low)
|
||||||
- [ ] Run C /feat: advisor usage section in /memory-feedback (main loop vs sub-agents, model served, input tokens; dedupe usage rows by message.id, model from the `advisor_message` iteration)
|
- [ ] Run C /feat: advisor usage section in /memory-feedback (main loop vs sub-agents, model served, input tokens; dedupe usage rows by message.id, model from the `advisor_message` iteration)
|
||||||
- [x] Stale citers after A: README/USAGE/CHANGELOG patched, BUGS-FOUND residual superseded + LOW logged, BDR-150 status, LRN-295 (LRN-294 kept: its lesson holds)
|
- [x] Stale citers after A: README/USAGE/CHANGELOG patched, BUGS-FOUND residual superseded + LOW logged, BDR-150 status, LRN-295 (LRN-294 kept: its lesson holds)
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,60 @@
|
|||||||
|
# CONTRACT — advisor-points-b3
|
||||||
|
- date: 2026-11-18 | flow: ship-feature | branch: feature/advisor-points-b3
|
||||||
|
- status: active
|
||||||
|
|
||||||
|
## REQUEST (verbatim — IMMUTABLE)
|
||||||
|
corrige les deux bugs mis dans le todos puis passe a C
|
||||||
|
|
||||||
|
Answers 2026-11-18 that scope this run: "Did 'les deux bugs' also mean TODO:10-11?" → "Yes, do 10-11 first". Route line wording → "First challenge call (Recommended)": "(route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due)". BUGS-FOUND :114 Advisor row → "Yes, same run (Recommended)". Flow → "/ship-feature (Recommended)". TODO:11 → "Skip when gates clean": feat/bugfix skip the end-of-run call when GATE 0, verifier and security passed first try and no stuck call ran; doctrine edit in effort-shift item 3 + 2 skills.
|
||||||
|
|
||||||
|
Skill args (/ship-feature): Advisor run B3 (TODO:10-11 + BUGS-FOUND :114 residual; user 2026-11-18). (1) The challenge route line in 12 skills (feat, bugfix, hotfix, ship-feature, init-project, audit-delta, code-clean, onboard, harden, pack-seo seo + geo, pack-web-validate web-validate) reads "(route: own level before the challenge; send it with the challenger dispatch)"; lib/challenge-plan.md now puts the main-loop advisor call (and a plan read) before the dispatch. User wording: "(route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due)". (2) Same 12 skills: each CHALLENGE SUMMARY template gains the `Advisor:` row lib/challenge-plan.md OUTPUT requires; BUGS-FOUND :114 residual → FIXED. (3) TODO:11 user decision "skip when gates clean": /feat and /bugfix skip the end-of-run advisor call when GATE 0, the verifier and security all passed on their first run and no stuck call ran; doctrine in lib/effort-shift.md § Advisor item 3 + skills/feat + skills/bugfix end lines; TODO:11 closed, BDR-150 status line. Method as B2: blocks in files + exact-once applier, simulated on a mktemp scratch copy with every contract CHECK before dispatch (LRN-296); markers and `§ Label` citations on one line followed by `)` or `;`; criteria plain `N.` labels (gates.sh now rejects others); full make test at the gates.sh default timeout; gates in order GATE 0 → verifier → security after CONFORME; at capitalize memory_pending first; docs CHANGELOG [Unreleased] Advisor doctrine bullet, README/USAGE only if they cite the changed lines.
|
||||||
|
|
||||||
|
## CLARIFICATIONS
|
||||||
|
Q: route line wording / A: user wording above [gated 2026-11-18]
|
||||||
|
Q: fold BUGS-FOUND :114 Advisor row into the run / A: yes [gated 2026-11-18]
|
||||||
|
Q: flow / A: /ship-feature [gated 2026-11-18]
|
||||||
|
Q: TODO:11 decision / A: skip when gates clean, feat and bugfix only [gated 2026-11-18]
|
||||||
|
Q: route wording vs a PLAN Read first / A: keep verbatim [gated 2026-11-18]
|
||||||
|
Q: Advisor row format / A: row with its three values inline; one-line summaries gain "/ advisor" [gated 2026-11-18]
|
||||||
|
Q: "gates clean" / A: strict: GATE 0 MET, verifier CONFORME, security PASS (not DEGRADED), each first attempt; anything else runs the call [gated 2026-11-18]
|
||||||
|
Q: add-ons / A: ADVISOR field in FEAT/BUGFIX COMPLETE; item 3 "end step" wording (BUGS-FOUND :118 wording part) [gated 2026-11-18]
|
||||||
|
Q: STEP 3 dispositions (plan "Dispositions shown at the STEP 3 gate": verdict out of view runs the call; all-manual GATE 0 MET counts; NEED-DECISION / deferred BLOCKER / REPORTED findings count as clean; a skip discharges its point and trigger; bugfix end route kept; reuse clause names later code commits) / A: approved as listed [gated 2026-11-18]
|
||||||
|
|
||||||
|
## ACCEPTANCE CRITERIA
|
||||||
|
1. No skill keeps the old route annotation "send it with the challenger dispatch". [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && n=$(git grep -c 'send it with the challenger dispatch' -- skills | wc -l); [ "$n" -eq 0 ] && echo OLD-ROUTE-GONE
|
||||||
|
EXPECT: OLD-ROUTE-GONE
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: OLD-ROUTE-GONE
|
||||||
|
2. Each of the 12 challenge callers carries the new route annotation exactly once, on its `mcp__model-router__route(phase=…)` line. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && n=0; for f in skills/feat/SKILL.md skills/bugfix/SKILL.md skills/hotfix/SKILL.md skills/ship-feature/SKILL.md skills/init-project/SKILL.md skills/audit-delta/SKILL.md skills/code-clean/SKILL.md skills/onboard/SKILL.md skills/harden/SKILL.md skills/pack-seo/skills/seo/SKILL.md skills/pack-seo/skills/geo/SKILL.md skills/pack-web-validate/skills/web-validate/SKILL.md; do c=$(grep -F 'mcp__model-router__route(phase=' "$f" | grep -cF '(route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).'); [ "$c" -eq 1 ] && n=$((n+1)); done; [ "$n" -eq 12 ] && echo ROUTE-12
|
||||||
|
EXPECT: ROUTE-12
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: ROUTE-12
|
||||||
|
3. In the 9 block-form CHALLENGE SUMMARY templates, the line right after `Lenses returned` is the `Advisor:` row, its noun equal to the noun of the block's own `BLOCKERs addressed` row. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && n=0; for f in skills/ship-feature/SKILL.md skills/init-project/SKILL.md skills/audit-delta/SKILL.md skills/code-clean/SKILL.md skills/onboard/SKILL.md skills/harden/SKILL.md skills/pack-seo/skills/seo/SKILL.md skills/pack-seo/skills/geo/SKILL.md skills/pack-web-validate/skills/web-validate/SKILL.md; do awk 'BEGIN{ok=0} /BLOCKERs addressed : <n>/{if (match($0,/named [a-z-]+ change/)) x=substr($0,RSTART+6,RLENGTH-13)} p{if (x!="" && index($0,"Advisor : <the " x " change it drove | called, no change | not called (absent | error | already called this run)>")) ok=1; p=0} /Lenses returned : correctness/{p=1} END{exit !ok}' "$f" && n=$((n+1)); done; [ "$n" -eq 9 ] && echo ROWS-9
|
||||||
|
EXPECT: ROWS-9
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: ROWS-9
|
||||||
|
4. feat, bugfix and hotfix name the advisor in their one-line CHALLENGE SUMMARY. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && n=0; for f in feat bugfix hotfix; do grep -qF 'lenses returned / advisor)' skills/$f/SKILL.md && grep -qF 'CHALLENGE SUMMARY' skills/$f/SKILL.md && n=$((n+1)); done; [ "$n" -eq 3 ] && echo SENTENCES-3
|
||||||
|
EXPECT: SENTENCES-3
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: SENTENCES-3
|
||||||
|
5. lib/effort-shift.md § Advisor item 3 keeps "never skipped for an earlier plan or stuck call" and names its two skips (audit-delta/tour with no fix; feat/bugfix on the strict rule, "(not DEGRADED)" and the verdict-out-of-view clause included); a skipped call discharges its point; feat/bugfix sit at their commit step; for the six gate flows a later merge proposal reuses the last run's answer or skip and names any later code commit (doc and memory commits excepted); "end step of feat" and "predates the newer commits" are gone. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && t=$(awk '/^3\. Before proposing a merge/{p=1} p&&/^$/{exit} p' lib/effort-shift.md | tr '\n' ' ' | tr -s ' '); for s in 'Wired at the commit step of feat and bugfix, at the end step of ship-feature' 'never skipped for an earlier plan or stuck call. Two skips only:' 'feat and bugfix when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt (any other verdict, a retry, a loop iteration or a verdict no longer in view runs the call)' '`skipped (gates clean on first pass)`' 'A skipped call discharges its point and the trigger it covers.' 'a later merge proposal reuses the last run' 'and names any code commit made after it (doc and memory commits excepted).'; do printf '%s' "$t" | grep -qF -- "$s" || exit 1; done; printf '%s' "$t" | grep -qF 'end step of feat' && exit 1; printf '%s' "$t" | grep -qF 'predates the newer commits' && exit 1; echo ITEM3-OK
|
||||||
|
EXPECT: ITEM3-OK
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: ITEM3-OK
|
||||||
|
6. skills/feat and skills/bugfix restate the skip condition ("(not DEGRADED)" and the verdict-out-of-view clause included) at their end-of-run line, before the COMPLETE summary, and the summary template carries the `ADVISOR` field with its three values; the old "as an `Advisor:` line" wording is gone. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && for f in skills/feat/SKILL.md skills/bugfix/SKILL.md; do t=$(tr '\n' ' ' < "$f" | tr -s ' '); for s in 'end-of-run advisor call (`lib/effort-shift.md` § Advisor), skipped when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt; any other verdict, a retry, a loop iteration or a verdict no longer in view runs the call.' '`ADVISOR` field, and a fix it drives goes back through the gates.' ': <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>'; do printf '%s' "$t" | grep -qF -- "$s" || exit 1; done; printf '%s' "$t" | grep -qF 'goes into the summary as an `Advisor:` line' && exit 1; a=$(grep -n '§ Advisor), skipped when' "$f" | cut -d: -f1); c=$(grep -nE '^ *(FEAT|BUGFIX) COMPLETE$' "$f" | tail -1 | cut -d: -f1); d=$(grep -n 'ADVISOR .*: <one-line answer' "$f" | cut -d: -f1); [ -n "$a" ] && [ -n "$c" ] && [ -n "$d" ] && [ "$a" -lt "$c" ] && [ "$c" -lt "$d" ] || exit 1; done; echo FEAT-BUGFIX-SKIP
|
||||||
|
EXPECT: FEAT-BUGFIX-SKIP
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: FEAT-BUGFIX-SKIP
|
||||||
|
7. CHANGELOG [Unreleased] "Advisor doctrine" bullet names the new callers, the summary row and route, the feat/bugfix skip (not DEGRADED), their commit step, the `ADVISOR` field and the reuse clause that names later code commits; "It sits at the end step of feat, bugfix" and "the answer goes into the reply, summary or finish proposal" are gone. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && u=$(awk '/^## \[Unreleased\]/{p=1;next} /^## \[/{p=0} p' CHANGELOG.md); for s in 'skills/{feat,bugfix,hotfix,ship-feature,init-project,onboard,code-clean,harden,a11y,guardrails,audit-delta,tour,release-candidate}/SKILL.md' 'the CHALLENGE SUMMARY of every caller gains an `Advisor:` row' 'with the first tool call of `lib/challenge-plan.md`' 'feat and bugfix skip it when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt' 'It sits at the commit step of feat and bugfix and at the end step of ship-feature' 'and a later merge proposal reuses the last run' 'names any code commit made after it (doc and memory commits excepted).' 'or into the feat/bugfix summary'; do printf '%s' "$u" | grep -qF -- "$s" || exit 1; done; printf '%s' "$u" | grep -qF 'It sits at the end step of feat, bugfix' && exit 1; printf '%s' "$u" | grep -qF 'the answer goes into the reply, summary or finish proposal' && exit 1; echo CHANGELOG-OK
|
||||||
|
EXPECT: CHANGELOG-OK
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: CHANGELOG-OK
|
||||||
|
8. Full make test green. [gated 2026-11-18]
|
||||||
|
CHECK: cd /home/bchanot/Documents/claude && PATH=$HOME/.bun/bin:$PATH make test </dev/null 2>&1 | tail -1
|
||||||
|
EXPECT: all suites green
|
||||||
|
EVIDENCE: MET exit=0 marker-found :: all suites green
|
||||||
|
9. No wording changed outside the planned edits; every marker and `§ Label` citation stays on one line followed by `)` or `;`; new prose lines ≤ 80 columns, except by name the 12 route lines and the template rows (`Advisor` row, `ADVISOR` field), which run as wide as the rows beside them, and the CHANGELOG bullet (one unwrapped line, like every bullet in that file) (manual). [gated 2026-11-18]
|
||||||
|
|
||||||
|
## FILE SCOPE
|
||||||
|
skills/feat/SKILL.md, skills/bugfix/SKILL.md, skills/hotfix/SKILL.md, skills/ship-feature/SKILL.md, skills/init-project/SKILL.md, skills/audit-delta/SKILL.md, skills/code-clean/SKILL.md, skills/onboard/SKILL.md, skills/harden/SKILL.md, skills/pack-seo/skills/seo/SKILL.md, skills/pack-seo/skills/geo/SKILL.md, skills/pack-web-validate/skills/web-validate/SKILL.md, lib/effort-shift.md, CHANGELOG.md
|
||||||
|
(bookkeeping: .claude/tasks/TODO.md, .claude/audits/BUGS-FOUND.md, .claude/memory via memory.sh, this contract; transient plan under docs/superpowers/plans/)
|
||||||
+1
-1
@@ -20,7 +20,7 @@ The BDR-125 context queue is delivered: phases 0, 0b, 4a, 1, 5, 2 and 4b-4d ship
|
|||||||
- **memory commit chokepoint**: `lib/memory.sh check --staged`, run by `lib/memory-commit.sh commit` before every memory commit (rc 6, registry unstaged), also refuses a staged v2 registry whose new `## ` entry does not carry the next free ID: the highest ID seen at any heading level, fenced or not, in HEAD and above the entry in the staged file, plus one, the same reading `add` uses. stderr: `memory: <file>:<line>: new entry <ID> is not the next free ID <PREFIX>-NNN`. A committed ID is never renamed: fix the uncommitted heading and every uncommitted mention of its ID (the `superseded by` line from `add --supersedes`, the journal line), or drop the new entry and re-add it with `memory.sh add`. Skipped when the registry is absent from HEAD, HEAD is v1 (an `upgrade` commit), HEAD has an open code fence, or HEAD has no well-formed `## ` entry. Tests: `lib/tests/memory.test.sh`.
|
- **memory commit chokepoint**: `lib/memory.sh check --staged`, run by `lib/memory-commit.sh commit` before every memory commit (rc 6, registry unstaged), also refuses a staged v2 registry whose new `## ` entry does not carry the next free ID: the highest ID seen at any heading level, fenced or not, in HEAD and above the entry in the staged file, plus one, the same reading `add` uses. stderr: `memory: <file>:<line>: new entry <ID> is not the next free ID <PREFIX>-NNN`. A committed ID is never renamed: fix the uncommitted heading and every uncommitted mention of its ID (the `superseded by` line from `add --supersedes`, the journal line), or drop the new entry and re-add it with `memory.sh add`. Skipped when the registry is absent from HEAD, HEAD is v1 (an `upgrade` commit), HEAD has an open code fence, or HEAD has no well-formed `## ` entry. Tests: `lib/tests/memory.test.sh`.
|
||||||
- **model-router write guard fails closed**: when the guard's own check throws or times out, a main-loop Edit, Write or NotebookEdit of a code file outside a skill run is held with `model-router: the write guard failed (<kind>), so this write is held. Enter /hotfix, /feat, /bugfix or /ship-feature, or re-enter the skill you were running, then make this edit.` One log line per session: `model-router: write guard failed (<kind>): main-loop code writes are held until a skill runs`. Sub-agents, skill runs (typed, model-declared phase, typed `/route`) and `.md` / `.txt` files still pass; an error raised by a downstream tool is replayed as before. The guard used to let the write through on its own failure. Tests: `mods/model-router/hooks/register.test.ts` (GUARD: a failing guard …).
|
- **model-router write guard fails closed**: when the guard's own check throws or times out, a main-loop Edit, Write or NotebookEdit of a code file outside a skill run is held with `model-router: the write guard failed (<kind>), so this write is held. Enter /hotfix, /feat, /bugfix or /ship-feature, or re-enter the skill you were running, then make this edit.` One log line per session: `model-router: write guard failed (<kind>): main-loop code writes are held until a skill runs`. Sub-agents, skill runs (typed, model-declared phase, typed `/route`) and `.md` / `.txt` files still pass; an error raised by a downstream tool is replayed as before. The guard used to let the write through on its own failure. Tests: `mods/model-router/hooks/register.test.ts` (GUARD: a failing guard …).
|
||||||
- **model-router: Fable leaves auto-routing**: the `best` and `big` tiers default to opus then sonnet (were fable>opus>sonnet and opus>fable>sonnet), so Opus is the strongest model the router routes to and Fable is the advisor (`advisorModel` in settings.json). Fable stays in the model table and first in the fallback rank, so a hand pick of fable ranks above opus. The first-use Change dialog offers opus, sonnet and haiku; the bare `/model` dialog still offers fable, labelled `fable (custom)`. The ask before Fable only fires when a machine override puts fable at the head of `best`: otherwise `/route ask-tier on` answers `(inert: best is not headed by fable)` and `/route show` prints `ask-tier: inert`. An agent on a best or big row keeps its opus frontmatter when Opus is down. The `tiers.best does not lead the fallback chain` log is gone; `routing.json` is unchanged. Tests: `mods/model-router/hooks/register.test.ts`; `lib/tests/effort-routing.test.sh` floors every row on its tier's head. The `/client-handover` skill-runner children and the `lib/model-gate.md` dispatch doctrine pin `model: "opus"` instead of `"fable"` (BDR-150: Fable is the advisor, never a dispatch target), and the model gate lets a sub-agent pass when the route answer says its model is `fixed at spawn`. Tests: `lib/tests/model-routing.test.sh` refuses any fable dispatch pin under agents/, skills/ and lib/; `lib/tests/effort-routing.test.sh` checks the 7 opus/effort="high" client-handover dispatches.
|
- **model-router: Fable leaves auto-routing**: the `best` and `big` tiers default to opus then sonnet (were fable>opus>sonnet and opus>fable>sonnet), so Opus is the strongest model the router routes to and Fable is the advisor (`advisorModel` in settings.json). Fable stays in the model table and first in the fallback rank, so a hand pick of fable ranks above opus. The first-use Change dialog offers opus, sonnet and haiku; the bare `/model` dialog still offers fable, labelled `fable (custom)`. The ask before Fable only fires when a machine override puts fable at the head of `best`: otherwise `/route ask-tier on` answers `(inert: best is not headed by fable)` and `/route show` prints `ask-tier: inert`. An agent on a best or big row keeps its opus frontmatter when Opus is down. The `tiers.best does not lead the fallback chain` log is gone; `routing.json` is unchanged. Tests: `mods/model-router/hooks/register.test.ts`; `lib/tests/effort-routing.test.sh` floors every row on its tier's head. The `/client-handover` skill-runner children and the `lib/model-gate.md` dispatch doctrine pin `model: "opus"` instead of `"fable"` (BDR-150: Fable is the advisor, never a dispatch target), and the model gate lets a sub-agent pass when the route answer says its model is `fixed at spawn`. Tests: `lib/tests/model-routing.test.sh` refuses any fable dispatch pin under agents/, skills/ and lib/; `lib/tests/effort-routing.test.sh` checks the 7 opus/effort="high" client-handover dispatches.
|
||||||
- **Advisor doctrine (`CLAUDE.global.md` § Workflow, `lib/effort-shift.md` § Advisor, `lib/challenge-plan.md`, `lib/verify-secure-loop.md`, `agents/plan-challenger.md`, `agents/verifier.md`, `agents/security-auditor.md`, `agents/analyzer.md`, `skills/{feat,bugfix,ship-feature,init-project,a11y,guardrails,audit-delta,tour,release-candidate}/SKILL.md`)**: when a stronger model is needed (an approach to settle before building, a stuck problem, a long task before calling it done, a change to recommend to the doctrine, the architecture or a public interface), the main loop calls the advisor tool (Fable, settings `advisorModel`, set by `/advisor`), at least on the written plan before the plan challengers are dispatched (`lib/challenge-plan.md`, every skill that challenges a plan, once per skill run, not before a re-challenge: an answer that lands a real flaw revises the plan file as plain plan text with no advisor attribution, the advice never enters a challenger brief, and the CHALLENGE SUMMARY gains an `Advisor:` row; the ORCHESTRATOR PROTOCOL in `agents/plan-challenger.md` mirrors this advisor-first step and the row), once per verify-secure run at the first gate loop to fail twice (floor, conformity, security, or a second structural failure, counting main-loop calls since GATE 0 first ran; the advice stays in the main loop and never enters an executor brief; every cap or escalation STOP carries it and says whether it predates the last iteration), and before proposing a merge (`gitflow finish`) or calling a long task done: one end-of-run call per skill run, never skipped for an earlier plan or stuck call. It sits at the end step of feat, bugfix, ship-feature, init-project, a11y and guardrails: the main loop first prints the run's diff stat, the answer goes into the reply, summary or finish proposal as an `Advisor:` line, a fix it drives goes back through the gates, and a later proposal reuses the answer and says it predates the newer commits. It also sits at the end of audit-delta and tour when the run applied a fix (tour: main loop only, never a runner), and at release-candidate STEP 4 before the go / hold ask. In those three the answer is reported only: a fix it calls for waits for a new run, and at the release gate it makes hold the recommended answer. The same six gate skills carry a `Stuck:` line that points at the verify-secure rule. Inside a skill run these points cover the triggers: no second call for the same recommendation. `plan-challenger`, `verifier`, `security-auditor` and `analyzer` may call it only when dispatched as a sub-agent, at most once per dispatch, late, before their verdict or report; the analyzer's output rests on the code it read, never on the advice alone, and advice proposing a design or a fix counts only where the brief asks for one. For the three gates advice only adds: the verifier may go back to a contract criterion and tags a resulting NOT-MET `(advisor-prompted)`, never clearing a gap on advice; the challenger never drops or lowers a finding on advice alone; the security-auditor tags an added finding `advisor:<STEP 3 class>` at that class's severity (REPORTED LOW when it matches no class), and tags a raised one `<rule>+advisor` only when the class's severity is higher than the finding's own; a raise that does not apply, or matches no class, changes nothing (no tag, no PROOF count). Its PROOF ends with `; advisor <n> added/raised`. Executors and every other sub-agent do not call it, even when the tool is listed. Advisor absent or erroring → proceed as written; advice waives no gate, cap or guard and, at a loop cap, feeds the STOP diagnosis. Fable on main comes only from a hand pick, a typed `/route model=fable`, a phase naming `model: fable` or a machine override that puts fable in a tier (BDR-150). Prose that still named Fable as the `audit` row head or a skill-runner pin (`agents/plan-challenger.md`, `lib/challenge-plan.md`, `lib/effort-shift.md`, `skills/tour/SKILL.md`) now says opus.
|
- **Advisor doctrine (`CLAUDE.global.md` § Workflow, `lib/effort-shift.md` § Advisor, `lib/challenge-plan.md`, `lib/verify-secure-loop.md`, `agents/plan-challenger.md`, `agents/verifier.md`, `agents/security-auditor.md`, `agents/analyzer.md`, `skills/{feat,bugfix,hotfix,ship-feature,init-project,onboard,code-clean,harden,a11y,guardrails,audit-delta,tour,release-candidate}/SKILL.md`, `skills/pack-seo/skills/{seo,geo}/SKILL.md`, `skills/pack-web-validate/skills/web-validate/SKILL.md`)**: when a stronger model is needed (an approach to settle before building, a stuck problem, a long task before calling it done, a change to recommend to the doctrine, the architecture or a public interface), the main loop calls the advisor tool (Fable, settings `advisorModel`, set by `/advisor`), at least on the written plan before the plan challengers are dispatched (`lib/challenge-plan.md`, every skill that challenges a plan, once per skill run, not before a re-challenge: an answer that lands a real flaw revises the plan file as plain plan text with no advisor attribution, the advice never enters a challenger brief, and the CHALLENGE SUMMARY of every caller gains an `Advisor:` row (the plan change it drove, `called, no change` or `not called (absent | error | already called this run)`), each caller sending its route before the challenge with the first tool call of `lib/challenge-plan.md`; the ORCHESTRATOR PROTOCOL in `agents/plan-challenger.md` mirrors this advisor-first step and the row), once per verify-secure run at the first gate loop to fail twice (floor, conformity, security, or a second structural failure, counting main-loop calls since GATE 0 first ran; the advice stays in the main loop and never enters an executor brief; every cap or escalation STOP carries it and says whether it predates the last iteration), and before proposing a merge (`gitflow finish`) or calling a long task done: one end-of-run call per skill run, never skipped for an earlier plan or stuck call, except that audit-delta and tour skip it when the run applied no fix and feat and bugfix skip it when GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED), each on its first attempt, their summary's `ADVISOR` field then reading `skipped (gates clean on first pass)`. It sits at the commit step of feat and bugfix and at the end step of ship-feature, init-project, a11y and guardrails: the main loop first prints the run's diff stat, the answer goes into the reply or finish proposal as an `Advisor:` line, or into the feat/bugfix summary's `ADVISOR` field, a fix it drives goes back through the gates, and a later merge proposal reuses the last run's answer, or its skip, and names any code commit made after it (doc and memory commits excepted). It also sits at the end of audit-delta and tour when the run applied a fix (tour: main loop only, never a runner), and at release-candidate STEP 4 before the go / hold ask. In those three the answer is reported only: a fix it calls for waits for a new run, and at the release gate it makes hold the recommended answer. The same six gate skills carry a `Stuck:` line that points at the verify-secure rule. Inside a skill run these points cover the triggers: no second call for the same recommendation. `plan-challenger`, `verifier`, `security-auditor` and `analyzer` may call it only when dispatched as a sub-agent, at most once per dispatch, late, before their verdict or report; the analyzer's output rests on the code it read, never on the advice alone, and advice proposing a design or a fix counts only where the brief asks for one. For the three gates advice only adds: the verifier may go back to a contract criterion and tags a resulting NOT-MET `(advisor-prompted)`, never clearing a gap on advice; the challenger never drops or lowers a finding on advice alone; the security-auditor tags an added finding `advisor:<STEP 3 class>` at that class's severity (REPORTED LOW when it matches no class), and tags a raised one `<rule>+advisor` only when the class's severity is higher than the finding's own; a raise that does not apply, or matches no class, changes nothing (no tag, no PROOF count). Its PROOF ends with `; advisor <n> added/raised`. Executors and every other sub-agent do not call it, even when the tool is listed. Advisor absent or erroring → proceed as written; advice waives no gate, cap or guard and, at a loop cap, feeds the STOP diagnosis. Fable on main comes only from a hand pick, a typed `/route model=fable`, a phase naming `model: fable` or a machine override that puts fable in a tier (BDR-150). Prose that still named Fable as the `audit` row head or a skill-runner pin (`agents/plan-challenger.md`, `lib/challenge-plan.md`, `lib/effort-shift.md`, `skills/tour/SKILL.md`) now says opus.
|
||||||
- **gates.sh timeout**: the default per-CHECK timeout (`GATES_TIMEOUT`) is 600 s, up from 120 s. A full `make test` (about 135 s) went NOT-MET on the timeout alone. A run lasts the sum of its CHECKs: a caller with a shorter limit (a foreground tool call stops at 600 s) runs it in the background, and a killed run writes nothing back, so the floor stays PENDING.
|
- **gates.sh timeout**: the default per-CHECK timeout (`GATES_TIMEOUT`) is 600 s, up from 120 s. A full `make test` (about 135 s) went NOT-MET on the timeout alone. A run lasts the sum of its CHECKs: a caller with a shorter limit (a foreground tool call stops at 600 s) runs it in the background, and a killed run writes nothing back, so the floor stays PENDING.
|
||||||
|
|
||||||
### Removed
|
### Removed
|
||||||
|
|||||||
@@ -79,7 +79,11 @@ plan challengers see it (`lib/challenge-plan.md`, once per skill run; the
|
|||||||
CHALLENGE SUMMARY's `Advisor:` row records what it changed), once per
|
CHALLENGE SUMMARY's `Advisor:` row records what it changed), once per
|
||||||
verify-secure run at the first gate loop to fail twice (the advice stays in
|
verify-secure run at the first gate loop to fail twice (the advice stays in
|
||||||
the main loop, never in an executor brief; a cap or escalation STOP carries
|
the main loop, never in an executor brief; a cap or escalation STOP carries
|
||||||
it), before proposing a merge or calling a long task done, and before
|
it), before proposing a merge or calling a long task done (two skips:
|
||||||
|
`/feat` and `/bugfix` when GATE 0 said MET, the verifier CONFORME and
|
||||||
|
security PASS, not DEGRADED, each on its first attempt, their summary's
|
||||||
|
`ADVISOR` field then reading `skipped (gates clean on first pass)`;
|
||||||
|
`/audit-delta` and `/tour` when the run applied no fix), and before
|
||||||
recommending a change to the doctrine, the architecture or a public interface.
|
recommending a change to the doctrine, the architecture or a public interface.
|
||||||
plan-challenger, verifier, security-auditor and `analyzer` may call it once
|
plan-challenger, verifier, security-auditor and `analyzer` may call it once
|
||||||
when dispatched as a sub-agent, before their verdict or report: advice can
|
when dispatched as a sub-agent, before their verdict or report: advice can
|
||||||
|
|||||||
@@ -200,7 +200,7 @@ l'outil `mcp__model-router__route` (`lib/effort-shift.md`). Les skills
|
|||||||
externes vendorés (pile design, superpowers, agent-skills, skills scroll
|
externes vendorés (pile design, superpowers, agent-skills, skills scroll
|
||||||
MengTo, 21st) ont aussi leur ligne.
|
MengTo, 21st) ont aussi leur ligne.
|
||||||
|
|
||||||
Taper un skill qui a une ligne route la boucle principale dessus. Une ligne du tier best (plan, reflect, orchestrate, escalate ; `audit` est une ligne d'agent, jamais tapée) tient d'un tour à l'autre pendant tout le run, jusqu'à `/route clear`, `/route off`, un `/model` tapé ou choisi dans le sélecteur, ou un skill d'un autre tier tapé. Un `/model <nom>` tapé, ou un choix dans le sélecteur `/model`, avec un modèle de la table demande sa portée (Échap ne change rien). Le changement du sélecteur est d'abord retenu (le moteur affiche qu'un hook l'a bloqué), puis la question vient ; un choix fait pendant qu'un autre dialogue est ouvert est refusé (`answer the open dialog first`) : This project écrit l'id complet dans `model` du `.claude/settings.local.json` du projet (créé s'il manque, à garder dans le `.gitignore`) et pose une route de modèle tenue ; This conversation pose la route seule, sans rien écrire ; Everywhere lance le `/model` natif (`settings.json` utilisateur, tous les projets). Default dans le sélecteur, sans argument, avec un nom inconnu, en headless (`-p`) ou mod coupé, le `/model` natif passe sans question. Un modèle choisi dans ce dialogue change toujours : ni plafond de relecture à froid, ni `mainUpgrade` ni `mainModelSwitch`. S'il est en panne, la boucle principale reste où elle est jusqu'à son retour. Un changement natif (ligne Model de `/config` comprise) ou `/clear` l'abandonne ; un `/route model=` tapé garde les plafonds. La ligne Model de `/config` écrit toujours le `settings.json` utilisateur, et un dialogue jamais répondu n'a pas de délai. Pour relancer un tour bloqué : `ultrathink` dans le prompt (plancher d'effort du tour) ou `/route effort=max` (tient jusqu'à `/route clear`). Le `/effort` intégré n'a pas d'effet dans un run : les lignes et les routes passent devant. Les règles de mots-clés du prompt (`plan`, `design`, `architecture`… prennent l'effort de plan ; `pourquoi`, `review`, `audit`… celui de reflect), `ultrathink` et un lancement d'agent par la boucle principale (route `orchestrate` dérivée, tenue jusqu'à la fin de ses agents en arrière-plan) ne fixent que le niveau d'effort du tour, jamais le modèle : ils ne font jamais monter la boucle principale au-dessus du modèle de la session, et un run best tenu garde son modèle. Fable n'arrive sur la boucle principale que par un choix à la main (`/model`, sélecteur), un `/route model=fable` tapé, une phase qui nomme `model: fable` ou une config machine qui le place dans un tier : aucun tier ni aucune phase livrés ne le contiennent. Fable sert de conseiller (outil advisor, `advisorModel` dans settings.json, réglé par `/advisor`) : la boucle principale l'appelle au moins sur le plan écrit, avant que les challengers du plan le voient (`lib/challenge-plan.md`, une fois par run de skill ; la ligne `Advisor:` du CHALLENGE SUMMARY dit ce qu'il a changé), une fois par run verify-secure à la première boucle de porte qui échoue deux fois (le conseil reste dans la boucle principale, jamais dans le brief d'un exécutant ; un STOP au plafond ou en escalade le reprend), avant de proposer un merge ou de déclarer finie une longue tâche, et avant de recommander un changement de la doctrine, de l'architecture ou d'une interface publique ; plan-challenger, verifier, security-auditor et `analyzer` peuvent l'appeler une fois, seulement quand ils sont lancés comme sous-agents, avant leur verdict ou leur rapport : un conseil peut ajouter un constat ou relever sa sévérité, jamais le retirer, l'abaisser ni l'effacer ; les autres sous-agents ne l'appellent pas, même quand l'outil est listé. Conseiller absent ou en erreur : on continue ; un conseil ne lève aucune porte, aucun plafond ni aucune garde. Un prompt tapé sans règle, skill ni route en cours passe par un classifieur (un appel au petit modèle, 3 secondes au plus) : le tour prend la route de la phase devinée : son niveau d'effort, et son modèle, jamais au-dessus de celui de la session. Une devinette `coding` ou `bookkeeping` fait descendre la boucle principale vers un modèle moins cher quand `mainModelSwitch` est actif (par défaut) et que la relecture à froid tient sous `downgradeMaxTokens` (120000 tokens par défaut). Cette relecture compte aussi le prompt qui vient d'être envoyé (un token pour 3 caractères), et un document joint bloque la descente pour cette étape. Le cache compte comme chaud pendant le TTL du moteur (`cache_ttl`, 5 ou 60 minutes), 60 minutes par défaut. `/route classify off` ou `"classify": false` dans la config machine le coupe, et un `/effort` tapé entre deux tours annule la devinette pour ce tour seulement. Avant d'envoyer la boucle principale sur un modèle, celui vers lequel elle se déplace comme celui qu'elle garde (le modèle de la session compris), le mod l'essaie une fois (un appel minimal, 8 secondes au plus) : sans réponse, ce modèle est marqué en panne (raison `probe`) et la décision eLine truncated
|
Taper un skill qui a une ligne route la boucle principale dessus. Une ligne du tier best (plan, reflect, orchestrate, escalate ; `audit` est une ligne d'agent, jamais tapée) tient d'un tour à l'autre pendant tout le run, jusqu'à `/route clear`, `/route off`, un `/model` tapé ou choisi dans le sélecteur, ou un skill d'un autre tier tapé. Un `/model <nom>` tapé, ou un choix dans le sélecteur `/model`, avec un modèle de la table demande sa portée (Échap ne change rien). Le changement du sélecteur est d'abord retenu (le moteur affiche qu'un hook l'a bloqué), puis la question vient ; un choix fait pendant qu'un autre dialogue est ouvert est refusé (`answer the open dialog first`) : This project écrit l'id complet dans `model` du `.claude/settings.local.json` du projet (créé s'il manque, à garder dans le `.gitignore`) et pose une route de modèle tenue ; This conversation pose la route seule, sans rien écrire ; Everywhere lance le `/model` natif (`settings.json` utilisateur, tous les projets). Default dans le sélecteur, sans argument, avec un nom inconnu, en headless (`-p`) ou mod coupé, le `/model` natif passe sans question. Un modèle choisi dans ce dialogue change toujours : ni plafond de relecture à froid, ni `mainUpgrade` ni `mainModelSwitch`. S'il est en panne, la boucle principale reste où elle est jusqu'à son retour. Un changement natif (ligne Model de `/config` comprise) ou `/clear` l'abandonne ; un `/route model=` tapé garde les plafonds. La ligne Model de `/config` écrit toujours le `settings.json` utilisateur, et un dialogue jamais répondu n'a pas de délai. Pour relancer un tour bloqué : `ultrathink` dans le prompt (plancher d'effort du tour) ou `/route effort=max` (tient jusqu'à `/route clear`). Le `/effort` intégré n'a pas d'effet dans un run : les lignes et les routes passent devant. Les règles de mots-clés du prompt (`plan`, `design`, `architecture`… prennent l'effort de plan ; `pourquoi`, `review`, `audit`… celui de reflect), `ultrathink` et un lancement d'agent par la boucle principale (route `orchestrate` dérivée, tenue jusqu'à la fin de ses agents en arrière-plan) ne fixent que le niveau d'effort du tour, jamais le modèle : ils ne font jamais monter la boucle principale au-dessus du modèle de la session, et un run best tenu garde son modèle. Fable n'arrive sur la boucle principale que par un choix à la main (`/model`, sélecteur), un `/route model=fable` tapé, une phase qui nomme `model: fable` ou une config machine qui le place dans un tier : aucun tier ni aucune phase livrés ne le contiennent. Fable sert de conseiller (outil advisor, `advisorModel` dans settings.json, réglé par `/advisor`) : la boucle principale l'appelle au moins sur le plan écrit, avant que les challengers du plan le voient (`lib/challenge-plan.md`, une fois par run de skill ; la ligne `Advisor:` du CHALLENGE SUMMARY dit ce qu'il a changé), une fois par run verify-secure à la première boucle de porte qui échoue deux fois (le conseil reste dans la boucle principale, jamais dans le brief d'un exécutant ; un STOP au plafond ou en escalade le reprend), avant de proposer un merge ou de déclarer finie une longue tâche (deux exceptions : `/feat` et `/bugfix` le sautent quand GATE 0 a dit MET, le verifier CONFORME et la sécurité PASS, pas DEGRADED, chacun au premier essai, et leur champ `ADVISOR` affiche alors `skipped (gates clean on first pass)` ; `/audit-delta` et `/tour` le sautent quand le run n'a appliqué aucun fix), et avant de recommander un changement de la doctrine, de l'architecture ou d'une interface publique ; plan-challenger, verifier, security-auditor et `analyzer` peuvent l'appeler une fois, seulement quand ils sont lancés comme sous-agents, avant leur verdict ou leur rapport : un conseil peut ajouter un constat ou relever sa sévérité, jamais le retirer, l'abaisser ni l'effacer ; les autres sous-agents ne l'appellent pas, même quand l'outil est listé. Conseiller absent ou en erreur : on continue ; un conseil ne lève aucune porte, aucun plafond ni aucune garde. Un prompt tapé sans règle, skill ni route en cours passe par un classifieur (un appel au petit modèle, 3 secondes au plus) : le tour prend la route de la phase devinée : son niveau d'effort, et son modèle, jamais au-dessus de celui de la session. Une devinette `coding` ou `bookkeeping` fait descendre la boucle principale vers un modèle moins cher quand `mainModelSwitch` est actif (par défaut) et que la relecture à froid tient sous `downgradeMaxTokens` (120000 tokens par défaut). Cette relecture compte aussi le prompt qui vient d'être envoyé (un token pour 3 caractères), et un document joint bloque la descente pour cette étape. Le cache compte comme chaud pendant le TTL du moteur (`cache_ttl`, 5 ou 60 minutes), 60 minutes par défaut. `/route classify off` ou `"classify": false` dans la config machine le coupe, et un `/effort` tapé entre deux tours annule la devinette pour ce toLine truncated
|
||||||
|
|
||||||
Garde d'écriture : un Edit, Write ou NotebookEdit d'un fichier de code par la boucle principale est redirigé avec « model-router: code is written inside a skill run… » tant qu'aucun skill n'a tourné sur la boucle principale dans la session (tapé ou chargé par le modèle ; un skill refusé ou inconnu ne compte pas), qu'aucune phase n'a été déclarée ce tour, et qu'aucun `/route` tapé ne tient. Chemins libres : `.md`, `.txt`, le `.claude/` du projet sauf `worktrees/`, et `docs/`. Les sous-agents écrivent librement. Si la vérification du garde échoue elle-même (exception ou délai dépassé), l'écriture est retenue au lieu de passer, avec « model-router: the write guard failed (<kind>), so this write is held… », journalisé une fois par session ; les sous-agents, un skill en cours, une phase déclarée ou un `/route` tapé, et les fichiers `.md` / `.txt` passent toujours, et une erreur levée par l'outil lui-même est transmise telle quelle. `/route clear`, `/route off` et `/clear` réarment le garde ; `/route off` le coupe aussi, et `"enabled": false` dans `~/.claude/model-router.json` coupe le routeur et le garde. Un choix à la main avec `/model` ne l'ouvre pas, et un rechargement de `register.ts` le remet à zéro.
|
Garde d'écriture : un Edit, Write ou NotebookEdit d'un fichier de code par la boucle principale est redirigé avec « model-router: code is written inside a skill run… » tant qu'aucun skill n'a tourné sur la boucle principale dans la session (tapé ou chargé par le modèle ; un skill refusé ou inconnu ne compte pas), qu'aucune phase n'a été déclarée ce tour, et qu'aucun `/route` tapé ne tient. Chemins libres : `.md`, `.txt`, le `.claude/` du projet sauf `worktrees/`, et `docs/`. Les sous-agents écrivent librement. Si la vérification du garde échoue elle-même (exception ou délai dépassé), l'écriture est retenue au lieu de passer, avec « model-router: the write guard failed (<kind>), so this write is held… », journalisé une fois par session ; les sous-agents, un skill en cours, une phase déclarée ou un `/route` tapé, et les fichiers `.md` / `.txt` passent toujours, et une erreur levée par l'outil lui-même est transmise telle quelle. `/route clear`, `/route off` et `/clear` réarment le garde ; `/route off` le coupe aussi, et `"enabled": false` dans `~/.claude/model-router.json` coupe le routeur et le garde. Un choix à la main avec `/model` ne l'ouvre pas, et un rechargement de `register.ts` le remet à zéro.
|
||||||
|
|
||||||
|
|||||||
+17
-9
@@ -115,15 +115,23 @@ triggers in CLAUDE.global.md § Workflow):
|
|||||||
(a contract micro-gate, an early escalation, the STOP diagnosis) and
|
(a contract micro-gate, an early escalation, the STOP diagnosis) and
|
||||||
never enters an executor brief.
|
never enters an executor brief.
|
||||||
3. Before proposing a merge (`gitflow finish`) or calling a long task
|
3. Before proposing a merge (`gitflow finish`) or calling a long task
|
||||||
done. Wired at the end step of feat, bugfix, ship-feature,
|
done. Wired at the commit step of feat and bugfix, at the end step
|
||||||
init-project, a11y, guardrails, audit-delta and tour, and at the
|
of ship-feature, init-project, a11y, guardrails, audit-delta and
|
||||||
release gate of release-candidate: one end-of-run call per skill
|
tour, and at the release gate of release-candidate: one end-of-run
|
||||||
run, never skipped for an earlier plan or stuck call; audit-delta
|
call per skill run, never skipped for an earlier plan or stuck call.
|
||||||
and tour skip it when the run applied no fix. In the six flows that
|
Two skips only: audit-delta and tour when the run applied no fix;
|
||||||
run the gates, the main loop first prints the run's diff stat, a fix
|
feat and bugfix when GATE 0 said MET, the verifier CONFORME and
|
||||||
the answer drives goes back through the gates, and a later proposal
|
security PASS (not DEGRADED), each on its first attempt (any other
|
||||||
reuses the answer and says it predates the newer commits. Elsewhere
|
verdict, a retry, a loop iteration or a verdict no longer in view
|
||||||
the answer is reported only and a fix it calls for is a new run.
|
runs the call), their summary then reading
|
||||||
|
`skipped (gates clean on first pass)`. A skipped call discharges
|
||||||
|
its point and the trigger it covers. In the six flows that run the
|
||||||
|
gates (feat, bugfix, ship-feature, init-project, a11y, guardrails),
|
||||||
|
the main loop first prints the run's diff stat, a fix the answer
|
||||||
|
drives goes back through the gates, and a later merge proposal
|
||||||
|
reuses the last run's answer, or its skip, and names any code commit
|
||||||
|
made after it (doc and memory commits excepted). Elsewhere the
|
||||||
|
answer is reported only and a fix it calls for is a new run.
|
||||||
|
|
||||||
Inside a skill run, the points above also cover the triggers of
|
Inside a skill run, the points above also cover the triggers of
|
||||||
CLAUDE.global.md § Workflow; no second call for the same recommendation.
|
CLAUDE.global.md § Workflow; no second call for the same recommendation.
|
||||||
|
|||||||
@@ -170,7 +170,7 @@ Then show the user the same compact table inline.
|
|||||||
|
|
||||||
### 3b-bis. CHALLENGE THE PROPOSALS (before the gate)
|
### 3b-bis. CHALLENGE THE PROPOSALS (before the gate)
|
||||||
|
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
This axis' findings + proposed fixes are a proposal set worth attacking before
|
This axis' findings + proposed fixes are a proposal set worth attacking before
|
||||||
the human gate. Persist THIS axis' finding list (not the whole append-only
|
the human gate. Persist THIS axis' finding list (not the whole append-only
|
||||||
report) to `.claude/tasks/plans/<date>-<axis>-<HHMM>.md`, then run
|
report) to `.claude/tasks/plans/<date>-<axis>-<HHMM>.md`, then run
|
||||||
@@ -192,6 +192,7 @@ CHALLENGE SUMMARY (3b-bis — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named finding-set change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named finding-set change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the finding-set change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
```
|
```
|
||||||
|
|
||||||
- "Fix what you find" said **in the invocation** does NOT skip this gate:
|
- "Fix what you find" said **in the invocation** does NOT skip this gate:
|
||||||
|
|||||||
+12
-6
@@ -127,7 +127,7 @@ RISK: <low/medium — what could go wrong>
|
|||||||
fast-path is not exempt: a 1-line fix with a visible choice still asks.
|
fast-path is not exempt: a 1-line fix with a visible choice still asks.
|
||||||
|
|
||||||
## STEP 3b — CHALLENGE THE FIX PLAN (before the contract)
|
## STEP 3b — CHALLENGE THE FIX PLAN (before the contract)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Unless the fix is the trivial 1-2 line case STEP 3 already fast-paths, the
|
Unless the fix is the trivial 1-2 line case STEP 3 already fast-paths, the
|
||||||
DIAGNOSIS + FIX PLAN is a reflection worth attacking before it hardens into a
|
DIAGNOSIS + FIX PLAN is a reflection worth attacking before it hardens into a
|
||||||
contract. Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
contract. Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
@@ -137,8 +137,8 @@ dispositions. Three blind challengers attack it (correctness = is the root cause
|
|||||||
right; robustness = blast radius / regressions; simplicity = is the fix minimal);
|
right; robustness = blast radius / regressions; simplicity = is the fix minimal);
|
||||||
RE-THINK every aspect a BLOCKER lands, re-challenge once if the plan materially
|
RE-THINK every aspect a BLOCKER lands, re-challenge once if the plan materially
|
||||||
changed. STEP 3.5 writes the contract from the REVISED plan. Print a CHALLENGE SUMMARY
|
changed. STEP 3.5 writes the contract from the REVISED plan. Print a CHALLENGE SUMMARY
|
||||||
(BLOCKERs addressed / deferred / lenses returned), folding any deferred BLOCKER into
|
(BLOCKERs addressed / deferred / lenses returned / advisor), folding any
|
||||||
the STEP 3 approval gate.
|
deferred BLOCKER into the STEP 3 approval gate.
|
||||||
|
|
||||||
## STEP 3.5 — CONTRACT
|
## STEP 3.5 — CONTRACT
|
||||||
|
|
||||||
@@ -233,9 +233,14 @@ Parse the `BUGFIX-EXEC REPORT`:
|
|||||||
two sentences of body).
|
two sentences of body).
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: end-of-run review).
|
`mcp__model-router__route(phase="reflect")` first (route: end-of-run review).
|
||||||
Before the summary, the main loop prints the run's diff stat, then makes its
|
Before the summary, the main loop prints the run's diff stat, then makes its
|
||||||
end-of-run advisor call (`lib/effort-shift.md` § Advisor); its answer
|
end-of-run advisor call (`lib/effort-shift.md` § Advisor), skipped when
|
||||||
goes into the summary as an `Advisor:` line, and a fix it drives goes
|
GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED),
|
||||||
back through the gates.
|
each on its first attempt; any other verdict, a retry, a loop iteration or
|
||||||
|
a verdict no longer in view runs the call. DEGRADED shows on the
|
||||||
|
auditor's `TOOL:` line, beside a PASS. A skip also settles the global
|
||||||
|
"long task before calling it done" trigger. The answer, or the skip,
|
||||||
|
goes into the summary's `ADVISOR` field, and a fix it drives goes back
|
||||||
|
through the gates.
|
||||||
4. Print summary:
|
4. Print summary:
|
||||||
```
|
```
|
||||||
BUGFIX COMPLETE
|
BUGFIX COMPLETE
|
||||||
@@ -244,6 +249,7 @@ Parse the `BUGFIX-EXEC REPORT`:
|
|||||||
FILE(S) : <changed files>
|
FILE(S) : <changed files>
|
||||||
TEST(S) : <added/updated tests, or "none — verified manually">
|
TEST(S) : <added/updated tests, or "none — verified manually">
|
||||||
REGRESSION : <checked areas>
|
REGRESSION : <checked areas>
|
||||||
|
ADVISOR : <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>
|
||||||
```
|
```
|
||||||
|
|
||||||
## STEP 7 — DOC SYNC (automatic)
|
## STEP 7 — DOC SYNC (automatic)
|
||||||
|
|||||||
@@ -122,7 +122,7 @@ TOTALS: <N blocking, N warn, N info>
|
|||||||
If no issues found: report clean state and stop.
|
If no issues found: report clean state and stop.
|
||||||
|
|
||||||
## STEP 3b — CHALLENGE THE SCOPE (before approval)
|
## STEP 3b — CHALLENGE THE SCOPE (before approval)
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
The STEP 3 report is the proposed cleanup scope — worth attacking before the
|
The STEP 3 report is the proposed cleanup scope — worth attacking before the
|
||||||
human approves it. It is still inline, so FIRST persist it to
|
human approves it. It is still inline, so FIRST persist it to
|
||||||
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (STEP 3 report format, one item
|
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (STEP 3 report format, one item
|
||||||
@@ -144,6 +144,7 @@ CHALLENGE SUMMARY (STEP 3b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named scope change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named scope change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the scope change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
|
||||||
AskUserQuestion:
|
AskUserQuestion:
|
||||||
Approve which items for execution? (all / <item numbers> / clarify <item>)
|
Approve which items for execution? (all / <item numbers> / clarify <item>)
|
||||||
|
|||||||
+12
-6
@@ -124,7 +124,7 @@ in the contract's CLARIFICATIONS `[gated]` and in the plan. A choice that
|
|||||||
surfaces only during execution comes back as `NEED-DECISION` (STEP 3).
|
surfaces only during execution comes back as `NEED-DECISION` (STEP 3).
|
||||||
|
|
||||||
## STEP 1b — CHALLENGE THE PLAN (before branching)
|
## STEP 1b — CHALLENGE THE PLAN (before branching)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
The STEP 1 plan is a reflection worth attacking before a branch is spent on it.
|
The STEP 1 plan is a reflection worth attacking before a branch is spent on it.
|
||||||
Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = that file, `KIND` = `build-plan`,
|
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = that file, `KIND` = `build-plan`,
|
||||||
@@ -132,8 +132,8 @@ Persist it to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
|||||||
Three blind challengers attack it; RE-THINK every aspect a BLOCKER lands (a named
|
Three blind challengers attack it; RE-THINK every aspect a BLOCKER lands (a named
|
||||||
plan change, or `[deferred]`), re-challenge once if the plan materially changed. The
|
plan change, or `[deferred]`), re-challenge once if the plan materially changed. The
|
||||||
STEP 3 executor receives the REVISED plan. Before dispatch, print a CHALLENGE SUMMARY
|
STEP 3 executor receives the REVISED plan. Before dispatch, print a CHALLENGE SUMMARY
|
||||||
(BLOCKERs addressed / deferred / lenses returned), surfacing any deferred BLOCKER in
|
(BLOCKERs addressed / deferred / lenses returned / advisor), surfacing any
|
||||||
the STEP 1 pass B batch.
|
deferred BLOCKER in the STEP 1 pass B batch.
|
||||||
|
|
||||||
## STEP 2 — BRANCH
|
## STEP 2 — BRANCH
|
||||||
|
|
||||||
@@ -207,9 +207,14 @@ propose/apply executor).
|
|||||||
Then `mcp__model-router__route(phase="reflect")` (route: nested commit-change loaded at apply; reload feat's level).
|
Then `mcp__model-router__route(phase="reflect")` (route: nested commit-change loaded at apply; reload feat's level).
|
||||||
|
|
||||||
Before the summary, the main loop prints the run's diff stat, then makes its
|
Before the summary, the main loop prints the run's diff stat, then makes its
|
||||||
end-of-run advisor call (`lib/effort-shift.md` § Advisor); its answer
|
end-of-run advisor call (`lib/effort-shift.md` § Advisor), skipped when
|
||||||
goes into the summary as an `Advisor:` line, and a fix it drives goes
|
GATE 0 said MET, the verifier CONFORME and security PASS (not DEGRADED),
|
||||||
back through the gates.
|
each on its first attempt; any other verdict, a retry, a loop iteration or
|
||||||
|
a verdict no longer in view runs the call. DEGRADED shows on the
|
||||||
|
auditor's `TOOL:` line, beside a PASS. A skip also settles the global
|
||||||
|
"long task before calling it done" trigger. The answer, or the skip,
|
||||||
|
goes into the summary's `ADVISOR` field, and a fix it drives goes back
|
||||||
|
through the gates.
|
||||||
|
|
||||||
Print summary:
|
Print summary:
|
||||||
```
|
```
|
||||||
@@ -218,6 +223,7 @@ FEATURE : <name>
|
|||||||
FILE(S) : <created/modified files>
|
FILE(S) : <created/modified files>
|
||||||
TEST(S) : <added tests>
|
TEST(S) : <added tests>
|
||||||
VERIFIED : <what was checked>
|
VERIFIED : <what was checked>
|
||||||
|
ADVISOR : <one-line answer | skipped (gates clean on first pass) | not called (absent | error)>
|
||||||
```
|
```
|
||||||
|
|
||||||
## STEP 6 — DOC SYNC (automatic)
|
## STEP 6 — DOC SYNC (automatic)
|
||||||
|
|||||||
@@ -522,7 +522,7 @@ Extract the score and critical-alert count from `.claude/audits/HARDEN.md` for t
|
|||||||
---
|
---
|
||||||
|
|
||||||
## STEP 2b — CHALLENGE THE FIX BUNDLE (MODE=fix only, advisory)
|
## STEP 2b — CHALLENGE THE FIX BUNDLE (MODE=fix only, advisory)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Skip if MODE=audit (no bundle exists). Else, before the STEP 3 gate, harden the bundle:
|
Skip if MODE=audit (no bundle exists). Else, before the STEP 3 gate, harden the bundle:
|
||||||
extract the `## 8. Fix bundle` section from HARDEN.md to
|
extract the `## 8. Fix bundle` section from HARDEN.md to
|
||||||
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (a clean, blind-judgeable artifact), then run
|
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (a clean, blind-judgeable artifact), then run
|
||||||
@@ -557,6 +557,7 @@ If MODE=fix and `.claude/audits/HARDEN.md` ends with `READY TO APPLY — awaitin
|
|||||||
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the bundle change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
|
||||||
Options :
|
Options :
|
||||||
A) Apply all
|
A) Apply all
|
||||||
|
|||||||
@@ -94,7 +94,7 @@ point. Run it ONLY when the settled fix touches control flow or behaviour — an
|
|||||||
off-by-one, a wrong operator/variable, a behaviour-changing config value, or a
|
off-by-one, a wrong operator/variable, a behaviour-changing config value, or a
|
||||||
missing import that alters execution. In doubt → it is probably a `/bugfix`.
|
missing import that alters execution. In doubt → it is probably a `/bugfix`.
|
||||||
|
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
For a logic fix: persist the STEP 1 located fix (root cause + the exact edit) to
|
For a logic fix: persist the STEP 1 located fix (root cause + the exact edit) to
|
||||||
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = that file, `KIND` =
|
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = that file, `KIND` =
|
||||||
@@ -102,8 +102,8 @@ For a logic fix: persist the STEP 1 located fix (root cause + the exact edit) to
|
|||||||
contract's acceptance criteria. Three blind challengers attack the fix; the main
|
contract's acceptance criteria. Three blind challengers attack the fix; the main
|
||||||
loop RE-THINKS any aspect a BLOCKER lands (a named change to the fix, or
|
loop RE-THINKS any aspect a BLOCKER lands (a named change to the fix, or
|
||||||
`[deferred]`) and re-challenges once if it materially changed. Print a
|
`[deferred]`) and re-challenges once if it materially changed. Print a
|
||||||
CHALLENGE SUMMARY (BLOCKERs addressed / deferred / lenses returned). A BLOCKER
|
CHALLENGE SUMMARY (BLOCKERs addressed / deferred / lenses returned / advisor).
|
||||||
that shows the fix is wrong or incomplete means this was never
|
A BLOCKER that shows the fix is wrong or incomplete means this was never
|
||||||
a hotfix — escalate to `/bugfix` (its STEP 3b runs the same phase under the full
|
a hotfix — escalate to `/bugfix` (its STEP 3b runs the same phase under the full
|
||||||
verify+secure loop).
|
verify+secure loop).
|
||||||
|
|
||||||
|
|||||||
@@ -192,7 +192,7 @@ Invoke `writing-plans` (vendored superpowers skill) with BRIEF + skeleton.
|
|||||||
Granular tasks (2-5 min each), exact file paths, TDD: tests before code.
|
Granular tasks (2-5 min each), exact file paths, TDD: tests before code.
|
||||||
|
|
||||||
## STEP 6b — CHALLENGE THE PLAN (before the gate)
|
## STEP 6b — CHALLENGE THE PLAN (before the gate)
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Before the human sees the implementation plan, harden it. Run
|
Before the human sees the implementation plan, harden it. Run
|
||||||
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = the plan STEP 6 wrote under
|
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` = the plan STEP 6 wrote under
|
||||||
`docs/superpowers/plans/`, `KIND` = `build-plan`, `SCOPE` = the skeleton + task file
|
`docs/superpowers/plans/`, `KIND` = `build-plan`, `SCOPE` = the skeleton + task file
|
||||||
@@ -213,6 +213,7 @@ CHALLENGE SUMMARY (STEP 6b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named plan change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named plan change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the plan change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
Approve and start? (yes / request changes)
|
Approve and start? (yes / request changes)
|
||||||
```
|
```
|
||||||
Changes → back to STEP 6. Approved → continue.
|
Changes → back to STEP 6. Approved → continue.
|
||||||
|
|||||||
@@ -917,7 +917,7 @@ Vérifier que les 4 fichiers `.claude/audits/ONBOARD_REPORT.md`, `.claude/audits
|
|||||||
---
|
---
|
||||||
|
|
||||||
## STEP 7b — CHALLENGE THE PROPOSALS (before the human gate)
|
## STEP 7b — CHALLENGE THE PROPOSALS (before the human gate)
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
The 4 audit files are on disk; `AUDIT_PROPOSALS.md` is the artifact worth
|
The 4 audit files are on disk; `AUDIT_PROPOSALS.md` is the artifact worth
|
||||||
attacking before the human spends a gate on it. Run
|
attacking before the human spends a gate on it. Run
|
||||||
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` =
|
`$HOME/.claude/lib/challenge-plan.md` with `PLAN` =
|
||||||
@@ -961,6 +961,7 @@ CHALLENGE SUMMARY (STEP 7b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named proposals change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named proposals change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the proposals change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
|
||||||
Prochaine étape : générer .claude/tasks/TODO.md depuis .claude/audits/AUDIT_PROPOSALS.md approuvé.
|
Prochaine étape : générer .claude/tasks/TODO.md depuis .claude/audits/AUDIT_PROPOSALS.md approuvé.
|
||||||
|
|
||||||
|
|||||||
@@ -86,7 +86,7 @@ your bundle."
|
|||||||
```
|
```
|
||||||
|
|
||||||
## STEP 1b — CHALLENGE THE FIX BUNDLE (advisory, before apply)
|
## STEP 1b — CHALLENGE THE FIX BUNDLE (advisory, before apply)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
The analyzer returned a `## FIX BUNDLE` — worth attacking before any edit lands.
|
The analyzer returned a `## FIX BUNDLE` — worth attacking before any edit lands.
|
||||||
**Skip if intervention mode = conservative** (nothing is applied). Else persist the
|
**Skip if intervention mode = conservative** (nothing is applied). Else persist the
|
||||||
bundle verbatim to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
bundle verbatim to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
@@ -138,6 +138,7 @@ CHALLENGE SUMMARY (STEP 1b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the bundle change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
Approve all / select (ids) / skip all?
|
Approve all / select (ids) / skip all?
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -511,7 +511,7 @@ the reports."
|
|||||||
```
|
```
|
||||||
|
|
||||||
## STEP 1b — CHALLENGE THE FIX BUNDLE (advisory, before apply)
|
## STEP 1b — CHALLENGE THE FIX BUNDLE (advisory, before apply)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Both envelopes now carry a `## FIX BUNDLE` — worth attacking before any edit lands.
|
Both envelopes now carry a `## FIX BUNDLE` — worth attacking before any edit lands.
|
||||||
**Skip if intervention mode = conservative** (nothing is applied). Else persist both
|
**Skip if intervention mode = conservative** (nothing is applied). Else persist both
|
||||||
bundles (seo + geo, verbatim) to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
bundles (seo + geo, verbatim) to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md`, then run
|
||||||
@@ -583,6 +583,7 @@ CHALLENGE SUMMARY (STEP 1b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the bundle change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
Approve all / select (ids) / skip all?
|
Approve all / select (ids) / skip all?
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -256,7 +256,7 @@ grep -c '^### \[Critique\]' .claude/audits/VALIDATE.md
|
|||||||
---
|
---
|
||||||
|
|
||||||
## STEP 2b — CHALLENGE THE FIX BUNDLE (MODE=fix only, advisory)
|
## STEP 2b — CHALLENGE THE FIX BUNDLE (MODE=fix only, advisory)
|
||||||
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="reflect")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Skip if MODE=audit (no bundle exists). Else, before the STEP 3 gate, harden the bundle:
|
Skip if MODE=audit (no bundle exists). Else, before the STEP 3 gate, harden the bundle:
|
||||||
extract the `## 5. Fix bundle` section from VALIDATE.md to
|
extract the `## 5. Fix bundle` section from VALIDATE.md to
|
||||||
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (a clean, blind-judgeable artifact), then run
|
`.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (a clean, blind-judgeable artifact), then run
|
||||||
@@ -296,6 +296,7 @@ CHALLENGE SUMMARY (STEP 2b — 3 lenses) :
|
|||||||
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named bundle change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the bundle change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
|
|
||||||
Options :
|
Options :
|
||||||
A) Apply all
|
A) Apply all
|
||||||
|
|||||||
@@ -133,7 +133,7 @@ request nor the STEP 1 brainstorm settled (check the contract's CLARIFICATIONS
|
|||||||
first) → one batch before STEP 2b; answers append to the contract `[gated]`.
|
first) → one batch before STEP 2b; answers append to the contract `[gated]`.
|
||||||
|
|
||||||
## STEP 2b — CHALLENGE THE PLAN (adversarial, before the gate)
|
## STEP 2b — CHALLENGE THE PLAN (adversarial, before the gate)
|
||||||
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the challenger dispatch).
|
`mcp__model-router__route(phase="plan")` first (route: own level before the challenge; send it with the first tool call of lib/challenge-plan.md, the advisor call when one is due).
|
||||||
Before the human sees the plan, harden it. Run `$HOME/.claude/lib/challenge-plan.md`:
|
Before the human sees the plan, harden it. Run `$HOME/.claude/lib/challenge-plan.md`:
|
||||||
- `PLAN` = the plan STEP 2 wrote under `docs/superpowers/plans/`
|
- `PLAN` = the plan STEP 2 wrote under `docs/superpowers/plans/`
|
||||||
- `KIND` = `build-plan`
|
- `KIND` = `build-plan`
|
||||||
@@ -163,6 +163,7 @@ CHALLENGE SUMMARY (STEP 2b — 3 lenses):
|
|||||||
BLOCKERs addressed : <n> — <finding → the named plan change that closes it>
|
BLOCKERs addressed : <n> — <finding → the named plan change that closes it>
|
||||||
Deferred (human-ack): <list | none>
|
Deferred (human-ack): <list | none>
|
||||||
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
Lenses returned : correctness / robustness / simplicity (NAME any that failed to return)
|
||||||
|
Advisor : <the plan change it drove | called, no change | not called (absent | error | already called this run)>
|
||||||
Approve and execute? (yes / request changes)
|
Approve and execute? (yes / request changes)
|
||||||
```
|
```
|
||||||
This block EXPOSES each in-force item with the plan's CLAIMED disposition, for human
|
This block EXPOSES each in-force item with the plan's CLAIMED disposition, for human
|
||||||
|
|||||||
Reference in new issue
Block a user