chore(memory): BDR-137 + LRN-258..261 + BLK-041 + EVAL-057 — ship-feature phase 4b memory capture

This commit is contained in:
bchanot committed 2026-11-04 15:26:01 +01:00
1 parent 181bcfc7f2
commit 08e36dcc0b
5 files changed
+44

No files matched your search

+8
View File
@@ -1487,3 +1487,11 @@ Supersedes [[BDR-030]].
- **Alternatives rejected**: `$.ui.ask` mod gate, phrase-list gate (challenges 2026-10-25); 16 routing rows for the guard (run slot drops mid-run, would open first-use + ask-tier dialogs); `git -C * merge *` (asks on any commit text with " merge ", sub-agent ask refused); quoted finish rule (matcher ignores quote in pattern); `gitflow_finish*`, `bash -s*` (bench RAN); `Bash(/*)` (kills `*/rtk` twins); per-spawn guard.
- **Residuals**: Bash write forms outside guard; latch reset on register.ts reload; sourced `gitflow_finish`, `git -C <dir> merge`; `rtk read -n .env` flag-first (security MEDIUM, TODO); code-limits TMPDIR state dir ownership unchecked; silent in this repo (code-origin foreign).
- **Gates**: plan r1 correctness FATAL(8) robustness FATAL(5) → r2 → confirmation CONCERNS(4) → r3; user interactive ask check; SDD 11 tasks; final opus review With fixes → fix wave; GATE 0 ABANDONED(2) user-accepted; verifier ECARTS(6) → ECARTS(2) human-gated; security PASS (1 MEDIUM, 3 LOW). Refs [[BDR-125]], [[BDR-068]], [[BDR-123]], [[BLK-018]], [[LRN-256]], [[LRN-257]].
## BDR-137 — Phase 4b memory capture mod: error-shaped Bash failures redacted into a per-project store, 4-gram index per call, one note per milestone, memory_pending (2026-11-04)
- **Context**: BDR-125 phase 4b, `feature/memory-capture` (f1d4f9d..HEAD), contract `.claude/tasks/contracts/2026-11-03-memory-capture-0100.md`, spec `docs/superpowers/specs/2026-11-03-memory-capture-design.md`, plan r3, spike `.claude/tasks/plans/2026-11-03-memory-capture-spike/REPORT.md`. Capture = weak link: 5/7 real errors of 2026-10-23 no entry.
- **Decision**: mod `mods/memory` (`memory@skills-dir`). (1) Failure = Bash `isError` text `Exit code N`; distinctive line = last line after rtk-trailer strip, must hold a letter AND an error word (`ERRORISH`, answer 2-amended after 83 % measured noise); permission/guard/tool_use texts never captured; sub-agent failures marked. (2) Redact BEFORE store: `KEY=value` (TOKEN|API_KEY|SECRET|PASSWORD|PASSWD, digits ok, quote-aware), 7 guardrails shapes, JWT first, Bearer, URL creds, `-u`/`--password`/`-b`(curl)/`--cookie`, `Authorization: Basic|Bearer|token`, vendor prefixes (sk-ant-, sk-proj-, github_pat_, glpat-, AIza, npm_), `--token|--api-key|--secret`, API-key/cookie headers, JSON/YAML password|token|secret|api[_-]?key keys, 40-hex URL user (answers 6-amended, 6-bis). (3) Store `$.store` key `p:<root>` → 3 sessions × 50 failures, 2 KiB/entry, milestones 20, red 10, 1 MiB sweep at session creation, one closure write chain. (4) Index per call from BLK/LRN backticked spans ≥ 12 (cap 300), word 4-grams, all-placeholder grams skipped (4-amended), superseded excluded (lexical reader, `shortcut:`), first ID wins. (5) Milestones main loop only: feat|fix commit (`-m` and heredoc forms), `gitflow.sh finish` ≠ `finish chore`, `make test` red→green; one `memory: <kind> <label> — n new failure mode(s)` note at next composer prompt, `st.pending` in closure, never per turn, never Stop, never sub-agent. (6) Tool `memory_pending` deferred (`ToolSearch` once), served `mcp__memory__memory_pending`, answer header / `index:` / milestones / NEW / known / earlier sessions, 20 000-char cap; consumers capitalize (`**Captured first.**`), close (alias), feat, bugfix, ship-feature, hotfix (NEW current-session non-sub-agent only), commit-change (both commit-changer dispatches, `MEMCAP_EOF_<random>` quoted heredoc body only); init-project excluded (7-amended). Off switch `~/.claude/memory.json` `{"enabled": false}` read lazily per session; unreadable or non-boolean → on + one log line.
- **Why**: engine facts (spike): refusals come back `isError` with the reason in text, no `deny` field; `$.store` per plugin, machine-wide, 4 MiB; no `$.state`; `-p` prompts origin `sdk` (note proven interactive only). Noise on the shipped rule 83 % (NOISE.md), filter keeps every useful sample, 81 → 27 captures.
- **Alternatives rejected**: classic hooks (no store, no tool); gitleaks as redaction engine (rules compiled in, allowlist ignored); per-session store (lost at /clear); index cache (stale registries); option B no sub-agent capture (loses reviewer findings); option C ship as is (70 % noise per call).
- **Residuals**: cross-process writes last-writer-wins; non-Bash failures; lexical superseded reader; 40-hex Gitea tokens kept (SHA-shaped); `user:p@ss@host` partial; `key: value` pair rule over-redacts prose (`token: expected`); session root moves with /cd or a worktree; bare finish on a chore branch counts; common-phrase 4-gram collisions (every ENOENT → known LRN-056 here) → 4c.
- **Gates**: plan r1 correctness FATAL(9) → r2, confirmation CONCERNS(5) → r3; SDD Tasks 1-6 + 8 (sonnet, 7 fix rounds), 7 and 9 controller; headless proof PASS; final opus review Approved with fixes (2 Important, 13 minors, 2 rounds); verifier ECARTS(3) → ECARTS(1) (interactive /clear half, user); security PASS ×3 (coverage rounds). 36+ commits.