forked from bchanot/claude
chore(tasks): phase 2 GATE 0 evidence (criterion 11 abandoned with reason, 16 proposed), TODO phase 2 shipped + residuals + hand-over
This commit is contained in:
1 parent
c3a6977aa3
commit
005bfe185d
2 files changed
+20
-11
No files matched your search
@@ -55,30 +55,37 @@ STEP 3 gate `[gated 2026-11-02]` (user: "oui aux trois, le prompt s'affiche, lan
|
||||
8. `make test` all suites green, shellcheck clean, mods suite green (`claude plugin test`); settings.json changes on the branch limited to `permissions.ask/deny`, `autoMode`, `hooks.PostToolUse` (no UI write, no `model`).
|
||||
CHECK: cd /home/bchanot/Documents/claude && t=$(make test 2>&1) && printf '%s\n' "$t" | grep -q 'all suites green' && shellcheck ./*.sh hooks/*.sh lib/*.sh && echo GREEN
|
||||
EXPECT: GREEN
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: GREEN
|
||||
9. Proof recorded (plan, journal): the routing bench L3 prompt enters a skill in a clone under the guard; the long-brief replay; `/close` ritual finishes after one click (user-run, interactive); guard off = today.
|
||||
10. TODO: phase 2 item ticked with what shipped; folded items (docker mount spellings, P41) closed or re-queued with the measured fact; T42 dead-entry drop handed to the user.
|
||||
|
||||
11. `[gated 2026-11-02]` Bench: `.claude/tasks/plans/2026-11-02-phase2-bench/` holds run.sh, bench.sh, cases.tsv, results.tsv (permissionMode column, every kept row `auto`), rtk.tsv, approved.txt and phase2.jq; a rule is in approved.txt only when every row naming it hit its want and one of them expects ASKED/DENIED; M3q (quoted finish form) ASKED.
|
||||
CHECK: cd /home/bchanot/Documents/claude/.claude/tasks/plans/2026-11-02-phase2-bench && [ -s approved.txt ] && grep -qF 'Bash(bash "*gitflow.sh" finish*)' approved.txt && awk -F'\t' '$2=="M3q"' results.tsv | tail -1 | grep -q 'ASKED' && echo BENCH-OK
|
||||
EXPECT: BENCH-OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: NOT-MET exit=1 (nonzero) ::
|
||||
12. `[gated 2026-11-02]` Guard: register.test.ts holds the GUARD tests of plan Task 3 + R3 (redirect before any skill, free paths, `~/.claude` and worktrees are code, sub-agent free, latch across a typed apply skill and a model-loaded unrowed skill, sub-agent Skill call does not latch, route-tool phase for one turn, typed /route, /route clear and /route off→on re-arm, /model hand pick does not open, /clear re-arms, `/../` paths are code); the mods suite is green.
|
||||
CHECK: cd /home/bchanot/Documents/claude && [ "$(/usr/bin/grep -c "^test('GUARD:\|^ test(\`GUARD:" mods/model-router/hooks/register.test.ts)" -ge 14 ] && a=$(make test suite=lib/tests/mods.test.sh 2>&1) && printf '%s\n' "$a" | grep -q 'all suites green' && echo GUARD-OK
|
||||
EXPECT: GUARD-OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: GUARD-OK
|
||||
13. `[gated 2026-11-02]` Hooks: the rtk suite holds T11-T13 and the pin matches; the code-limits suite passes 14 checks; both hooks shellcheck clean and ≤ 80 columns.
|
||||
CHECK: cd /home/bchanot/Documents/claude && (cd hooks && sha256sum -c .rtk-hook.sha256 >/dev/null) && a=$(make test suite=lib/tests/rtk-rewrite.test.sh 2>&1) && printf '%s\n' "$a" | grep -q 'all suites green' && b=$(make test suite=lib/tests/code-limits.test.sh 2>&1) && printf '%s\n' "$b" | grep -q 'PASS=14 FAIL=0' && shellcheck hooks/rtk-rewrite.sh hooks/code-limits.sh && [ "$(awk 'length($0) > 80' hooks/code-limits.sh | wc -l)" = 0 ] && echo HOOKS-OK
|
||||
EXPECT: HOOKS-OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: HOOKS-OK
|
||||
14. `[gated 2026-11-02]` Settings: every approved rule and every rtk read twin is present (push-guard T62, T63 green), no old entry left any permissions or autoMode list (set check against develop), `hooks.PostToolUse` registers code-limits, the branch diff of settings.json carries no `theme`, `model` or `switchModelsOnFlag` change.
|
||||
CHECK: cd /home/bchanot/Documents/claude && a=$(make test suite=lib/tests/push-guard.test.sh 2>&1) && printf '%s\n' "$a" | grep -q 'all suites green' && [ "$(jq -n --slurpfile o <(git show develop:settings.json) --slurpfile n <(git show HEAD:settings.json) '[["permissions","allow"],["permissions","ask"],["permissions","deny"],["autoMode","allow"],["autoMode","soft_deny"],["autoMode","hard_deny"]] | map(. as $p | ($o[0] | getpath($p)) - ($n[0] | getpath($p))) | add | length')" = 0 ] && git show HEAD:settings.json | jq -e '.hooks.PostToolUse[] | select(.hooks[0].command == "bash ~/.claude/hooks/code-limits.sh")' >/dev/null && ! git diff develop..HEAD -- settings.json | grep -qE '^[-+] *"(theme|model|switchModelsOnFlag)"' && echo SETTINGS-OK
|
||||
EXPECT: SETTINGS-OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: SETTINGS-OK
|
||||
15. `[gated 2026-11-02]` Release and capitalize: no `SPAN: finish` or `finish+tag` left in skills, agents, lib, README.md, USAGE.md; release-candidate STEP 5 runs `gitflow.sh finish` and `git tag -a` in the main loop; capitalize 5C and STEP 6 name the declined-prompt outcome.
|
||||
CHECK: cd /home/bchanot/Documents/claude && ! /usr/bin/grep -rqn 'SPAN: finish\|finish+tag' skills agents lib README.md USAGE.md && /usr/bin/grep -q 'git tag -a v<X.Y.Z> main' skills/release-candidate/SKILL.md && /usr/bin/grep -qi 'declined' skills/capitalize/SKILL.md && echo RELEASE-OK
|
||||
EXPECT: RELEASE-OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: RELEASE-OK
|
||||
|
||||
16. (PROPOSED 2026-11-02 by the controller, pending the user; replaces 11) Bench: the directory holds run.sh, bench.sh, cases.tsv, results.tsv (permissionMode column, every row `auto`), rtk.tsv, approved.txt, phase2.jq; approved.txt holds `Bash(bash *gitflow.sh finish*)`; the quoted call-site form `bash "$HOME/…/gitflow.sh" finish` is ASKED under it, isolated (M3x) and with the live settings (L6).
|
||||
CHECK: cd /home/bchanot/Documents/claude/.claude/tasks/plans/2026-11-02-phase2-bench && for f in run.sh bench.sh cases.tsv results.tsv rtk.tsv approved.txt phase2.jq; do [ -s "$f" ] || exit 1; done && grep -qF 'Bash(bash *gitflow.sh finish*)' approved.txt && awk -F'\t' '$2=="M3x"' results.tsv | tail -1 | grep -q 'ASKED' && awk -F'\t' '$2=="L6"' results.tsv | tail -1 | grep -q 'ASKED' && ! awk -F'\t' '$2 ~ /^[A-Z][0-9]/ && $6 != "" && $6 != "auto"' results.tsv | grep -q . && echo BENCH-OK
|
||||
EXPECT: BENCH-OK
|
||||
EVIDENCE: MET exit=0 marker-found :: BENCH-OK
|
||||
|
||||
ABANDON: 11 the M3q clause is impossible: the permission matcher does not match a literal quote inside a pattern (M3q `Bash(bash "*gitflow.sh" finish*)` RAN, M6q RAN), so that rule cannot be approved; the clause's purpose (the quoted finish form every skill types is asked) is met by `Bash(bash *gitflow.sh finish*)` (M3x ASKED isolated, L6 ASKED live); handoff: criterion 16 proposed, the user accepts or rejects it at the merge gate.
|
||||
|
||||
## FILE SCOPE (final, STEP 3 `[gated 2026-11-02]`)
|
||||
- settings.json (`permissions.ask`, `permissions.deny`, `autoMode.hard_deny/soft_deny`, `hooks.PostToolUse`) through the index recipe
|
||||
|
||||
Reference in new issue
Block a user