U2 Task 6 review by self: - The overview stays shown during a selection (A3): its rows and view rows now go through the drawing guard, so a started move or redraw asks before a click there drops it (R-12). Was a regression: the column was unreachable while selected before Task 6. - The edit form compares and merges trimmed names and colour: a space typed alone is no change and writes no `update`. - A layer opened with no opener (reload, Forward) returns the focus to its row on close. - Board 31 A: icons on « Modifier », « Modifier la forme » (the shape's glyph), « Marquer comme relu »; « Supprimer » as red text with its trash icon. - Tests: overview row and view row ask during a started move; a row asks during a started redraw; whitespace-only save; unnamed link read rows; focus back to the row with no opener. Dead helpers removed (tests/helpers openProperties, e2e propertiesDialog). Mapping: the point-edit « Enter on the selected row … asks first » test (which replaced « Toutes les annotations asks first ») keeps its place; the overview-row path it did not cover now has its own test.
27 lines
941 B
TypeScript
27 lines
941 B
TypeScript
/** U2 Task 6: the Annotations tab with a real navigation, so its properties dialog opens. */
|
|
import AnnotationsTab, {
|
|
type AnnotationsTabProps,
|
|
} from '@/components/editor/tabs/AnnotationsTab'
|
|
import { annotationLayerOf } from '@/editor/findingLayer'
|
|
import { AnnounceContext } from '@/editor/focusRequest'
|
|
import {
|
|
useEditorNavigation,
|
|
type EditorNavigation,
|
|
} from '@/editor/useEditorNavigation'
|
|
|
|
/** The last navigation a `LayeredTab` rendered with, for the tests to drive (Back, Forward). */
|
|
export const layered: { nav: EditorNavigation | null } = { nav: null }
|
|
|
|
export function LayeredTab(
|
|
props: Omit<AnnotationsTabProps, 'annotationLayer'>,
|
|
) {
|
|
const nav = useEditorNavigation('annotations')
|
|
layered.nav = nav
|
|
return (
|
|
<AnnounceContext value={nav.announce}>
|
|
<AnnotationsTab {...props} annotationLayer={annotationLayerOf(nav)} />
|
|
<p data-testid="live-region">{nav.live}</p>
|
|
</AnnounceContext>
|
|
)
|
|
}
|