M4 20261028100000_sheet_access_hardening + M5 20261028110000_sheet_review_workflow (applied together; no unprotected window). Implements contract §5-§14. - Catalogue rights table + owner RPCs; has_mfa / has_aal2_session (live auth.sessions check); grant_active vs caller_has split; catalogue reader predicate; can_edit_sheet on the sheet_editor capability (F14). - AR-1 B: aal2 required on every platform role change, target verified factor, race-free last-owner guard (F18/F19); service_role loses table privileges on the catalogue + profiles/profile_roles and EXECUTE on the role RPCs (F12/F17). - Reviewed lifecycle: version provenance + review columns, content/freeze/ author triggers, rounds/comments/acknowledgments, save/submit/withdraw/ comment/acknowledge/decide, atomic publish_sheet_version(review_id) on the stored verdict, deprecate/archive/restore, species RPCs, equine working copy, uploads with the storage check (F7) + editor INSERT policy + 2 MiB bucket. F1-F3,F5,F6,F8,F9,F13,F15,F16 closed. Verdict is a fixture until M6 (V1-2.3). - O22: SQL business mirror removed, declared status check kept; pgTAP 011 and the Rust generator's SQL parts deleted, ledger retargeted. - Access layer sheets.ts (closed SheetFailure kinds); old client publish gate deleted; types regenerated; upload tool reads via get_sheet_asset_state. Tested on the throwaway sandbox only; DEV untouched. pgTAP 850 (real stack) / 122 (PGlite) green; real-GoTrue AR-1 B + F18 race green; fresh install and M3->M5 upgrade green; V1-1 regression green; rust:check, typecheck, lint, build, types drift clean. BDR-084, LRN-095.
83 lines
6.6 KiB
PL/PgSQL
83 lines
6.6 KiB
PL/PgSQL
-- Anatomical sheets: schema contract and privileges after V1-2.1 (M4, M5).
|
|
-- The lifecycle, review and publication behaviour lives in 016; the AR-1 B and
|
|
-- rights matrix in 015. This file pins the tables, enums, RLS, the start-from-
|
|
-- zero privileges for every API role including service_role (F12), the narrow
|
|
-- reader column grants, and the removal of the Step 4 write paths and the SQL
|
|
-- business mirror.
|
|
begin;
|
|
select plan(45);
|
|
|
|
-- Tables and enums
|
|
select has_table('public', 'species', 'table species exists');
|
|
select has_table('public', 'anatomical_sheets', 'table anatomical_sheets exists');
|
|
select has_table('public', 'anatomical_sheet_versions', 'table anatomical_sheet_versions exists');
|
|
select has_table('public', 'anatomical_sheet_assets', 'table anatomical_sheet_assets exists');
|
|
select has_table('public', 'anatomical_catalog_grants', 'table anatomical_catalog_grants exists');
|
|
select has_table('public', 'anatomical_sheet_reviews', 'table anatomical_sheet_reviews exists');
|
|
select has_table('public', 'anatomical_sheet_review_comments', 'table anatomical_sheet_review_comments exists');
|
|
select has_table('public', 'anatomical_sheet_review_acknowledgments', 'table anatomical_sheet_review_acknowledgments exists');
|
|
select enum_has_labels('public', 'catalog_grant_kind',
|
|
array['catalog_reader', 'sheet_editor', 'sheet_reviewer', 'sheet_publisher'], 'catalog_grant_kind labels');
|
|
select enum_has_labels('public', 'sheet_round_status',
|
|
array['verifying', 'open', 'approved', 'changes_requested', 'withdrawn', 'verification_failed'], 'sheet_round_status labels');
|
|
|
|
-- RLS enabled on every catalogue table
|
|
select ok(
|
|
(select bool_and(relrowsecurity) from pg_class
|
|
where oid in ('public.species'::regclass, 'public.anatomical_sheets'::regclass,
|
|
'public.anatomical_sheet_versions'::regclass, 'public.anatomical_sheet_assets'::regclass,
|
|
'public.anatomical_catalog_grants'::regclass, 'public.anatomical_sheet_reviews'::regclass,
|
|
'public.anatomical_sheet_review_comments'::regclass,
|
|
'public.anatomical_sheet_review_acknowledgments'::regclass)),
|
|
'RLS enabled on the eight catalogue tables'
|
|
);
|
|
|
|
-- API roles start from zero (F12: service_role too)
|
|
select ok(not has_table_privilege('anon', 'public.anatomical_sheets', 'select'), 'anon cannot select sheets');
|
|
select ok(not has_table_privilege('anon', 'public.species', 'select'), 'anon cannot select species');
|
|
select ok(not has_table_privilege('service_role', 'public.anatomical_sheets', 'select'), 'service_role cannot select sheets (F12)');
|
|
select ok(not has_table_privilege('service_role', 'public.anatomical_sheet_versions', 'update'), 'service_role cannot update versions (F12)');
|
|
select ok(not has_table_privilege('service_role', 'public.anatomical_sheet_assets', 'update'), 'service_role cannot update assets (F12)');
|
|
select ok(not has_table_privilege('service_role', 'public.anatomical_catalog_grants', 'select'), 'service_role cannot read grants');
|
|
select ok(not has_table_privilege('service_role', 'public.profile_roles', 'insert'), 'service_role cannot write profile_roles (F17)');
|
|
select ok(not has_table_privilege('service_role', 'public.profiles', 'update'), 'service_role cannot write profiles (F17)');
|
|
|
|
-- Editors never write sheet identity, status, content directly (F9)
|
|
select ok(not has_table_privilege('authenticated', 'public.anatomical_sheets', 'insert'), 'authenticated cannot insert sheets');
|
|
select ok(not has_table_privilege('authenticated', 'public.anatomical_sheets', 'update'), 'authenticated cannot update sheets directly');
|
|
select ok(not has_table_privilege('authenticated', 'public.anatomical_sheet_versions', 'insert'), 'authenticated cannot insert versions');
|
|
select ok(not has_column_privilege('authenticated', 'public.anatomical_sheet_versions', 'content', 'update'), 'authenticated cannot update version content directly (F9)');
|
|
select ok(has_column_privilege('authenticated', 'public.anatomical_sheet_versions', 'revision', 'select'), 'authenticated may read the draft revision');
|
|
select ok(not has_column_privilege('authenticated', 'public.anatomical_sheet_versions', 'authors', 'select'), 'authenticated cannot read the author set directly');
|
|
select ok(not has_table_privilege('authenticated', 'public.anatomical_sheet_assets', 'insert'), 'authenticated cannot insert assets');
|
|
select ok(not has_table_privilege('authenticated', 'public.anatomical_catalog_grants', 'insert'), 'authenticated cannot write grants directly');
|
|
select ok(not has_table_privilege('authenticated', 'public.anatomical_sheet_reviews', 'insert'), 'authenticated cannot write rounds directly');
|
|
|
|
-- Reader column grants on sheets exclude the staff-only columns (§5.3)
|
|
select ok(not has_column_privilege('authenticated', 'public.anatomical_sheets', 'last_version_number', 'select'), 'last_version_number not readable');
|
|
select ok(not has_column_privilege('authenticated', 'public.anatomical_sheets', 'updated_at', 'select'), 'updated_at not readable');
|
|
select ok(not has_column_privilege('authenticated', 'public.anatomical_sheets', 'working_copy_source_version_id', 'select'), 'working_copy source not readable');
|
|
select ok(not has_column_privilege('authenticated', 'public.anatomical_sheets', 'creator_user_id', 'select'), 'creator_user_id not readable');
|
|
select ok(has_column_privilege('authenticated', 'public.anatomical_sheets', 'current_version_id', 'select'), 'current_version_id readable');
|
|
|
|
-- The Step 4 write paths are gone (F1, F3, F6)
|
|
select hasnt_function('public', 'create_anatomical_sheet', 'create_anatomical_sheet dropped (F1)');
|
|
select hasnt_function('public', 'fork_anatomical_sheet', 'fork_anatomical_sheet dropped (D5)');
|
|
select hasnt_function('public', 'set_sheet_visibility', 'set_sheet_visibility dropped (F6)');
|
|
|
|
-- The SQL business mirror is gone; the structural guards stay (§12.2)
|
|
select hasnt_function('private', 'sheet_document_issues', 'SQL business mirror dropped (O22)');
|
|
select hasnt_function('private', 'sheet_document_view_issues', 'view mirror dropped');
|
|
select hasnt_function('private', 'sheet_document_annotation_issues', 'annotation mirror dropped');
|
|
select has_function('private', 'sheet_document_has_shape', 'shape guard kept');
|
|
select has_function('private', 'sheet_document_unknown_assets', 'unknown-asset guard kept');
|
|
select has_function('private', 'sheet_all_reviewed', 'status check added (§12.2)');
|
|
|
|
-- The new workflow RPCs exist
|
|
select has_function('public', 'create_official_sheet', 'create_official_sheet exists');
|
|
select has_function('public', 'publish_sheet_version', 'publish_sheet_version exists');
|
|
select has_function('public', 'create_sheet_working_copy', 'create_sheet_working_copy exists');
|
|
|
|
select * from finish();
|
|
rollback;
|