Helpers citationsDialog, closeCitations by the dialog's ✕. Owner journey with tap at 375, keyboard and axe; geometry checks now dialog in viewport with focus inside; refused « Tout afficher » over a dirty form.
332 lines
12 KiB
TypeScript
332 lines
12 KiB
TypeScript
import { fr } from '@/i18n/fr'
|
|
import type { Locator, Page, TestInfo } from '@playwright/test'
|
|
import { expect, test } from '../support/browser'
|
|
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
|
|
import {
|
|
addReference,
|
|
backToDrawing,
|
|
copyKeyOf,
|
|
storedCopy,
|
|
closeCitations,
|
|
closeFinding,
|
|
editorActor,
|
|
openEditor,
|
|
openCitations,
|
|
openSection,
|
|
pickAnnotation,
|
|
place,
|
|
pointOf,
|
|
seedDraft,
|
|
selectTab,
|
|
shapeWith,
|
|
showDrawing,
|
|
historyButton,
|
|
openTab,
|
|
} from '../support/editor'
|
|
|
|
// V1-2.6 U1 B2a: tabs, Annotations sections and the Références tab stay mounted. What
|
|
// was typed, the canvas zoom and the focus survive a change of place; focus lands on a
|
|
// named element, never on `body`. happy-dom does not refuse focus on hidden elements, so
|
|
// the focus rules are checked here with `document.activeElement`.
|
|
|
|
const dict = fr
|
|
|
|
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
|
|
|
|
async function open(page: Page) {
|
|
const actor = await editorActor('fr')
|
|
const free = {
|
|
...pointOf('anno-free', 'main', { cx: 120, cy: 120, r: 6 }, 'Point libre'),
|
|
finding_zone_id: null,
|
|
}
|
|
const seed = await seedDraft(actor, { shape: shapeWith(free) })
|
|
await openEditor(page, dict, actor, seed.sheetId)
|
|
return { ...seed, actor }
|
|
}
|
|
|
|
/** The button's centre hits the button itself: no panel or scrim covers it (any state). */
|
|
const hitsItself = (button: Locator) =>
|
|
button.evaluate((element) => {
|
|
const box = element.getBoundingClientRect()
|
|
const hit = document.elementFromPoint(
|
|
box.x + box.width / 2,
|
|
box.y + box.height / 2,
|
|
)
|
|
return hit !== null && element.contains(hit)
|
|
})
|
|
|
|
const active = (page: Page) => page.locator(':focus')
|
|
const layerTransform = (page: Page) =>
|
|
page
|
|
.getByTestId('annotation-canvas')
|
|
.evaluate((box) => (box.firstElementChild as HTMLElement).style.transform)
|
|
|
|
test.describe('editor shell, kept places (B2a)', () => {
|
|
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
|
test.beforeEach(async ({ context }, info) => {
|
|
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
|
await routeToSandbox(context)
|
|
})
|
|
test.afterEach(async ({ context }) => {
|
|
await dropLateReplays(context)
|
|
})
|
|
|
|
test('the category form text and the zoom survive tab and section changes', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await openSection(page, dict, 'categories')
|
|
await page.locator('#category-new-fr').fill('Brouillon')
|
|
await selectTab(page, dict, 'general')
|
|
const hidden = page.locator('[data-place="annotations.categories"]')
|
|
await expect(hidden).toHaveCount(1)
|
|
await expect(hidden).toBeHidden()
|
|
await selectTab(page, dict, 'annotations')
|
|
await expect(page.locator('#category-new-fr')).toHaveValue('Brouillon')
|
|
|
|
await backToDrawing(page, dict)
|
|
await page
|
|
.getByRole('button', { name: dict['catalogue.zoom.in'], exact: true })
|
|
.click()
|
|
const zoomed = await layerTransform(page)
|
|
expect(zoomed).not.toContain('scale(1)')
|
|
await selectTab(page, dict, 'findings')
|
|
await showDrawing(page, dict)
|
|
expect(await layerTransform(page)).toBe(zoomed)
|
|
})
|
|
|
|
test('the Références tab keeps its search and no id repeats, panel open included', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await openTab(page, dict, 'references')
|
|
const search = page.getByRole('searchbox', {
|
|
name: dict['editor.references.search'],
|
|
})
|
|
await search.fill('Smith 1999')
|
|
await openTab(page, dict, 'general')
|
|
await openTab(page, dict, 'references')
|
|
await expect(search).toHaveValue('Smith 1999')
|
|
for (const tab of ['general', 'findings', 'verification']) {
|
|
await selectTab(page, dict, tab)
|
|
}
|
|
for (const section of ['views', 'categories', 'regions'] as const) {
|
|
await openSection(page, dict, section)
|
|
}
|
|
// The tab bodies stay mounted under the panel: its card ids carry their own prefix.
|
|
await openCitations(page, dict, 'Constat A')
|
|
const repeated = await page.evaluate(() => {
|
|
const ids = [...document.querySelectorAll('[id]')].map((e) => e.id)
|
|
return ids.filter((id, i) => ids.indexOf(id) !== i)
|
|
})
|
|
expect(repeated).toEqual([])
|
|
await closeCitations(page, dict)
|
|
await closeFinding(page, dict)
|
|
})
|
|
|
|
for (const width of [1024, 1280]) {
|
|
test(`the open references dialog is modal: the header and the tab row are out of reach at ${width} px`, async ({
|
|
page,
|
|
}) => {
|
|
await page.setViewportSize({ width, height: 800 })
|
|
await open(page)
|
|
// An edit first, so « Enregistrer » is enabled: a reference added in its tab.
|
|
await openTab(page, dict, 'references')
|
|
await addReference(page, dict, 'Smith 1999')
|
|
await openCitations(page, dict, 'Constat A')
|
|
const targets = [
|
|
page.getByRole('button', { name: dict['common.save'], exact: true }),
|
|
page.getByRole('tab', {
|
|
name: new RegExp(`^${dict['editor.tab.findings']}`),
|
|
}),
|
|
historyButton(page, dict, 'undo'),
|
|
]
|
|
for (const target of targets) {
|
|
expect(await hitsItself(target)).toBe(false)
|
|
}
|
|
await closeCitations(page, dict)
|
|
await closeFinding(page, dict)
|
|
for (const target of targets) {
|
|
expect(await hitsItself(target)).toBe(true)
|
|
}
|
|
})
|
|
}
|
|
|
|
test('focus lands on a named element after a tab click, « Retour au dessin » and « Aller à »', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await selectTab(page, dict, 'findings')
|
|
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
|
|
|
|
await openSection(page, dict, 'categories')
|
|
await backToDrawing(page, dict)
|
|
await expect(active(page)).toHaveAttribute(
|
|
'data-section-entry',
|
|
'categories',
|
|
)
|
|
|
|
await selectTab(page, dict, 'verification')
|
|
await page
|
|
.getByRole('button', { name: 'Aller à Point libre' })
|
|
.first()
|
|
.click()
|
|
await expect(place(page, 'annotations.drawing')).toBeVisible()
|
|
await expect(active(page)).toHaveAttribute(
|
|
'data-properties-heading',
|
|
'true',
|
|
)
|
|
})
|
|
|
|
test('arrowing back onto a tab keeps the focus on the tab', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await selectTab(page, dict, 'annotations')
|
|
await page
|
|
.getByRole('tab', { name: dict['editor.tab.annotations'] })
|
|
.focus()
|
|
await page.keyboard.press('ArrowRight')
|
|
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
|
|
await page.keyboard.press('ArrowLeft')
|
|
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
|
|
})
|
|
})
|
|
|
|
// V1-2.6 U1 B2b: a 1 024 px crossing never loses typed input.
|
|
test.describe('editor shell, width crossing (B2b)', () => {
|
|
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
|
test.beforeEach(async ({ context }, info) => {
|
|
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
|
await routeToSandbox(context)
|
|
})
|
|
test.afterEach(async ({ context }) => {
|
|
await dropLateReplays(context)
|
|
})
|
|
|
|
test('a field typed without a blur is committed before the crossing and the copy is written', async ({
|
|
page,
|
|
}) => {
|
|
const { actor, draftId } = await open(page)
|
|
await selectTab(page, dict, 'general')
|
|
const field = page.locator('#general-name-fr')
|
|
await field.click()
|
|
await field.fill('Nom saisi sans quitter le champ')
|
|
const key = copyKeyOf(actor.account.id, draftId)
|
|
expect(await storedCopy(page, key)).toBeNull()
|
|
await page.setViewportSize({ width: 800, height: 900 })
|
|
await expect(page.locator('#general-name-fr')).toHaveText(
|
|
'Nom saisi sans quitter le champ',
|
|
)
|
|
await expect.poll(() => storedCopy(page, key)).not.toBeNull()
|
|
})
|
|
|
|
test('the category form text is hidden below 1 024 px and comes back on widening', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await openSection(page, dict, 'categories')
|
|
const field = page.locator('#category-new-fr')
|
|
await field.fill('Brouillon')
|
|
await page.setViewportSize({ width: 800, height: 900 })
|
|
await expect(field).toBeHidden()
|
|
// The field's focus went to the shown tab, never to `body`.
|
|
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
|
|
await page.setViewportSize({ width: 1280, height: 900 })
|
|
await expect(field).toBeVisible()
|
|
await expect(field).toHaveValue('Brouillon')
|
|
})
|
|
})
|
|
|
|
// V1-2.6 U1 F (AC9): in the editor the sidebar shows from 1 280 px only; below, the top
|
|
// bar's menu button opens the drawer, which stays open while the sidebar stays hidden.
|
|
test.describe('editor shell, sidebar from 1 280 px (F)', () => {
|
|
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
|
test.beforeEach(async ({ context }, info) => {
|
|
test.skip(isPhone(info), 'the widths are set by the tests themselves') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
|
await routeToSandbox(context)
|
|
})
|
|
test.afterEach(async ({ context }) => {
|
|
await dropLateReplays(context)
|
|
})
|
|
|
|
const nav = (page: Page) =>
|
|
page.getByRole('navigation', { name: dict['shell.nav_label'] })
|
|
const menu = (page: Page) =>
|
|
page.getByRole('button', { name: dict['shell.open_menu'] })
|
|
const drawer = (page: Page) =>
|
|
page.getByRole('dialog', { name: dict['shell.nav_label'] })
|
|
|
|
async function measure(page: Page, width: number) {
|
|
await page.setViewportSize({ width, height: 800 })
|
|
await selectTab(page, dict, 'annotations')
|
|
await pickAnnotation(page, dict, 'Point libre')
|
|
const canvas = await page.getByTestId('annotation-canvas').boundingBox()
|
|
const scroll = await page.evaluate(() => ({
|
|
scrollWidth: document.documentElement.scrollWidth,
|
|
clientWidth: document.documentElement.clientWidth,
|
|
}))
|
|
test.info().annotations.push({
|
|
type: 'canvas-width',
|
|
description: `${canvas?.width}px at ${width}px`,
|
|
})
|
|
return scroll
|
|
}
|
|
|
|
test('the sidebar is hidden below 1 280 px and shown from 1 280 px', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
for (const width of [1024, 1180, 1279]) {
|
|
const scroll = await measure(page, width)
|
|
expect(scroll.scrollWidth, `${width} px`).toBeLessThanOrEqual(
|
|
scroll.clientWidth,
|
|
)
|
|
await expect(nav(page), `${width} px`).toHaveCount(0)
|
|
await expect(menu(page), `${width} px`).toBeVisible()
|
|
}
|
|
const scroll = await measure(page, 1280)
|
|
expect(scroll.scrollWidth).toBeLessThanOrEqual(scroll.clientWidth)
|
|
await expect(nav(page)).toBeVisible()
|
|
await expect(menu(page)).toHaveCount(0)
|
|
})
|
|
|
|
test('the menu is one tap away and the drawer stays open at 1 180 px', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await page.setViewportSize({ width: 1180, height: 800 })
|
|
await menu(page).click()
|
|
await expect(drawer(page)).toBeVisible()
|
|
await page.setViewportSize({ width: 1279, height: 800 })
|
|
await page.evaluate(
|
|
() =>
|
|
new Promise((done) =>
|
|
requestAnimationFrame(() => requestAnimationFrame(done)),
|
|
),
|
|
)
|
|
await expect(drawer(page)).toBeVisible()
|
|
await page.setViewportSize({ width: 1280, height: 800 })
|
|
await expect(drawer(page)).toBeHidden()
|
|
await expect(nav(page)).toBeVisible()
|
|
})
|
|
|
|
test('a drawer link asks before leaving while the draft has unsaved changes', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await page.setViewportSize({ width: 1180, height: 800 })
|
|
await selectTab(page, dict, 'general')
|
|
await page.locator('#general-name-fr').fill('Travail non enregistré')
|
|
await menu(page).click()
|
|
await drawer(page)
|
|
.getByRole('link', { name: new RegExp(dict['shell.nav.account']) })
|
|
.click()
|
|
const leave = page.getByRole('dialog', { name: dict['leave.title'] })
|
|
await expect(leave).toBeVisible()
|
|
await leave.getByRole('button', { name: dict['leave.stay'] }).click()
|
|
await expect(leave).toBeHidden()
|
|
await expect(page).toHaveURL(/\/draft/)
|
|
})
|
|
})
|