Files
faunosteo/apps/app/e2e/shell/editor-shell.spec.ts
T
bchanot cd794f3c39 feat(editor): properties dialog over the column, transactional save
U2 Task 6 (A1, A2, A3, A9, A10, R-3, R-5, R-6, R-14, R-16).

- Dialog: `anchor` places the panel at the column's left and width,
  from its top, under a 22 % ink veil that ignores clicks; the visual
  viewport below 320 px; centred without an anchor box.
- Navigation: `annotation` layer (LAYERS, EditorView, history entry,
  leave guards, left-draft flag); Back closes, Forward reopens.
- AnnotationDialog: read body, « Modifier » form (CreationFields with
  « Couleur », missingFields, R-3 messages), one `update` on the
  current annotation by id, « Marquer comme relu », « Modifier la
  forme », « Supprimer »; read-only flip keeps the draft.
- The column always shows the overview, selected row marked; Enter on
  it, a second click or a double click, the strip's « Propriétés »
  open the dialog. « Aller à » focuses the row (R-5).
- Read-only twin: strip and read-only dialog at 1 024 px and wider,
  inline read body below. PropertiesPanel and AnnotationFields gone.
- Strip lead 256 px and a fixed status slot, so the commands fit at
  1 024 px and a status change moves nothing.
- e2e: `aside-content` exemption removed; scroll-to-top workarounds
  of editor-geometry, editor-zones and editor-journey removed.

Removed assertions mapped:
  editor-annotations-tab.test.tsx:
  - selectFromList waited for `annotation-properties` -> waits for the strip's « Propriétés » (selection without dialog, A1)
  - refused place: issues block `annotation-geometry-issues` in the panel -> the strip notice alert (present, then gone)
  - keyboard creation / C26 confirmation: `annotation-properties` after create -> strip « Propriétés » (new element selected)
  - Désélectionner from the panel -> « Désélectionner » in the strip (all 7 tests); « panel closes » -> strip has no « Propriétés »
  - undo after deselect (typed name) -> handle key series then deselect then undo
  - commits a valid typed value once without blur (name field) -> a pending handle key series committed once by the strip deselect
  - a refused typed value: the panel closes (two tests: strip deselect, tap deselect) -> removed: no field outside the dialog; the dialog's draft writes nothing before « Enregistrer » (new dialog tests)
  - not offered while a replace tracing runs: panel's Désélectionner absent -> strip offers neither « Désélectionner » nor « Propriétés » during the tracing
  - tap: isDeselected read `annotation-properties` -> strip « Propriétés » absent; link select -> strip title data-selection
  - tap: undo after tap deselect (typed name) -> handle series; typed value committed on blur -> handle series committed on blur
  - strip geometry issues: list read in the panel -> list read in the properties dialog's issues block
  - a new commit replaces the message (typed name) -> « Marquer comme relu » in the dialog
  editor-escape.test.tsx:
  - `panel()` = `annotation-properties` -> the strip's « Propriétés » or the phone twin's inline read body
  - Escape from a panel button (« Marquer comme relu ») -> from the selected row in the side column: focus on the row
  - after A then B from the panel (via « Toutes les annotations ») -> select A, select B, Escape from a button of the side column: focus on B's row
  - a text field (panel « Nom (FR) ») -> the overview « Filtrer par nom »
  - redraw via the panel's « Remplacer par un polygone » -> the strip's command
  - modal / delete dialog opened by the panel's « Supprimer » -> « Supprimer » of the properties dialog
  - read-only width: hidden `annotation-properties` -> hidden strip « Propriétés » of the kept edit body
  editor-history-buttons.test.tsx (typed text and the press, 8 tests): the annotation's committed « Nom (FR) » field of the panel -> the sheet's committed « Nom (FR) » on Général (same TextField commit-on-blur path; annotation fields are now a dialog draft)
  editor-focus-request.test.tsx: « Aller à » focuses `data-properties-heading` inside `annotation-properties` -> focuses the annotation's row, marked aria-current, no dialog (R-5)
  editor-sections.test.tsx: « Aller à » with nothing in progress focused the properties heading -> focuses the row (R-5); creation kept: no `annotation-properties` -> no strip « Propriétés »
  editor-overview.test.tsx (edit and read-only): row opens `annotation-properties`, « Toutes les annotations » returns -> row selects, stays marked aria-current, no dialog; strip « Désélectionner » returns focus to the row; filter kept across select and « Désélectionner »
  editor-citations-guards.test.tsx: LAYERS_TOP_DOWN gains 'annotation' at the bottom
  editor-keep-alive.test.tsx: `annotation-properties` visible after the round trip -> the strip's « Propriétés » visible (selection kept)
  editor-no-loss.test.tsx: ids `ro-annotation-name-fr` and `annotation-name-fr` (both panels' fields) -> the twin's inline read body (no ids), then the dialog edit form's `annotation-edit-fr`, kept through a flip to 800 px, no duplicate id; « Aller à » visible `annotation-properties` -> visible `annotation-read` (inline twin), none at 1 280
  editor-point-edit.test.tsx / editor-zone-edit.test.tsx: `select()` waited for `annotation-properties` and returned it -> waits for the strip's « Propriétés » and returns the strip (its « Désélectionner » and « Remplacer par un polygone » moved there)
  - move mode Escape: `annotation-properties` still there -> the strip's « Propriétés » back after the mode
  - « Toutes les annotations » asks first during a started move -> Enter on the selected row asks first (no dialog), and the strip offers neither « Propriétés » nor « Désélectionner » during the mode
  - Escape from the handle / slider: `annotation-properties` gone -> the strip's « Propriétés » gone
  - I-3 touch tap: `annotation-properties` gone -> the strip's « Propriétés » gone
  e2e (sandbox):
  - support/layout.ts: `aside-content` exemption removed (ShiftExemption type, the loose compare); every `swaps`/`SWAPS` argument removed (editor-annotations, editor-zones, editor-geometry)
  - support/editor.ts pickAnnotation: clicked « Toutes les annotations » first when the panel showed -> the overview is always shown: clicks the row, then scrolls back to the top (the page no longer shortens)
  - editor-annotations: `annotation-properties` visible after a creation -> strip with « Propriétés »; review toggle and « Supprimer » of the panel -> the properties dialog's; a jitter click on the selected point now opens the dialog (A1), closed by Escape before the drag; handle names exact (the marked row shares the prefix); trace close moved out of expectNoShift (creation panel until Task 7, shortcut + TODO)
  - editor-deselect: `annotation-properties` -> the strip with « Propriétés » or the twin's inline read body; Escape in a field: panel « Nom (FR) » -> overview filter; delete dialog from the panel -> from the properties dialog (Escape closes it, then the dialog); « a typed value is applied by the click that deselects » (name field, refused blank) -> a pending point-handle key series applied by the deselecting click and by « Désélectionner » (refused value: no field outside the dialog); « the selected one stays » -> a second click, double click and jitter open the dialog, Escape closes it, selection kept
  - editor-geometry: `annotation-geometry-issues` in the panel -> read in the properties dialog, then the strip notice; after the refusal the error count unchanged; scroll-to-top workaround removed
  - editor-zones: panel « Désélectionner » -> strip; scroll-to-top after pickAnnotation removed (helper does it)
  - editor-structures: panel « Supprimer » -> properties dialog « Supprimer », confirmation over it
  - editor-journey: `#annotation-name-fr` committed field + `#annotation-laterality` -> the dialog's edit form, one « Enregistrer »; scroll-to-top removed
  - editor-shell / editor-shell-journeys: « Aller à » focus on `data-properties-heading` -> the annotation's row (aria-current), no dialog (R-5)
  - editor-shell-layout: focus kind `annotation-properties` -> removed (the overview is the side)
2026-11-17 22:01:57 +01:00

335 lines
12 KiB
TypeScript

import { fr } from '@/i18n/fr'
import type { Locator, Page, TestInfo } from '@playwright/test'
import { expect, test } from '../support/browser'
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
import {
addReference,
backToDrawing,
copyKeyOf,
storedCopy,
closeCitations,
closeFinding,
editorActor,
openEditor,
openCitations,
openSection,
pickAnnotation,
place,
pointOf,
seedDraft,
selectTab,
shapeWith,
showDrawing,
historyButton,
openTab,
} from '../support/editor'
// V1-2.6 U1 B2a: tabs, Annotations sections and the Références tab stay mounted. What
// was typed, the canvas zoom and the focus survive a change of place; focus lands on a
// named element, never on `body`. happy-dom does not refuse focus on hidden elements, so
// the focus rules are checked here with `document.activeElement`.
const dict = fr
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
async function open(page: Page) {
const actor = await editorActor('fr')
const free = {
...pointOf('anno-free', 'main', { cx: 120, cy: 120, r: 6 }, 'Point libre'),
finding_zone_id: null,
}
const seed = await seedDraft(actor, { shape: shapeWith(free) })
await openEditor(page, dict, actor, seed.sheetId)
return { ...seed, actor }
}
/** The button's centre hits the button itself: no panel or scrim covers it (any state). */
const hitsItself = (button: Locator) =>
button.evaluate((element) => {
const box = element.getBoundingClientRect()
const hit = document.elementFromPoint(
box.x + box.width / 2,
box.y + box.height / 2,
)
return hit !== null && element.contains(hit)
})
const active = (page: Page) => page.locator(':focus')
const layerTransform = (page: Page) =>
page
.getByTestId('annotation-canvas')
.evaluate((box) => (box.firstElementChild as HTMLElement).style.transform)
test.describe('editor shell, kept places (B2a)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('the category form text and the zoom survive tab and section changes', async ({
page,
}) => {
await open(page)
await openSection(page, dict, 'categories')
await page.locator('#category-new-fr').fill('Brouillon')
await selectTab(page, dict, 'general')
const hidden = page.locator('[data-place="annotations.categories"]')
await expect(hidden).toHaveCount(1)
await expect(hidden).toBeHidden()
await selectTab(page, dict, 'annotations')
await expect(page.locator('#category-new-fr')).toHaveValue('Brouillon')
await backToDrawing(page, dict)
await page
.getByRole('button', { name: dict['catalogue.zoom.in'], exact: true })
.click()
const zoomed = await layerTransform(page)
expect(zoomed).not.toContain('scale(1)')
await selectTab(page, dict, 'findings')
await showDrawing(page, dict)
expect(await layerTransform(page)).toBe(zoomed)
})
test('the Références tab keeps its search and no id repeats, panel open included', async ({
page,
}) => {
await open(page)
await openTab(page, dict, 'references')
const search = page.getByRole('searchbox', {
name: dict['editor.references.search'],
})
await search.fill('Smith 1999')
await openTab(page, dict, 'general')
await openTab(page, dict, 'references')
await expect(search).toHaveValue('Smith 1999')
for (const tab of ['general', 'findings', 'verification']) {
await selectTab(page, dict, tab)
}
for (const section of ['views', 'categories', 'regions'] as const) {
await openSection(page, dict, section)
}
// The tab bodies stay mounted under the panel: its card ids carry their own prefix.
await openCitations(page, dict, 'Constat A')
const repeated = await page.evaluate(() => {
const ids = [...document.querySelectorAll('[id]')].map((e) => e.id)
return ids.filter((id, i) => ids.indexOf(id) !== i)
})
expect(repeated).toEqual([])
await closeCitations(page, dict)
await closeFinding(page, dict)
})
for (const width of [1024, 1280]) {
test(`the open references dialog is modal: the header and the tab row are out of reach at ${width} px`, async ({
page,
}) => {
await page.setViewportSize({ width, height: 800 })
await open(page)
// An edit first, so « Enregistrer » is enabled: a reference added in its tab.
await openTab(page, dict, 'references')
await addReference(page, dict, 'Smith 1999')
await openCitations(page, dict, 'Constat A')
const targets = [
page.getByRole('button', { name: dict['common.save'], exact: true }),
page.getByRole('tab', {
name: new RegExp(`^${dict['editor.tab.findings']}`),
}),
historyButton(page, dict, 'undo'),
]
for (const target of targets) {
expect(await hitsItself(target)).toBe(false)
}
await closeCitations(page, dict)
await closeFinding(page, dict)
for (const target of targets) {
expect(await hitsItself(target)).toBe(true)
}
})
}
test('focus lands on a named element after a tab click, « Retour au dessin » and « Aller à »', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'findings')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
await openSection(page, dict, 'categories')
await backToDrawing(page, dict)
await expect(active(page)).toHaveAttribute(
'data-section-entry',
'categories',
)
await selectTab(page, dict, 'verification')
await page
.getByRole('button', { name: 'Aller à Point libre' })
.first()
.click()
await expect(place(page, 'annotations.drawing')).toBeVisible()
// R-5: the annotation's row takes the focus, no dialog opens (U2 Task 6).
await expect(active(page)).toHaveAttribute(
'data-focus-key',
/"kind":"annotation"/,
)
await expect(active(page)).toHaveAttribute('aria-current', 'true')
await expect(page.getByRole('dialog')).toHaveCount(0)
})
test('arrowing back onto a tab keeps the focus on the tab', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'annotations')
await page
.getByRole('tab', { name: dict['editor.tab.annotations'] })
.focus()
await page.keyboard.press('ArrowRight')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
await page.keyboard.press('ArrowLeft')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
})
})
// V1-2.6 U1 B2b: a 1 024 px crossing never loses typed input.
test.describe('editor shell, width crossing (B2b)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('a field typed without a blur is committed before the crossing and the copy is written', async ({
page,
}) => {
const { actor, draftId } = await open(page)
await selectTab(page, dict, 'general')
const field = page.locator('#general-name-fr')
await field.click()
await field.fill('Nom saisi sans quitter le champ')
const key = copyKeyOf(actor.account.id, draftId)
expect(await storedCopy(page, key)).toBeNull()
await page.setViewportSize({ width: 800, height: 900 })
await expect(page.locator('#general-name-fr')).toHaveText(
'Nom saisi sans quitter le champ',
)
await expect.poll(() => storedCopy(page, key)).not.toBeNull()
})
test('the category form text is hidden below 1 024 px and comes back on widening', async ({
page,
}) => {
await open(page)
await openSection(page, dict, 'categories')
const field = page.locator('#category-new-fr')
await field.fill('Brouillon')
await page.setViewportSize({ width: 800, height: 900 })
await expect(field).toBeHidden()
// The field's focus went to the shown tab, never to `body`.
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
await page.setViewportSize({ width: 1280, height: 900 })
await expect(field).toBeVisible()
await expect(field).toHaveValue('Brouillon')
})
})
// V1-2.6 U1 F (AC9): in the editor the sidebar shows from 1 280 px only; below, the top
// bar's menu button opens the drawer, which stays open while the sidebar stays hidden.
test.describe('editor shell, sidebar from 1 280 px (F)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'the widths are set by the tests themselves') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
const nav = (page: Page) =>
page.getByRole('navigation', { name: dict['shell.nav_label'] })
const menu = (page: Page) =>
page.getByRole('button', { name: dict['shell.open_menu'] })
const drawer = (page: Page) =>
page.getByRole('dialog', { name: dict['shell.nav_label'] })
async function measure(page: Page, width: number) {
await page.setViewportSize({ width, height: 800 })
await selectTab(page, dict, 'annotations')
await pickAnnotation(page, dict, 'Point libre')
const canvas = await page.getByTestId('annotation-canvas').boundingBox()
const scroll = await page.evaluate(() => ({
scrollWidth: document.documentElement.scrollWidth,
clientWidth: document.documentElement.clientWidth,
}))
test.info().annotations.push({
type: 'canvas-width',
description: `${canvas?.width}px at ${width}px`,
})
return scroll
}
test('the sidebar is hidden below 1 280 px and shown from 1 280 px', async ({
page,
}) => {
await open(page)
for (const width of [1024, 1180, 1279]) {
const scroll = await measure(page, width)
expect(scroll.scrollWidth, `${width} px`).toBeLessThanOrEqual(
scroll.clientWidth,
)
await expect(nav(page), `${width} px`).toHaveCount(0)
await expect(menu(page), `${width} px`).toBeVisible()
}
const scroll = await measure(page, 1280)
expect(scroll.scrollWidth).toBeLessThanOrEqual(scroll.clientWidth)
await expect(nav(page)).toBeVisible()
await expect(menu(page)).toHaveCount(0)
})
test('the menu is one tap away and the drawer stays open at 1 180 px', async ({
page,
}) => {
await open(page)
await page.setViewportSize({ width: 1180, height: 800 })
await menu(page).click()
await expect(drawer(page)).toBeVisible()
await page.setViewportSize({ width: 1279, height: 800 })
await page.evaluate(
() =>
new Promise((done) =>
requestAnimationFrame(() => requestAnimationFrame(done)),
),
)
await expect(drawer(page)).toBeVisible()
await page.setViewportSize({ width: 1280, height: 800 })
await expect(drawer(page)).toBeHidden()
await expect(nav(page)).toBeVisible()
})
test('a drawer link asks before leaving while the draft has unsaved changes', async ({
page,
}) => {
await open(page)
await page.setViewportSize({ width: 1180, height: 800 })
await selectTab(page, dict, 'general')
await page.locator('#general-name-fr').fill('Travail non enregistré')
await menu(page).click()
await drawer(page)
.getByRole('link', { name: new RegExp(dict['shell.nav.account']) })
.click()
const leave = page.getByRole('dialog', { name: dict['leave.title'] })
await expect(leave).toBeVisible()
await leave.getByRole('button', { name: dict['leave.stay'] }).click()
await expect(leave).toBeHidden()
await expect(page).toHaveURL(/\/draft/)
})
})