Files
faunosteo/apps/app/e2e/shell/editor-structures.spec.ts
T
bchanot c21995b3fb feat(editor): collapsible reference tiles in the Références tab
Board 23 / 24 / 27 tiles: closed (citation on two lines, type, « Citée
{n} fois » / « Non citée »), open (Type, DOI, URL as safe links, the
citers with « famille » badge and « Aller à »), edit (« Terminer » with a
leave guard re-committing every changed field; a refusal keeps edit
and focuses the field). A cited reference shows the deletion hint, an
uncited one keeps « Supprimer ». Read-only keeps DOI, URL, « Aller à ».
« Terminer » keeps focus in the field on press, so a refusal message
can no longer move the button under the pointer.

Gates: typecheck, lint, test:run (app 1419), build, e2e:ui 251;
e2e:shell 16 specs on db:sandbox (editor-equine never listed): 111
passed / 99 skipped / 3 failed in the new editor-references.spec (two
test bugs, one app bug), fixed and rerun: 5 passed / 4 skipped; full-row
guard: no pre-existing row changed in any table.

## R-24 (removed or rewritten assertions)
| file | old | new |
|---|---|---|
| editor-citations.test.ts | `citationCounts` counts 2/1/0, memoised, empty | `citersOf`: ordered citers (Cat, Node), family flag, trail from zone, key, memoised, empty |
| editor-references-tab.test.tsx | cards say « citée N fois » (ref-a 1, ref-c 0) | « Citée 2 fois » (fixture gains a node citing ref-a), « Citée 1 fois », « Non citée » |
| same | ids `#tab-reference-ref-a-citation` exist when closed | header id `#tab-reference-0-ref-a-header`; field ids only inside an open edit tile |
| same | ↑/↓ on every card | in open tiles only, absent under a search |
| same | Ctrl+Z on an always-visible field | open tile, Modifier, then same assertion on `#tab-reference-0-ref-a-citation` |
| same | « Aller à » focuses the card (`listitem` count 3, focus key) | tile opened (aria-expanded true), header focused, 3 tiles |
| same | add: `getByText('Nouvelle source')` | tile header named « Nouvelle source » |
| same | read-only: no Supprimer / add | same after opening every tile |
| editor-tabs-lists.test.tsx | edit on blur and arrows on always-open cards | open tile, Modifier, blur applies, Terminer, Monter on opened tile |
| same | cited reference deletion refused in a dialog listing citers | REMOVED: no Supprimer on a cited tile (hint asserted, citer listed); uncited delete kept. The dialog's blocked path stays covered by `DeleteDialog`'s own tests |
| same | read-only: no button at all | read-only: facts shown, no Modifier / Supprimer / Citation textbox (header buttons exist now) |
| editor-keep-alive.test.tsx:~330 | tab-click commit of `#tab-reference-ref-1-citation` | opens tile + Modifier first, id `#tab-reference-0-ref-1-citation` |
| editor-keep-alive.test.tsx:~350,367 | `#panel-reference-ref-1-citation` | `#panel-reference-0-ref-1-citation` |
| editor-references-panel.test.tsx | « citée 2 fois / 1 fois » | « Citée 2 fois / 1 fois » |
| same | `#panel-reference-ref-a-citation`; no `#tab-reference-ref-a-citation` | `#panel-reference-0-ref-a-citation`; no `[id^="tab-reference-"]` while the tab tiles are closed |
| same | ids unique, tab and panel field ids present | tab tile opened in edit first; `tab-reference-0-ref-a-citation` and `panel-reference-0-ref-a-citation` unique |
| e2e editor-structures.spec.ts:~88-110 | citation inputs count 3/1/2, « citée 0 fois » x2, « citée 1 fois », move via row buttons | tile headers count, « Non citée » x2, « Citée 1 fois », tile opened before Monter/Supprimer, `tiles.nth(1)` contains the moved text (saved-list assertion unchanged) |

## i18n (fr / en)
Changed (in place, P18): `editor.references.cited_one|other`: « citée {count} fois » -> « Citée {count} fois »; « cited {count} time(s) » -> « Cited {count} time(s) ».
Added: `editor.references.uncited` Non citée / Not cited; `citers_one|other` « Citée {count} fois, par : » / « Cited {count} time(s), by: »; `no_citers` « Aucun constat ni aucune famille ne cite cette référence. » / « No finding or family cites this reference. »; `family` famille / family; `go_to` Aller à / Go to; `edit` Modifier / Edit; `done` Terminer / Done; `edit_title` Modifier la référence / Edit the reference; `url_label` URL / URL; `none_doi` Aucun / None; `none_url` Aucune / None; `new_tab` (nouvel onglet) / (new tab) (sr-only); `delete_hint` (REVUE wording, fr and en).
Removed: none. R10 grep (src, tests, e2e incl. editor-equine) found no reader of the old lowercase wording left.
2026-11-12 20:50:25 +01:00

332 lines
12 KiB
TypeScript

import { fr } from '@/i18n/fr'
import type { Locator, Page, TestInfo } from '@playwright/test'
import { expect, expectAccessible, test } from '../support/browser'
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
import {
bareShape,
editorActor,
libraryRoot,
openEditor,
openTab,
openSection,
pickAnnotation,
pointOf,
revisionText,
saveDraft,
saveLine,
seedDraft,
selectTab,
serverDocument,
serverRevision,
shapeWith,
showDrawing,
} from '../support/editor'
// V1-2.6 A4 (contract C9 to C12, C19): the structures around the drawing. Annotation
// categories, references, vertebral regions, then the findings tree (zones, categories,
// nodes): add, edit, reorder, mark reviewed, delete with and without dependents.
const dict = fr
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
const dialog = (page: Page) => page.getByRole('dialog')
const button = (page: Page, name: string) =>
page.getByRole('button', { name, exact: true })
async function open(page: Page, ...annotations: unknown[]) {
const actor = await editorActor('fr')
const seed = await seedDraft(actor, { shape: shapeWith(...annotations) })
await openEditor(page, dict, actor, seed.sheetId)
return { actor, seed }
}
async function commitText(field: Locator, value: string) {
await field.fill(value)
await field.press('Enter')
}
test.describe('editor structures (A4)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('categories, references and regions: add, edit, reorder, delete', async ({
page,
requests,
}) => {
const { actor, seed } = await open(page)
requests.forbid(actor.account.email, actor.account.password)
// A category added, then renamed in place.
await openSection(page, dict, 'categories')
await page.locator('#category-new-fr').fill('Catégorie B')
await page.locator('#category-new-en').fill('Category B')
await page
.getByRole('button', { name: dict['editor.general.category_add'] })
.click()
const names = page.locator('[id^="category-"][id$="-name-fr"]')
await expect(page.locator('#category-new-fr')).toHaveValue('')
await expect(names).toHaveCount(2)
await commitText(names.nth(1), 'Catégorie B bis')
await expect(names.nth(1)).toHaveValue('Catégorie B bis')
await expectAccessible(page, 'the categories section')
// Two references added in the Références tab, the second moved up (the shape's
// « Référence A » stays first: it is cited by « Constat A »).
await openTab(page, dict, 'references')
for (const citation of ['Première référence', 'Seconde référence']) {
await page.locator('#tab-reference-new-type').selectOption('book')
await page.locator('#tab-reference-new-citation').fill(citation)
await page
.getByRole('button', { name: dict['editor.reference.add'] })
.click()
await expect(page.getByText(citation)).toBeVisible()
}
const tiles = page.locator('[id^="tab-reference-"][id$="-header"]')
const tileOf = (citation: string) =>
page.getByRole('listitem').filter({ hasText: citation }).first()
await expect(tiles).toHaveCount(3)
await expect(
libraryRoot(page).getByText(dict['editor.references.uncited']),
).toHaveCount(2)
await expect(libraryRoot(page).getByText('Citée 1 fois')).toHaveCount(1)
const search = page.getByRole('searchbox', {
name: dict['editor.references.search'],
})
await search.fill('seconde')
await expect(tiles).toHaveCount(1)
await search.fill('')
await expect(tiles).toHaveCount(3)
await tiles.filter({ hasText: 'Seconde référence' }).click()
await tileOf('Seconde référence')
.getByRole('button', { name: dict['editor.action.move_up'] })
.click()
await expect(tiles.nth(1)).toContainText('Seconde référence')
await tiles.filter({ hasText: 'Première référence' }).click()
await tileOf('Première référence')
.getByRole('button', { name: dict['editor.action.delete'] })
.click()
await dialog(page)
.getByRole('button', { name: dict['editor.delete.confirm'] })
.click()
await expect(tiles).toHaveCount(2)
// A region with its count.
await openSection(page, dict, 'regions')
await page.locator('#region-new-code').fill('T')
await page.locator('#region-new-fr').fill('Thoracique')
await page.locator('#region-new-en').fill('Thoracic')
await page.locator('#region-new-count').fill('18')
await page
.getByRole('button', { name: dict['editor.vertebra.add'] })
.click()
await commitText(page.locator('#region-T-count'), '17')
await expect(page.locator('#region-T-count')).toHaveValue('17')
await saveDraft(page, dict, seed.revision + 1)
const saved = await serverDocument<{
categories: { name: { fr: string } }[]
references: { citation: string }[]
vertebral_config: { regions: { code: string; count: number }[] }
}>(seed.draftId)
expect(saved.categories.map((c) => c.name.fr)).toEqual([
'Catégorie A',
'Catégorie B bis',
])
expect(saved.references.map((r) => r.citation)).toEqual([
'Référence A',
'Seconde référence',
])
expect(saved.vertebral_config.regions).toEqual([
expect.objectContaining({ code: 'T', count: 17 }),
])
})
test('the findings tree: add zone, category and node, review, reorder', async ({
page,
requests,
}) => {
const { actor, seed } = await open(page)
requests.forbid(actor.account.email, actor.account.password)
await selectTab(page, dict, 'findings')
const items = page.getByTestId('finding-item')
// The seeded zone is open: the zone and its category show, the node is folded.
await expect(items).toHaveCount(2)
await page
.getByRole('button', { name: dict['editor.findings.add_zone'] })
.click()
await page.locator('#finding-new-name-fr').fill('Zone B')
await page.locator('#finding-new-name-en').fill('Zone B en')
await page
.getByRole('button', { name: dict['editor.findings.create'] })
.click()
await expect(items.filter({ hasText: 'Zone B' })).toBeVisible()
await page
.getByRole('button', { name: dict['editor.findings.add_category'] })
.click()
await page.locator('#finding-new-zone').selectOption({ label: 'Zone B' })
await page.locator('#finding-new-kind').selectOption('anamnesis')
await page.locator('#finding-new-name-fr').fill('Anamnèse B')
await page.locator('#finding-new-name-en').fill('History B')
await page
.getByRole('button', { name: dict['editor.findings.create'] })
.click()
const category = items.filter({ hasText: 'Anamnèse B' })
await expect(category).toBeVisible()
await expect(
category.getByText(dict['editor.findings.status.to_confirm']),
).toBeVisible()
await page
.getByRole('button', { name: dict['editor.findings.add_node'] })
.click()
await page.locator('#finding-new-name-fr').fill('Constat B1')
await page.locator('#finding-new-name-en').fill('Finding B1')
await page
.getByRole('button', { name: dict['editor.findings.create'] })
.click()
const node = items.filter({ hasText: 'Constat B1' })
await expect(node).toBeVisible()
// Marked reviewed: the badge of the row follows.
await page
.getByRole('button', { name: dict['editor.findings.mark_reviewed'] })
.click()
await expect(
node.getByText(dict['editor.findings.status.reviewed']),
).toBeVisible()
// The tab row (history buttons included) scrolled under the sticky top bar is not a
// target-size finding of its own: audit it from the top.
await page.evaluate(() => window.scrollTo(0, 0))
await expectAccessible(page, 'the findings tree')
// Reorder: the new zone moves above the seeded one.
await items.filter({ hasText: 'Zone B' }).first().click()
await page
.getByRole('button', { name: dict['editor.action.move_up'] })
.click()
await expect(items.first()).toContainText('Zone B')
await saveDraft(page, dict, seed.revision + 1)
const saved = await serverDocument<{
finding_zones: { name: { fr: string } }[]
}>(seed.draftId)
expect(saved.finding_zones.map((z) => z.name.fr)).toEqual([
'Zone B',
'Zone A',
])
})
test('a draft stored with bare nodes loads filled: rename, save, reload clean', async ({
page,
requests,
}) => {
const actor = await editorActor('fr')
requests.forbid(actor.account.email, actor.account.password)
const seed = await seedDraft(actor, { shape: bareShape })
await openEditor(page, dict, actor, seed.sheetId)
await selectTab(page, dict, 'findings')
const items = page.getByTestId('finding-item')
await items.filter({ hasText: 'Catégorie nue' }).click()
await commitText(page.locator('#finding-name-fr'), 'Catégorie renommée')
await saveDraft(page, dict, seed.revision + 1)
const saved = await serverDocument<{
finding_zones: { categories: { reference_ids: string[] }[] }[]
}>(seed.draftId)
expect(saved.finding_zones[0].categories[0].reference_ids).toEqual([])
expect(await serverRevision(seed.draftId)).toBe(seed.revision + 1)
await page.reload()
await selectTab(page, dict, 'findings')
await expect(items.filter({ hasText: 'Catégorie renommée' })).toBeVisible()
await expect(saveLine(page)).toHaveText(
revisionText(dict, seed.revision + 1),
)
await expect(
button(page, dict['editor.draft.recovery.restore']),
).toHaveCount(0)
})
test('delete with dependents: refused with the list; without, descendants named', async ({
page,
requests,
}) => {
const { actor } = await open(
page,
pointOf('p1', 'main', { cx: 500, cy: 400, r: 40 }, 'Point lié'),
)
requests.forbid(actor.account.email, actor.account.password)
// The category is used by the point: the dialog lists it and offers no deletion.
await openSection(page, dict, 'categories')
await page
.getByRole('listitem')
.filter({ has: page.locator('#category-cat-a-name-fr') })
.getByRole('button', { name: dict['editor.action.delete'] })
.click()
await expect(
dialog(page).getByText(
dict['editor.delete.blocked'].replace('{name}', 'Catégorie A'),
),
).toBeVisible()
await expect(dialog(page).getByText('Point lié')).toBeVisible()
await expect(
dialog(page).getByRole('button', { name: dict['editor.delete.confirm'] }),
).toHaveCount(0)
await dialog(page)
.getByRole('button', { name: dict['editor.delete.close'], exact: true })
.last()
.click()
// The zone is linked by the point as well: refused.
await selectTab(page, dict, 'findings')
const zone = page.getByTestId('finding-item').filter({ hasText: 'Zone A' })
await zone.first().click()
await page
.getByRole('button', { name: dict['editor.action.delete'] })
.click()
await expect(
dialog(page).getByText(
dict['editor.delete.blocked'].replace('{name}', 'Zone A'),
),
).toBeVisible()
await dialog(page)
.getByRole('button', { name: dict['editor.delete.close'], exact: true })
.last()
.click()
// The point goes first; the zone then deletes with its descendants named.
await showDrawing(page, dict)
await pickAnnotation(page, dict, /Point lié/)
await page
.getByTestId('annotation-properties')
.getByRole('button', { name: dict['editor.action.delete'] })
.click()
await dialog(page)
.getByRole('button', { name: dict['editor.delete.confirm'] })
.click()
await selectTab(page, dict, 'findings')
await zone.first().click()
await page
.getByRole('button', { name: dict['editor.action.delete'] })
.click()
await expect(
dialog(page).getByText(dict['editor.delete.descendants']),
).toBeVisible()
await expect(dialog(page).getByText('Dysfonction A')).toBeVisible()
await dialog(page)
.getByRole('button', { name: dict['editor.delete.confirm'] })
.click()
await expect(page.getByTestId('finding-item')).toHaveCount(0)
await expect(page.getByText(dict['editor.findings.empty'])).toBeVisible()
})
})