Files
faunosteo/apps/app/tests/unit/editor-sections.test.tsx
T
bchanot bc2dba7c14 feat(editor): four tabs, Annotations sections, references from the header
U1 Lot B1. Four tabs (Général, Annotations, Constats, Vérification); views,
categories and regions become full-width Annotations sections opened from the
overview panel; references move to a header-toggled panel (minimal, Lot D
completes it); « Aller à » goes through EditorTarget and the navigation hook.
EditorWorkspace owns the navigation; DraftHeader split in HeaderActions and
SaveLine; EditorTabs split in TabList and MoreTabs.

R-24, assertions removed or rewritten (file: old -> new):
unit
- editor-route.test: seven tab names -> four; « Plus » at 800 px with
  Références clicked -> no « Plus »; below 640 px five others -> Général,
  Constats, and Constats opens the findings tab; + references panel cases
- editor-route-recovery.test: tab Références + editor-tab-references label ->
  header button + editor-references-panel labelled by its heading
- editor-mode.test: small tier `more` of five -> [general, findings]
- editor-focus-request.test: {key,serial} -> {target,serial}; ReferencesTab and
  VertebraeTab -> ReferencesPanel and RegionsSection; issueTarget tab/key ->
  target place/section/key (vertebrae tab -> annotations/regions); consumed
  context (serial) -> (serial, outcome); annotation case adds heading focus
- editor-verification.test: onGoTo('annotations', key) -> navigate(targetOfKey
  (key), opener); props onSelectTab/onGoTo -> navigate
- editor-annotations-tab.test: props onSelectTab -> navigate + section props;
  no_category text « (onglet Général) » -> « (Annotations, section
  Catégories) »
- editor-tabs-general.test: categories cases render GeneralTab ->
  CategoriesSection(doc); + Général holds no categories editor
- editor-tabs-lists.test: tab imports -> panel and section; read-only
  references « no button » -> only « Fermer les références »
- editor-tabs-views, editor-drawing-upload, editor-repair.test: ViewsTab ->
  ViewsSection import, assertions kept; editor-findings.test: navigate prop
e2e
- support/editor selectTab: exact name -> pattern (error badge in the name);
  + place, openSection, showDrawing, backToDrawing, openReferences, TABS
- support/warm-up: seven tabs -> four + sections + references panel
- editor-access: seven-tab axe loops -> four tabs + three sections + panel
  (edit and read-only); narrow widths add panel overflow and axe
- editor-drawings: tab Vues -> openSection views; tab Annotations ->
  showDrawing
- editor-structures: tab Général (categories) -> openSection categories, axe
  label « general tab » -> « categories section »; tab Références ->
  openReferences/closeReferences; tab Vertèbres -> openSection regions; tab
  Annotations -> showDrawing
- editor-geometry: three tab Vues -> openSection views
- editor-equine: tab Général (categories add) -> openSection categories; five
  tabs loop -> two tabs + sections + panel; tab Annotations -> showDrawing
- editor-journey: tab Vues, tab Général (category), tab Annotations ->
  openSection views/categories, showDrawing; frozen axe scrolls to the header
- lan/trial-lan (not run): tab Vues -> Annotations tab + views entry

Verified: typecheck, lint, vitest 107 files / 1125 tests, whole shell suite on
the sandbox 151 passed, 49 skipped, 0 failed.
2026-11-06 20:25:35 +01:00

278 lines
9.4 KiB
TypeScript

/** U1 Lot B1: the Annotations sections, their entries, the view fallback, « Aller à » kept. */
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import {
act,
cleanup,
fireEvent,
render,
screen,
waitFor,
within,
} from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import AnnotationsTab from '@/components/editor/tabs/AnnotationsTab'
import {
AnnounceContext,
FocusConsumedContext,
type FocusRequest,
} from '@/editor/focusRequest'
import { targetOfKey } from '@/editor/navigation'
import { useLocaleStore } from '@/state/localeStore'
import { drawnText, insert, point } from '../helpers/editorFixtures'
import {
baseText,
openReady,
resetStore,
serverHas,
store,
} from '../helpers/editorHarness'
import { mountDraft, setWidth } from '../helpers/editorRoute'
vi.mock('@/lib/supabase', () => ({ getSupabaseClient: () => ({}) }))
vi.mock('@faunosteo/supabase', async (orig) => ({
...(await orig<typeof import('@faunosteo/supabase')>()),
getSheetVersion: vi.fn(),
downloadSheetDrawing: vi.fn(),
saveSheetDraft: vi.fn(),
getOfficialSheetAdmin: vi.fn(),
submitSheetReview: vi.fn(),
}))
beforeEach(() => {
useLocaleStore.setState({ locale: 'fr' })
const identity = { a: 1, b: 0, c: 0, d: 1, e: 0, f: 0 }
Object.defineProperty(window.SVGElement.prototype, 'getScreenCTM', {
configurable: true,
value: () => ({ ...identity, inverse: () => identity }),
})
})
afterEach(() => {
cleanup()
resetStore()
setWidth(1024)
})
const ready = () =>
screen.findByRole('heading', { level: 1, name: 'Brouillon, version 4' })
const entry = (name: string | RegExp) => screen.getByRole('button', { name })
const place = (name: string) =>
document.querySelector<HTMLElement>(`[data-place="${name}"]`)
describe('the overview entries', () => {
beforeEach(() => serverHas(baseText(), 3))
it.each([
['Gérer les vues', 'views', 'Vues'],
['Modifier les catégories', 'categories', 'Catégories'],
[/^Régions vertébrales/, 'regions', 'Régions vertébrales'],
] as const)(
'%s opens its section on the heading; « Retour au dessin » refocuses the entry',
async (label, section, title) => {
const user = userEvent.setup()
mountDraft()
await ready()
await user.click(entry(label))
const shown = place(`annotations.${section}`)!
expect(shown).toBeVisible()
expect(document.activeElement).toBe(
within(shown).getByRole('heading', { level: 2, name: title }),
)
expect(screen.getByRole('tab', { name: 'Annotations' })).toHaveAttribute(
'aria-selected',
'true',
)
expect(place('annotations.drawing')).toBeNull()
await user.click(screen.getByRole('button', { name: 'Retour au dessin' }))
expect(place('annotations.drawing')).toBeVisible()
expect(document.activeElement).toHaveAttribute(
'data-section-entry',
section,
)
},
)
it('the regions entry is there with no role code, counting the regions', async () => {
mountDraft()
await ready()
expect(entry('Régions vertébrales (0 région)')).toBeVisible()
})
it('announces the section reached, politely', async () => {
const user = userEvent.setup()
mountDraft()
await ready()
await user.click(entry('Gérer les vues'))
const live = document.querySelector('p[aria-live="polite"]')!
expect(live).toHaveTextContent('Annotations · Vues')
})
it('read-only: the entries read « Voir … » and still open the sections', async () => {
const user = userEvent.setup()
mountDraft({ width: 800 })
await ready()
expect(screen.queryByRole('button', { name: 'Gérer les vues' })).toBeNull()
await user.click(entry('Voir les catégories'))
expect(place('annotations.categories')).toBeVisible()
expect(
within(place('annotations.categories')!).queryByRole('textbox'),
).toBeNull()
await user.click(screen.getByRole('button', { name: 'Retour au dessin' }))
await user.click(entry('Voir les vues'))
expect(place('annotations.views')).toBeVisible()
})
})
const props = {
readOnly: false,
navigate: vi.fn(),
reloadSheet: vi.fn(),
section: 'drawing' as const,
onOpenSection: vi.fn(),
onBack: vi.fn(),
}
const detailView = {
kind: 'view',
value: {
kind: 'detail',
id: 'view-det',
name: { fr: 'Tête', en: 'Head' },
svg_asset_id: null,
view_box: { min_x: 10, min_y: 20, width: 40, height: 60 },
parent_view_id: 'view-main',
},
} as const
const consumed = vi.fn()
const announce = vi.fn()
const Drawing = ({ focus }: { focus?: FocusRequest }) => (
<FocusConsumedContext value={consumed}>
<AnnounceContext value={announce}>
<AnnotationsTab {...props} focus={focus} />
</AnnounceContext>
</FocusConsumedContext>
)
async function mountDrawing(text = drawnText()) {
consumed.mockReset()
announce.mockReset()
await openReady({ text })
const user = userEvent.setup()
const view = render(<Drawing />)
await waitFor(() =>
expect(
screen.getByTestId('annotation-canvas-drawing').querySelector('svg'),
).not.toBeNull(),
)
return { user, view }
}
const addPoint = async (user: ReturnType<typeof userEvent.setup>) => {
await waitFor(() =>
expect(
screen.getByRole('button', { name: 'Ajouter un point' }),
).toBeEnabled(),
)
await user.click(screen.getByRole('button', { name: 'Ajouter un point' }))
}
describe('the shown view disappears (undo)', () => {
async function onDetailView() {
const base = await mountDrawing()
act(
() => void store.getState().commit({ op: 'insert', element: detailView }),
)
await base.user.click(await screen.findByRole('button', { name: 'Tête' }))
return base
}
it('a pending point on it: back to the main view, the creation cleared', async () => {
const { user } = await onDetailView()
await addPoint(user)
expect(await screen.findByTestId('annotation-creation')).toBeInTheDocument()
act(() => void store.getState().undoStep())
await waitFor(() =>
expect(screen.queryByTestId('annotation-creation')).toBeNull(),
)
expect(screen.queryByRole('button', { name: 'Tête' })).toBeNull()
expect(screen.getByTestId('annotation-overview')).toBeInTheDocument()
expect(store.getState().previewState!.document.annotations).toHaveLength(0)
})
it('a tracing on it: the tracing is cleared too', async () => {
const { user } = await onDetailView()
await waitFor(() =>
expect(screen.getByRole('button', { name: 'Zone' })).toBeEnabled(),
)
await user.click(screen.getByRole('button', { name: 'Zone' }))
fireEvent.click(screen.getByTestId('annotation-canvas'), {
clientX: 20,
clientY: 30,
})
expect(screen.getByTestId('tracing-bar')).toBeInTheDocument()
act(() => void store.getState().undoStep())
await waitFor(() => expect(screen.queryByTestId('tracing-bar')).toBeNull())
})
it('dispatches nothing while the shown view still exists', async () => {
const { user } = await onDetailView()
await addPoint(user)
const panel = await screen.findByTestId('annotation-creation')
const element = point('anno-x', 30, 40, 2, 'view-det')
act(() => void store.getState().commit({ op: 'insert', element }))
expect(screen.getByTestId('annotation-creation')).toBe(panel)
})
})
describe('« Aller à » an annotation while something is in progress', () => {
const key = { kind: 'annotation', id: 'anno-a' } as const
const request = { target: targetOfKey(key), serial: 7 }
async function withProgress(
start: (user: ReturnType<typeof userEvent.setup>) => Promise<void>,
) {
const text = insert(drawnText(), point('anno-a', 50, 50, 5))
const { user, view } = await mountDrawing(text)
await start(user)
view.rerender(<Drawing focus={request} />)
return { consumed, announce }
}
it('a pending creation is kept: its panel takes the focus, the live region says why', async () => {
const { consumed, announce } = await withProgress(addPoint)
await waitFor(() => expect(consumed).toHaveBeenCalledWith(7, 'kept'))
expect(screen.getByTestId('annotation-creation')).toBeInTheDocument()
expect(document.activeElement).toHaveAttribute('data-creation-heading')
expect(announce).toHaveBeenCalledWith(
expect.stringContaining('création est en cours'),
)
expect(screen.queryByTestId('annotation-properties')).toBeNull()
})
it('an open zone tracing is kept: the bar takes the focus', async () => {
const { consumed, announce } = await withProgress(async (user) => {
await waitFor(() =>
expect(screen.getByRole('button', { name: 'Zone' })).toBeEnabled(),
)
await user.click(screen.getByRole('button', { name: 'Zone' }))
fireEvent.click(screen.getByTestId('annotation-canvas'), {
clientX: 20,
clientY: 20,
})
})
await waitFor(() => expect(consumed).toHaveBeenCalledWith(7, 'kept'))
expect(document.activeElement).toBe(screen.getByTestId('tracing-bar'))
expect(announce).toHaveBeenCalledWith(
expect.stringContaining('tracé est en cours'),
)
})
it('with nothing in progress the annotation is selected and its heading focused', async () => {
const { consumed } = await withProgress(async () => undefined)
await waitFor(() => expect(consumed).toHaveBeenCalledWith(7, 'found'))
await waitFor(() =>
expect(document.activeElement).toHaveAttribute('data-properties-heading'),
)
})
})