Files
faunosteo/apps/app/e2e/shell/editor-shell-journeys.spec.ts
T
bchanot 4499bc740c feat(editor): fifth tab « Références », citations panel from a finding
The reference library moves into a fifth editor tab (Général,
Annotations, Constats, Références, Vérification; under « Plus » below
640 px with Général and Constats). The header « Références » button is
removed. The side panel becomes the citations list of one finding,
opened only from a finding's trigger (owner GO 2026-11-12: never from a
family; the family keeps its inline list with « Retirer »). Selecting a
tab closes it; every close records one pending move applied after the
panel is gone, focus back to the trigger else the active tab button.
Vérification's reference issues land on the tab. e2e seed gains a
reference cited by « Constat A ».

Gates: typecheck, lint, test:run (app 1396), build, e2e:ui 251 passed;
e2e:shell 15 specs on db:sandbox (editor-equine never listed): 107
passed / 95 skipped / 2 failed (test remap dropped its edit), fixed and
rerun: editor-shell.spec 11 passed; full-row data guard: no
pre-existing row changed in any table. editor-equine.spec.ts helper
calls updated, not run.

## R-24 table (removed or rewritten assertions; old = fc3fec7 line, new = current file)

Unit tests:

| file:old line | old | new |
|---|---|---|
| editor-verification.test.tsx:87-96 | `navigate` called with target AND `expect.any(HTMLElement)` | called with the target only (opener dropped) |
| editor-verification.test.tsx:238-241 | `references[0]` path -> `{place:'references', citedBy:null}` | `{place:'tab', tab:'references', section:null}` |
| editor-verification.test.tsx:262-264 | `placeKey(references[9])` = `editor.place.references` | `editor.tab.references` |
| editor-navigation.test.ts:63 | targetOfKey reference -> `{place:'references', key, citedBy:null}` | `{place:'tab', tab:'references', section:null, key}` |
| editor-navigation.test.ts:80 | `referencesMounted` false at start | `citationsOf` null and `libraryReset` 0 |
| editor-navigation.test.ts:95-110 | go_to a reference opens the panel over the place | go_to a reference shows the Références tab with its focus request |
| editor-navigation.test.ts:112-122 | go_to a tab closes the panel (`references` object) | same, via `citationsOf` null |
| editor-navigation.test.ts:124-136 | select_tab keeps the panel | select_tab CLOSES the panel (P21), keeps section, no request |
| editor-navigation.test.ts:138-146 | `clear_cited_by` drops the filter | removed (action gone); replaced by `open_citations` refuses family/zone/view, `show_all_references` (closes, tab, reset bump), plain go_to leaves reset alone |
| editor-navigation.test.ts:160-175 | open/close references keep tab and section | open/close citations, same assertions on `citationsOf` |
| editor-mode.test.ts:100-109 | tabsFor four tabs, small more = general, findings | five tabs, small more = general, findings, references |
| editor-route.test.tsx:46,50 | TABS four, title « four tabs » | five |
| editor-route.test.tsx:139-146 | 640-1023 px four tabs | five tabs, tablist has `flex-wrap` |
| editor-route.test.tsx:149-161 | « Plus » lists Général, Constats | lists Général, Constats, Références |
| editor-route.test.tsx:168-190 | header button opens panel, ✕ returns focus to button | no header button, panel not mounted at start (full panel flow moved to editor-references-panel.test.tsx) |
| editor-route.test.tsx:192-206 | Escape closes, panel content kept for next opening | removed: the panel is no longer kept mounted (design choice 3); Escape/close covered in editor-references-panel + editor-escape |
| editor-route.test.tsx:208-218 | read-only: panel lists references, no edit control | read-only: the Références tab lists them, no textbox, no add button; plus new: tab keeps mounted when left |
| editor-tabs-lists.test.tsx:47,75,114,130 | render `ReferencesPanel` | render `ReferencesTab` |
| editor-tabs-lists.test.tsx:77 | selector `#reference-ref-a-url` | `#tab-reference-ref-a-url` |
| editor-tabs-lists.test.tsx:131-135 | read-only buttons = only « Fermer les références » | no button at all |
| editor-focus-request.test.tsx:166-171,200-202,346 | `ReferencesPanel` with `panel` props and focus | `ReferenceLibrary` with focus (same assertions) |
| editor-focus-request.test.tsx:226 | `ownedBy(ref,'citations')` is the request | `ownedBy(ref,'references')` is the request, `'citations'` undefined |
| editor-focus-request.test.tsx (Probe) | none | new: Vérification « Aller à » reference -> tab + focused row; reference path naming no element -> tab heading |
| editor-keep-alive.test.tsx:71,178-190 | add form survives closing/reopening the panel | survives leaving/returning to the Références tab (`#tab-reference-new-citation`) |
| editor-keep-alive.test.tsx:300-326 | « Aller à » without focus move commits Références text | a tab click without focus move commits it (one undo entry): « Aller à » is not reachable from the Références tab in R2.1 |
| editor-keep-alive.test.tsx:333-347 | Escape in panel reference field commits, panel hides | same, panel opened from a finding node, field `#panel-reference-ref-1-citation` |
| editor-keep-alive.test.tsx:350-363 | header toggle (no focus move) closes after committing | scrim click (no focus move) closes after committing |
| editor-keep-alive.test.tsx:425 | `referencesButton` click in the all-places sweep | `Références` added to the tab loop |
| editor-escape.test.tsx:218-227 | header button toggle, Escape on body closes panel, annotation selection kept | trigger-opened panel (A5), Escape closes it, `aria-expanded` back to false, selection kept after returning to Annotations |
| editor-escape.test.tsx:255-266 | Escape from tab row closes panel | same from the Constats tab button |
| editor-no-loss.test.tsx:146-153 | reference creation form, in the panel | in the Références tab, id `tab-reference-new-citation` |
| editor-no-loss.test.tsx:285-291 | focused header button survives crossing | focused tab button (Constats) survives crossing: no header button left |
| editor-no-loss.test.tsx:293-307 | references search in panel keeps focus/text | same in the Références tab body |
| editor-no-loss.test.tsx:390-400 | `everyPlace` ends by opening the panel | visits Références in the tab loop, no panel open |
| editor-no-loss-decisions.test.tsx:248-259 | open references panel holds the decision back | REMOVED: the panel exists only over Constats, decisions live in Annotations (hidden then); « a widening on another tab opens nothing » (same file) covers the withholding |
| editor-route-recovery.test.tsx:93-97 | recovery offer: header button opens panel, `aria-labelledby` | tab Références shows `editor-tab-references` labelled by `editor-references-title` |
| editor-references-panel.test.tsx (all) | header-button-driven panel tests incl. search, order, add, « Aller à » | split: panel tests (finding path only) stay in this file; library tests moved to new editor-references-tab.test.tsx (search matching, ↑/↓ only without search, counts, Ctrl+Z, read-only, « Aller à », add clears search, refused add keeps it); new: reset signal, ids unique with both mounted (P14), P6 fallback under « Plus » |

e2e (updated only, not run):

| file:old line | old | new |
|---|---|---|
| editor-shell.spec.ts:95-108 | panel keeps form text, no id repeats | Références tab keeps form text (`#tab-reference-new-citation`), ids unique with the panel open |
| editor-shell.spec.ts:121-142 | open panel leaves header and tab row clickable (incl. header Références button, add form) | `openCitations`; header button target and form steps dropped |
| editor-shell-journeys.spec.ts:113-123 | four tabs, `old` list includes « Références » | five tabs, « Références » removed from the old-layout list |
| editor-shell-journeys.spec.ts:246-249 | Aller à reference -> panel visible, close | `place('references')` visible, tab Références selected, row focus key, no close |
| editor-shell-layout.spec.ts:84-103 | overflow on four tabs + panel over drawing | five tabs + `openCitations`/`closeCitations` |
| editor-shell-layout.spec.ts:54-63 | local `goToTab` | removed, uses `openTab` |
| editor-shell-layout.spec.ts:140-158 | canvas width without/with panel over the drawing | E1: width measured before open and after a P21 switch to Annotations, asserted equal |
| editor-shell-layout.spec.ts:161-189 | axe on four tabs + open panel | five tabs + citations panel |
| editor-shell-layout.spec.ts:~255-310 | keyboard order began with `header` (the Références button) | `header` dropped from both orders (no focusable header control while the draft is clean); panel test selects Annotations before walking to `side` |
| editor-access.spec.ts:150-152,191-194,219-220 | axe/overflow with the panel at 320/375/768/800, 1024, read-only | same checks through `openCitations` (`showDrawing` calls dropped) |
| editor-shell-crossing.spec.ts:194-206 | references form with panel open, tab `annotations` | in the tab, focus expected on `editor-tab-references` |
| editor-shell-crossing.spec.ts:264-282 | panel open + add-form text across crossing | citations panel over a crossing, no typed-text step |
| editor-shell-crossing.spec.ts:~385-410 | decision withheld while panel open, Reprendre | REMOVED (state unreachable, see unit row) |
| editor-deselect.spec.ts:226-229 | Escape closes header-opened panel, selection kept | opened via Constats, Escape, back to Annotations, selection kept |
| editor-structures.spec.ts:80-122 | two references added, counts 2/1 | shape now holds `ref-a`: counts 3/2, `nth(1)` after move, saved list `['Référence A','Seconde référence']`, no panel |
| editor-equine.spec.ts:304-305,404-405 | openReferences/closeReferences | `openTab(page, dict, 'references')`: mis à jour, non exécuté, non vérifié |

Fix round 1: 1. e2e/shell/editor-shell.spec.ts « the open citations panel leaves the header and the tab row clickable »: before `openCitations`, the test now opens the Références tab and adds a reference through the library form (`#tab-reference-new-type` book, `#tab-reference-new-citation` « Smith 1999 », « Ajouter la référence »), so the draft is dirty and Save is enabled. All original assertion
2026-11-12 20:29:27 +01:00

276 lines
9.2 KiB
TypeScript

import { fr } from '@/i18n/fr'
import type { Page, TestInfo } from '@playwright/test'
import { expect, test } from '../support/browser'
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
import {
TABS,
draftTitle,
editorActor,
historyButton,
openEditor,
place,
pointOf,
pressAtBox,
saveLine,
seedDraft,
selectTab,
shapeWith,
standardShape,
UNSAVED_LINE,
} from '../support/editor'
// V1-2.6 U1 H (AC1, AC5, AC12, AC13, AC17): the journeys of the five-tab shell in a real
// browser. Every query is scoped to the visible place (`place()`) or goes by role, so a
// hidden, kept-mounted copy never answers.
const dict = fr
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
const active = (page: Page) => page.locator(':focus')
const nameField = (page: Page) => page.locator('#general-name-fr')
const ghost = 'absent'
/** A document that carries one issue of each kind « Aller à » can reach. */
function issueShape(document: Record<string, unknown>) {
standardShape(document)
const text = (value: string) => ({ fr: value, en: value })
const views = document.views as unknown[]
views.push({
id: 'detail-b',
kind: 'detail',
name: text('Détail B'),
svg_asset_id: null,
view_box: { min_x: 0, min_y: 0, width: 100, height: 80 },
parent_view_id: ghost,
})
const categories = document.categories as unknown[]
categories.push({ id: 'cat-a', name: text('Catégorie bis'), color: null })
document.vertebral_config = {
regions: [
{
code: 'T',
name: text('Thoracique'),
count: 5,
count_range: { min: 9, max: 3 },
},
],
}
const reference = (citation: string) => ({
id: 'ref-a',
type: 'book',
citation,
url: null,
doi: null,
})
document.references = [reference('Barone, Ostéologie'), reference('Bis')]
const point = pointOf(
'anno-free',
'main',
{ cx: 120, cy: 120, r: 6 },
'Point libre',
)
document.annotations = [
{ ...point, category_id: ghost, finding_zone_id: null },
]
const zones = document.finding_zones as {
categories: { children: { reference_ids: string[] }[] }[]
}[]
zones[0].categories[0].children[0].reference_ids = [ghost]
}
async function open(page: Page, shape = shapeWith()) {
const actor = await editorActor('fr')
const seed = await seedDraft(actor, { shape })
await openEditor(page, dict, actor, seed.sheetId)
return { ...seed, actor }
}
async function commitName(page: Page, value: string) {
await selectTab(page, dict, 'general')
await nameField(page).fill(value)
await nameField(page).press('Enter')
}
const unsaved = (page: Page, count: number) =>
expect(saveLine(page)).toHaveText(
dict[
count === 1
? 'editor.draft.status.unsaved_count_one'
: 'editor.draft.status.unsaved_count_other'
].replace('{count}', String(count)),
)
test.describe('editor shell journeys (H)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('five tabs and no tab of the old layout', async ({ page }) => {
await open(page)
const tabs = page.getByRole('tablist').getByRole('tab')
await expect(tabs).toHaveCount(5)
for (const [index, tab] of TABS.entries()) {
await expect(tabs.nth(index)).toHaveText(
new RegExp(`^${dict[`editor.tab.${tab}`]}`),
)
}
for (const old of ['Vues et illustrations', 'Vertèbres']) {
await expect(page.getByRole('tab', { name: old })).toHaveCount(0)
}
})
test('undo from another tab reverts the change, redo brings it back', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'general')
const original = await nameField(page).inputValue()
await commitName(page, 'Nom depuis Général')
await unsaved(page, 1)
await selectTab(page, dict, 'findings')
await historyButton(page, dict, 'undo').click()
await selectTab(page, dict, 'general')
await expect(nameField(page)).toHaveValue(original)
await historyButton(page, dict, 'redo').click()
await expect(nameField(page)).toHaveValue('Nom depuis Général')
await unsaved(page, 1)
})
test('text typed without a blur is committed by the header undo, which then reverts it', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'general')
const original = await nameField(page).inputValue()
await nameField(page).fill('Saisi, jamais validé')
// « Défaire » is aria-disabled until the typed text is committed: press at its box.
await pressAtBox(page, historyButton(page, dict, 'undo'))
await expect(nameField(page)).toHaveValue(original)
await expect(saveLine(page)).not.toHaveText(UNSAVED_LINE)
await historyButton(page, dict, 'redo').click()
await expect(nameField(page)).toHaveValue('Saisi, jamais validé')
})
test('a field left empty keeps its error: Tab to « Défaire », Enter, nothing undone, focus back', async ({
page,
}) => {
await open(page)
await commitName(page, 'Premier nom')
await nameField(page).fill('')
const undo = historyButton(page, dict, 'undo')
for (let step = 0; step < 40; step++) {
await page.keyboard.press('Shift+Tab')
if (await undo.evaluate((button) => button === document.activeElement))
break
}
await expect(undo).toBeFocused()
await expect(nameField(page)).toHaveAttribute('aria-invalid', 'true')
await page.keyboard.press('Enter')
await expect(nameField(page)).toBeFocused()
await unsaved(page, 1)
await expect(undo).toHaveAttribute('aria-disabled', 'false')
await expect(historyButton(page, dict, 'redo')).toHaveAttribute(
'aria-disabled',
'true',
)
})
test('Ctrl+Z outside a field undoes, inside a field it leaves the history alone', async ({
page,
}) => {
await open(page)
await commitName(page, 'Nom un')
await commitName(page, 'Nom deux')
await unsaved(page, 2)
await page
.getByRole('heading', { level: 1, name: draftTitle(dict) })
.click()
await page.keyboard.press('Control+z')
await unsaved(page, 1)
await expect(nameField(page)).toHaveValue('Nom un')
await nameField(page).click()
await nameField(page).pressSequentially(' suite')
await page.keyboard.press('Control+z')
// The field's own undo ran; the document history did not (a second step would show 0).
await unsaved(page, 1)
})
test('« Aller à » reaches the place and the element of each issue kind', async ({
page,
}) => {
await open(page, issueShape)
const goTo = (name: string) =>
place(page, 'verification')
.getByRole('button', { name: `Aller à ${name}`, exact: true })
.first()
.click()
const focusKey = (id: string) =>
expect(active(page)).toHaveAttribute('data-focus-key', new RegExp(id))
await selectTab(page, dict, 'verification')
await goTo('Détail B')
await expect(place(page, 'annotations.views')).toBeVisible()
await focusKey('detail-b')
await selectTab(page, dict, 'verification')
await goTo('Catégorie A')
await expect(place(page, 'annotations.categories')).toBeVisible()
await focusKey('cat-a')
await selectTab(page, dict, 'verification')
await goTo('Thoracique')
await expect(place(page, 'annotations.regions')).toBeVisible()
await focusKey('"T"')
await selectTab(page, dict, 'verification')
await goTo('Point libre')
await expect(place(page, 'annotations.drawing')).toBeVisible()
await expect(active(page)).toHaveAttribute(
'data-properties-heading',
'true',
)
await selectTab(page, dict, 'verification')
await goTo('Constat A')
await expect(place(page, 'findings')).toBeVisible()
await expect(place(page, 'findings').locator(':focus')).toHaveCount(1)
await selectTab(page, dict, 'verification')
await goTo('Barone, Ostéologie')
await expect(place(page, 'references')).toBeVisible()
await expect(
page.getByRole('tab', {
name: new RegExp(`^${dict['editor.tab.references']}`),
}),
).toHaveAttribute('aria-selected', 'true')
await focusKey('ref-a')
})
test('the save line goes from the count to « Enregistrement… » to the time and the revision', async ({
page,
context,
}) => {
const seed = await open(page)
await context.route('**/rest/v1/rpc/save_sheet_draft', async (route) => {
await new Promise((done) => setTimeout(done, 1500))
await route.fallback()
})
await commitName(page, 'Nom à enregistrer')
await unsaved(page, 1)
await page
.getByRole('button', { name: dict['common.save'], exact: true })
.click()
await expect(saveLine(page)).toHaveText(dict['editor.draft.status.saving'])
const timed = dict['editor.draft.status.saved_at']
.replace('{time}', '\\d\\d:\\d\\d')
.replace('{revision}', String(seed.revision + 1))
await expect(saveLine(page)).toHaveText(new RegExp(`^${timed}$`))
})
})