Files
faunosteo/apps/app/e2e/shell/editor-shell.spec.ts
T
bchanot ab51ea764d feat(editor): references side panel with filter, search and counts
Non-modal panel in a relative container after the tab row (scrim over the
tab panels, which are inert while it is open). Chip "Citées par" opened
from a finding's Citations block, "Tout afficher (N)", accent- and
case-insensitive search on citation, DOI and URL, "citée n fois" per card
(citationCounts, memoised TS read; the core stays the authority for
refused deletions). Up/down only without filter or search. "Aller à" a
reference clears a hiding search then focuses the card.

Rewritten assertions (R-24): editor-shell "the references panel keeps its
form text and no id repeats" closes the panel before reaching the inert
tab panels. Added: Chromium clickability at 1 024 and 1 280 px (top and
scrolled), editor-structures count and search, unit
editor-references-panel, editor-citations, navigation clear_cited_by.
2026-11-08 17:33:26 +01:00

229 lines
8.1 KiB
TypeScript

import { fr } from '@/i18n/fr'
import type { Page, TestInfo } from '@playwright/test'
import { expect, test } from '../support/browser'
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
import {
backToDrawing,
copyKeyOf,
storedCopy,
closeReferences,
editorActor,
openEditor,
openReferences,
openSection,
place,
pointOf,
seedDraft,
selectTab,
shapeWith,
showDrawing,
} from '../support/editor'
// V1-2.6 U1 B2a: tabs, Annotations sections and the references panel stay mounted. What
// was typed, the canvas zoom and the focus survive a change of place; focus lands on a
// named element, never on `body`. happy-dom does not refuse focus on hidden elements, so
// the focus rules are checked here with `document.activeElement`.
const dict = fr
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
async function open(page: Page) {
const actor = await editorActor('fr')
const free = {
...pointOf('anno-free', 'main', { cx: 120, cy: 120, r: 6 }, 'Point libre'),
finding_zone_id: null,
}
const seed = await seedDraft(actor, { shape: shapeWith(free) })
await openEditor(page, dict, actor, seed.sheetId)
return { ...seed, actor }
}
const active = (page: Page) => page.locator(':focus')
const layerTransform = (page: Page) =>
page
.getByTestId('annotation-canvas')
.evaluate((box) => (box.firstElementChild as HTMLElement).style.transform)
test.describe('editor shell, kept places (B2a)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('the category form text and the zoom survive tab and section changes', async ({
page,
}) => {
await open(page)
await openSection(page, dict, 'categories')
await page.locator('#category-new-fr').fill('Brouillon')
await selectTab(page, dict, 'general')
const hidden = page.locator('[data-place="annotations.categories"]')
await expect(hidden).toHaveCount(1)
await expect(hidden).toBeHidden()
await selectTab(page, dict, 'annotations')
await expect(page.locator('#category-new-fr')).toHaveValue('Brouillon')
await backToDrawing(page, dict)
await page
.getByRole('button', { name: dict['catalogue.zoom.in'], exact: true })
.click()
const zoomed = await layerTransform(page)
expect(zoomed).not.toContain('scale(1)')
await selectTab(page, dict, 'findings')
await showDrawing(page, dict)
expect(await layerTransform(page)).toBe(zoomed)
})
test('the references panel keeps its form text and no id repeats', async ({
page,
}) => {
await open(page)
await openReferences(page, dict)
await page.locator('#reference-new-citation').fill('Smith 1999')
await closeReferences(page, dict)
await openReferences(page, dict)
await expect(page.locator('#reference-new-citation')).toHaveValue(
'Smith 1999',
)
// The tab panels are inert while the panel is open (AC3): close it to reach them.
await closeReferences(page, dict)
for (const tab of ['general', 'findings', 'verification']) {
await selectTab(page, dict, tab)
}
for (const section of ['views', 'categories', 'regions'] as const) {
await openSection(page, dict, section)
}
const repeated = await page.evaluate(() => {
const ids = [...document.querySelectorAll('[id]')].map((e) => e.id)
return ids.filter((id, i) => ids.indexOf(id) !== i)
})
expect(repeated).toEqual([])
})
for (const width of [1024, 1280]) {
test(`the open references panel leaves the header and the tab row clickable at ${width} px`, async ({
page,
}) => {
await page.setViewportSize({ width, height: 800 })
await open(page)
await openReferences(page, dict)
await page.locator('#reference-new-type').selectOption('book')
await page.locator('#reference-new-citation').fill('Smith 1999')
await page
.getByRole('button', { name: dict['editor.reference.add'] })
.click()
const header = page.locator('main header').first()
const tabs = page.getByRole('tablist')
const panel = place(page, 'references')
const targets = [
page.getByRole('button', { name: dict['common.save'], exact: true }),
page.getByRole('button', {
name: dict['editor.references.open'],
exact: true,
}),
page.getByRole('tab', {
name: new RegExp(`^${dict['editor.tab.findings']}`),
}),
]
for (const scrolled of [false, true]) {
await page.evaluate((y) => window.scrollTo(0, y), scrolled ? 400 : 0)
for (const target of targets) await target.click({ trial: true })
const box = await panel.boundingBox()
for (const above of [header, tabs]) {
const other = await above.boundingBox()
expect(box!.y).toBeGreaterThanOrEqual(other!.y + other!.height - 1)
}
}
})
}
test('focus lands on a named element after a tab click, « Retour au dessin » and « Aller à »', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'findings')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
await openSection(page, dict, 'categories')
await backToDrawing(page, dict)
await expect(active(page)).toHaveAttribute(
'data-section-entry',
'categories',
)
await selectTab(page, dict, 'verification')
await page
.getByRole('button', { name: 'Aller à Point libre' })
.first()
.click()
await expect(place(page, 'annotations.drawing')).toBeVisible()
await expect(active(page)).toHaveAttribute(
'data-properties-heading',
'true',
)
})
test('arrowing back onto a tab keeps the focus on the tab', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'annotations')
await page
.getByRole('tab', { name: dict['editor.tab.annotations'] })
.focus()
await page.keyboard.press('ArrowRight')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
await page.keyboard.press('ArrowLeft')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
})
})
// V1-2.6 U1 B2b: a 1 024 px crossing never loses typed input.
test.describe('editor shell, width crossing (B2b)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('a field typed without a blur is committed before the crossing and the copy is written', async ({
page,
}) => {
const { actor, draftId } = await open(page)
await selectTab(page, dict, 'general')
const field = page.locator('#general-name-fr')
await field.click()
await field.fill('Nom saisi sans quitter le champ')
const key = copyKeyOf(actor.account.id, draftId)
expect(await storedCopy(page, key)).toBeNull()
await page.setViewportSize({ width: 800, height: 900 })
await expect(page.locator('#general-name-fr')).toHaveText(
'Nom saisi sans quitter le champ',
)
await expect.poll(() => storedCopy(page, key)).not.toBeNull()
})
test('the category form text is hidden below 1 024 px and comes back on widening', async ({
page,
}) => {
await open(page)
await openSection(page, dict, 'categories')
const field = page.locator('#category-new-fr')
await field.fill('Brouillon')
await page.setViewportSize({ width: 800, height: 900 })
await expect(field).toBeHidden()
await expect(page.locator(':focus')).toHaveCount(0)
await page.setViewportSize({ width: 1280, height: 900 })
await expect(field).toBeVisible()
await expect(field).toHaveValue('Brouillon')
})
})