Final review M-3, M-4, M-5, M-6 in the sandbox suites: - editor-annotations (A14 at 1024, 1180, 1280 px): « Défaire » on the line hit-tested 44 px tall below xl and 36 px from xl, its pill 36 px; pressed under expectNoShift, the drawing then has the focus. - editor-geometry: the same refused move twice under expectNoShift is a new alert pill. - editor-zones: « Redessiner » takes the focus back after a close and a cancel; with the strip scrolled out and the focus on body, the close returns it with no scroll. Tests: no assertion removed.
302 lines
11 KiB
TypeScript
302 lines
11 KiB
TypeScript
import { fr } from '@/i18n/fr'
|
||
import type { Page, TestInfo } from '@playwright/test'
|
||
import { expect, expectAccessible, test } from '../support/browser'
|
||
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
|
||
import {
|
||
clientOf,
|
||
editorActor,
|
||
equineDrawing,
|
||
equineShape,
|
||
openEditor,
|
||
pickAnnotation,
|
||
seedDraft,
|
||
selectionTag,
|
||
shownPoints,
|
||
toolButton,
|
||
scrollToTop,
|
||
} from '../support/editor'
|
||
import { expectNoShift } from '../support/layout'
|
||
|
||
// V1-2.6 U2 Task 5: a zone edited on the drawing, « Vertèbres thoraciques » of the equine
|
||
// draft on its own drawing: vertex drag, « + », « − », zone drag, redraw accepted and
|
||
// refused, each undone, nothing around the drawing moving (A14); the topmost rule.
|
||
|
||
const dict = fr
|
||
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
|
||
const THORACIC = /Vertèbres thoraciques/
|
||
// The side panel's content may change (U2 Task 6 moves it into a dialog).
|
||
|
||
async function openThoracic(page: Page) {
|
||
await page.setViewportSize({ width: 1280, height: 800 })
|
||
const actor = await editorActor('fr')
|
||
const seed = await seedDraft(actor, {
|
||
drawing: equineDrawing(),
|
||
shape: equineShape,
|
||
})
|
||
await openEditor(page, dict, actor, seed.sheetId)
|
||
await expect(toolButton(page, dict, 'point')).toBeEnabled()
|
||
return actor
|
||
}
|
||
|
||
const handle = (page: Page, name: string) =>
|
||
page.getByRole('button', { name, exact: true })
|
||
const line = (page: Page) => page.getByTestId('gesture-line')
|
||
const button = (page: Page, key: string) =>
|
||
page.getByRole('button', { name: dict[key], exact: true })
|
||
const undo = (page: Page) => page.keyboard.press('Control+z')
|
||
|
||
/** An undo back to `points`, nothing around the drawing moving (A14). */
|
||
async function undoTo(
|
||
page: Page,
|
||
points: () => Promise<unknown>,
|
||
expected: unknown,
|
||
) {
|
||
await expectNoShift(page, async () => {
|
||
await undo(page)
|
||
await expect.poll(points).toEqual(expected)
|
||
})
|
||
}
|
||
|
||
/** A press and release at the centre of a handle's hit shape. */
|
||
async function pressHandle(page: Page, name: string) {
|
||
const box = (await handle(page, name).locator('[data-handle]').boundingBox())!
|
||
await page.mouse.click(box.x + box.width / 2, box.y + box.height / 2)
|
||
}
|
||
|
||
/** A mouse drag between two drawing points, past the slop. */
|
||
async function dragDrawing(
|
||
page: Page,
|
||
from: { x: number; y: number },
|
||
to: { x: number; y: number },
|
||
) {
|
||
const start = await clientOf(page, from.x, from.y)
|
||
const end = await clientOf(page, to.x, to.y)
|
||
await page.mouse.move(start.x, start.y)
|
||
await page.mouse.down()
|
||
await page.mouse.move(end.x, end.y, { steps: 6 })
|
||
await page.mouse.up()
|
||
}
|
||
|
||
async function clickAt(page: Page, x: number, y: number) {
|
||
const at = await clientOf(page, x, y)
|
||
await page.mouse.click(at.x, at.y)
|
||
}
|
||
|
||
const count = async (page: Page) => (await shownPoints(page)).length
|
||
|
||
test.describe('editor zones on the drawing (U2 Task 5)', () => {
|
||
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
||
test.beforeEach(async ({ context }, info) => {
|
||
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
||
await routeToSandbox(context)
|
||
})
|
||
test.afterEach(async ({ context }) => {
|
||
await dropLateReplays(context)
|
||
})
|
||
|
||
test('Thoraciques: vertex drag, « + », « − », zone drag, each undone', async ({
|
||
page,
|
||
requests,
|
||
}) => {
|
||
const actor = await openThoracic(page)
|
||
requests.forbid(actor.account.email, actor.account.password)
|
||
await pickAnnotation(page, dict, THORACIC)
|
||
// The row sits low in the equine list: the click left the drawing out of view.
|
||
await scrollToTop(page)
|
||
await expect(selectionTag(page)).toContainText('Vertèbres thoraciques')
|
||
await expect(handle(page, 'Sommet 9')).toBeAttached()
|
||
// R-18: at fit zoom some segments are too short for their « + ».
|
||
await expect(page.getByTestId('edit-strip-notice')).toContainText(
|
||
dict['editor.annotations.strip.zoom_hint'],
|
||
)
|
||
await expectAccessible(page, 'a selected zone: vertices and « + »')
|
||
const stored = await shownPoints(page)
|
||
|
||
// A vertex dragged: one commit, the vertex chosen, then undone.
|
||
await expectNoShift(page, async () => {
|
||
await dragDrawing(page, { x: 1103, y: 558.9 }, { x: 1103, y: 620 })
|
||
await expect(line(page)).toContainText(
|
||
dict['editor.annotations.message.vertex_moved'],
|
||
)
|
||
})
|
||
const [, moved] = await shownPoints(page)
|
||
expect(Math.abs(moved[1] - 620)).toBeLessThan(3)
|
||
await undoTo(page, () => shownPoints(page), stored)
|
||
|
||
// « + » on the segment from vertex 2: a vertex added and chosen, then undone.
|
||
await expectNoShift(page, async () => {
|
||
await pressHandle(page, 'Ajouter un sommet après le sommet 2')
|
||
await expect(line(page)).toContainText(
|
||
dict['editor.annotations.message.vertex_added'],
|
||
)
|
||
})
|
||
expect(await count(page)).toBe(10)
|
||
await expect(page.getByTestId('edit-strip-detail')).toContainText(
|
||
'sommet 3 choisi',
|
||
)
|
||
await undoTo(page, () => count(page), 9)
|
||
|
||
// « − » on the chosen vertex 3, then undone.
|
||
await expectNoShift(page, async () => {
|
||
await pressHandle(page, 'Sommet 3')
|
||
await expect(page.getByTestId('edit-strip-detail')).toContainText(
|
||
'sommet 3 choisi',
|
||
)
|
||
})
|
||
await expectNoShift(page, async () => {
|
||
await pressHandle(page, 'Retirer le sommet 3')
|
||
await expect(line(page)).toContainText(
|
||
dict['editor.annotations.message.vertex_removed'],
|
||
)
|
||
})
|
||
expect(await count(page)).toBe(8)
|
||
await undoTo(page, () => shownPoints(page), stored)
|
||
|
||
// The interior dragged by the mouse moves the zone as a block, then undone.
|
||
await expectNoShift(page, async () => {
|
||
await dragDrawing(page, { x: 914, y: 498 }, { x: 954, y: 538 })
|
||
await expect(line(page)).toContainText(
|
||
dict['editor.annotations.message.moved.zone'],
|
||
)
|
||
})
|
||
const [first] = await shownPoints(page)
|
||
expect(Math.abs(first[0] - (stored[0][0] + 40))).toBeLessThan(3)
|
||
await undoTo(page, () => shownPoints(page), stored)
|
||
})
|
||
|
||
test('Thoraciques: « Désélectionner » commits the arrow steps pending on a vertex', async ({
|
||
page,
|
||
requests,
|
||
}) => {
|
||
const actor = await openThoracic(page)
|
||
requests.forbid(actor.account.email, actor.account.password)
|
||
await pickAnnotation(page, dict, THORACIC)
|
||
const [, second] = await shownPoints(page)
|
||
await handle(page, 'Sommet 2').focus()
|
||
await page.keyboard.press('ArrowDown')
|
||
// Not under expectNoShift: the button returns the focus to the list row, which
|
||
// scrolls it into view by design.
|
||
await page
|
||
.getByTestId('edit-strip')
|
||
.getByRole('button', { name: dict['editor.annotations.deselect'] })
|
||
.click()
|
||
await expect(line(page)).toContainText(
|
||
dict['editor.annotations.message.vertex_moved'],
|
||
)
|
||
await pickAnnotation(page, dict, THORACIC)
|
||
const [, after] = await shownPoints(page)
|
||
expect(after[1]).toBeGreaterThan(second[1])
|
||
})
|
||
|
||
test('Thoraciques: redraw accepted, then refused, the old outline kept meanwhile', async ({
|
||
page,
|
||
requests,
|
||
}) => {
|
||
const actor = await openThoracic(page)
|
||
requests.forbid(actor.account.email, actor.account.password)
|
||
await pickAnnotation(page, dict, THORACIC)
|
||
// The row sits low in the equine list: the click left the drawing out of view.
|
||
await scrollToTop(page)
|
||
const stored = await shownPoints(page)
|
||
|
||
// Accepted: four clicks, « Fermer le tracé », one commit, every property kept.
|
||
await expectNoShift(page, () =>
|
||
button(page, 'editor.annotations.redraw').click(),
|
||
)
|
||
for (const [x, y] of [
|
||
[850, 440],
|
||
[1100, 470],
|
||
[1100, 560],
|
||
[850, 545],
|
||
])
|
||
await expectNoShift(page, () => clickAt(page, x, y))
|
||
await expect(page.getByTestId('overlay-old-place')).toBeAttached()
|
||
await expectNoShift(page, async () => {
|
||
await button(page, 'editor.annotations.trace_close').click()
|
||
await expect(line(page)).toContainText(
|
||
dict['editor.annotations.message.redrawn.zone'],
|
||
)
|
||
})
|
||
// M-6: the focus is back on « Redessiner », which started the redraw.
|
||
await expect(button(page, 'editor.annotations.redraw')).toBeFocused()
|
||
await expect(selectionTag(page)).toContainText('Vertèbres thoraciques')
|
||
expect(await count(page)).toBe(4)
|
||
await undoTo(page, () => shownPoints(page), stored)
|
||
|
||
// Refused: a sliver; the tracing stays open with the core's message, then cancelled.
|
||
await expectNoShift(page, () =>
|
||
button(page, 'editor.annotations.redraw').click(),
|
||
)
|
||
for (const [x, y] of [
|
||
[900, 450],
|
||
[1100, 452],
|
||
[1300, 455],
|
||
])
|
||
await expectNoShift(page, () => clickAt(page, x, y))
|
||
await expectNoShift(page, async () => {
|
||
await button(page, 'editor.annotations.trace_close').click()
|
||
await expect(page.getByTestId('edit-strip-title')).toHaveText(
|
||
dict['editor.annotations.strip.close_refused'],
|
||
)
|
||
})
|
||
await expect(button(page, 'editor.annotations.trace_close')).toBeVisible()
|
||
await expectNoShift(page, () =>
|
||
button(page, 'editor.annotations.trace_cancel').click(),
|
||
)
|
||
await expect.poll(() => shownPoints(page)).toEqual(stored)
|
||
await expect(button(page, 'editor.annotations.redraw')).toBeFocused()
|
||
|
||
// M-6: the strip out of view, the focus on body, the close pressed in place (no scroll
|
||
// into view): the focus goes back to « Redessiner » without a scroll (A14).
|
||
await expectNoShift(page, () =>
|
||
button(page, 'editor.annotations.redraw').click(),
|
||
)
|
||
for (const [x, y] of [
|
||
[850, 440],
|
||
[1100, 470],
|
||
[1100, 560],
|
||
[850, 545],
|
||
])
|
||
await expectNoShift(page, () => clickAt(page, x, y))
|
||
const strip = (await page.getByTestId('edit-strip').boundingBox())!
|
||
await page.evaluate((by) => window.scrollBy(0, by), strip.y + strip.height)
|
||
await page.evaluate(() => (document.activeElement as HTMLElement).blur())
|
||
await expectNoShift(page, async () => {
|
||
await button(page, 'editor.annotations.trace_close').dispatchEvent(
|
||
'click',
|
||
)
|
||
await expect(line(page)).toContainText(
|
||
dict['editor.annotations.message.redrawn.zone'],
|
||
)
|
||
})
|
||
await expect(button(page, 'editor.annotations.redraw')).toBeFocused()
|
||
})
|
||
|
||
test('a click inside Thoraciques on C7-T1 selects the point drawn on top', async ({
|
||
page,
|
||
requests,
|
||
}) => {
|
||
const actor = await openThoracic(page)
|
||
requests.forbid(actor.account.email, actor.account.password)
|
||
await clickAt(page, 865, 528)
|
||
await expect(selectionTag(page)).toContainText('C7-T1')
|
||
|
||
// Thoraciques selected: zoomed at C7-T1 so that its vertex handles leave room, a click
|
||
// inside both shapes still selects the point (the selection's interior comes after).
|
||
await pickAnnotation(page, dict, THORACIC)
|
||
// The row sits low in the equine list: the click left the drawing out of view.
|
||
await scrollToTop(page)
|
||
const at = await clientOf(page, 870, 515)
|
||
await page.mouse.move(at.x, at.y)
|
||
await page.keyboard.down('Control')
|
||
for (let notch = 0; notch < 14; notch++) await page.mouse.wheel(0, -100)
|
||
await page.keyboard.up('Control')
|
||
// R-18: zoomed enough, every « + » shows and the zoom line is gone.
|
||
await expect(page.getByTestId('edit-strip-notice')).not.toContainText(
|
||
dict['editor.annotations.strip.zoom_hint'],
|
||
)
|
||
await clickAt(page, 870, 515)
|
||
await expect(selectionTag(page)).toContainText('C7-T1')
|
||
})
|
||
})
|