Files
faunosteo/apps/app/e2e/shell/editor-shell.spec.ts
T
bchanot 3baac4dbb5 feat(editor): search, sort, count and add in the Références tab
Search (citation, DOI, URL) with « Effacer la recherche » and Escape;
« Trier par » sheet order, citation (locale collator), citation count,
type (business order); every sort stable on stored order, display only:
document, stored order, ids and history unchanged (unit + e2e). Count
« {n} références » / « {n} sur {total} » counts matching references
only. « Monter » / « Descendre » only in sheet order without search
(A1). « Ajouter une référence » resets search and sort and appends a
draft tile in edit; a tile in edit stays pinned while sorted or
searched; tile state pruned of absent ids. Reset path ready for « Tout
afficher » (R2.4).

Gates: typecheck, lint, test:run (app 1452), build, e2e:ui 251;
e2e:shell 16 specs on db:sandbox (editor-equine never listed): 115
passed / 102 skipped / 2 failed: editor-structures (test-side, fixed,
rerun with editor-references 12 passed / 11 skipped) and admin.spec A0
« Target crashed » during axe on the rights screen (not R2: that
screen renders every grant, 1 282 accumulated e2e fixtures; reported as
an open risk); full-row guard: no pre-existing row changed in any table.

## R-24 (removed or rewritten assertions)
| file | old | new |
|---|---|---|
| editor-references-tab.test.tsx | `#tab-reference-new-citation` present on load | null until « Ajouter une référence » |
| same | no match text « Aucune référence ne correspond. » | notice « Aucune référence ne contient « zzz ». » |
| same | add: form always visible, add clears the search, `getByText('Nouvelle source')` | click « Ajouter une référence » first; new tile header open, focused, search empty, 4 tiles |
| same | « a refused add keeps the search » | REMOVED (P24: add resets the search at once); replaced by « draft opens with citation focused, refused add keeps the draft, no write » |
| editor-tabs-lists.test.tsx | add form directly | click « Ajouter une référence » before the form assertions (same assertions after) |
| editor-keep-alive.test.tsx | form survives tab round trip | same, after opening the draft |
| editor-no-loss.test.tsx | reference form keeps typed text | same, after opening the draft |
| e2e editor-shell.spec (2), editor-shell-crossing.spec, editor-structures.spec | fill `#tab-reference-new-*` directly; `getByText(citation)` visible | open the draft first; structures asserts the new header is focused |
| e2e editor-references.spec keyboard walk | focus search, Tab reaches header 0 | focus « Ajouter une référence » (search, sort, add precede the headers) |
Other readers of `editor.reference.add`/new ids: grep of src, tests, e2e incl. editor-equine found none left unlisted. editor-equine is not affected ("updated, not run": nothing to update).

## i18n (fr / en)
Added: `editor.references.add` Ajouter une référence / Add a reference; `add_help` Type et citation obligatoires. / Type and citation required.; `clear_search` Effacer la recherche / Clear the search; `sort_by` Trier par / Sort by; `sort.sheet|citation|count|type` Ordre de la fiche, Citation (A → Z), Nombre de citations, Type / Sheet order, Citation (A → Z), Number of citations, Type; `count_one|other` {count} référence(s) / reference(s); `count_of_one|other` {count} référence(s) sur {total} / {count} reference(s) of {total}; `reorder_hint` Pour réorganiser, affichez l'ordre de la fiche sans recherche. / To reorder, show the sheet order without a search.; `no_result` Aucune référence ne contient « {q} ». / No reference contains “{q}”.; `no_result_scope` La recherche porte sur la citation, le DOI et l'URL. / The search covers the citation, the DOI and the URL. (REVUE sentence split in two keys so the first half is bold).
Changed: none. Removed: none (`editor.references.no_match` kept, the panel's EmptyLine still uses it).
2026-11-12 21:18:56 +01:00

347 lines
13 KiB
TypeScript

import { fr } from '@/i18n/fr'
import type { Locator, Page, TestInfo } from '@playwright/test'
import { expect, test } from '../support/browser'
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
import {
backToDrawing,
copyKeyOf,
storedCopy,
closeCitations,
editorActor,
openEditor,
openCitations,
openSection,
pickAnnotation,
place,
pointOf,
seedDraft,
selectTab,
shapeWith,
showDrawing,
historyButton,
openTab,
} from '../support/editor'
// V1-2.6 U1 B2a: tabs, Annotations sections and the Références tab stay mounted. What
// was typed, the canvas zoom and the focus survive a change of place; focus lands on a
// named element, never on `body`. happy-dom does not refuse focus on hidden elements, so
// the focus rules are checked here with `document.activeElement`.
const dict = fr
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
async function open(page: Page) {
const actor = await editorActor('fr')
const free = {
...pointOf('anno-free', 'main', { cx: 120, cy: 120, r: 6 }, 'Point libre'),
finding_zone_id: null,
}
const seed = await seedDraft(actor, { shape: shapeWith(free) })
await openEditor(page, dict, actor, seed.sheetId)
return { ...seed, actor }
}
/** The button's centre hits the button itself: no panel or scrim covers it (any state). */
const hitsItself = (button: Locator) =>
button.evaluate((element) => {
const box = element.getBoundingClientRect()
const hit = document.elementFromPoint(
box.x + box.width / 2,
box.y + box.height / 2,
)
return hit !== null && element.contains(hit)
})
const active = (page: Page) => page.locator(':focus')
const layerTransform = (page: Page) =>
page
.getByTestId('annotation-canvas')
.evaluate((box) => (box.firstElementChild as HTMLElement).style.transform)
test.describe('editor shell, kept places (B2a)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('the category form text and the zoom survive tab and section changes', async ({
page,
}) => {
await open(page)
await openSection(page, dict, 'categories')
await page.locator('#category-new-fr').fill('Brouillon')
await selectTab(page, dict, 'general')
const hidden = page.locator('[data-place="annotations.categories"]')
await expect(hidden).toHaveCount(1)
await expect(hidden).toBeHidden()
await selectTab(page, dict, 'annotations')
await expect(page.locator('#category-new-fr')).toHaveValue('Brouillon')
await backToDrawing(page, dict)
await page
.getByRole('button', { name: dict['catalogue.zoom.in'], exact: true })
.click()
const zoomed = await layerTransform(page)
expect(zoomed).not.toContain('scale(1)')
await selectTab(page, dict, 'findings')
await showDrawing(page, dict)
expect(await layerTransform(page)).toBe(zoomed)
})
test('the Références tab keeps its form text and no id repeats, panel open included', async ({
page,
}) => {
await open(page)
await openTab(page, dict, 'references')
await page
.getByRole('button', { name: dict['editor.references.add'] })
.click()
await page.locator('#tab-reference-new-citation').fill('Smith 1999')
await openTab(page, dict, 'general')
await openTab(page, dict, 'references')
await expect(page.locator('#tab-reference-new-citation')).toHaveValue(
'Smith 1999',
)
for (const tab of ['general', 'findings', 'verification']) {
await selectTab(page, dict, tab)
}
for (const section of ['views', 'categories', 'regions'] as const) {
await openSection(page, dict, section)
}
// The tab bodies stay mounted under the panel: its card ids carry their own prefix.
await openCitations(page, dict, 'Constat A')
const repeated = await page.evaluate(() => {
const ids = [...document.querySelectorAll('[id]')].map((e) => e.id)
return ids.filter((id, i) => ids.indexOf(id) !== i)
})
expect(repeated).toEqual([])
await closeCitations(page, dict)
})
for (const width of [1024, 1280]) {
test(`the open citations panel leaves the header and the tab row clickable at ${width} px`, async ({
page,
}) => {
await page.setViewportSize({ width, height: 800 })
await open(page)
// An edit first, so « Enregistrer » is enabled: a reference added in its tab.
await openTab(page, dict, 'references')
await page
.getByRole('button', { name: dict['editor.references.add'] })
.click()
await page.locator('#tab-reference-new-type').selectOption('book')
await page.locator('#tab-reference-new-citation').fill('Smith 1999')
await page
.getByRole('button', { name: dict['editor.reference.add'] })
.click()
await openCitations(page, dict, 'Constat A')
const header = page.locator('main header').first()
const tabs = page.getByRole('tablist')
const panel = place(page, 'citations')
const targets = [
page.getByRole('button', { name: dict['common.save'], exact: true }),
page.getByRole('tab', {
name: new RegExp(`^${dict['editor.tab.findings']}`),
}),
]
for (const scrolled of [false, true]) {
await page.evaluate((y) => window.scrollTo(0, y), scrolled ? 400 : 0)
for (const target of targets) await target.click({ trial: true })
// « Défaire » / « Refaire » may be aria-disabled (a trial click would wait).
for (const kind of ['undo', 'redo'] as const) {
const button = historyButton(page, dict, kind)
await button.scrollIntoViewIfNeeded()
expect(await hitsItself(button)).toBe(true)
}
const box = await panel.boundingBox()
for (const above of [header, tabs]) {
const other = await above.boundingBox()
expect(box!.y).toBeGreaterThanOrEqual(other!.y + other!.height - 1)
}
}
})
}
test('focus lands on a named element after a tab click, « Retour au dessin » and « Aller à »', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'findings')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
await openSection(page, dict, 'categories')
await backToDrawing(page, dict)
await expect(active(page)).toHaveAttribute(
'data-section-entry',
'categories',
)
await selectTab(page, dict, 'verification')
await page
.getByRole('button', { name: 'Aller à Point libre' })
.first()
.click()
await expect(place(page, 'annotations.drawing')).toBeVisible()
await expect(active(page)).toHaveAttribute(
'data-properties-heading',
'true',
)
})
test('arrowing back onto a tab keeps the focus on the tab', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'annotations')
await page
.getByRole('tab', { name: dict['editor.tab.annotations'] })
.focus()
await page.keyboard.press('ArrowRight')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-findings')
await page.keyboard.press('ArrowLeft')
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
})
})
// V1-2.6 U1 B2b: a 1 024 px crossing never loses typed input.
test.describe('editor shell, width crossing (B2b)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('a field typed without a blur is committed before the crossing and the copy is written', async ({
page,
}) => {
const { actor, draftId } = await open(page)
await selectTab(page, dict, 'general')
const field = page.locator('#general-name-fr')
await field.click()
await field.fill('Nom saisi sans quitter le champ')
const key = copyKeyOf(actor.account.id, draftId)
expect(await storedCopy(page, key)).toBeNull()
await page.setViewportSize({ width: 800, height: 900 })
await expect(page.locator('#general-name-fr')).toHaveText(
'Nom saisi sans quitter le champ',
)
await expect.poll(() => storedCopy(page, key)).not.toBeNull()
})
test('the category form text is hidden below 1 024 px and comes back on widening', async ({
page,
}) => {
await open(page)
await openSection(page, dict, 'categories')
const field = page.locator('#category-new-fr')
await field.fill('Brouillon')
await page.setViewportSize({ width: 800, height: 900 })
await expect(field).toBeHidden()
// The field's focus went to the shown tab, never to `body`.
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
await page.setViewportSize({ width: 1280, height: 900 })
await expect(field).toBeVisible()
await expect(field).toHaveValue('Brouillon')
})
})
// V1-2.6 U1 F (AC9): in the editor the sidebar shows from 1 280 px only; below, the top
// bar's menu button opens the drawer, which stays open while the sidebar stays hidden.
test.describe('editor shell, sidebar from 1 280 px (F)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'the widths are set by the tests themselves') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
const nav = (page: Page) =>
page.getByRole('navigation', { name: dict['shell.nav_label'] })
const menu = (page: Page) =>
page.getByRole('button', { name: dict['shell.open_menu'] })
const drawer = (page: Page) =>
page.getByRole('dialog', { name: dict['shell.nav_label'] })
async function measure(page: Page, width: number) {
await page.setViewportSize({ width, height: 800 })
await selectTab(page, dict, 'annotations')
await pickAnnotation(page, dict, 'Point libre')
const canvas = await page.getByTestId('annotation-canvas').boundingBox()
const scroll = await page.evaluate(() => ({
scrollWidth: document.documentElement.scrollWidth,
clientWidth: document.documentElement.clientWidth,
}))
test.info().annotations.push({
type: 'canvas-width',
description: `${canvas?.width}px at ${width}px`,
})
return scroll
}
test('the sidebar is hidden below 1 280 px and shown from 1 280 px', async ({
page,
}) => {
await open(page)
for (const width of [1024, 1180, 1279]) {
const scroll = await measure(page, width)
expect(scroll.scrollWidth, `${width} px`).toBeLessThanOrEqual(
scroll.clientWidth,
)
await expect(nav(page), `${width} px`).toHaveCount(0)
await expect(menu(page), `${width} px`).toBeVisible()
}
const scroll = await measure(page, 1280)
expect(scroll.scrollWidth).toBeLessThanOrEqual(scroll.clientWidth)
await expect(nav(page)).toBeVisible()
await expect(menu(page)).toHaveCount(0)
})
test('the menu is one tap away and the drawer stays open at 1 180 px', async ({
page,
}) => {
await open(page)
await page.setViewportSize({ width: 1180, height: 800 })
await menu(page).click()
await expect(drawer(page)).toBeVisible()
await page.setViewportSize({ width: 1279, height: 800 })
await page.evaluate(
() =>
new Promise((done) =>
requestAnimationFrame(() => requestAnimationFrame(done)),
),
)
await expect(drawer(page)).toBeVisible()
await page.setViewportSize({ width: 1280, height: 800 })
await expect(drawer(page)).toBeHidden()
await expect(nav(page)).toBeVisible()
})
test('a drawer link asks before leaving while the draft has unsaved changes', async ({
page,
}) => {
await open(page)
await page.setViewportSize({ width: 1180, height: 800 })
await selectTab(page, dict, 'general')
await page.locator('#general-name-fr').fill('Travail non enregistré')
await menu(page).click()
await drawer(page)
.getByRole('link', { name: new RegExp(dict['shell.nav.account']) })
.click()
const leave = page.getByRole('dialog', { name: dict['leave.title'] })
await expect(leave).toBeVisible()
await leave.getByRole('button', { name: dict['leave.stay'] }).click()
await expect(leave).toBeHidden()
await expect(page).toHaveURL(/\/draft/)
})
})