Files
faunosteo/apps/app/tests/unit/editor-keep-alive.test.tsx
T
bchanot 4d2c64f57f feat(editor): creation on the drawing then the creation dialog
U2 Task 7 (A2, A4, A5, A7, A12, A15; R-3, R-4, R-12, R-13, R-14).
The work store's `creation` owns the new shape, its form, its view and
F: a click with the point tool, a closed tracing or a keyboard
« Ajouter … » opens « Nouveau point / zone / accès », a modal without
a history layer over the right column, mounted beside EditOnly so a
read-only flip keeps it (« Créer », « Replacer », « Reprendre » off).
A new zone or link is a creation from its first vertex. The ghost
takes the form's category colour; the point tool previews under a
mouse; the canvas carries data-creating (other markers dimmed,
unselectable). « Replacer le point » / « Reprendre le tracé » hide the
dialog and keep the form; the strip offers « Revenir aux propriétés »,
« Retirer le dernier sommet », « Abandonner ». « Créer »: one insert,
tool back to « Sélectionner », the new element selected, « Point
créé · Défaire », focus on its row. ✕, Échap, « Abandonner » and Back
always ask « Abandonner la création ? » (DiscardConfirm inside the
dialog; DrawingGuardDialog elsewhere); answerDrawing drops the
creation. Undo, its shortcuts and the line's « Défaire » are inactive
during a creation. missingFields replaces formProblem (MissingSummary
shared with the edit form); the C26 notice has no numbers.
CreationPanel, formProblem, withGeometry and the keys required.fields,
required.names and create_cancel are gone; GeometryGroup is imported
by RepairDialog only.

Removed or rewritten assertions:
- tab « holds a point at the frame centre »: « Centre x » = 50 ->
  the ghost circle cx = 50; plus tool back to Sélectionner, « Point
  créé », one undo step.
- tab « refuses a creation without laterality »: the general line
  « Choisissez la catégorie et la latéralité » -> only « Choisissez
  une latéralité. » and « À compléter : Latéralité. », focus on it.
- tab « applies the geometry group to a pending zone »: removed (A8,
  no coordinate field) -> « places a triangle at the centre: the ghost
  shows it, Créer inserts it »; vertex edits after Créer are the e2e
  keyboard test.
- tab C26 « proposes C »: « x = 15, y = 15 » in the notice -> the R-4
  text, the notice inside the dialog; cancel test « Centre x » = 0 ->
  ghost cx = 0.
- tab « offers the correction when the core refuses a pending point »
  (typed cx 98): removed, no typed coordinate is possible; the verdict
  path stays covered by the C26 click tests and correctionFor units.
- tab H5 « a typed radius shows the core issue »: removed (A8); the
  size refusal is the slider's (Task 4 tests).
- tab H6 « a second click moves the pending point »: -> « Replacer le
  point », then the click moves the ghost, the form kept.
- tab H7 « Centre x/y » = 30/50 -> ghost cx/cy.
- tab tracing Enter: « x du sommet 3 » -> ghost points; « drops the
  tracing on Escape » -> Escape asks first (board 32 row 3), Continuer
  keeps, Abandonner drops; new « Annuler le tracé acts at once ».
- keep-alive « a pending creation is kept and focused » and « a
  tracing … is kept and focused »: the tab now asks first (R-12) ->
  « Continuer » keeps the tracing / the form, « Abandonner » goes.
- sections « its panel takes the focus » -> its dialog's
  [data-creation-focus] takes it.
- no-loss « pending creation with its name » (hidden with the body) ->
  the dialog stays across the crossing, read-only, Créer off (R-14).
- point-edit A5 « Rayon » = 7 / 9 -> ghost r = 7 / 9.
- e2e editor-annotations keyboard test « numeric position » (cx field
  250) -> UX_TESTS Keyboard: zone added, vertex added and removed,
  moved by the move mode, validated, saved. The « Fermer le tracé »
  step runs under expectNoShift again (shortcut removed).
- e2e editor-geometry C26: the proposed x, y read from the notice
  text -> from the overlay's correction circle; the R-4 text checked
  in the dialog.
- e2e editor-deselect « Escape cancels the tracing only » -> Escape
  asks, « Abandonner » cancels it, the selection kept.
- e2e editor-shell-crossing « keeps its tool and its pending
  creation » (field hidden) -> the dialog stays read-only, Créer off,
  then editable on widening.
2026-11-17 23:32:42 +01:00

578 lines
21 KiB
TypeScript

/** U1 Lot B2a: tabs, Annotations sections and the Références tab stay mounted. */
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import {
act,
cleanup,
fireEvent,
render,
screen,
waitFor,
within,
} from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import EditorTabBody from '@/components/editor/EditorTabBody'
import KeptPlace from '@/components/editor/KeptPlace'
import { useSheetDocument } from '@/editor/sheetDocument'
import { usePlaceVisible } from '@/lib/placeVisibility'
import { FocusConsumedContext } from '@/editor/focusRequest'
import { targetOfKey } from '@/editor/navigation'
import { useLocaleStore } from '@/state/localeStore'
import { useAnnotationWork } from '@/editor/annotations/workStore'
import { cleanSvg } from '@/editor/core/cleaning'
import {
ASSET,
drawnText,
edit,
emptyText,
insert,
point,
} from '../helpers/editorFixtures'
import {
baseText,
resetStore,
sb,
serverHas,
store,
versionAnswer,
pressAt,
} from '../helpers/editorHarness'
import { testLayer } from '../helpers/findingsHost'
import { mountDraft, setWidth } from '../helpers/editorRoute'
vi.mock('@/lib/supabase', () => ({ getSupabaseClient: () => ({}) }))
vi.mock('@faunosteo/supabase', async (orig) => ({
...(await orig<typeof import('@faunosteo/supabase')>()),
getSheetVersion: vi.fn(),
downloadSheetDrawing: vi.fn(),
saveSheetDraft: vi.fn(),
getOfficialSheetAdmin: vi.fn(),
submitSheetReview: vi.fn(),
}))
beforeEach(() => {
useLocaleStore.setState({ locale: 'fr' })
const identity = { a: 1, b: 0, c: 0, d: 1, e: 0, f: 0 }
Object.defineProperty(window.SVGElement.prototype, 'getScreenCTM', {
configurable: true,
value: () => ({ ...identity, inverse: () => identity }),
})
})
afterEach(() => {
cleanup()
resetStore()
setWidth(1024)
})
const ready = () =>
screen.findByRole('heading', { level: 1, name: 'Brouillon, version 4' })
const tab = (name: string | RegExp) => screen.getByRole('tab', { name })
const entry = (name: string | RegExp) => screen.getByRole('button', { name })
const place = (name: string) =>
document.querySelector<HTMLElement>(`[data-place="${name}"]`)!
const inPlace = (name: string) => within(place(name))
const name = (n: string) => ({ fr: n, en: n })
function findingsText(from = baseText(), nodeRefs?: string[]): string {
const text = insert(from, {
kind: 'zone',
value: { id: 'zone-a', name: name('Zone A'), categories: [] },
})
const family = edit(text, {
op: 'insert',
parent: { kind: 'zone', id: 'zone-a' },
element: {
kind: 'finding_category',
value: {
id: 'fcat-a',
kind: 'dysfunction',
name: name('Cat A'),
description: {},
reference_ids: [],
review_status: 'to_confirm',
children: [],
},
},
})
if (!nodeRefs) return family
return edit(family, {
op: 'insert',
parent: { kind: 'finding', zone_id: 'zone-a', path: ['fcat-a'] },
element: {
kind: 'finding_node',
value: {
id: 'fnode-a',
name: name('Node A'),
description: {},
reference_ids: nodeRefs,
requires_vet_referral: false,
review_status: 'to_confirm',
children: [],
},
},
})
}
async function mount(text = baseText()) {
serverHas(text, 3)
const user = userEvent.setup()
mountDraft()
await ready()
return user
}
describe('KeptPlace', () => {
function Probe() {
return <p>{usePlaceVisible() ? 'yes' : 'no'}</p>
}
it('hides its children and composes with the places around it', () => {
render(
<KeptPlace name="outer" visible>
<KeptPlace name="inner" visible={false}>
<Probe />
</KeptPlace>
<KeptPlace name="other" visible>
<Probe />
</KeptPlace>
</KeptPlace>,
)
expect(place('inner')).not.toBeVisible()
expect(place('other')).toBeVisible()
expect(screen.getAllByText('yes')).toHaveLength(1)
})
it('an own visible place inside a hidden one is not visible', () => {
render(
<KeptPlace name="outer" visible={false}>
<KeptPlace name="inner" visible>
<Probe />
</KeptPlace>
</KeptPlace>,
)
expect(screen.getByText('no')).toBeInTheDocument()
})
it('is visible outside any place', () => {
render(<Probe />)
expect(screen.getByText('yes')).toBeInTheDocument()
})
})
describe('text typed in a place that is left', () => {
it('the category add form survives Général ↔ Annotations and a section round trip', async () => {
const user = await mount()
await user.click(tab('Annotations'))
await user.click(entry('Modifier les catégories'))
const field = inPlace('annotations.categories').getByLabelText(
'Nom de la catégorie (FR)',
{ selector: '#category-new-fr' },
)
await user.type(field, 'Brouillon')
await user.click(tab('Général'))
expect(place('annotations.categories')).not.toBeVisible()
await user.click(tab('Annotations'))
expect(place('annotations.categories')).toBeVisible()
await user.click(screen.getByRole('button', { name: 'Retour au dessin' }))
await user.click(entry('Modifier les catégories'))
expect(document.querySelector('#category-new-fr')).toBe(field)
expect(field).toHaveValue('Brouillon')
expect(store.getState().unsaved).toBe(false)
})
it('the references search survives leaving and returning to the Références tab', async () => {
const user = await mount()
await user.click(tab('Références'))
const box = inPlace('references').getByRole('searchbox', {
name: 'Rechercher une référence',
})
await user.type(box, 'Smith 1999')
await user.click(tab('Annotations'))
expect(place('references')).not.toBeVisible()
await user.click(tab('Références'))
expect(box).toHaveValue('Smith 1999')
expect(store.getState().unsaved).toBe(false)
})
})
describe('findings and canvas state across a tab change', () => {
it('the findings selection and expansion survive', async () => {
const user = await mount(findingsText())
await user.click(tab('Constats'))
const zone = inPlace('findings').getByRole('treeitem', { name: /Zone A/ })
const cat = inPlace('findings').getByRole('treeitem', { name: /Cat A/ })
await user.click(cat)
expect(zone).toHaveAttribute('aria-expanded', 'true')
await user.click(tab('Général'))
await user.click(tab('Constats'))
expect(inPlace('findings').getByRole('treeitem', { name: /Cat A/ })).toBe(
cat,
)
expect(cat).toHaveAttribute('aria-selected', 'true')
expect(zone).toHaveAttribute('aria-expanded', 'true')
})
it('the canvas tool, selection and zoom survive a tab change and a section round trip', async () => {
const text = insert(drawnText(), point('anno-a', 50, 50, 5))
const user = await mount(text)
await waitFor(() =>
expect(
inPlace('annotations.drawing').getByRole('button', { name: 'Zone' }),
).toBeEnabled(),
)
const drawing = inPlace('annotations.drawing')
await user.click(drawing.getByRole('button', { name: 'Zone' }))
await user.click(drawing.getByRole('button', { name: 'Zoom avant' }))
const layer = () =>
drawing.getByTestId('annotation-canvas').firstElementChild as HTMLElement
const zoomed = layer().style.transform
expect(zoomed).not.toContain('scale(1)')
await user.click(tab('Général'))
await user.click(tab('Annotations'))
await user.click(entry('Gérer les vues'))
await user.click(screen.getByRole('button', { name: 'Retour au dessin' }))
expect(drawing.getByRole('button', { name: 'Zone' })).toHaveAttribute(
'aria-pressed',
'true',
)
expect(layer().style.transform).toBe(zoomed)
const list = drawing.getByRole('list', { name: 'Annotations de la vue' })
await user.click(within(list).getAllByRole('button')[0])
const marker = () =>
drawing
.getByTestId('annotation-canvas-drawing')
.querySelector('[data-anno-id="anno-a"]')
const stillSelected = () =>
waitFor(() => expect(marker()).toHaveAttribute('data-state', 'current'))
await stillSelected()
await user.click(tab('Général'))
await user.click(tab('Annotations'))
await stillSelected()
// U2 Task 6: the selection's strip offers its properties (the panel left the column).
expect(drawing.getByRole('button', { name: 'Propriétés' })).toBeVisible()
})
it('the unmeasured hint opens the views section and « Retour au dessin » restores the same canvas', async () => {
serverHas(emptyText(), 3, false)
const user = userEvent.setup()
mountDraft()
await ready()
await user.click(tab('Annotations'))
const drawing = inPlace('annotations.drawing')
const canvas = drawing.getByTestId('annotation-canvas')
await user.click(drawing.getByRole('button', { name: 'Vues' }))
expect(place('annotations.views')).toBeVisible()
expect(place('annotations.drawing')).not.toBeVisible()
await user.click(screen.getByRole('button', { name: 'Retour au dessin' }))
expect(place('annotations.drawing')).toBeVisible()
expect(drawing.getByTestId('annotation-canvas')).toBe(canvas)
})
})
describe('a field still focused while a place is left', () => {
async function generalNameField(user: ReturnType<typeof userEvent.setup>) {
await user.click(tab('Général'))
const field = inPlace('general').getByLabelText('Nom (FR)', {
exact: true,
selector: '#general-name-fr',
})
await user.click(field)
fireEvent.change(field, { target: { value: 'Nom saisi' } })
return field
}
it('a click that moves no focus (Safari) still commits it, as one undo entry', async () => {
const user = await mount()
const before = store.getState().documentText
const field = await generalNameField(user)
expect(document.activeElement).toBe(field)
fireEvent.click(tab('Annotations'))
expect(JSON.parse(store.getState().documentText).name.fr).toBe('Nom saisi')
expect(store.getState().unsaved).toBe(true)
act(() => void store.getState().undoStep())
expect(store.getState().documentText).toBe(before)
})
it('an arrow key on the tab list commits it first, as one undo entry', async () => {
const user = await mount()
const before = store.getState().documentText
const field = await generalNameField(user)
fireEvent.keyDown(tab('Général'), { key: 'ArrowRight' })
expect(tab('Annotations')).toHaveAttribute('aria-selected', 'true')
expect(JSON.parse(store.getState().documentText).name.fr).toBe('Nom saisi')
expect(field).toHaveValue('Nom saisi')
expect(store.getState().unsaved).toBe(true)
act(() => void store.getState().undoStep())
expect(store.getState().documentText).toBe(before)
})
})
describe('ids and parses', () => {
const detail = {
kind: 'view',
value: {
kind: 'detail',
id: 'view-det',
name: { fr: 'Tête', en: 'Head' },
svg_asset_id: null,
view_box: { min_x: 10, min_y: 20, width: 40, height: 60 },
parent_view_id: 'view-main',
},
} as const
/** A drawing whose own elements carry ids, so a second composed copy would repeat them. */
function serveDrawingWithIds(text: string): void {
const svg =
'<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100">' +
'<defs><linearGradient id="fade"><stop offset="0"/></linearGradient></defs>' +
'<rect id="body" width="4" height="4" fill="url(#fade)"/></svg>'
const cleaned = cleanSvg(new TextEncoder().encode(svg))
if (!cleaned.ok || !cleaned.value.stored) throw new Error('uncleanable')
const bytes = new TextEncoder().encode(cleaned.value.stored)
const answer = versionAnswer(text, 3)
answer.drawings = [{ asset_id: ASSET, sha256: cleaned.value.sha256! }]
sb.getSheetVersion.mockResolvedValue(answer as never)
sb.downloadSheetDrawing.mockResolvedValue(bytes)
}
const composedHosts = () =>
[
...document.querySelectorAll(
'[data-testid="annotation-canvas-drawing"], [data-testid="crop-canvas-drawing"]',
),
].filter((host) => host.querySelector('svg'))
it('every place visited, a crop group open: one composed copy, no id repeats', async () => {
serveDrawingWithIds(insert(drawnText(), detail))
const user = userEvent.setup()
mountDraft()
await ready()
await waitFor(() => expect(composedHosts()).toHaveLength(1))
await user.click(entry('Gérer les vues'))
await user.click(
inPlace('annotations.views').getByRole('button', {
name: 'Modifier le recadrage',
}),
)
await waitFor(() => expect(composedHosts()).toHaveLength(1))
expect(composedHosts()[0]).toHaveAttribute(
'data-testid',
'crop-canvas-drawing',
)
await user.click(screen.getByRole('button', { name: 'Retour au dessin' }))
await user.click(entry('Modifier les catégories'))
await user.click(screen.getByRole('button', { name: 'Retour au dessin' }))
await user.click(entry(/^Régions vertébrales/))
for (const name of ['Général', 'Constats', 'Références', /Vérification/]) {
await user.click(tab(name))
}
expect(composedHosts()).toHaveLength(0)
await user.click(tab('Annotations'))
await user.click(screen.getByRole('button', { name: 'Retour au dessin' }))
await waitFor(() => expect(composedHosts()).toHaveLength(1))
const ids = [...document.querySelectorAll('[id]')].map((e) => e.id)
expect(ids.filter((id, i) => ids.indexOf(id) !== i)).toEqual([])
expect(ids.some((id) => id.includes('body'))).toBe(true)
})
it('every place reads the same parsed document per text', async () => {
await mount()
const seen: unknown[] = []
function Probe() {
seen.push(useSheetDocument())
return null
}
const first = render(
<>
<Probe />
<Probe />
</>,
)
expect(seen[0]).not.toBeNull()
expect(seen[1]).toBe(seen[0])
first.unmount()
act(() => {
store.getState().commit({
op: 'insert',
element: {
kind: 'category',
value: { id: 'cat-z', name: name('Z'), color: null },
},
})
})
seen.length = 0
render(
<>
<Probe />
<Probe />
</>,
)
expect(seen[1]).toBe(seen[0])
expect(seen[0]).toMatchObject({
categories: expect.arrayContaining([
expect.objectContaining({ id: 'cat-z' }),
]),
})
})
})
describe('a request reaches only its owner', () => {
it('a finding request focuses the findings place while others are mounted', async () => {
await mount(findingsText())
await userEvent.setup().click(tab('Constats'))
await userEvent.setup().click(tab('Général'))
const consumed = vi.fn()
const { unmount } = render(
<FocusConsumedContext value={consumed}>
<EditorTabBody
tab="findings"
visited={['general', 'annotations', 'findings']}
readOnly={false}
navigate={vi.fn()}
reloadSheet={vi.fn()}
layer={testLayer}
focus={{
target: targetOfKey({
kind: 'finding',
zone_id: 'zone-a',
path: ['fcat-a'],
}),
serial: 9,
}}
annotations={{
section: 'drawing',
visited: ['drawing'],
onOpenSection: vi.fn(),
onBack: vi.fn(),
}}
/>
</FocusConsumedContext>,
)
await waitFor(() => expect(consumed).toHaveBeenCalledTimes(1))
expect(consumed).toHaveBeenCalledWith(9, 'found')
unmount()
})
it('after « Aller à » a finding, arrowing back onto Constats keeps the focus on the tab', async () => {
const text = insert(findingsText(), {
...point('anno-bare', 10, 10, 2),
})
const user = await mount(text)
await user.click(tab('Constats'))
await user.click(
inPlace('findings').getByRole('treeitem', { name: /Cat A/ }),
)
await user.click(tab('Annotations'))
tab('Annotations').focus()
await user.keyboard('{ArrowRight}')
expect(tab('Constats')).toHaveAttribute('aria-selected', 'true')
expect(document.activeElement).toBe(tab('Constats'))
})
})
describe('a tab while a creation or a tracing is in progress', () => {
function bareAnnotationText(): string {
const bare = point('anno-bare', 10, 10, 2)
const value = { ...bare.value, geometry: null, name: name('Sans tracé') }
return insert(drawnText(), { kind: 'annotation', value } as typeof bare)
}
// U2 Task 7 (R-12, A12): a creation no longer waits for « Aller à » in the background;
// the tab that would leave it asks first. « Continuer » keeps it, « Abandonner » goes.
it('a tracing from the Zone tool: the tab asks first, « Continuer » keeps it', async () => {
const user = await mount(bareAnnotationText())
const drawing = inPlace('annotations.drawing')
await waitFor(() =>
expect(drawing.getByRole('button', { name: 'Zone' })).toBeEnabled(),
)
await user.click(drawing.getByRole('button', { name: 'Zone' }))
pressAt(screen.getByTestId('annotation-canvas'), 20, 20)
await user.click(tab(/Vérification/))
const ask = await screen.findByRole('dialog', {
name: 'Abandonner la création ?',
})
await user.click(within(ask).getByRole('button', { name: 'Continuer' }))
expect(tab('Annotations')).toHaveAttribute('aria-selected', 'true')
expect(drawing.getByTestId('tracing-commands')).toBeVisible()
await user.click(tab(/Vérification/))
await user.click(
within(
await screen.findByRole('dialog', { name: 'Abandonner la création ?' }),
).getByRole('button', { name: 'Abandonner' }),
)
expect(tab(/Vérification/)).toHaveAttribute('aria-selected', 'true')
expect(useAnnotationWork.getState().creation).toBeNull()
})
// U2 Task 5 (R-12): « Remplacer par un polygone » is a redraw mode. With nothing placed a
// tab ends it at once; with a vertex placed the tab asks first and « Continuer » keeps it.
it('a « Remplacer par un polygone » redraw: ended by a tab when empty, asked once a vertex is placed', async () => {
const zone = point('zone-a', 0, 0, 1)
const zoneValue = {
...zone.value,
kind: 'zone',
geometry: { type: 'path', d: 'M 20 20 L 80 20 L 50 80 Z' },
}
const text = insert(bareAnnotationText(), {
kind: 'annotation',
value: zoneValue,
} as typeof zone)
const user = await mount(text)
const drawing = inPlace('annotations.drawing')
const replace = async () => {
await user.click(
await drawing.findByRole('button', {
name: 'Remplacer par un polygone',
}),
)
expect(drawing.getByTestId('tracing-commands')).toBeVisible()
}
const list = drawing.getByRole('list', { name: 'Annotations de la vue' })
await user.click(within(list).getAllByRole('button')[0])
await replace()
await user.click(tab(/Vérification/))
expect(tab(/Vérification/)).toHaveAttribute('aria-selected', 'true')
expect(useAnnotationWork.getState().mode).toBeNull()
await user.click(tab('Annotations'))
await replace()
pressAt(screen.getByTestId('annotation-canvas'), 20, 20)
await user.click(tab(/Vérification/))
expect(
await screen.findByRole('dialog', {
name: 'Abandonner le nouveau tracé ?',
}),
).toBeInTheDocument()
await user.click(screen.getByRole('button', { name: 'Continuer' }))
expect(tab('Annotations')).toHaveAttribute('aria-selected', 'true')
expect(drawing.getByTestId('tracing-commands')).toBeVisible()
})
it('a point being replaced (dialog hidden): the tab asks, « Continuer » keeps the form', async () => {
const user = await mount(bareAnnotationText())
const drawing = inPlace('annotations.drawing')
await waitFor(() =>
expect(
drawing.getByRole('button', { name: 'Ajouter un point' }),
).toBeEnabled(),
)
await user.click(drawing.getByRole('button', { name: 'Ajouter un point' }))
const dialog = await screen.findByRole('dialog', { name: 'Nouveau point' })
await user.type(within(dialog).getByLabelText('Nom (FR)'), 'Nuque')
await user.click(
within(dialog).getByRole('button', { name: 'Replacer le point' }),
)
await waitFor(() => expect(screen.queryByRole('dialog')).toBeNull())
await user.click(tab(/Vérification/))
await user.click(
within(
await screen.findByRole('dialog', { name: 'Abandonner la création ?' }),
).getByRole('button', { name: 'Continuer' }),
)
expect(tab('Annotations')).toHaveAttribute('aria-selected', 'true')
await user.click(
drawing.getByRole('button', { name: 'Revenir aux propriétés' }),
)
const back = await screen.findByRole('dialog', { name: 'Nouveau point' })
expect(within(back).getByLabelText('Nom (FR)')).toHaveValue('Nuque')
})
})