The reference library moves into a fifth editor tab (Général,
Annotations, Constats, Références, Vérification; under « Plus » below
640 px with Général and Constats). The header « Références » button is
removed. The side panel becomes the citations list of one finding,
opened only from a finding's trigger (owner GO 2026-11-12: never from a
family; the family keeps its inline list with « Retirer »). Selecting a
tab closes it; every close records one pending move applied after the
panel is gone, focus back to the trigger else the active tab button.
Vérification's reference issues land on the tab. e2e seed gains a
reference cited by « Constat A ».
Gates: typecheck, lint, test:run (app 1396), build, e2e:ui 251 passed;
e2e:shell 15 specs on db:sandbox (editor-equine never listed): 107
passed / 95 skipped / 2 failed (test remap dropped its edit), fixed and
rerun: editor-shell.spec 11 passed; full-row data guard: no
pre-existing row changed in any table. editor-equine.spec.ts helper
calls updated, not run.
## R-24 table (removed or rewritten assertions; old = fc3fec7 line, new = current file)
Unit tests:
| file:old line | old | new |
|---|---|---|
| editor-verification.test.tsx:87-96 | `navigate` called with target AND `expect.any(HTMLElement)` | called with the target only (opener dropped) |
| editor-verification.test.tsx:238-241 | `references[0]` path -> `{place:'references', citedBy:null}` | `{place:'tab', tab:'references', section:null}` |
| editor-verification.test.tsx:262-264 | `placeKey(references[9])` = `editor.place.references` | `editor.tab.references` |
| editor-navigation.test.ts:63 | targetOfKey reference -> `{place:'references', key, citedBy:null}` | `{place:'tab', tab:'references', section:null, key}` |
| editor-navigation.test.ts:80 | `referencesMounted` false at start | `citationsOf` null and `libraryReset` 0 |
| editor-navigation.test.ts:95-110 | go_to a reference opens the panel over the place | go_to a reference shows the Références tab with its focus request |
| editor-navigation.test.ts:112-122 | go_to a tab closes the panel (`references` object) | same, via `citationsOf` null |
| editor-navigation.test.ts:124-136 | select_tab keeps the panel | select_tab CLOSES the panel (P21), keeps section, no request |
| editor-navigation.test.ts:138-146 | `clear_cited_by` drops the filter | removed (action gone); replaced by `open_citations` refuses family/zone/view, `show_all_references` (closes, tab, reset bump), plain go_to leaves reset alone |
| editor-navigation.test.ts:160-175 | open/close references keep tab and section | open/close citations, same assertions on `citationsOf` |
| editor-mode.test.ts:100-109 | tabsFor four tabs, small more = general, findings | five tabs, small more = general, findings, references |
| editor-route.test.tsx:46,50 | TABS four, title « four tabs » | five |
| editor-route.test.tsx:139-146 | 640-1023 px four tabs | five tabs, tablist has `flex-wrap` |
| editor-route.test.tsx:149-161 | « Plus » lists Général, Constats | lists Général, Constats, Références |
| editor-route.test.tsx:168-190 | header button opens panel, ✕ returns focus to button | no header button, panel not mounted at start (full panel flow moved to editor-references-panel.test.tsx) |
| editor-route.test.tsx:192-206 | Escape closes, panel content kept for next opening | removed: the panel is no longer kept mounted (design choice 3); Escape/close covered in editor-references-panel + editor-escape |
| editor-route.test.tsx:208-218 | read-only: panel lists references, no edit control | read-only: the Références tab lists them, no textbox, no add button; plus new: tab keeps mounted when left |
| editor-tabs-lists.test.tsx:47,75,114,130 | render `ReferencesPanel` | render `ReferencesTab` |
| editor-tabs-lists.test.tsx:77 | selector `#reference-ref-a-url` | `#tab-reference-ref-a-url` |
| editor-tabs-lists.test.tsx:131-135 | read-only buttons = only « Fermer les références » | no button at all |
| editor-focus-request.test.tsx:166-171,200-202,346 | `ReferencesPanel` with `panel` props and focus | `ReferenceLibrary` with focus (same assertions) |
| editor-focus-request.test.tsx:226 | `ownedBy(ref,'citations')` is the request | `ownedBy(ref,'references')` is the request, `'citations'` undefined |
| editor-focus-request.test.tsx (Probe) | none | new: Vérification « Aller à » reference -> tab + focused row; reference path naming no element -> tab heading |
| editor-keep-alive.test.tsx:71,178-190 | add form survives closing/reopening the panel | survives leaving/returning to the Références tab (`#tab-reference-new-citation`) |
| editor-keep-alive.test.tsx:300-326 | « Aller à » without focus move commits Références text | a tab click without focus move commits it (one undo entry): « Aller à » is not reachable from the Références tab in R2.1 |
| editor-keep-alive.test.tsx:333-347 | Escape in panel reference field commits, panel hides | same, panel opened from a finding node, field `#panel-reference-ref-1-citation` |
| editor-keep-alive.test.tsx:350-363 | header toggle (no focus move) closes after committing | scrim click (no focus move) closes after committing |
| editor-keep-alive.test.tsx:425 | `referencesButton` click in the all-places sweep | `Références` added to the tab loop |
| editor-escape.test.tsx:218-227 | header button toggle, Escape on body closes panel, annotation selection kept | trigger-opened panel (A5), Escape closes it, `aria-expanded` back to false, selection kept after returning to Annotations |
| editor-escape.test.tsx:255-266 | Escape from tab row closes panel | same from the Constats tab button |
| editor-no-loss.test.tsx:146-153 | reference creation form, in the panel | in the Références tab, id `tab-reference-new-citation` |
| editor-no-loss.test.tsx:285-291 | focused header button survives crossing | focused tab button (Constats) survives crossing: no header button left |
| editor-no-loss.test.tsx:293-307 | references search in panel keeps focus/text | same in the Références tab body |
| editor-no-loss.test.tsx:390-400 | `everyPlace` ends by opening the panel | visits Références in the tab loop, no panel open |
| editor-no-loss-decisions.test.tsx:248-259 | open references panel holds the decision back | REMOVED: the panel exists only over Constats, decisions live in Annotations (hidden then); « a widening on another tab opens nothing » (same file) covers the withholding |
| editor-route-recovery.test.tsx:93-97 | recovery offer: header button opens panel, `aria-labelledby` | tab Références shows `editor-tab-references` labelled by `editor-references-title` |
| editor-references-panel.test.tsx (all) | header-button-driven panel tests incl. search, order, add, « Aller à » | split: panel tests (finding path only) stay in this file; library tests moved to new editor-references-tab.test.tsx (search matching, ↑/↓ only without search, counts, Ctrl+Z, read-only, « Aller à », add clears search, refused add keeps it); new: reset signal, ids unique with both mounted (P14), P6 fallback under « Plus » |
e2e (updated only, not run):
| file:old line | old | new |
|---|---|---|
| editor-shell.spec.ts:95-108 | panel keeps form text, no id repeats | Références tab keeps form text (`#tab-reference-new-citation`), ids unique with the panel open |
| editor-shell.spec.ts:121-142 | open panel leaves header and tab row clickable (incl. header Références button, add form) | `openCitations`; header button target and form steps dropped |
| editor-shell-journeys.spec.ts:113-123 | four tabs, `old` list includes « Références » | five tabs, « Références » removed from the old-layout list |
| editor-shell-journeys.spec.ts:246-249 | Aller à reference -> panel visible, close | `place('references')` visible, tab Références selected, row focus key, no close |
| editor-shell-layout.spec.ts:84-103 | overflow on four tabs + panel over drawing | five tabs + `openCitations`/`closeCitations` |
| editor-shell-layout.spec.ts:54-63 | local `goToTab` | removed, uses `openTab` |
| editor-shell-layout.spec.ts:140-158 | canvas width without/with panel over the drawing | E1: width measured before open and after a P21 switch to Annotations, asserted equal |
| editor-shell-layout.spec.ts:161-189 | axe on four tabs + open panel | five tabs + citations panel |
| editor-shell-layout.spec.ts:~255-310 | keyboard order began with `header` (the Références button) | `header` dropped from both orders (no focusable header control while the draft is clean); panel test selects Annotations before walking to `side` |
| editor-access.spec.ts:150-152,191-194,219-220 | axe/overflow with the panel at 320/375/768/800, 1024, read-only | same checks through `openCitations` (`showDrawing` calls dropped) |
| editor-shell-crossing.spec.ts:194-206 | references form with panel open, tab `annotations` | in the tab, focus expected on `editor-tab-references` |
| editor-shell-crossing.spec.ts:264-282 | panel open + add-form text across crossing | citations panel over a crossing, no typed-text step |
| editor-shell-crossing.spec.ts:~385-410 | decision withheld while panel open, Reprendre | REMOVED (state unreachable, see unit row) |
| editor-deselect.spec.ts:226-229 | Escape closes header-opened panel, selection kept | opened via Constats, Escape, back to Annotations, selection kept |
| editor-structures.spec.ts:80-122 | two references added, counts 2/1 | shape now holds `ref-a`: counts 3/2, `nth(1)` after move, saved list `['Référence A','Seconde référence']`, no panel |
| editor-equine.spec.ts:304-305,404-405 | openReferences/closeReferences | `openTab(page, dict, 'references')`: mis à jour, non exécuté, non vérifié |
Fix round 1: 1. e2e/shell/editor-shell.spec.ts « the open citations panel leaves the header and the tab row clickable »: before `openCitations`, the test now opens the Références tab and adds a reference through the library form (`#tab-reference-new-type` book, `#tab-reference-new-citation` « Smith 1999 », « Ajouter la référence »), so the draft is dirty and Save is enabled. All original assertion
363 lines
12 KiB
TypeScript
363 lines
12 KiB
TypeScript
import { fr } from '@/i18n/fr'
|
|
import type { Locator, Page, TestInfo } from '@playwright/test'
|
|
import { expect, test } from '../support/browser'
|
|
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
|
|
import {
|
|
clientOf,
|
|
closeCitations,
|
|
copyKeyOf,
|
|
editorActor,
|
|
geometryField,
|
|
historyButton,
|
|
libraryRoot,
|
|
openEditor,
|
|
openCitations,
|
|
openTab,
|
|
openSection,
|
|
pickAnnotation,
|
|
place,
|
|
pointOf,
|
|
saveLine,
|
|
seedDraft,
|
|
selectTab,
|
|
shapeWith,
|
|
standardShape,
|
|
storedCopy,
|
|
UNSAVED_LINE,
|
|
} from '../support/editor'
|
|
|
|
// V1-2.6 U1 H (AC11, AC21): a width change across 1 024 px in a real browser. Every
|
|
// edit-only part keeps what was typed, nothing is editable or focused below the threshold,
|
|
// the unsaved work stays, dialogs that confirm an edit close, a drag in flight commits
|
|
// nothing. Queries go to the visible place or by role; hidden parts stay in the DOM.
|
|
|
|
const dict = fr
|
|
|
|
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
|
|
const active = (page: Page) => page.locator(':focus')
|
|
const dialogs = (page: Page) => page.locator('dialog[open]')
|
|
const NARROW = { width: 800, height: 900 }
|
|
const WIDE = { width: 1280, height: 900 }
|
|
|
|
const spareCategory = (document: Record<string, unknown>) => {
|
|
standardShape(document)
|
|
;(document.categories as unknown[]).push({
|
|
id: 'cat-spare',
|
|
name: { fr: 'Libre', en: 'Free' },
|
|
color: null,
|
|
})
|
|
}
|
|
|
|
async function open(page: Page, shape = shapeWith()) {
|
|
const actor = await editorActor('fr')
|
|
const seed = await seedDraft(actor, { shape })
|
|
await openEditor(page, dict, actor, seed.sheetId)
|
|
return { ...seed, actor }
|
|
}
|
|
|
|
async function commitName(page: Page, value: string) {
|
|
await selectTab(page, dict, 'general')
|
|
await page.locator('#general-name-fr').fill(value)
|
|
await page.locator('#general-name-fr').press('Enter')
|
|
}
|
|
|
|
/** The editor is read-only in this page: no save, no text field, no edit toolbar. */
|
|
async function expectReadOnly(page: Page) {
|
|
await expect(
|
|
page.getByRole('button', { name: dict['common.save'], exact: true }),
|
|
).toHaveCount(0)
|
|
await expect(page.getByRole('textbox')).toHaveCount(0)
|
|
await expect(
|
|
page.getByRole('toolbar', { name: dict['editor.annotations.tools'] }),
|
|
).toHaveCount(0)
|
|
for (const kind of ['undo', 'redo'] as const) {
|
|
await expect(historyButton(page, dict, kind)).toHaveAttribute(
|
|
'aria-disabled',
|
|
'true',
|
|
)
|
|
}
|
|
}
|
|
|
|
/** A real crossing: the dialogs are gone and nothing is left to animate before the checks. */
|
|
async function cross(page: Page, size: { width: number; height: number }) {
|
|
await page.setViewportSize(size)
|
|
await expect(dialogs(page)).toHaveCount(0)
|
|
}
|
|
|
|
/**
|
|
* Types in `field` with no blur, crosses below 1 024 px, checks the part left the page and
|
|
* the focus sits on a named tab, widens, and checks the typed value is back untouched.
|
|
*/
|
|
async function keepsTypedValue(
|
|
page: Page,
|
|
field: Locator,
|
|
addButton: string,
|
|
tab: string,
|
|
) {
|
|
await field.fill('Saisie')
|
|
await cross(page, NARROW)
|
|
await expect(field).toBeHidden()
|
|
await expect(
|
|
page.getByRole('button', { name: addButton, exact: true }),
|
|
).toHaveCount(0)
|
|
await expectReadOnly(page)
|
|
await expect(active(page)).toHaveAttribute('id', `editor-tab-${tab}`)
|
|
await cross(page, WIDE)
|
|
await expect(field).toBeVisible()
|
|
await expect(field).toHaveValue('Saisie')
|
|
await expect(saveLine(page)).not.toHaveText(UNSAVED_LINE)
|
|
}
|
|
|
|
test.describe('editor shell, width crossing (H)', () => {
|
|
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
|
test.beforeEach(async ({ context }, info) => {
|
|
test.skip(isPhone(info), 'the widths are set by the tests themselves') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
|
await routeToSandbox(context)
|
|
})
|
|
test.afterEach(async ({ context }) => {
|
|
await dropLateReplays(context)
|
|
})
|
|
|
|
test('the category, region and detail view forms keep their typed text', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await openSection(page, dict, 'categories')
|
|
await keepsTypedValue(
|
|
page,
|
|
page.locator('#category-new-fr'),
|
|
dict['editor.general.category_add'],
|
|
'annotations',
|
|
)
|
|
await openSection(page, dict, 'regions')
|
|
await keepsTypedValue(
|
|
page,
|
|
page.locator('#region-new-code'),
|
|
dict['editor.vertebra.add'],
|
|
'annotations',
|
|
)
|
|
await openSection(page, dict, 'views')
|
|
await keepsTypedValue(
|
|
page,
|
|
page.locator('#view-new-fr'),
|
|
dict['editor.views.add'],
|
|
'annotations',
|
|
)
|
|
})
|
|
|
|
test('the crop group editor keeps its typed numbers, its read-only twin has its own ids', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await openSection(page, dict, 'views')
|
|
await place(page, 'annotations.views')
|
|
.getByRole('button', { name: dict['editor.views.crop.toggle'] })
|
|
.first()
|
|
.click()
|
|
const field = page.locator('#view-detail-a-crop-min_x')
|
|
await field.fill('7x')
|
|
await cross(page, NARROW)
|
|
await expect(field).toBeHidden()
|
|
await expect(page.locator('#ro-view-detail-a-crop-min_x')).toBeVisible()
|
|
await cross(page, WIDE)
|
|
await expect(field).toHaveValue('7x')
|
|
const ids = await page.evaluate(() => {
|
|
const all = [...document.querySelectorAll('[id]')].map((e) => e.id)
|
|
return all.filter((id, i) => all.indexOf(id) !== i)
|
|
})
|
|
expect(ids).toEqual([])
|
|
})
|
|
|
|
test('the findings creation form and the submission note keep their typed text', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await selectTab(page, dict, 'findings')
|
|
await page
|
|
.getByRole('button', { name: dict['editor.findings.add_zone'] })
|
|
.click()
|
|
await keepsTypedValue(
|
|
page,
|
|
page.locator('#finding-new-name-fr'),
|
|
dict['editor.findings.add_zone'],
|
|
'findings',
|
|
)
|
|
await selectTab(page, dict, 'verification')
|
|
await keepsTypedValue(
|
|
page,
|
|
page.locator('#verification-note'),
|
|
dict['editor.verification.submit'],
|
|
'verification',
|
|
)
|
|
})
|
|
|
|
test('the references form keeps its typed text, in the Références tab', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await openTab(page, dict, 'references')
|
|
await keepsTypedValue(
|
|
page,
|
|
page.locator('#tab-reference-new-citation'),
|
|
dict['editor.reference.add'],
|
|
'references',
|
|
)
|
|
await expect(libraryRoot(page).getByRole('searchbox')).toBeVisible()
|
|
})
|
|
|
|
test('the annotation edit body keeps its tool and its pending creation', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await selectTab(page, dict, 'annotations')
|
|
const zone = page.getByRole('button', {
|
|
name: dict['editor.annotations.tool.zone'],
|
|
exact: true,
|
|
})
|
|
await expect(zone).toBeEnabled()
|
|
await zone.click()
|
|
await page
|
|
.getByRole('button', { name: dict['editor.annotations.add.point'] })
|
|
.click()
|
|
const name = page.getByLabel(dict['editor.annotations.name_fr'])
|
|
await name.fill('Futur point')
|
|
await cross(page, NARROW)
|
|
await expect(name).toBeHidden()
|
|
await expect(zone).toHaveCount(0)
|
|
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
|
|
await cross(page, WIDE)
|
|
await expect(name).toHaveValue('Futur point')
|
|
await expect(zone).toHaveAttribute('aria-pressed', 'true')
|
|
await expect(saveLine(page)).not.toHaveText(UNSAVED_LINE)
|
|
})
|
|
|
|
test('a section open: read-only below the threshold, unsaved work kept, edit back on widening', async ({
|
|
page,
|
|
}) => {
|
|
const { actor, draftId } = await open(page)
|
|
await commitName(page, 'Nom conservé')
|
|
await openSection(page, dict, 'categories')
|
|
await page.locator('#category-new-fr').fill('Brouillon')
|
|
await cross(page, NARROW)
|
|
await expectReadOnly(page)
|
|
await expect(place(page, 'annotations.categories')).toBeVisible()
|
|
await expect(saveLine(page)).toHaveText(
|
|
dict['editor.draft.status.unsaved_count_one'].replace('{count}', '1'),
|
|
)
|
|
expect(
|
|
await storedCopy(page, copyKeyOf(actor.account.id, draftId)),
|
|
).not.toBeNull()
|
|
await cross(page, WIDE)
|
|
await expect(
|
|
page.getByRole('button', { name: dict['common.save'], exact: true }),
|
|
).toBeEnabled()
|
|
await expect(historyButton(page, dict, 'undo')).toHaveAttribute(
|
|
'aria-disabled',
|
|
'false',
|
|
)
|
|
await expect(page.locator('#category-new-fr')).toHaveValue('Brouillon')
|
|
await expect(saveLine(page)).toHaveText(UNSAVED_LINE)
|
|
})
|
|
|
|
test('the citations panel open: read-only below the threshold, unsaved work kept, edit back on widening', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await commitName(page, 'Nom conservé')
|
|
await openCitations(page, dict, 'Constat A')
|
|
await cross(page, NARROW)
|
|
await expectReadOnly(page)
|
|
await expect(place(page, 'citations')).toBeVisible()
|
|
await expect(saveLine(page)).toHaveText(UNSAVED_LINE)
|
|
await cross(page, WIDE)
|
|
await expect(
|
|
page.getByRole('button', { name: dict['common.save'], exact: true }),
|
|
).toBeEnabled()
|
|
await closeCitations(page, dict)
|
|
})
|
|
|
|
test('text typed without a blur is unsaved after the crossing and the copy is written', async ({
|
|
page,
|
|
}) => {
|
|
const { actor, draftId } = await open(page)
|
|
await selectTab(page, dict, 'general')
|
|
await page.locator('#general-name-fr').fill('Sans quitter le champ')
|
|
await cross(page, NARROW)
|
|
await expect(saveLine(page)).toHaveText(
|
|
dict['editor.draft.status.unsaved_count_one'].replace('{count}', '1'),
|
|
)
|
|
await expect
|
|
.poll(() => storedCopy(page, copyKeyOf(actor.account.id, draftId)))
|
|
.not.toBeNull()
|
|
})
|
|
|
|
test('a focused drawing tool hands its focus to the shown tab on a crossing', async ({
|
|
page,
|
|
}) => {
|
|
await open(page)
|
|
await selectTab(page, dict, 'annotations')
|
|
const zone = page.getByRole('button', {
|
|
name: dict['editor.annotations.tool.zone'],
|
|
exact: true,
|
|
})
|
|
await expect(zone).toBeEnabled()
|
|
await zone.focus()
|
|
await cross(page, NARROW)
|
|
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
|
|
})
|
|
|
|
test('a drag across the crossing commits nothing', async ({ page }) => {
|
|
await open(
|
|
page,
|
|
shapeWith(
|
|
pointOf('anno-free', 'main', { cx: 120, cy: 120, r: 6 }, 'Point libre'),
|
|
),
|
|
)
|
|
await selectTab(page, dict, 'annotations')
|
|
await pickAnnotation(page, dict, 'Point libre')
|
|
const cx = geometryField(page, dict, 'cx')
|
|
const before = await cx.inputValue()
|
|
const from = await clientOf(page, 120, 120)
|
|
const to = await clientOf(page, 200, 160)
|
|
await page.mouse.move(from.x, from.y)
|
|
await page.mouse.down()
|
|
await page.mouse.move(to.x, to.y, { steps: 6 })
|
|
await cross(page, NARROW)
|
|
await page.mouse.up()
|
|
await cross(page, WIDE)
|
|
await expect(geometryField(page, dict, 'cx')).toHaveValue(before)
|
|
await expect(saveLine(page)).not.toHaveText(UNSAVED_LINE)
|
|
await expect(historyButton(page, dict, 'undo')).toHaveAttribute(
|
|
'aria-disabled',
|
|
'true',
|
|
)
|
|
})
|
|
|
|
test('a delete confirmation and the discard confirmation close when the editor turns read-only', async ({
|
|
page,
|
|
}) => {
|
|
await open(page, spareCategory)
|
|
await openSection(page, dict, 'categories')
|
|
await page
|
|
.getByRole('listitem')
|
|
.filter({ has: page.locator('#category-cat-spare-name-fr') })
|
|
.getByRole('button', { name: dict['editor.action.delete'] })
|
|
.click()
|
|
await expect(dialogs(page)).toHaveCount(1)
|
|
await cross(page, NARROW)
|
|
await cross(page, WIDE)
|
|
await expect(dialogs(page)).toHaveCount(0)
|
|
await expect(page.locator('#category-cat-spare-name-fr')).toHaveCount(1)
|
|
await expect(saveLine(page)).not.toHaveText(UNSAVED_LINE)
|
|
|
|
await commitName(page, 'Nom à abandonner')
|
|
await page
|
|
.getByRole('button', { name: dict['editor.draft.discard'], exact: true })
|
|
.click()
|
|
await expect(dialogs(page)).toHaveCount(1)
|
|
await cross(page, NARROW)
|
|
await cross(page, WIDE)
|
|
await expect(saveLine(page)).toHaveText(UNSAVED_LINE)
|
|
})
|
|
})
|