U1 Lot B1. Four tabs (Général, Annotations, Constats, Vérification); views,
categories and regions become full-width Annotations sections opened from the
overview panel; references move to a header-toggled panel (minimal, Lot D
completes it); « Aller à » goes through EditorTarget and the navigation hook.
EditorWorkspace owns the navigation; DraftHeader split in HeaderActions and
SaveLine; EditorTabs split in TabList and MoreTabs.
R-24, assertions removed or rewritten (file: old -> new):
unit
- editor-route.test: seven tab names -> four; « Plus » at 800 px with
Références clicked -> no « Plus »; below 640 px five others -> Général,
Constats, and Constats opens the findings tab; + references panel cases
- editor-route-recovery.test: tab Références + editor-tab-references label ->
header button + editor-references-panel labelled by its heading
- editor-mode.test: small tier `more` of five -> [general, findings]
- editor-focus-request.test: {key,serial} -> {target,serial}; ReferencesTab and
VertebraeTab -> ReferencesPanel and RegionsSection; issueTarget tab/key ->
target place/section/key (vertebrae tab -> annotations/regions); consumed
context (serial) -> (serial, outcome); annotation case adds heading focus
- editor-verification.test: onGoTo('annotations', key) -> navigate(targetOfKey
(key), opener); props onSelectTab/onGoTo -> navigate
- editor-annotations-tab.test: props onSelectTab -> navigate + section props;
no_category text « (onglet Général) » -> « (Annotations, section
Catégories) »
- editor-tabs-general.test: categories cases render GeneralTab ->
CategoriesSection(doc); + Général holds no categories editor
- editor-tabs-lists.test: tab imports -> panel and section; read-only
references « no button » -> only « Fermer les références »
- editor-tabs-views, editor-drawing-upload, editor-repair.test: ViewsTab ->
ViewsSection import, assertions kept; editor-findings.test: navigate prop
e2e
- support/editor selectTab: exact name -> pattern (error badge in the name);
+ place, openSection, showDrawing, backToDrawing, openReferences, TABS
- support/warm-up: seven tabs -> four + sections + references panel
- editor-access: seven-tab axe loops -> four tabs + three sections + panel
(edit and read-only); narrow widths add panel overflow and axe
- editor-drawings: tab Vues -> openSection views; tab Annotations ->
showDrawing
- editor-structures: tab Général (categories) -> openSection categories, axe
label « general tab » -> « categories section »; tab Références ->
openReferences/closeReferences; tab Vertèbres -> openSection regions; tab
Annotations -> showDrawing
- editor-geometry: three tab Vues -> openSection views
- editor-equine: tab Général (categories add) -> openSection categories; five
tabs loop -> two tabs + sections + panel; tab Annotations -> showDrawing
- editor-journey: tab Vues, tab Général (category), tab Annotations ->
openSection views/categories, showDrawing; frozen axe scrolls to the header
- lan/trial-lan (not run): tab Vues -> Annotations tab + views entry
Verified: typecheck, lint, vitest 107 files / 1125 tests, whole shell suite on
the sandbox 151 passed, 49 skipped, 0 failed.
179 lines
6.3 KiB
TypeScript
179 lines
6.3 KiB
TypeScript
import { fr } from '@/i18n/fr'
|
|
import type { Page, TestInfo } from '@playwright/test'
|
|
import { expect, expectAccessible, test } from '../support/browser'
|
|
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
|
|
import {
|
|
DRAWING_SVG,
|
|
editorActor,
|
|
INKSCAPE_EXPORT,
|
|
openEditor,
|
|
openSection,
|
|
saveDraft,
|
|
seedDraft,
|
|
serverDocument,
|
|
showDrawing,
|
|
standardShape,
|
|
} from '../support/editor'
|
|
|
|
// V1-2.6 A2 (contract C16, C20): a drawing imported into a view. A hostile file is
|
|
// refused, an Inkscape export is cleaned after a preview, a valid file is attached, a
|
|
// detail view shows the drawing by crop. Both upload outcomes (the object is new, or the
|
|
// same bytes are already stored) end on the same screen.
|
|
|
|
const dict = fr
|
|
|
|
const HOSTILE_SVG =
|
|
'<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 400 300">' +
|
|
'<script>alert(1)</script><rect x="20" y="20" width="360" height="260"/></svg>'
|
|
|
|
const file = (svg: string | Buffer, name = 'dessin.svg') => ({
|
|
name,
|
|
mimeType: 'image/svg+xml',
|
|
buffer: Buffer.from(svg),
|
|
})
|
|
|
|
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
|
|
|
|
const mainFile = (page: Page) => page.getByTestId('view-main-file')
|
|
const mainDrawing = (page: Page) => page.getByTestId('view-main-drawing')
|
|
|
|
test.describe('editor drawings (A2)', () => {
|
|
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
|
test.beforeEach(async ({ context }, info) => {
|
|
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
|
await routeToSandbox(context)
|
|
})
|
|
test.afterEach(async ({ context }) => {
|
|
await dropLateReplays(context)
|
|
})
|
|
|
|
test('hostile file refused, nothing added, no cleaning box', async ({
|
|
page,
|
|
requests,
|
|
}) => {
|
|
const actor = await editorActor('fr')
|
|
requests.forbid(actor.account.email, actor.account.password)
|
|
const seed = await seedDraft(actor, { drawing: null })
|
|
await openEditor(page, dict, actor, seed.sheetId)
|
|
await openSection(page, dict, 'views')
|
|
await expect(
|
|
mainDrawing(page).getByText(dict['editor.views.drawing.none']),
|
|
).toBeVisible()
|
|
|
|
await mainFile(page).setInputFiles(file(HOSTILE_SVG, 'hostile.svg'))
|
|
await expect(
|
|
page.getByText(dict['editor.upload.err.svg_active_content']),
|
|
).toBeVisible()
|
|
await expect(
|
|
page.getByRole('dialog', { name: dict['editor.cleaning.title'] }),
|
|
).toHaveCount(0)
|
|
await expect(
|
|
mainDrawing(page).getByText(dict['editor.views.drawing.none']),
|
|
).toBeVisible()
|
|
await expect(page.getByText(dict['editor.upload.done'])).toHaveCount(0)
|
|
await expectAccessible(page, 'the refused drawing')
|
|
})
|
|
|
|
test('Inkscape export: preview, cancel adds nothing, confirm cleans and attaches', async ({
|
|
page,
|
|
requests,
|
|
}) => {
|
|
const actor = await editorActor('fr')
|
|
requests.forbid(actor.account.email, actor.account.password)
|
|
const seed = await seedDraft(actor, { drawing: null })
|
|
await openEditor(page, dict, actor, seed.sheetId)
|
|
await openSection(page, dict, 'views')
|
|
|
|
await mainFile(page).setInputFiles(
|
|
file(INKSCAPE_EXPORT, 'inkscape-1.4.3.svg'),
|
|
)
|
|
const dialog = page.getByRole('dialog', {
|
|
name: dict['editor.cleaning.title'],
|
|
})
|
|
await expect(dialog).toBeVisible()
|
|
await expect(
|
|
dialog.getByTestId('cleaning-preview').locator('svg'),
|
|
).toBeVisible()
|
|
await expect(
|
|
dialog.getByText(dict['editor.cleaning.removed']),
|
|
).toBeVisible()
|
|
await expectAccessible(page, 'the cleaning box')
|
|
await dialog
|
|
.getByRole('button', { name: dict['editor.cleaning.cancel'] })
|
|
.click()
|
|
await expect(dialog).toBeHidden()
|
|
await expect(
|
|
mainDrawing(page).getByText(dict['editor.views.drawing.none']),
|
|
).toBeVisible()
|
|
|
|
await mainFile(page).setInputFiles(
|
|
file(INKSCAPE_EXPORT, 'inkscape-1.4.3.svg'),
|
|
)
|
|
await dialog
|
|
.getByRole('button', { name: dict['editor.cleaning.confirm'] })
|
|
.click()
|
|
await expect(page.getByText(dict['editor.upload.done'])).toBeVisible()
|
|
await expect(
|
|
mainDrawing(page).getByText(dict['editor.views.drawing.ok']),
|
|
).toBeVisible()
|
|
await saveDraft(page, dict, seed.revision + 1)
|
|
const saved = await serverDocument<{
|
|
views: { svg_asset_id: string | null }[]
|
|
}>(seed.draftId)
|
|
expect(saved.views[0].svg_asset_id).not.toBeNull()
|
|
})
|
|
|
|
test('valid file attached; a detail view shows it by crop; the same bytes attach twice', async ({
|
|
page,
|
|
requests,
|
|
}) => {
|
|
const actor = await editorActor('fr')
|
|
requests.forbid(actor.account.email, actor.account.password)
|
|
const seed = await seedDraft(actor, { drawing: null, shape: standardShape })
|
|
await openEditor(page, dict, actor, seed.sheetId)
|
|
await openSection(page, dict, 'views')
|
|
|
|
await mainFile(page).setInputFiles(file(DRAWING_SVG, 'valide.svg'))
|
|
await expect(page.getByText(dict['editor.upload.done'])).toBeVisible()
|
|
await expect(
|
|
mainDrawing(page).getByText(dict['editor.views.drawing.ok']),
|
|
).toBeVisible()
|
|
|
|
// The detail view crops the main drawing: its own drawing line says it is inherited.
|
|
const detail = page.getByRole('listitem', { name: 'Détail A' })
|
|
await expect(
|
|
detail.getByText(dict['editor.views.drawing.inherited']),
|
|
).toBeVisible()
|
|
|
|
// The same bytes attached to the detail view: the stored object already exists.
|
|
await detail
|
|
.getByTestId('view-detail-a-file')
|
|
.setInputFiles(file(DRAWING_SVG))
|
|
await expect(
|
|
detail.getByText(dict['editor.views.drawing.ok']),
|
|
).toBeVisible()
|
|
await detail
|
|
.getByRole('button', { name: dict['editor.views.drawing.use_parent'] })
|
|
.click()
|
|
await page
|
|
.getByRole('dialog')
|
|
.getByRole('button', {
|
|
name: dict['editor.views.drawing.use_parent_confirm'],
|
|
})
|
|
.click()
|
|
await expect(
|
|
detail.getByText(dict['editor.views.drawing.inherited']),
|
|
).toBeVisible()
|
|
|
|
await showDrawing(page, dict)
|
|
await page
|
|
.getByRole('group', { name: dict['editor.annotations.views'] })
|
|
.getByRole('button', { name: 'Détail A' })
|
|
.click()
|
|
// The view shows the crop of the parent drawing, not the whole drawing.
|
|
await expect(
|
|
page.getByTestId('annotation-canvas-drawing').locator('svg').first(),
|
|
).toHaveAttribute('viewBox', '100 100 300 240')
|
|
})
|
|
})
|