Files
faunosteo/apps/app/tests/unit/editor-findings.test.tsx
T
bchanot 8db6f4287f feat(editor): contextual citations panel of a finding (board 25)
The panel opens only from a finding's « {n} références » trigger: 34 rem
at most, never wider than the room, a scrim, slide in 180 ms and out
140 ms (motion/react; none under reduced motion, callbacks still fire).
It lists the finding's references as tiles with « Modifier », « Retirer
de ce constat » (one « Défaire » restores it and the review status) and
« Aller à »; dangling ids read « Référence introuvable »; zero left
reads « Ce constat ne cite plus aucune référence. ». « Tout afficher
dans l'onglet Références » resets search and sort, keeps open tiles and
edits. Every close (✕, Escape outside fields, scrim, tab, « Aller à »,
« Tout afficher », element gone) records one pending move applied
after the exit, page inert until then; focus back to the trigger, else
the active tab button. A refused draft cancels a user close; a forced
close drops it and announces « Saisie non appliquée : {field} ». Places
keeps a permanent dvh min-height; the panel fits the visible viewport
at every scroll position, document size unchanged.

Gates: typecheck, lint, test:run (app 1488), build, e2e:ui 251;
e2e:shell 16 specs on db:sandbox (admin and editor-equine excluded):
117 passed / 107 skipped / 0 failed, rerun after the fix rounds: 118
passed / 108 skipped / 0 failed; layout spec 13 passed after round 2;
full-row guard: no pre-existing row changed in any table. Known limit:
landscape 667 x 375 at scroll 0 leaves ~13 px of panel (the trigger is
below the fold there).

## R-24 (removed or rewritten assertions)

| file | old | new |
|---|---|---|
| editor-references-panel.test.tsx (whole file) | R2.1 interim-panel tests, synchronous closes | rewritten: 39 tests (opening, motion, close matrix in both modes, exit, Retirer, P22'', library + history) |
| same, opening | heading `Références` focused right after the click | heading `Références citées` focused after the enter (`waitFor`), `aria-expanded` only after click |
| same | chip `references-filter-chip` « Citées par « Node A » (2) » | REMOVED (REVUE: path line + count line « 2 références citées par ce constat ») |
| same | `listitem` cards « Citée 2 fois » | tiles (`ul > li`) with the same counts, in the finding's order |
| same | field id `#panel-reference-0-ref-a-citation` present at once | tile opened + « Modifier » first (tiles since R2.2) |
| same | « Tout afficher (3) », sync | « Tout afficher dans l'onglet Références », after exit, heading focus asserted |
| same | Escape / ✕ / scrim / tab / vanish: sync null panel | all `await closed()` + `document.activeElement` checks, `describe.each` normal / reduced motion |
| same | « makes the tab panels inert while open, header usable » | split: inert page + inert panel until the exit ends then lifted; « Défaire / Refaire usable »; the `Enregistrer` enabled check dropped (covered by the focus-moved-off test) |
| same | Ctrl+Z test on an always-open field | open tile + Modifier first |
| same | read-only: no Supprimer, no textbox | open tile: no Modifier, no Retirer, no textbox |
| same | P6 under « Plus »: sync | in the close matrix, awaited |
| editor-escape.test.tsx (2 tests) | `expect(citations()).toBeNull()` right after Escape | `await waitFor(...)`; trigger `aria-expanded` false after exit |
| editor-keep-alive.test.tsx | « Escape in a citations panel field commits the text before the panel closes » | REPLACED by « Escape in a field of a panel tile neither closes nor commits » (A5, P27) |
| same | scrim click closes the panel after committing, sync, id on a closed tile | tile opened in edit first, close awaited, commit asserted before the exit |
| editor-focus-request.test.tsx | `ReferenceLibrary` with `resetSignal`; `ownedBy(ref,'citations')` undefined | `ReferencesTab` (+ `reloadSheet`); the `'citations'` assertion removed with the type |
| editor-references-tab / -view.test.tsx | `ReferenceLibrary`, `resetSignal` | `ReferencesTab`, `libraryReset` (+ `reloadSheet`) |
| e2e support `openCitations` | waited for the panel visible | also waits for the heading focus (slide over) |

New unit coverage: editor-citations-exit.test.tsx (hook, fake timers), editor-findings (aria-expanded per finding),
`useDecisionsOpen` gate, panel file (Retirer + status + one undo, P20 chain, zero state, dangling id, P4 reset, P6 after undo,
P22'' four paths, reduced motion, inert/exit, second close, tab replace, focus-moved-off).

## i18n (FR / EN)

Added: `editor.references.panel_title` Références citées / Cited references; `panel_count_one|other` « {count} référence citée par
ce constat » / « {count} références citées par ce constat » and « {count} reference cited by this finding » / « … references … »;
`panel_show_all` Tout afficher dans l'onglet Références / Show all in the References tab; `panel_empty` Ce constat ne cite plus
aucune référence. / This finding no longer cites any reference.; `remove_citation` Retirer de ce constat / Remove from this finding;
`this_finding` ce constat / this finding; `missing` Référence introuvable / Reference not found; `draft_dropped`
Saisie non appliquée : {field} / Entry not applied: {field}.
Changed: none. Removed: `editor.references.cited_by` (« Citées par « {name} » ({count}) » / « Cited by « {name} » ({count}) »),
`editor.references.show_all` (« Tout afficher ({count}) » / « Show all ({count}) »). R10 grep over src, tests and e2e including
editor-equine: no reader left. `editor-equine` has no panel reference: « updated, not run » (nothing to update). The three
provisional FR labels are exactly as listed in the brief; `…` = the refused field's label.
2026-11-12 22:27:32 +01:00

700 lines
25 KiB
TypeScript

/** Lot I: the Constats tree. */
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { cleanup, render, screen, within } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import type {
AnatomicalSheetDocument,
ElementKey,
FindingNode,
} from '@faunosteo/core-wasm/types'
import FindingCreateForm from '@/components/editor/findings/FindingCreateForm'
import FindingsTab from '@/components/editor/tabs/FindingsTab'
import { buildItems, keyMove, visibleItems } from '@/editor/findings/tree'
import { initialNavigation, navigationReducer } from '@/editor/navigation'
import { ReferencesOpenContext } from '@/editor/editingContext'
import { useLocaleStore } from '@/state/localeStore'
import { edit, insert } from '../helpers/editorFixtures'
import {
baseText,
openReady,
serverHas,
resetStore,
store,
} from '../helpers/editorHarness'
vi.mock('@/lib/supabase', () => ({ getSupabaseClient: () => ({}) }))
vi.mock('@faunosteo/supabase', async (orig) => ({
...(await orig<typeof import('@faunosteo/supabase')>()),
getSheetVersion: vi.fn(),
downloadSheetDrawing: vi.fn(),
saveSheetDraft: vi.fn(),
getOfficialSheetAdmin: vi.fn(),
submitSheetReview: vi.fn(),
}))
const props = { readOnly: false, navigate: vi.fn(), reloadSheet: vi.fn() }
const doc = (): AnatomicalSheetDocument =>
JSON.parse(store.getState().documentText)
const name = (n: string) => ({ fr: n, en: n })
const node = (id: string): FindingNode => ({
id,
name: name(id),
description: {},
requires_vet_referral: false,
reference_ids: [],
review_status: 'to_confirm',
children: [],
})
/** zone-a > fcat-a > node-a > node-b, and zone-b alone. */
function treeText(): string {
let text = insert(baseText(), {
kind: 'zone',
value: { id: 'zone-a', name: name('Zone A'), categories: [] },
})
text = insert(text, {
kind: 'zone',
value: { id: 'zone-b', name: name('Zone B'), categories: [] },
})
text = edit(text, {
op: 'insert',
parent: { kind: 'zone', id: 'zone-a' },
element: {
kind: 'finding_category',
value: {
id: 'fcat-a',
kind: 'dysfunction',
name: name('Cat A'),
description: {},
reference_ids: [],
review_status: 'to_confirm',
children: [],
},
},
})
const under = (id: string, path: string[]) =>
edit(text, {
op: 'insert',
parent: { kind: 'finding', zone_id: 'zone-a', path },
element: { kind: 'finding_node', value: node(id) },
})
text = under('node-a', ['fcat-a'])
return under('node-b', ['fcat-a', 'node-a'])
}
beforeEach(() => useLocaleStore.setState({ locale: 'fr' }))
afterEach(() => {
cleanup()
resetStore()
})
const items = () => screen.getAllByRole('treeitem')
const labels = () => items().map((i) => i.textContent ?? '')
describe('findings tree model', () => {
it('flattens in order and hides collapsed branches', async () => {
await openReady({ text: treeText() })
const all = buildItems(doc())
expect(all.map((i) => i.level)).toEqual([1, 2, 3, 4, 1])
const shown = visibleItems(all, new Set(['["zone-a"]']))
expect(shown.map((i) => i.kind)).toEqual(['zone', 'category', 'zone'])
})
it('loads a stored draft whose nodes omit defaulted fields, filled and clean', async () => {
const stored = JSON.parse(baseText()) as Record<string, unknown>
const bare = {
id: 'n1',
name: name('N1'),
children: [{ id: 'n2', name: name('N2') }],
}
stored.finding_zones = [
{
id: 'z',
name: name('Z'),
categories: [
{ id: 'c', kind: 'dysfunction', name: name('C'), children: [bare] },
],
},
]
await openReady({ text: JSON.stringify(stored) })
const n2 = doc().finding_zones[0].categories[0].children[0].children[0]
expect(n2).toMatchObject({
reference_ids: [],
children: [],
review_status: 'inherited',
})
render(<FindingsTab {...props} />)
expect(screen.getAllByRole('treeitem').length).toBeGreaterThan(0)
})
it('a reload that brings bare nodes keeps the filled text, not dirty', async () => {
await openReady()
const stored = JSON.parse(baseText()) as Record<string, unknown>
stored.finding_zones = [
{
id: 'z',
name: name('Z'),
categories: [
{
id: 'c',
kind: 'dysfunction',
name: name('C'),
children: [{ id: 'n1', name: name('N1') }],
},
],
},
]
serverHas(JSON.stringify(stored), 7)
expect(
await store.getState().reloadServerDraft({ confirmed: true }),
).toEqual({
ok: true,
})
const state = store.getState()
expect(state.unsaved).toBe(false)
expect(state.savedText).toBe(state.documentText)
expect(state.savedRevision).toBe(7)
expect(doc().finding_zones[0].categories[0].children[0]).toMatchObject({
reference_ids: [],
children: [],
review_status: 'inherited',
})
})
it('maps the WAI-ARIA keys', async () => {
await openReady({ text: treeText() })
const all = buildItems(doc())
const open = new Set(all.map((i) => i.id))
const [zone, category] = all
expect(keyMove(all, zone, open, 'ArrowDown')).toEqual({
select: category.id,
})
expect(keyMove(all, category, open, 'ArrowLeft')).toEqual({
collapse: category.id,
})
expect(keyMove(all, all[4], open, 'ArrowRight')).toBeNull()
expect(keyMove(all, all[4], open, 'End')).toEqual({ select: all[4].id })
expect(keyMove(all, zone, new Set(), 'ArrowRight')).toEqual({
expand: zone.id,
})
})
})
describe('Constats tab', () => {
it('renders a tree with levels, and zones carry no badge', async () => {
await openReady({ text: treeText() })
render(<FindingsTab {...props} />)
expect(screen.getByRole('tree')).toBeInTheDocument()
const [zoneA] = items()
expect(zoneA).toHaveAttribute('aria-level', '1')
expect(zoneA).toHaveAttribute('aria-expanded', 'true')
expect(within(zoneA).queryByText('À confirmer')).toBeNull()
expect(items()).toHaveLength(3)
expect(within(items()[1]).getByText('À confirmer')).toBeInTheDocument()
})
it('moves with the arrows, opens and closes branches', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
items()[0].focus()
await user.keyboard('{ArrowDown}')
expect(items()[1]).toHaveFocus()
expect(items()[1]).toHaveAttribute('aria-selected', 'true')
await user.keyboard('{ArrowRight}')
expect(items()).toHaveLength(4)
await user.keyboard('{ArrowRight}')
expect(items()[2]).toHaveFocus()
await user.keyboard('{ArrowLeft}')
expect(items()[1]).toHaveFocus()
await user.keyboard('{ArrowLeft}')
expect(items()).toHaveLength(3)
await user.keyboard('{ArrowLeft}')
expect(items()[0]).toHaveFocus()
})
it('creates a zone only with both names', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(screen.getByRole('button', { name: 'Ajouter une zone' }))
await user.type(
screen.getByLabelText('Nom (FR)', { selector: '#finding-new-name-fr' }),
'Tête',
)
await user.click(screen.getByRole('button', { name: 'Créer' }))
expect(screen.getByRole('alert')).toHaveTextContent('Renseignez le nom')
expect(doc().finding_zones).toHaveLength(2)
await user.type(
screen.getByLabelText('Nom (EN)', { selector: '#finding-new-name-en' }),
'Head',
)
await user.click(screen.getByRole('button', { name: 'Créer' }))
expect(doc().finding_zones).toHaveLength(3)
expect(doc().finding_zones[2].id).toMatch(/^zone-[a-z2-7]{10}$/)
expect(
screen.getByLabelText('Nom (FR)', { selector: '#finding-name-fr' }),
).toHaveValue('Tête')
})
it('creates a category with a kind and a node under the selection', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[0])
await user.click(
screen.getByRole('button', { name: 'Ajouter une catégorie' }),
)
await user.type(
screen.getByLabelText('Nom (FR)', { selector: '#finding-new-name-fr' }),
'Nouv',
)
await user.type(
screen.getByLabelText('Nom (EN)', { selector: '#finding-new-name-en' }),
'New',
)
await user.click(screen.getByRole('button', { name: 'Créer' }))
expect(screen.getByRole('alert')).toBeInTheDocument()
await user.selectOptions(screen.getByLabelText('Zone'), 'zone-a')
await user.click(screen.getByRole('button', { name: 'Créer' }))
expect(screen.getByRole('alert')).toBeInTheDocument()
await user.selectOptions(
screen.getByLabelText('Type de catégorie'),
'anamnesis',
)
await user.click(screen.getByRole('button', { name: 'Créer' }))
const categories = doc().finding_zones[0].categories
expect(categories).toHaveLength(2)
expect(categories[1]).toMatchObject({
kind: 'anamnesis',
review_status: 'to_confirm',
})
await user.click(screen.getByRole('button', { name: 'Ajouter un constat' }))
await user.type(
screen.getByLabelText('Nom (FR)', { selector: '#finding-new-name-fr' }),
'Fr',
)
await user.type(
screen.getByLabelText('Nom (EN)', { selector: '#finding-new-name-en' }),
'En',
)
await user.click(screen.getByRole('button', { name: 'Créer' }))
expect(doc().finding_zones[0].categories[1].children).toHaveLength(1)
})
async function fillCategory(user: ReturnType<typeof userEvent.setup>) {
await user.type(
screen.getByLabelText('Nom (FR)', { selector: '#finding-new-name-fr' }),
'Nouv',
)
await user.type(
screen.getByLabelText('Nom (EN)', { selector: '#finding-new-name-en' }),
'New',
)
await user.selectOptions(
screen.getByLabelText('Type de catégorie'),
'anamnesis',
)
}
it('lands in the zone chosen in the form, not the zone of the selected node (C46)', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
items()[0].focus()
await user.keyboard('{ArrowDown}{ArrowRight}{ArrowRight}')
expect(items()[2]).toHaveAttribute('aria-selected', 'true')
await user.click(
screen.getByRole('button', { name: 'Ajouter une catégorie' }),
)
expect(screen.getByLabelText('Zone')).toHaveValue('')
await user.selectOptions(screen.getByLabelText('Zone'), 'zone-b')
expect(
screen.getByText('Nouvelle catégorie dans la zone « Zone B »'),
).toBeInTheDocument()
await fillCategory(user)
await user.click(screen.getByRole('button', { name: 'Créer' }))
expect(doc().finding_zones[1].categories).toHaveLength(1)
expect(doc().finding_zones[1].categories[0].kind).toBe('anamnesis')
expect(doc().finding_zones[0].categories.map((c) => c.id)).toEqual([
'fcat-a',
])
})
it('appends the category after the existing ones of the chosen zone', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(
screen.getByRole('button', { name: 'Ajouter une catégorie' }),
)
await user.selectOptions(screen.getByLabelText('Zone'), 'zone-a')
await fillCategory(user)
await user.click(screen.getByRole('button', { name: 'Créer' }))
const ids = doc().finding_zones[0].categories.map((c) => c.id)
expect(ids).toEqual(['fcat-a', expect.any(String)])
})
it('is enabled with nothing selected and preselects nothing among several zones', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
const add = screen.getByRole('button', { name: 'Ajouter une catégorie' })
expect(add).toBeEnabled()
await user.click(items()[2])
await user.click(add)
expect(screen.getByLabelText('Zone')).toHaveValue('')
})
it('preselects the zone when exactly one exists', async () => {
const text = edit(baseText(), {
op: 'insert',
element: {
kind: 'zone',
value: { id: 'zone-a', name: name('Zone A'), categories: [] },
},
})
await openReady({ text })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(
screen.getByRole('button', { name: 'Ajouter une catégorie' }),
)
expect(screen.getByLabelText('Zone')).toHaveValue('zone-a')
expect(
screen.getByText('Nouvelle catégorie dans la zone « Zone A »'),
).toBeInTheDocument()
})
it('is disabled with its hint while no zone exists', async () => {
await openReady()
render(<FindingsTab {...props} />)
expect(
screen.getByRole('button', { name: 'Ajouter une catégorie' }),
).toBeDisabled()
expect(
screen.getByText("Créez d'abord une zone pour ajouter une catégorie."),
).toBeInTheDocument()
})
it('disables « Ajouter un constat » on a zone and at depth 8', async () => {
let text = treeText()
let path = ['fcat-a', 'node-a', 'node-b']
for (let i = 0; i < 5; i++) {
const id = `deep-${i}`
text = edit(text, {
op: 'insert',
parent: { kind: 'finding', zone_id: 'zone-a', path },
element: { kind: 'finding_node', value: node(id) },
})
path = [...path, id]
}
await openReady({ text })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
const add = screen.getByRole('button', { name: 'Ajouter un constat' })
await user.click(items()[0])
expect(add).toBeDisabled()
await user.click(items()[1])
for (let i = 0; i < 30; i++) {
if (document.activeElement?.getAttribute('aria-level') === '8') break
await user.keyboard('{ArrowRight}')
}
expect(add).toBeEnabled()
await user.keyboard('{ArrowRight}{ArrowRight}')
expect(document.activeElement).toHaveAttribute('aria-level', '9')
expect(add).toBeDisabled()
})
it('renames, marks reviewed and resets to confirm', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[1])
await user.click(screen.getByRole('button', { name: 'Marquer comme relu' }))
expect(doc().finding_zones[0].categories[0].review_status).toBe('reviewed')
expect(within(items()[1]).getByText('Relu')).toBeInTheDocument()
await user.click(
screen.getByRole('button', { name: 'Remettre à confirmer' }),
)
expect(doc().finding_zones[0].categories[0].review_status).toBe(
'to_confirm',
)
const fr = screen.getByLabelText('Nom (FR)', {
selector: '#finding-name-fr',
})
await user.clear(fr)
await user.type(fr, 'Renommée')
await user.tab()
expect(doc().finding_zones[0].categories[0].name.fr).toBe('Renommée')
})
it('marks a node with set_status and a zone with mark_reviewed', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[0])
expect(
screen.queryByRole('button', { name: 'Remettre à confirmer' }),
).toBeNull()
await user.click(screen.getByRole('button', { name: 'Marquer comme relu' }))
const cat = doc().finding_zones[0].categories[0]
expect(cat.review_status).toBe('reviewed')
expect(cat.children[0].children[0].review_status).toBe('reviewed')
await user.click(items()[1])
await user.keyboard('{ArrowRight}{ArrowDown}')
await user.click(
screen.getByRole('button', { name: 'Remettre à confirmer' }),
)
expect(doc().finding_zones[0].categories[0].children[0].review_status).toBe(
'to_confirm',
)
})
it('reorders siblings with the arrows', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[1])
expect(screen.getByRole('button', { name: 'Monter' })).toBeDisabled()
await user.click(items()[0])
await user.click(screen.getByRole('button', { name: 'Descendre' }))
expect(doc().finding_zones.map((z) => z.id)).toEqual(['zone-b', 'zone-a'])
expect(labels()[0]).toContain('Zone B')
})
it('deletes with the descendants listed, then removes them', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[1])
await user.click(screen.getByRole('button', { name: 'Supprimer' }))
const dialog = await screen.findByRole('dialog')
expect(within(dialog).getByText(/aussi supprimés/)).toBeInTheDocument()
expect(within(dialog).getAllByRole('listitem')).toHaveLength(2)
await user.click(within(dialog).getByRole('button', { name: 'Supprimer' }))
expect(doc().finding_zones[0].categories).toEqual([])
expect(screen.queryByText('Cat A')).toBeNull()
})
it('lists the annotations that still use a zone and offers no deletion', async () => {
let text = treeText()
const anno = JSON.parse(text).annotations[0]
text = edit(text, {
op: 'update',
key: { kind: 'annotation', id: 'anno-a' },
element: {
kind: 'annotation',
value: { ...anno, finding_zone_id: 'zone-a' },
},
})
await openReady({ text })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[0])
await user.click(screen.getByRole('button', { name: 'Supprimer' }))
const dialog = await screen.findByRole('dialog')
expect(
within(dialog).getByText(/ne peut pas être supprimé/),
).toBeInTheDocument()
expect(
within(dialog).queryByRole('button', { name: 'Supprimer' }),
).toBeNull()
expect(doc().finding_zones).toHaveLength(2)
})
it('is plain text and keyboard-navigable when read-only', async () => {
await openReady({ text: treeText() })
render(<FindingsTab {...props} readOnly />)
expect(
screen.queryByRole('button', { name: 'Ajouter une zone' }),
).toBeNull()
expect(screen.queryByRole('button', { name: 'Supprimer' })).toBeNull()
expect(items()).toHaveLength(3)
const user = userEvent.setup()
await user.click(items()[1])
expect(screen.queryByRole('textbox')).toBeNull()
expect(document.querySelector('#finding-name-fr')).toHaveTextContent(
'Cat A',
)
})
it('edits descriptions (blank side omitted), the vet flag and the cited references', async () => {
let text = treeText()
text = insert(text, {
kind: 'reference',
value: {
id: 'ref-a',
type: 'book',
citation: 'Alpha',
url: null,
doi: null,
},
})
await openReady({ text })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[1])
await user.keyboard('{ArrowRight}{ArrowDown}')
const node = () => doc().finding_zones[0].categories[0].children[0]
const fr = screen.getByLabelText('Description (FR)')
await user.type(fr, 'Texte')
await user.tab()
expect(node().description).toEqual({ fr: 'Texte' })
await user.clear(fr)
await user.tab()
expect(node().description).toEqual({})
await user.click(screen.getByLabelText('Renvoi vers un vétérinaire'))
expect(node().requires_vet_referral).toBe(true)
await user.selectOptions(
screen.getByLabelText('Citer une référence'),
'ref-a',
)
expect(node().reference_ids).toEqual(['ref-a'])
await user.click(screen.getByRole('button', { name: /Retirer Alpha/ }))
expect(node().reference_ids).toEqual([])
})
it('the trigger shows exactly for the keys open_citations accepts', async () => {
let text = insert(treeText(), {
kind: 'reference',
value: { id: 'ref-a', type: 'book', citation: 'A', url: null, doi: null },
})
for (const item of buildItems(JSON.parse(text))) {
if (item.element.kind === 'zone') continue
text = edit(text, {
op: 'update',
key: item.key,
element: {
...item.element,
value: { ...item.element.value, reference_ids: ['ref-a'] },
} as never,
})
}
await openReady({ text })
const user = userEvent.setup()
const openCitations = vi.fn()
render(<FindingsTab {...props} openCitations={openCitations} />)
await user.click(items()[1])
await user.keyboard('{ArrowRight}{ArrowDown}{ArrowRight}')
const all = buildItems(doc())
expect(items()).toHaveLength(all.length)
const truth: [string, boolean][] = []
for (const [index, item] of all.entries()) {
await user.click(items()[index])
const shown = screen.queryByRole('button', { name: /^1 référence$/ })
const start = initialNavigation('findings')
const accepted =
navigationReducer(start, { type: 'open_citations', citedBy: item.key })
.citationsOf !== null
expect(shown !== null, item.id).toBe(accepted)
truth.push([item.kind, shown !== null])
}
expect(truth).toEqual([
['zone', false],
['category', false],
['node', true],
['node', true],
['zone', false],
])
expect(all.some((item) => item.kind === 'category')).toBe(true)
expect(all.filter((item) => item.kind === 'node')).toHaveLength(2)
})
it('the trigger reads « expanded » only for the finding the panel shows', async () => {
let text = insert(treeText(), {
kind: 'reference',
value: { id: 'ref-a', type: 'book', citation: 'A', url: null, doi: null },
})
const nodes = buildItems(JSON.parse(text)).filter((i) => i.kind === 'node')
for (const item of nodes) {
text = edit(text, {
op: 'update',
key: item.key,
element: {
...item.element,
value: { ...item.element.value, reference_ids: ['ref-a'] },
} as never,
})
}
await openReady({ text })
const user = userEvent.setup()
const shows = (citationsOf: ElementKey | null) => (
<ReferencesOpenContext value={citationsOf}>
<FindingsTab {...props} openCitations={vi.fn()} />
</ReferencesOpenContext>
)
const { rerender } = render(shows(nodes[1].key))
await user.click(items()[1])
await user.keyboard('{ArrowRight}{ArrowDown}')
await user.click(items()[2])
const trigger = () => screen.getByRole('button', { name: /^1 référence$/ })
expect(trigger()).toHaveAttribute('aria-expanded', 'false')
rerender(shows(nodes[0].key))
expect(trigger()).toHaveAttribute('aria-expanded', 'true')
rerender(shows(null))
expect(trigger()).toHaveAttribute('aria-expanded', 'false')
})
it('a category has no vet flag; read-only hides the editing actions', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
const { rerender } = render(<FindingsTab {...props} />)
await user.click(items()[1])
expect(screen.queryByLabelText('Renvoi vers un vétérinaire')).toBeNull()
rerender(<FindingsTab {...props} readOnly />)
expect(screen.queryByLabelText('Citer une référence')).toBeNull()
expect(screen.queryByRole('textbox')).toBeNull()
})
it('collapsing an ancestor of the selection selects the ancestor', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[1])
await user.keyboard('{ArrowRight}{ArrowRight}')
expect(items()[2]).toHaveAttribute('aria-selected', 'true')
await user.click(items()[0].querySelector('span') as HTMLElement)
expect(items()[0]).toHaveAttribute('aria-selected', 'true')
expect(items()).toHaveLength(2)
})
it('after a delete the previous sibling, else the parent, is selected and focused', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(<FindingsTab {...props} />)
await user.click(items()[2])
await user.click(screen.getByRole('button', { name: 'Supprimer' }))
const dialog = await screen.findByRole('dialog')
await user.click(within(dialog).getByRole('button', { name: 'Supprimer' }))
expect(doc().finding_zones.map((z) => z.id)).toEqual(['zone-a'])
expect(items()[0]).toHaveAttribute('aria-selected', 'true')
expect(items()[0]).toHaveFocus()
await user.click(items()[1])
await user.click(screen.getAllByRole('button', { name: 'Supprimer' })[0])
const second = (await screen.findAllByRole('dialog')).at(-1) as HTMLElement
await user.click(within(second).getByRole('button', { name: 'Supprimer' }))
expect(items()[0]).toHaveAttribute('aria-selected', 'true')
expect(items()[0]).toHaveFocus()
})
})
describe('the category form title (N1 review, C46)', () => {
it('names the chosen zone, and falls back to an existing label before the choice', async () => {
await openReady({ text: treeText() })
const user = userEvent.setup()
render(
<FindingCreateForm
pending={{ kind: 'category', parent: null }}
onCreated={vi.fn()}
onCancel={vi.fn()}
/>,
)
const title = () => document.querySelector('p.font-medium')?.textContent
expect(title()).toBe('Ajouter une catégorie')
await user.selectOptions(screen.getByLabelText('Zone'), 'zone-a')
expect(title()).toBe('Nouvelle catégorie dans la zone « Zone A »')
})
})