U2 Task 7 (A2, A4, A5, A7, A12, A15; R-3, R-4, R-12, R-13, R-14). The work store's `creation` owns the new shape, its form, its view and F: a click with the point tool, a closed tracing or a keyboard « Ajouter … » opens « Nouveau point / zone / accès », a modal without a history layer over the right column, mounted beside EditOnly so a read-only flip keeps it (« Créer », « Replacer », « Reprendre » off). A new zone or link is a creation from its first vertex. The ghost takes the form's category colour; the point tool previews under a mouse; the canvas carries data-creating (other markers dimmed, unselectable). « Replacer le point » / « Reprendre le tracé » hide the dialog and keep the form; the strip offers « Revenir aux propriétés », « Retirer le dernier sommet », « Abandonner ». « Créer »: one insert, tool back to « Sélectionner », the new element selected, « Point créé · Défaire », focus on its row. ✕, Échap, « Abandonner » and Back always ask « Abandonner la création ? » (DiscardConfirm inside the dialog; DrawingGuardDialog elsewhere); answerDrawing drops the creation. Undo, its shortcuts and the line's « Défaire » are inactive during a creation. missingFields replaces formProblem (MissingSummary shared with the edit form); the C26 notice has no numbers. CreationPanel, formProblem, withGeometry and the keys required.fields, required.names and create_cancel are gone; GeometryGroup is imported by RepairDialog only. Removed or rewritten assertions: - tab « holds a point at the frame centre »: « Centre x » = 50 -> the ghost circle cx = 50; plus tool back to Sélectionner, « Point créé », one undo step. - tab « refuses a creation without laterality »: the general line « Choisissez la catégorie et la latéralité » -> only « Choisissez une latéralité. » and « À compléter : Latéralité. », focus on it. - tab « applies the geometry group to a pending zone »: removed (A8, no coordinate field) -> « places a triangle at the centre: the ghost shows it, Créer inserts it »; vertex edits after Créer are the e2e keyboard test. - tab C26 « proposes C »: « x = 15, y = 15 » in the notice -> the R-4 text, the notice inside the dialog; cancel test « Centre x » = 0 -> ghost cx = 0. - tab « offers the correction when the core refuses a pending point » (typed cx 98): removed, no typed coordinate is possible; the verdict path stays covered by the C26 click tests and correctionFor units. - tab H5 « a typed radius shows the core issue »: removed (A8); the size refusal is the slider's (Task 4 tests). - tab H6 « a second click moves the pending point »: -> « Replacer le point », then the click moves the ghost, the form kept. - tab H7 « Centre x/y » = 30/50 -> ghost cx/cy. - tab tracing Enter: « x du sommet 3 » -> ghost points; « drops the tracing on Escape » -> Escape asks first (board 32 row 3), Continuer keeps, Abandonner drops; new « Annuler le tracé acts at once ». - keep-alive « a pending creation is kept and focused » and « a tracing … is kept and focused »: the tab now asks first (R-12) -> « Continuer » keeps the tracing / the form, « Abandonner » goes. - sections « its panel takes the focus » -> its dialog's [data-creation-focus] takes it. - no-loss « pending creation with its name » (hidden with the body) -> the dialog stays across the crossing, read-only, Créer off (R-14). - point-edit A5 « Rayon » = 7 / 9 -> ghost r = 7 / 9. - e2e editor-annotations keyboard test « numeric position » (cx field 250) -> UX_TESTS Keyboard: zone added, vertex added and removed, moved by the move mode, validated, saved. The « Fermer le tracé » step runs under expectNoShift again (shortcut removed). - e2e editor-geometry C26: the proposed x, y read from the notice text -> from the overlay's correction circle; the R-4 text checked in the dialog. - e2e editor-deselect « Escape cancels the tracing only » -> Escape asks, « Abandonner » cancels it, the selection kept. - e2e editor-shell-crossing « keeps its tool and its pending creation » (field hidden) -> the dialog stays read-only, Créer off, then editable on widening.
250 lines
8.1 KiB
TypeScript
250 lines
8.1 KiB
TypeScript
/** Lot N2: sign-out asks only when something would be lost (contract C43). */
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { cleanup, render, screen, waitFor } from '@testing-library/react'
|
|
import userEvent from '@testing-library/user-event'
|
|
import { MemoryRouter } from 'react-router-dom'
|
|
import SignOutButton from '@/components/shell/SignOutButton'
|
|
import { copyKey } from '@/editor/state/recovery'
|
|
import { useEditorStore } from '@/editor/state/editorStore'
|
|
import { useAuthStore } from '@/state/authStore'
|
|
import { useLocaleStore } from '@/state/localeStore'
|
|
import { fr } from '@/i18n/fr'
|
|
import { fakeUser } from '../helpers/fakeSupabase'
|
|
import DrawingGuardDialog from '@/components/editor/annotations/DrawingGuardDialog'
|
|
import { guardDrawing } from '@/editor/annotations/drawingGuard'
|
|
import {
|
|
resetWork,
|
|
markRedraw,
|
|
setModePreview,
|
|
startMove,
|
|
startRedraw,
|
|
useAnnotationWork,
|
|
} from '@/editor/annotations/workStore'
|
|
import { useLeaveGuardStore } from '@/state/leaveGuardStore'
|
|
import { emptyForm } from '@/editor/annotations/creation'
|
|
import { traceVertex } from '@/editor/annotations/creationWork'
|
|
|
|
const user = fakeUser()
|
|
const OTHER = 'bbbbbbbb-0000-0000-0000-000000000002'
|
|
const signOut = vi.fn(() => Promise.resolve())
|
|
|
|
beforeEach(() => {
|
|
useLocaleStore.setState({ locale: 'fr' })
|
|
useAuthStore.setState({ status: 'signed_in', user, signOut })
|
|
useEditorStore.setState({ unsaved: false, recovery: 'none' })
|
|
})
|
|
afterEach(() => {
|
|
cleanup()
|
|
sessionStorage.clear()
|
|
signOut.mockClear()
|
|
})
|
|
|
|
const click = () =>
|
|
userEvent.click(screen.getByRole('button', { name: fr['shell.sign_out'] }))
|
|
|
|
function mount() {
|
|
render(
|
|
<MemoryRouter>
|
|
<SignOutButton />
|
|
</MemoryRouter>,
|
|
)
|
|
}
|
|
|
|
describe('SignOutButton', () => {
|
|
it('signs out at once when nothing would be lost', async () => {
|
|
mount()
|
|
await click()
|
|
expect(screen.queryByRole('dialog')).toBeNull()
|
|
await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1))
|
|
})
|
|
|
|
it('asks when the editor holds unsaved changes, and cancel keeps everything', async () => {
|
|
useEditorStore.setState({ unsaved: true })
|
|
sessionStorage.setItem(copyKey(user.id, 'v1'), '{}')
|
|
mount()
|
|
await click()
|
|
expect(screen.getByRole('dialog')).toBeTruthy()
|
|
await userEvent.click(
|
|
screen.getByRole('button', { name: fr['shell.sign_out_loss_cancel'] }),
|
|
)
|
|
expect(signOut).not.toHaveBeenCalled()
|
|
expect(sessionStorage.getItem(copyKey(user.id, 'v1'))).toBe('{}')
|
|
})
|
|
|
|
it('asks when a pending recovery offer exists', async () => {
|
|
useEditorStore.setState({ recovery: 'pending' })
|
|
mount()
|
|
await click()
|
|
expect(screen.getByRole('dialog')).toBeTruthy()
|
|
})
|
|
|
|
it('asks for a copy of its own, then confirming purges only that account and signs out', async () => {
|
|
sessionStorage.setItem(copyKey(user.id, 'v1'), '{}')
|
|
sessionStorage.setItem(copyKey(OTHER, 'v1'), '{}')
|
|
mount()
|
|
await click()
|
|
await userEvent.click(
|
|
screen.getByRole('button', { name: fr['shell.sign_out_loss_confirm'] }),
|
|
)
|
|
await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1))
|
|
expect(sessionStorage.getItem(copyKey(user.id, 'v1'))).toBeNull()
|
|
expect(sessionStorage.getItem(copyKey(OTHER, 'v1'))).toBe('{}')
|
|
})
|
|
|
|
it('purges again when a copy is written while the sign-out is in flight', async () => {
|
|
sessionStorage.setItem(copyKey(user.id, 'v1'), '{}')
|
|
signOut.mockImplementationOnce(async () => {
|
|
sessionStorage.setItem(copyKey(user.id, 'v2'), '{}')
|
|
})
|
|
mount()
|
|
await click()
|
|
await userEvent.click(
|
|
screen.getByRole('button', { name: fr['shell.sign_out_loss_confirm'] }),
|
|
)
|
|
await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1))
|
|
await waitFor(() =>
|
|
expect(sessionStorage.getItem(copyKey(user.id, 'v2'))).toBeNull(),
|
|
)
|
|
})
|
|
|
|
it('ignores the copies of another account', async () => {
|
|
sessionStorage.setItem(copyKey(OTHER, 'v1'), '{}')
|
|
mount()
|
|
await click()
|
|
expect(screen.queryByRole('dialog')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('SignOutButton and a started move on the drawing (R-12)', () => {
|
|
const STORED = { type: 'circle' as const, cx: 1, cy: 2, r: 3 }
|
|
beforeEach(() => {
|
|
useLeaveGuardStore.getState().setAsk(guardDrawing)
|
|
startMove('a', 'doc')
|
|
setModePreview({ ...STORED, cx: 9 }, STORED)
|
|
})
|
|
afterEach(() => {
|
|
useLeaveGuardStore.getState().setAsk(null)
|
|
resetWork()
|
|
})
|
|
function mountWithGuard() {
|
|
render(
|
|
<MemoryRouter>
|
|
<SignOutButton />
|
|
<DrawingGuardDialog />
|
|
</MemoryRouter>,
|
|
)
|
|
}
|
|
const question = () =>
|
|
screen.queryByRole('dialog', { name: 'Abandonner le déplacement ?' })
|
|
|
|
it('asks the drawing question, never the sign-out text; « Continuer » stays', async () => {
|
|
mountWithGuard()
|
|
await click()
|
|
expect(question()).not.toBeNull()
|
|
expect(screen.queryByText(fr['shell.sign_out_loss_title'])).toBeNull()
|
|
await userEvent.click(screen.getByRole('button', { name: 'Continuer' }))
|
|
expect(signOut).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('« Abandonner » signs out when nothing else is at stake', async () => {
|
|
mountWithGuard()
|
|
await click()
|
|
await userEvent.click(screen.getByRole('button', { name: 'Abandonner' }))
|
|
await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1))
|
|
})
|
|
|
|
it('with unsaved sheet changes too: the drawing first, then the sheet question', async () => {
|
|
useEditorStore.setState({ unsaved: true })
|
|
mountWithGuard()
|
|
await click()
|
|
expect(screen.queryByText(fr['shell.sign_out_loss_title'])).toBeNull()
|
|
await userEvent.click(screen.getByRole('button', { name: 'Abandonner' }))
|
|
expect(
|
|
await screen.findByText(fr['shell.sign_out_loss_title']),
|
|
).toBeTruthy()
|
|
expect(signOut).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('SignOutButton and a started redraw (R-12)', () => {
|
|
beforeEach(() => {
|
|
useLeaveGuardStore.getState().setAsk(guardDrawing)
|
|
startRedraw('a', 'doc')
|
|
markRedraw(true)
|
|
})
|
|
afterEach(() => {
|
|
useLeaveGuardStore.getState().setAsk(null)
|
|
resetWork()
|
|
})
|
|
|
|
it('asks « Abandonner le nouveau tracé ? »; « Abandonner » signs out', async () => {
|
|
render(
|
|
<MemoryRouter>
|
|
<SignOutButton />
|
|
<DrawingGuardDialog />
|
|
</MemoryRouter>,
|
|
)
|
|
await click()
|
|
expect(
|
|
screen.getByRole('dialog', { name: 'Abandonner le nouveau tracé ?' }),
|
|
).toBeInTheDocument()
|
|
expect(signOut).not.toHaveBeenCalled()
|
|
await userEvent.click(screen.getByRole('button', { name: 'Abandonner' }))
|
|
await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1))
|
|
})
|
|
|
|
it('an unstarted redraw signs out at once and ends', async () => {
|
|
markRedraw(false)
|
|
render(
|
|
<MemoryRouter>
|
|
<SignOutButton />
|
|
<DrawingGuardDialog />
|
|
</MemoryRouter>,
|
|
)
|
|
await click()
|
|
await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1))
|
|
expect(screen.queryByRole('dialog')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('SignOutButton during a creation (R-12, A12)', () => {
|
|
beforeEach(() => {
|
|
useLeaveGuardStore.getState().setAsk(guardDrawing)
|
|
// A tracing with one vertex: no dialog, a shape exists.
|
|
traceVertex(
|
|
{
|
|
viewId: 'v',
|
|
frame: null,
|
|
origin: 'tool',
|
|
form: emptyForm({ categories: [] } as never),
|
|
},
|
|
'zone',
|
|
[1, 1],
|
|
)
|
|
})
|
|
afterEach(() => {
|
|
useLeaveGuardStore.getState().setAsk(null)
|
|
resetWork()
|
|
})
|
|
|
|
it('asks « Abandonner la création ? »; « Continuer » keeps it, « Abandonner » signs out', async () => {
|
|
render(
|
|
<MemoryRouter>
|
|
<SignOutButton />
|
|
<DrawingGuardDialog />
|
|
</MemoryRouter>,
|
|
)
|
|
await click()
|
|
expect(
|
|
screen.getByRole('dialog', { name: 'Abandonner la création ?' }),
|
|
).toBeInTheDocument()
|
|
await userEvent.click(screen.getByRole('button', { name: 'Continuer' }))
|
|
expect(signOut).not.toHaveBeenCalled()
|
|
expect(useAnnotationWork.getState().creation).not.toBeNull()
|
|
await click()
|
|
await userEvent.click(screen.getByRole('button', { name: 'Abandonner' }))
|
|
await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1))
|
|
expect(useAnnotationWork.getState().creation).toBeNull()
|
|
})
|
|
})
|