Files
faunosteo/tests/unit/pdf.roundtrip.test.ts
T
Bastien Chanot 143fdc3208 hotfix(pdf): swap vet-referral marker ⚠ → (!) for WinAnsi compatibility
Root cause: src/pdf/fonts.ts embeds StandardFonts.Helvetica /
HelveticaBold / TimesRoman, which use WinAnsi encoding (Latin-1
only). PDF export threw `WinAnsi cannot encode "⚠" (0x26a0)` the
moment the text-height estimator measured a vet-flagged leaf
label (countSegmentedLines → widthOfTextAtSize).

Fix: replace the PDF prefix "⚠ " with WinAnsi-safe "(!) ". The
picker DOM keeps the original "⚠" since browsers render U+26A0
natively — the limitation is purely on the PDF side.

Regression test exercises embedFonts + widthOfTextAtSize on a
realistic prefixed label; would catch any future non-WinAnsi
marker re-introduction.

Follow-up (not in scope): switch the PDF body to embedded TTF
(Inter / Fraunces per CLAUDE.md spec) so the catalog can carry
arbitrary glyphs. CLAUDE.md states TTFs should be used; current
StandardFonts is a drift from intent.

155/155 tests green, typecheck clean.
2026-05-21 03:33:59 +02:00

113 lines
4.4 KiB
TypeScript

import { describe, it, expect, vi } from 'vitest'
import { AFRelationship, PDFDocument } from 'pdf-lib'
import { exportReportToPdf } from '@/pdf/export'
import { importReportFromPdf, ImportError } from '@/pdf/import'
import { embedFonts } from '@/pdf/fonts'
import type { Report } from '@/domain/schema/report'
vi.mock('@/pdf/render/svgToPng', () => ({ rasterizeSvg: async () => new Uint8Array([137, 80, 78, 71]) }))
const report: Report = {
version: 2,
id: 'r1',
createdAt: '2026-05-18T10:00:00Z',
date: '2026-05-18',
practitioner: { name: 'Dr. Dupont' },
animal: { speciesId: 'equine', name: 'Mistral' },
owner: { name: 'Jean Martin' },
observations: [],
conclusion: 'ok',
recommendations: '',
}
describe('PDF roundtrip', () => {
it('rejects unrelated PDF bytes with ImportError', async () => {
const fake = new Uint8Array([37, 80, 68, 70, 45, 49, 46, 52, 10, 37, 226, 227, 207, 211, 10])
await expect(importReportFromPdf(fake)).rejects.toThrow(ImportError)
})
it('roundtrips a minimal report (no observations)', async () => {
const bytes = await exportReportToPdf(report, { locale: 'fr' })
const imported = await importReportFromPdf(bytes)
expect(imported.animal.name).toBe('Mistral')
expect(imported.version).toBe(2)
})
it('roundtrips a report exported with locale=fr', async () => {
const bytes = await exportReportToPdf(report, { locale: 'fr' })
const imported = await importReportFromPdf(bytes)
expect(imported.animal.name).toBe('Mistral')
expect(imported.version).toBe(2)
})
it('roundtrips a report exported with locale=en', async () => {
const bytes = await exportReportToPdf(report, { locale: 'en' })
const imported = await importReportFromPdf(bytes)
expect(imported.animal.name).toBe('Mistral')
expect(imported.version).toBe(2)
})
it('FR and EN exports both produce non-empty byte streams', async () => {
// pdf-lib subsets fonts (LRN-016), so plain-text grep over the bytes
// is unreliable. The imported JSON is the strongest invariant — the
// locale lives outside the Report, so both imports return the same
// payload while the static label snapshots differ inside the PDF.
const fr = await exportReportToPdf(report, { locale: 'fr' })
const en = await exportReportToPdf(report, { locale: 'en' })
expect(fr.byteLength).toBeGreaterThan(0)
expect(en.byteLength).toBeGreaterThan(0)
const frImported = await importReportFromPdf(fr)
const enImported = await importReportFromPdf(en)
expect(frImported.animal.name).toBe(enImported.animal.name)
expect(frImported.version).toBe(enImported.version)
})
it('vet-referral marker is encodable by the body font (regression: WinAnsi cannot encode U+26A0)', async () => {
// observationPage prefixes vet-referral leaves with a marker that
// is rendered using the WinAnsi-encoded StandardFonts.Helvetica.
// The previous "⚠ " marker (U+26A0) threw `WinAnsi cannot encode "⚠"`
// the moment the text-height estimator measured the leaf label.
// Guard against re-introducing a non-WinAnsi marker by exercising
// the same path: load the body font and measure a label that
// carries the prefix.
const doc = await PDFDocument.create()
const fonts = await embedFonts(doc)
expect(() =>
fonts.bodyRegular.widthOfTextAtSize('(!) Difficulté de déglutition', 10),
).not.toThrow()
})
it('rejects a legacy v1 PDF with a version-specific message', async () => {
const doc = await PDFDocument.create()
doc.addPage()
const legacyPayload = {
version: 1,
id: 'legacy',
createdAt: '2025-12-01T00:00:00Z',
date: '2025-12-01',
practitioner: { name: 'Dr. Dupont' },
animal: { speciesId: 'equine', name: 'Mistral' },
owner: { name: 'Jean Martin' },
observations: [],
conclusion: '',
recommendations: '',
}
const bytes = new TextEncoder().encode(JSON.stringify(legacyPayload))
await doc.attach(bytes, 'osteo-report.json', {
mimeType: 'application/json',
description: 'Osteo Report state v1',
afRelationship: AFRelationship.Data,
})
const pdfBytes = await doc.save()
try {
await importReportFromPdf(pdfBytes)
throw new Error('expected rejection')
} catch (err) {
expect(err).toBeInstanceOf(ImportError)
const e = err as ImportError
expect(e.kind).toBe('incompatible_version')
expect(e.foundVersion).toBe(1)
}
})
})