Files
faunosteo/apps/app/tests/unit/editor-overview.test.tsx
T
bchanot cd794f3c39 feat(editor): properties dialog over the column, transactional save
U2 Task 6 (A1, A2, A3, A9, A10, R-3, R-5, R-6, R-14, R-16).

- Dialog: `anchor` places the panel at the column's left and width,
  from its top, under a 22 % ink veil that ignores clicks; the visual
  viewport below 320 px; centred without an anchor box.
- Navigation: `annotation` layer (LAYERS, EditorView, history entry,
  leave guards, left-draft flag); Back closes, Forward reopens.
- AnnotationDialog: read body, « Modifier » form (CreationFields with
  « Couleur », missingFields, R-3 messages), one `update` on the
  current annotation by id, « Marquer comme relu », « Modifier la
  forme », « Supprimer »; read-only flip keeps the draft.
- The column always shows the overview, selected row marked; Enter on
  it, a second click or a double click, the strip's « Propriétés »
  open the dialog. « Aller à » focuses the row (R-5).
- Read-only twin: strip and read-only dialog at 1 024 px and wider,
  inline read body below. PropertiesPanel and AnnotationFields gone.
- Strip lead 256 px and a fixed status slot, so the commands fit at
  1 024 px and a status change moves nothing.
- e2e: `aside-content` exemption removed; scroll-to-top workarounds
  of editor-geometry, editor-zones and editor-journey removed.

Removed assertions mapped:
  editor-annotations-tab.test.tsx:
  - selectFromList waited for `annotation-properties` -> waits for the strip's « Propriétés » (selection without dialog, A1)
  - refused place: issues block `annotation-geometry-issues` in the panel -> the strip notice alert (present, then gone)
  - keyboard creation / C26 confirmation: `annotation-properties` after create -> strip « Propriétés » (new element selected)
  - Désélectionner from the panel -> « Désélectionner » in the strip (all 7 tests); « panel closes » -> strip has no « Propriétés »
  - undo after deselect (typed name) -> handle key series then deselect then undo
  - commits a valid typed value once without blur (name field) -> a pending handle key series committed once by the strip deselect
  - a refused typed value: the panel closes (two tests: strip deselect, tap deselect) -> removed: no field outside the dialog; the dialog's draft writes nothing before « Enregistrer » (new dialog tests)
  - not offered while a replace tracing runs: panel's Désélectionner absent -> strip offers neither « Désélectionner » nor « Propriétés » during the tracing
  - tap: isDeselected read `annotation-properties` -> strip « Propriétés » absent; link select -> strip title data-selection
  - tap: undo after tap deselect (typed name) -> handle series; typed value committed on blur -> handle series committed on blur
  - strip geometry issues: list read in the panel -> list read in the properties dialog's issues block
  - a new commit replaces the message (typed name) -> « Marquer comme relu » in the dialog
  editor-escape.test.tsx:
  - `panel()` = `annotation-properties` -> the strip's « Propriétés » or the phone twin's inline read body
  - Escape from a panel button (« Marquer comme relu ») -> from the selected row in the side column: focus on the row
  - after A then B from the panel (via « Toutes les annotations ») -> select A, select B, Escape from a button of the side column: focus on B's row
  - a text field (panel « Nom (FR) ») -> the overview « Filtrer par nom »
  - redraw via the panel's « Remplacer par un polygone » -> the strip's command
  - modal / delete dialog opened by the panel's « Supprimer » -> « Supprimer » of the properties dialog
  - read-only width: hidden `annotation-properties` -> hidden strip « Propriétés » of the kept edit body
  editor-history-buttons.test.tsx (typed text and the press, 8 tests): the annotation's committed « Nom (FR) » field of the panel -> the sheet's committed « Nom (FR) » on Général (same TextField commit-on-blur path; annotation fields are now a dialog draft)
  editor-focus-request.test.tsx: « Aller à » focuses `data-properties-heading` inside `annotation-properties` -> focuses the annotation's row, marked aria-current, no dialog (R-5)
  editor-sections.test.tsx: « Aller à » with nothing in progress focused the properties heading -> focuses the row (R-5); creation kept: no `annotation-properties` -> no strip « Propriétés »
  editor-overview.test.tsx (edit and read-only): row opens `annotation-properties`, « Toutes les annotations » returns -> row selects, stays marked aria-current, no dialog; strip « Désélectionner » returns focus to the row; filter kept across select and « Désélectionner »
  editor-citations-guards.test.tsx: LAYERS_TOP_DOWN gains 'annotation' at the bottom
  editor-keep-alive.test.tsx: `annotation-properties` visible after the round trip -> the strip's « Propriétés » visible (selection kept)
  editor-no-loss.test.tsx: ids `ro-annotation-name-fr` and `annotation-name-fr` (both panels' fields) -> the twin's inline read body (no ids), then the dialog edit form's `annotation-edit-fr`, kept through a flip to 800 px, no duplicate id; « Aller à » visible `annotation-properties` -> visible `annotation-read` (inline twin), none at 1 280
  editor-point-edit.test.tsx / editor-zone-edit.test.tsx: `select()` waited for `annotation-properties` and returned it -> waits for the strip's « Propriétés » and returns the strip (its « Désélectionner » and « Remplacer par un polygone » moved there)
  - move mode Escape: `annotation-properties` still there -> the strip's « Propriétés » back after the mode
  - « Toutes les annotations » asks first during a started move -> Enter on the selected row asks first (no dialog), and the strip offers neither « Propriétés » nor « Désélectionner » during the mode
  - Escape from the handle / slider: `annotation-properties` gone -> the strip's « Propriétés » gone
  - I-3 touch tap: `annotation-properties` gone -> the strip's « Propriétés » gone
  e2e (sandbox):
  - support/layout.ts: `aside-content` exemption removed (ShiftExemption type, the loose compare); every `swaps`/`SWAPS` argument removed (editor-annotations, editor-zones, editor-geometry)
  - support/editor.ts pickAnnotation: clicked « Toutes les annotations » first when the panel showed -> the overview is always shown: clicks the row, then scrolls back to the top (the page no longer shortens)
  - editor-annotations: `annotation-properties` visible after a creation -> strip with « Propriétés »; review toggle and « Supprimer » of the panel -> the properties dialog's; a jitter click on the selected point now opens the dialog (A1), closed by Escape before the drag; handle names exact (the marked row shares the prefix); trace close moved out of expectNoShift (creation panel until Task 7, shortcut + TODO)
  - editor-deselect: `annotation-properties` -> the strip with « Propriétés » or the twin's inline read body; Escape in a field: panel « Nom (FR) » -> overview filter; delete dialog from the panel -> from the properties dialog (Escape closes it, then the dialog); « a typed value is applied by the click that deselects » (name field, refused blank) -> a pending point-handle key series applied by the deselecting click and by « Désélectionner » (refused value: no field outside the dialog); « the selected one stays » -> a second click, double click and jitter open the dialog, Escape closes it, selection kept
  - editor-geometry: `annotation-geometry-issues` in the panel -> read in the properties dialog, then the strip notice; after the refusal the error count unchanged; scroll-to-top workaround removed
  - editor-zones: panel « Désélectionner » -> strip; scroll-to-top after pickAnnotation removed (helper does it)
  - editor-structures: panel « Supprimer » -> properties dialog « Supprimer », confirmation over it
  - editor-journey: `#annotation-name-fr` committed field + `#annotation-laterality` -> the dialog's edit form, one « Enregistrer »; scroll-to-top removed
  - editor-shell / editor-shell-journeys: « Aller à » focus on `data-properties-heading` -> the annotation's row (aria-current), no dialog (R-5)
  - editor-shell-layout: focus kind `annotation-properties` -> removed (the overview is the side)
2026-11-17 22:01:57 +01:00

199 lines
6.9 KiB
TypeScript

/** V1-2.6 U1 Lot C: board 01's « Annotations de la vue » card, in edit and read-only. */
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import {
cleanup,
render,
screen,
waitFor,
within,
} from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import type { Annotation } from '@faunosteo/core-wasm/types'
import AnnotationsTab from '@/components/editor/tabs/AnnotationsTab'
import { useLocaleStore } from '@/state/localeStore'
import { drawnText, insert, point } from '../helpers/editorFixtures'
import { openReady, resetStore } from '../helpers/editorHarness'
vi.mock('@/lib/supabase', () => ({ getSupabaseClient: () => ({}) }))
vi.mock('@faunosteo/supabase', async (orig) => ({
...(await orig<typeof import('@faunosteo/supabase')>()),
getSheetVersion: vi.fn(),
downloadSheetDrawing: vi.fn(),
saveSheetDraft: vi.fn(),
getOfficialSheetAdmin: vi.fn(),
submitSheetReview: vi.fn(),
}))
const props = {
readOnly: false,
navigate: vi.fn(),
reloadSheet: vi.fn(),
section: 'drawing' as const,
visited: ['drawing'] as const,
onOpenSection: vi.fn(),
onBack: vi.fn(),
}
const named = (
id: string,
fr: string,
category: string,
view = 'view-main',
) => {
const base = point(id, 50, 50, 5, view).value as Annotation
return {
kind: 'annotation',
value: { ...base, category_id: category, name: { fr, en: fr } },
} as const
}
/** Two categories (b declared after a); the first annotation sits in b. */
function sheet(): string {
let text = insert(drawnText(), {
kind: 'category',
value: { id: 'cat-b', name: { fr: 'Os', en: 'Bone' }, color: '#aa0000' },
})
text = insert(text, named('a1', 'Épaule', 'cat-b'))
text = insert(text, named('a2', 'Genou', 'cat-a'))
return insert(text, {
kind: 'view',
value: {
kind: 'detail',
id: 'view-det',
name: { fr: 'Tête', en: 'Head' },
svg_asset_id: null,
view_box: { min_x: 10, min_y: 10, width: 80, height: 80 },
parent_view_id: 'view-main',
},
})
}
beforeEach(() => useLocaleStore.setState({ locale: 'fr' }))
afterEach(() => {
cleanup()
resetStore()
})
async function mount(readOnly = false) {
await openReady({ text: sheet() })
render(<AnnotationsTab {...props} readOnly={readOnly} />)
await screen.findByRole('list', { name: 'Annotations de la vue' })
}
const overview = () =>
screen.getByRole('region', { name: 'Aperçu de la fiche' })
const card = () =>
within(overview()).getByRole('list', { name: 'Annotations de la vue' })
/** The visible body: the read-only twin hides the kept edit one. */
const body = () =>
screen
.getAllByTestId('editor-tab-annotations')
.find((el) => !el.closest('[hidden]'))!
const canvas = (readOnly: boolean) =>
within(body()).getByTestId(
readOnly ? 'catalogue-canvas' : 'annotation-canvas',
)
const rows = () => within(card()).getAllByRole('button')
const chip = (name: string) =>
within(screen.getByRole('group', { name: 'Vues' })).getByRole('button', {
name,
})
describe.each([
['edit', false],
['read-only', true],
])('the annotation card (%s)', (_mode, readOnly) => {
it('groups the rows by category in document order, with a count per group', async () => {
await mount(readOnly)
const groups = within(card()).getAllByRole('list')
expect(groups).toHaveLength(2)
const [first, second] = groups
expect(first).toHaveAccessibleName('N 1')
expect(second).toHaveAccessibleName('Os 1')
expect(within(first).getByRole('button')).toHaveTextContent('Genou')
expect(within(second).getByRole('button')).toHaveTextContent('Épaule')
})
it('filters on the displayed name, ignoring case and accents', async () => {
await mount(readOnly)
const user = userEvent.setup()
const field = within(overview()).getByRole('searchbox', {
name: 'Filtrer par nom',
})
await user.type(field, 'EPAULE')
expect(rows()).toHaveLength(1)
expect(rows()[0]).toHaveTextContent('Épaule')
await user.type(field, 'zzz')
expect(
within(overview()).getByText('Aucune annotation ne correspond.'),
).toBeInTheDocument()
})
it('a row selects the annotation and stays marked (A3); « Désélectionner » focuses its row', async () => {
await mount(readOnly)
const user = userEvent.setup()
await user.click(rows()[1])
await waitFor(() =>
expect(rows()[1]).toHaveAttribute('aria-current', 'true'),
)
expect(overview()).toBeVisible()
expect(within(body()).queryByRole('dialog')).toBeNull()
await user.click(screen.getByRole('button', { name: 'Désélectionner' }))
expect(rows()[1]).not.toHaveAttribute('aria-current')
await waitFor(() => expect(document.activeElement).toBe(rows()[1]))
})
it('keeps the « Filtrer par nom » term across a selection and back', async () => {
await mount(readOnly)
const user = userEvent.setup()
const field = () =>
within(overview()).getByRole('searchbox', { name: 'Filtrer par nom' })
await user.type(field(), 'epaule')
await user.click(rows()[0])
await user.click(screen.getByRole('button', { name: 'Désélectionner' }))
expect(field()).toHaveValue('epaule')
expect(rows()).toHaveLength(1)
expect(rows()[0]).toHaveTextContent('Épaule')
})
it('a view row switches the canvas view', async () => {
await mount(readOnly)
const user = userEvent.setup()
const name = (view: string) => (readOnly ? `Dessin : ${view}` : view)
expect(canvas(readOnly)).not.toHaveAccessibleName(name('Tête'))
expect(chip('Tête')).toHaveAttribute('aria-pressed', 'false')
await user.click(within(overview()).getByRole('button', { name: /^Tête/ }))
expect(
within(overview()).getByRole('button', { name: /^Tête/ }),
).toHaveAttribute('aria-current', 'true')
expect(chip('Tête')).toHaveAttribute('aria-pressed', 'true')
expect(canvas(readOnly)).toHaveAccessibleName(name('Tête'))
expect(
within(overview()).getByText('Aucune annotation dans cette vue.'),
).toBeInTheDocument()
})
})
describe('« Sans catégorie »', () => {
it('a group appears only for an annotation whose category is not in the document', async () => {
let text = insert(drawnText(), named('stray', 'Perdue', 'ghost'))
text = insert(text, named('a2', 'Genou', 'cat-a'))
await openReady({ text })
render(<AnnotationsTab {...props} />)
await screen.findByRole('list', { name: 'Annotations de la vue' })
const groups = within(card()).getAllByRole('list')
expect(groups).toHaveLength(2)
expect(groups[1]).toHaveAccessibleName('Sans catégorie 1')
expect(within(groups[1]).getByRole('button')).toHaveTextContent('Perdue')
})
})
describe('the side column', () => {
it('sits beside the canvas from lg (1 024 px), not xl', async () => {
await mount()
const grid = overview().closest('.grid')
expect(grid?.className).toContain('lg:grid-cols-[minmax(0,1fr)_22rem]')
expect(grid?.className).not.toContain('xl:')
})
})