Files
faunosteo/apps/app/e2e/shell/editor-shell-journeys.spec.ts
T
bchanot cd794f3c39 feat(editor): properties dialog over the column, transactional save
U2 Task 6 (A1, A2, A3, A9, A10, R-3, R-5, R-6, R-14, R-16).

- Dialog: `anchor` places the panel at the column's left and width,
  from its top, under a 22 % ink veil that ignores clicks; the visual
  viewport below 320 px; centred without an anchor box.
- Navigation: `annotation` layer (LAYERS, EditorView, history entry,
  leave guards, left-draft flag); Back closes, Forward reopens.
- AnnotationDialog: read body, « Modifier » form (CreationFields with
  « Couleur », missingFields, R-3 messages), one `update` on the
  current annotation by id, « Marquer comme relu », « Modifier la
  forme », « Supprimer »; read-only flip keeps the draft.
- The column always shows the overview, selected row marked; Enter on
  it, a second click or a double click, the strip's « Propriétés »
  open the dialog. « Aller à » focuses the row (R-5).
- Read-only twin: strip and read-only dialog at 1 024 px and wider,
  inline read body below. PropertiesPanel and AnnotationFields gone.
- Strip lead 256 px and a fixed status slot, so the commands fit at
  1 024 px and a status change moves nothing.
- e2e: `aside-content` exemption removed; scroll-to-top workarounds
  of editor-geometry, editor-zones and editor-journey removed.

Removed assertions mapped:
  editor-annotations-tab.test.tsx:
  - selectFromList waited for `annotation-properties` -> waits for the strip's « Propriétés » (selection without dialog, A1)
  - refused place: issues block `annotation-geometry-issues` in the panel -> the strip notice alert (present, then gone)
  - keyboard creation / C26 confirmation: `annotation-properties` after create -> strip « Propriétés » (new element selected)
  - Désélectionner from the panel -> « Désélectionner » in the strip (all 7 tests); « panel closes » -> strip has no « Propriétés »
  - undo after deselect (typed name) -> handle key series then deselect then undo
  - commits a valid typed value once without blur (name field) -> a pending handle key series committed once by the strip deselect
  - a refused typed value: the panel closes (two tests: strip deselect, tap deselect) -> removed: no field outside the dialog; the dialog's draft writes nothing before « Enregistrer » (new dialog tests)
  - not offered while a replace tracing runs: panel's Désélectionner absent -> strip offers neither « Désélectionner » nor « Propriétés » during the tracing
  - tap: isDeselected read `annotation-properties` -> strip « Propriétés » absent; link select -> strip title data-selection
  - tap: undo after tap deselect (typed name) -> handle series; typed value committed on blur -> handle series committed on blur
  - strip geometry issues: list read in the panel -> list read in the properties dialog's issues block
  - a new commit replaces the message (typed name) -> « Marquer comme relu » in the dialog
  editor-escape.test.tsx:
  - `panel()` = `annotation-properties` -> the strip's « Propriétés » or the phone twin's inline read body
  - Escape from a panel button (« Marquer comme relu ») -> from the selected row in the side column: focus on the row
  - after A then B from the panel (via « Toutes les annotations ») -> select A, select B, Escape from a button of the side column: focus on B's row
  - a text field (panel « Nom (FR) ») -> the overview « Filtrer par nom »
  - redraw via the panel's « Remplacer par un polygone » -> the strip's command
  - modal / delete dialog opened by the panel's « Supprimer » -> « Supprimer » of the properties dialog
  - read-only width: hidden `annotation-properties` -> hidden strip « Propriétés » of the kept edit body
  editor-history-buttons.test.tsx (typed text and the press, 8 tests): the annotation's committed « Nom (FR) » field of the panel -> the sheet's committed « Nom (FR) » on Général (same TextField commit-on-blur path; annotation fields are now a dialog draft)
  editor-focus-request.test.tsx: « Aller à » focuses `data-properties-heading` inside `annotation-properties` -> focuses the annotation's row, marked aria-current, no dialog (R-5)
  editor-sections.test.tsx: « Aller à » with nothing in progress focused the properties heading -> focuses the row (R-5); creation kept: no `annotation-properties` -> no strip « Propriétés »
  editor-overview.test.tsx (edit and read-only): row opens `annotation-properties`, « Toutes les annotations » returns -> row selects, stays marked aria-current, no dialog; strip « Désélectionner » returns focus to the row; filter kept across select and « Désélectionner »
  editor-citations-guards.test.tsx: LAYERS_TOP_DOWN gains 'annotation' at the bottom
  editor-keep-alive.test.tsx: `annotation-properties` visible after the round trip -> the strip's « Propriétés » visible (selection kept)
  editor-no-loss.test.tsx: ids `ro-annotation-name-fr` and `annotation-name-fr` (both panels' fields) -> the twin's inline read body (no ids), then the dialog edit form's `annotation-edit-fr`, kept through a flip to 800 px, no duplicate id; « Aller à » visible `annotation-properties` -> visible `annotation-read` (inline twin), none at 1 280
  editor-point-edit.test.tsx / editor-zone-edit.test.tsx: `select()` waited for `annotation-properties` and returned it -> waits for the strip's « Propriétés » and returns the strip (its « Désélectionner » and « Remplacer par un polygone » moved there)
  - move mode Escape: `annotation-properties` still there -> the strip's « Propriétés » back after the mode
  - « Toutes les annotations » asks first during a started move -> Enter on the selected row asks first (no dialog), and the strip offers neither « Propriétés » nor « Désélectionner » during the mode
  - Escape from the handle / slider: `annotation-properties` gone -> the strip's « Propriétés » gone
  - I-3 touch tap: `annotation-properties` gone -> the strip's « Propriétés » gone
  e2e (sandbox):
  - support/layout.ts: `aside-content` exemption removed (ShiftExemption type, the loose compare); every `swaps`/`SWAPS` argument removed (editor-annotations, editor-zones, editor-geometry)
  - support/editor.ts pickAnnotation: clicked « Toutes les annotations » first when the panel showed -> the overview is always shown: clicks the row, then scrolls back to the top (the page no longer shortens)
  - editor-annotations: `annotation-properties` visible after a creation -> strip with « Propriétés »; review toggle and « Supprimer » of the panel -> the properties dialog's; a jitter click on the selected point now opens the dialog (A1), closed by Escape before the drag; handle names exact (the marked row shares the prefix); trace close moved out of expectNoShift (creation panel until Task 7, shortcut + TODO)
  - editor-deselect: `annotation-properties` -> the strip with « Propriétés » or the twin's inline read body; Escape in a field: panel « Nom (FR) » -> overview filter; delete dialog from the panel -> from the properties dialog (Escape closes it, then the dialog); « a typed value is applied by the click that deselects » (name field, refused blank) -> a pending point-handle key series applied by the deselecting click and by « Désélectionner » (refused value: no field outside the dialog); « the selected one stays » -> a second click, double click and jitter open the dialog, Escape closes it, selection kept
  - editor-geometry: `annotation-geometry-issues` in the panel -> read in the properties dialog, then the strip notice; after the refusal the error count unchanged; scroll-to-top workaround removed
  - editor-zones: panel « Désélectionner » -> strip; scroll-to-top after pickAnnotation removed (helper does it)
  - editor-structures: panel « Supprimer » -> properties dialog « Supprimer », confirmation over it
  - editor-journey: `#annotation-name-fr` committed field + `#annotation-laterality` -> the dialog's edit form, one « Enregistrer »; scroll-to-top removed
  - editor-shell / editor-shell-journeys: « Aller à » focus on `data-properties-heading` -> the annotation's row (aria-current), no dialog (R-5)
  - editor-shell-layout: focus kind `annotation-properties` -> removed (the overview is the side)
2026-11-17 22:01:57 +01:00

316 lines
11 KiB
TypeScript

import { fr } from '@/i18n/fr'
import type { Page, TestInfo } from '@playwright/test'
import { expect, test } from '../support/browser'
import { sessionAal, stepUpAdmin } from '../support/admin'
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
import { signIn } from '../support/shell'
import {
TABS,
closeFinding,
draftTitle,
editorActor,
findingDialog,
historyButton,
openEditor,
place,
pointOf,
pressAtBox,
saveLine,
seedDraft,
selectTab,
shapeWith,
standardShape,
UNSAVED_LINE,
} from '../support/editor'
// V1-2.6 U1 H (AC1, AC5, AC12, AC13, AC17): the journeys of the five-tab shell in a real
// browser. Every query is scoped to the visible place (`place()`) or goes by role, so a
// hidden, kept-mounted copy never answers.
const dict = fr
const isPhone = (info: TestInfo) => info.project.name === 'chromium-375'
const active = (page: Page) => page.locator(':focus')
const nameField = (page: Page) => page.locator('#general-name-fr')
const ghost = 'absent'
/** A document that carries one issue of each kind « Aller à » can reach. */
function issueShape(document: Record<string, unknown>) {
standardShape(document)
const text = (value: string) => ({ fr: value, en: value })
const views = document.views as unknown[]
views.push({
id: 'detail-b',
kind: 'detail',
name: text('Détail B'),
svg_asset_id: null,
view_box: { min_x: 0, min_y: 0, width: 100, height: 80 },
parent_view_id: ghost,
})
const categories = document.categories as unknown[]
categories.push({ id: 'cat-a', name: text('Catégorie bis'), color: null })
document.vertebral_config = {
regions: [
{
code: 'T',
name: text('Thoracique'),
count: 5,
count_range: { min: 9, max: 3 },
},
],
}
const reference = (citation: string) => ({
id: 'ref-a',
type: 'book',
citation,
url: null,
doi: null,
})
document.references = [reference('Barone, Ostéologie'), reference('Bis')]
const point = pointOf(
'anno-free',
'main',
{ cx: 120, cy: 120, r: 6 },
'Point libre',
)
document.annotations = [
{ ...point, category_id: ghost, finding_zone_id: null },
]
const zones = document.finding_zones as {
categories: { children: { reference_ids: string[] }[] }[]
}[]
zones[0].categories[0].children[0].reference_ids = [ghost]
}
async function open(page: Page, shape = shapeWith()) {
const actor = await editorActor('fr')
const seed = await seedDraft(actor, { shape })
await openEditor(page, dict, actor, seed.sheetId)
return { ...seed, actor }
}
async function commitName(page: Page, value: string) {
await selectTab(page, dict, 'general')
await nameField(page).fill(value)
await nameField(page).press('Enter')
}
const unsaved = (page: Page, count: number) =>
expect(saveLine(page)).toHaveText(
dict[
count === 1
? 'editor.draft.status.unsaved_count_one'
: 'editor.draft.status.unsaved_count_other'
].replace('{count}', String(count)),
)
test.describe('editor shell journeys (H)', () => {
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
test.beforeEach(async ({ context }, info) => {
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
await routeToSandbox(context)
})
test.afterEach(async ({ context }) => {
await dropLateReplays(context)
})
test('five tabs and no tab of the old layout', async ({ page }) => {
await open(page)
const tabs = page.getByRole('tablist').getByRole('tab')
await expect(tabs).toHaveCount(5)
for (const [index, tab] of TABS.entries()) {
await expect(tabs.nth(index)).toHaveText(
new RegExp(`^${dict[`editor.tab.${tab}`]}`),
)
}
for (const old of ['Vues et illustrations', 'Vertèbres']) {
await expect(page.getByRole('tab', { name: old })).toHaveCount(0)
}
})
test('undo from another tab reverts the change, redo brings it back', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'general')
const original = await nameField(page).inputValue()
await commitName(page, 'Nom depuis Général')
await unsaved(page, 1)
await selectTab(page, dict, 'findings')
await historyButton(page, dict, 'undo').click()
await selectTab(page, dict, 'general')
await expect(nameField(page)).toHaveValue(original)
await historyButton(page, dict, 'redo').click()
await expect(nameField(page)).toHaveValue('Nom depuis Général')
await unsaved(page, 1)
})
test('text typed without a blur is committed by the header undo, which then reverts it', async ({
page,
}) => {
await open(page)
await selectTab(page, dict, 'general')
const original = await nameField(page).inputValue()
await nameField(page).fill('Saisi, jamais validé')
// « Défaire » is aria-disabled until the typed text is committed: press at its box.
await pressAtBox(page, historyButton(page, dict, 'undo'))
await expect(nameField(page)).toHaveValue(original)
await expect(saveLine(page)).not.toHaveText(UNSAVED_LINE)
await historyButton(page, dict, 'redo').click()
await expect(nameField(page)).toHaveValue('Saisi, jamais validé')
})
test('a field left empty keeps its error: Tab to « Défaire », Enter, nothing undone, focus back', async ({
page,
}) => {
await open(page)
await commitName(page, 'Premier nom')
await nameField(page).fill('')
const undo = historyButton(page, dict, 'undo')
for (let step = 0; step < 40; step++) {
await page.keyboard.press('Shift+Tab')
if (await undo.evaluate((button) => button === document.activeElement))
break
}
await expect(undo).toBeFocused()
await expect(nameField(page)).toHaveAttribute('aria-invalid', 'true')
await page.keyboard.press('Enter')
await expect(nameField(page)).toBeFocused()
await unsaved(page, 1)
await expect(undo).toHaveAttribute('aria-disabled', 'false')
await expect(historyButton(page, dict, 'redo')).toHaveAttribute(
'aria-disabled',
'true',
)
})
test('Ctrl+Z outside a field undoes, inside a field it leaves the history alone', async ({
page,
}) => {
await open(page)
await commitName(page, 'Nom un')
await commitName(page, 'Nom deux')
await unsaved(page, 2)
await page
.getByRole('heading', { level: 1, name: draftTitle(dict) })
.click()
await page.keyboard.press('Control+z')
await unsaved(page, 1)
await expect(nameField(page)).toHaveValue('Nom un')
await nameField(page).click()
await nameField(page).pressSequentially(' suite')
await page.keyboard.press('Control+z')
// The field's own undo ran; the document history did not (a second step would show 0).
await unsaved(page, 1)
})
test('« Aller à » reaches the place and the element of each issue kind', async ({
page,
}) => {
await open(page, issueShape)
const goTo = (name: string) =>
place(page, 'verification')
.getByRole('button', { name: `Aller à ${name}`, exact: true })
.first()
.click()
const focusKey = (id: string) =>
expect(active(page)).toHaveAttribute('data-focus-key', new RegExp(id))
await selectTab(page, dict, 'verification')
await goTo('Détail B')
await expect(place(page, 'annotations.views')).toBeVisible()
await focusKey('detail-b')
await selectTab(page, dict, 'verification')
await goTo('Catégorie A')
await expect(place(page, 'annotations.categories')).toBeVisible()
await focusKey('cat-a')
await selectTab(page, dict, 'verification')
await goTo('Thoracique')
await expect(place(page, 'annotations.regions')).toBeVisible()
await focusKey('"T"')
await selectTab(page, dict, 'verification')
await goTo('Point libre')
await expect(place(page, 'annotations.drawing')).toBeVisible()
// R-5: the annotation's row takes the focus, no dialog opens (U2 Task 6).
await expect(active(page)).toHaveAttribute(
'data-focus-key',
/"kind":"annotation"/,
)
await expect(active(page)).toHaveAttribute('aria-current', 'true')
await expect(page.getByRole('dialog')).toHaveCount(0)
await selectTab(page, dict, 'verification')
await goTo('Constat A')
await expect(place(page, 'findings')).toBeVisible()
// The finding opens in its dialog, in view mode; closed, its row holds the focus.
await expect(
findingDialog(page).getByRole('heading', { name: 'Constat A' }),
).toBeVisible()
await expect(
findingDialog(page).getByRole('button', {
name: dict['editor.findings.edit'],
}),
).toBeVisible()
await closeFinding(page, dict)
await expect(place(page, 'findings').locator(':focus')).toHaveCount(1)
await selectTab(page, dict, 'verification')
await goTo('Barone, Ostéologie')
await expect(place(page, 'references')).toBeVisible()
await expect(
page.getByRole('tab', {
name: new RegExp(`^${dict['editor.tab.references']}`),
}),
).toHaveAttribute('aria-selected', 'true')
await focusKey('ref-a')
})
test('the save line goes from the count to « Enregistrement… » to the time and the revision', async ({
page,
context,
}) => {
const seed = await open(page)
await context.route('**/rest/v1/rpc/save_sheet_draft', async (route) => {
await new Promise((done) => setTimeout(done, 1500))
await route.fallback()
})
await commitName(page, 'Nom à enregistrer')
await unsaved(page, 1)
await page
.getByRole('button', { name: dict['common.save'], exact: true })
.click()
await expect(saveLine(page)).toHaveText(dict['editor.draft.status.saving'])
const timed = dict['editor.draft.status.saved_at']
.replace('{time}', '\\d\\d:\\d\\d')
.replace('{revision}', String(seed.revision + 1))
await expect(saveLine(page)).toHaveText(new RegExp(`^${timed}$`))
})
test('the step-up of the setup survives one GoTrue verify failure (verifier 10)', async ({
page,
}) => {
// Under the eight-worker sweep GoTrue answered a verify HTTP 500 (gate final.log):
// the step-up shows « indisponible » and the setup must try again, never stop there.
const actor = await editorActor('fr')
let failed = false
await page.route('**/auth/v1/factors/*/verify', (route) => {
if (failed) return route.fallback()
failed = true
return route.fulfill({
status: 500,
contentType: 'application/json',
body: JSON.stringify({ code: 500, error_code: 'unexpected_failure' }),
})
})
await signIn(page, actor.account, dict)
await page.goto('/app/admin')
await stepUpAdmin(page, dict, actor.secret)
expect(failed).toBe(true)
expect(await sessionAal(page)).toBe('aal2')
})
})