2.8 KiB
2.8 KiB
CONTRACT — step-06 phase 0 freeze
- date: 2026-10-11 | flow: ship-feature (executor) | branch: feature/step-06-pdf-archives
- status: active
- spec: docs/development/STEP6_PDF_ARCHIVE_ANALYSIS.md Part II (§17 goldens, §13 types for naming only)
REQUEST (IMMUTABLE)
Freeze the current PDF pipeline behaviour before any refactor: new fixtures, goldens generated once with the current code, characterisation tests of the two routes. Production code under apps/app/src is NOT modified in this phase.
ACCEPTANCE CRITERIA
- Fixture
apps/app/tests/fixtures/report-v3.demo.json: valid Report v3 on the bundled draft (ids taken from draft/document.json), 6 observations covering: main view zones, head view zone, a spine zone with vertebrae, a bilateral zone with left and right sides, a vet-referral leaf (requiresVetReferral: true), a leaf whose label holds an en dash (U+2013), free-text findings, severities, comment, conclusion, recommendations, nextAppointment;sheet= the draft ref. CHECK: cd apps/app && corepack pnpm vitest run tests/unit/pdf.goldens.test.ts 2>&1 | tail -3 EXPECT: Tests .* passed - Goldens under
apps/app/tests/fixtures/goldens/step6/exactly as spec §17 (text/images/links per report × locale × logo mode, views per report), generated byMAKE_GOLDEN=1 corepack pnpm vitest run tests/unit/pdf.goldens.test.ts, then asserted by the same file without the flag. Reports: v2full, demo, v2unresolved. Logo modes: nologos, logos. CHECK: ls apps/app/tests/fixtures/goldens/step6 | wc -l EXPECT: >= 20 - Fixture
apps/app/tests/fixtures/report-v3.bare.pdf: the demo report exported by the current code (rasteriser stubbed 1×1, no logos), produced by the same MAKE_GOLDEN run;tests/fixtures/README.mddocuments the new files and the rule "never regenerate without a user decision". CHECK: test -s apps/app/tests/fixtures/report-v3.bare.pdf && echo ok EXPECT: ok - Characterisation tests
tests/unit/routes.HomeRoute.import.test.tsxandtests/unit/routes.EditorRoute.export.test.tsxas spec §17 (import mocked at module level; alert text with count; the three current error kinds + generic; navigation to /editor; export call shape; download name; failure alert). CHECK: cd apps/app && corepack pnpm vitest run tests/unit/routes.HomeRoute.import.test.tsx tests/unit/routes.EditorRoute.export.test.tsx 2>&1 | tail -3 EXPECT: Tests .* passed - Whole app suite, typecheck and lint green; no file under apps/app/src changed. CHECK: cd apps/app && corepack pnpm typecheck && corepack pnpm lint && corepack pnpm test:run 2>&1 | tail -4; git -C /home/bchanot/Documents/faunosteo status --short apps/app/src | wc -l EXPECT: Tests .* passed ; 0
FILE SCOPE
apps/app/tests/** only (new test files, fixtures, goldens, helpers, README). No change under apps/app/src, packages/, docs/.