Files
faunosteo/tests/unit/lib.zoneMatch.test.ts
Bastien ChanotandClaude Opus 4.7 95d746b555 feat(editor): fuzzy zone matcher (EN-first, FR fallback, typo-tolerant)
ObservationCard previously bridged SVG zones to the JSON findings
catalog with a strict FR-name equality check. That broke as soon as the
JSON used "(ATM)" while the SVG carried "Articulation Temporo-
Mandibulaire (ATM)" or whenever either side picked up a minor casse /
accent / typo drift.

The new matcher (src/lib/zoneMatch.ts) normalizes both sides
aggressively (lowercase + NFD-strip accents + drop non-alphanumerics)
and scores each pairing across all four (bone-lang, zone-lang)
combinations:

  0     exact normalized match
  1     one normalized string is contained in the other
  2+d   Levenshtein distance d, capped at max(2, ceil(maxLen * 0.25))
  ∞     beyond tolerance — discarded

Preference order: English exact/substring first (no accents → fewer
normalization edge cases), then French exact/substring, then fuzzy
across both languages.

Real-world payoff for the current equine catalog:

  bone EN "Sphenoid"                                    → sphenoid (score 0)
  bone EN "Spheno-Basilar Synchondrosis (SBS)"          → ssb      (score 0)
  bone EN "Temporomandibular Joint (TMJ)"               → atm      (score 0)
  bone FR "(ATM)" alone                                 → atm      (score 1)
  bone EN "sphenoi" / "shenoide" (typo)                 → sphenoid (fuzzy)
  bone EN "Hyoid", "Hip joint", "Stifle", ...           → undefined (correct)

23 new unit tests cover normalization, Levenshtein, scorePair branches,
the full matchZoneFindings strategy ladder, and the absence of false
positives (Sphenoid ↛ SSB, Hyoid/Hanche/etc ↛ anything).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-20 04:25:05 +02:00

155 lines
4.7 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import {
normalizeLabel,
levenshtein,
scorePair,
matchZoneFindings,
} from '@/lib/zoneMatch'
import type { ZoneFindings } from '@/domain/schema/findings'
const ZONES: ZoneFindings[] = [
{
id: 'sphenoid',
name_fr: 'Sphénoïde',
name_en: 'Sphenoid',
categories: [],
},
{
id: 'ssb',
name_fr: 'Synchondrose Sphéno-Basilaire (SSB)',
name_en: 'Spheno-Basilar Synchondrosis (SBS)',
categories: [],
},
{
id: 'atm',
name_fr: 'Articulation Temporo-Mandibulaire (ATM)',
name_en: 'Temporomandibular Joint (TMJ)',
categories: [],
},
]
describe('normalizeLabel', () => {
it('lowercases, strips accents and non-alphanumerics', () => {
expect(normalizeLabel('Sphénoïde')).toBe('sphenoide')
})
it('strips parens and whitespace', () => {
expect(normalizeLabel('Articulation Temporo-Mandibulaire (ATM)')).toBe(
'articulationtemporomandibulaireatm',
)
})
it('keeps short bare labels intact', () => {
expect(normalizeLabel('(ATM)')).toBe('atm')
})
it('returns empty string for nullish inputs', () => {
expect(normalizeLabel(undefined)).toBe('')
expect(normalizeLabel(null)).toBe('')
expect(normalizeLabel('')).toBe('')
})
})
describe('levenshtein', () => {
it('returns 0 for identical strings', () => {
expect(levenshtein('abc', 'abc')).toBe(0)
})
it('handles classic textbook case', () => {
expect(levenshtein('kitten', 'sitting')).toBe(3)
})
it('returns length when one string is empty', () => {
expect(levenshtein('', 'abc')).toBe(3)
expect(levenshtein('abc', '')).toBe(3)
})
it('costs 1 per single-char typo', () => {
expect(levenshtein('sphenoide', 'sphenoid')).toBe(1)
expect(levenshtein('shenoide', 'sphenoide')).toBe(1)
})
})
describe('scorePair', () => {
it('scores exact normalized matches at 0', () => {
expect(scorePair('Sphenoid', 'Sphénoïde')).toBeGreaterThan(-1)
expect(scorePair('Sphenoid', 'sphenoid')).toBe(0)
})
it('scores substring matches at 1', () => {
expect(scorePair('(ATM)', 'Articulation Temporo-Mandibulaire (ATM)')).toBe(1)
})
it('routes a substring hit ("sphenoide" contains "sphenoid") to score 1', () => {
expect(scorePair('sphenoide', 'sphenoid')).toBe(1)
})
it('routes a pure-edit typo to Levenshtein scoring (2+d)', () => {
expect(scorePair('shenoide', 'sphenoid')).toBeGreaterThanOrEqual(2)
expect(scorePair('shenoide', 'sphenoid')).toBeLessThanOrEqual(5)
})
it('returns infinity for unrelated strings', () => {
expect(scorePair('Sphenoid', 'Synchondrose Sphéno-Basilaire (SSB)')).toBe(
Number.POSITIVE_INFINITY,
)
})
it('rejects empty inputs', () => {
expect(scorePair('', 'Sphenoid')).toBe(Number.POSITIVE_INFINITY)
expect(scorePair('Sphenoid', '')).toBe(Number.POSITIVE_INFINITY)
})
})
describe('matchZoneFindings', () => {
it('matches the SVG Sphenoid bone to the sphenoid zone via EN exact', () => {
const z = matchZoneFindings({ fr: 'Sphénoïde', en: 'Sphenoid' }, ZONES)
expect(z?.id).toBe('sphenoid')
})
it('matches the SVG SSB bone to the ssb zone via EN exact', () => {
const z = matchZoneFindings(
{ fr: 'Synchondrose Sphéno-Basilaire (SSB)', en: 'Spheno-Basilar Synchondrosis (SBS)' },
ZONES,
)
expect(z?.id).toBe('ssb')
})
it('matches the SVG ATM bone to the atm zone', () => {
const z = matchZoneFindings(
{ fr: 'Articulation Temporo-Mandibulaire (ATM)', en: 'Temporomandibular Joint (TMJ)' },
ZONES,
)
expect(z?.id).toBe('atm')
})
it('matches via FR-only labels when EN is empty', () => {
const z = matchZoneFindings({ fr: 'Sphénoïde', en: '' }, ZONES)
expect(z?.id).toBe('sphenoid')
})
it('matches abbreviation typed alone via substring', () => {
const z = matchZoneFindings({ fr: '(ATM)', en: '' }, ZONES)
expect(z?.id).toBe('atm')
})
it('tolerates small typos via Levenshtein', () => {
expect(matchZoneFindings({ fr: '', en: 'sphenoide' }, ZONES)?.id).toBe('sphenoid')
expect(matchZoneFindings({ fr: '', en: 'shenoide' }, ZONES)?.id).toBe('sphenoid')
expect(matchZoneFindings({ fr: '', en: 'sphenoi' }, ZONES)?.id).toBe('sphenoid')
})
it('returns undefined for clearly unrelated zones', () => {
expect(matchZoneFindings({ fr: 'Hanche (coxo-fémorale)', en: 'Hip joint' }, ZONES)).toBeUndefined()
expect(matchZoneFindings({ fr: 'hyoïde', en: 'Hyoid' }, ZONES)).toBeUndefined()
})
it('does not collapse Sphenoid into the SSB zone', () => {
expect(matchZoneFindings({ fr: 'Sphénoïde', en: 'Sphenoid' }, ZONES)?.id).toBe('sphenoid')
})
it('returns undefined when the catalog is empty', () => {
expect(matchZoneFindings({ fr: 'Sphénoïde', en: 'Sphenoid' }, [])).toBeUndefined()
})
})