Commit Graph
113 Commits
Author SHA1 Message Date
bchanot cf9c300c80 test(editor): view row switches the canvas view 2026-11-08 17:18:02 +01:00
bchanot 7cca88592f test(editor): scoped overview card queries, group names 2026-11-07 03:03:39 +01:00
bchanot 6131225288 feat(editor): board 01 annotation card, side column from 1 024 px
Annotations of the view move from under the drawing to the overview card
(grouped by category, name filter, all rows); side column from lg.
Properties panel gains « Toutes les annotations ».

E2E mapping (R-24): after a creation the card is hidden (the new annotation is
selected), so list(...).getByText(name) became selectionTag toContainText
(annotations, geometry, journey); row clicks go through pickAnnotation
(annotations, geometry, journey, structures); geometry's list count 0 while a
creation is pending became selectionTag count 0.
2026-11-06 21:40:25 +01:00
bchanot 51fd3db608 feat(editor): no silent loss on a 1 024 px crossing
Drawing actions stay mounted and hidden while read-only: an upload in
flight, a cleaning candidate, a repair offer and a parent choice come
back on widening. Decision dialogs open only while editing, in a shown
place, references panel closed; otherwise the decision is held per
object, shown as a pending line, reopened by « Reprendre » (absent in
read-only). Picker, file input and parent button are disabled while one
is pending. Repair geometries move into RepairDialog, keyed on the offer.

R-24: no existing assertion rewritten; editor-no-loss-decisions.test.tsx
added (12 cases).
2026-11-06 21:23:46 +01:00
bchanot c57af6441f feat(editor): keep edit-only forms across a width change
Edit-only parts (creation forms, submission note, crop group, annotation
edit body) mount at the first editable render and stay mounted, hidden
and detached from canvases, while read-only. Guards: the viewport hook
commits the focused field before the tier crosses 1 024 px, the route
releases focus left in a hidden part and treats a store out of step as
read-only, delete and discard confirmations close when the editor turns
read-only, a drag is dropped while the edit body is hidden. Read-only
twins take an id prefix.

R-24: no existing assertion rewritten; editor-no-loss.test.tsx and two
editor-shell Chromium cases added.
2026-11-06 21:22:10 +01:00
bchanot 9d89daed19 test(editor): pending creation announcement on « Aller à » 2026-11-06 20:59:11 +01:00
bchanot 79a09f8b25 test(editor): keep-alive paths, neutral place visibility
Place visibility context moves to lib/placeVisibility.ts so the catalogue
no longer imports from components/editor. Adds tests: selection survival,
unmeasured hint round trip, keyboard tab move and « Aller à » with a field
focused, replace-tracing kept, announcements. Parse-sharing test uses
object identity. Early exits are two statements; shortcut comment on the
parse cache.

R-24:
- editor-equine.spec.ts:118, editor-geometry.spec.ts:376,
  editor-recovery.spec.ts:39, editor-signout.spec.ts:26: page.getByLabel
  ('Nom (FR)') -> place(page, 'general').getByLabel(...)
- editor-shell.spec.ts: toHaveCount(0) on the visible query -> count 1
  on the raw selector and toBeHidden()
- editor-keep-alive.test.tsx: JSON.parse stack-trace count -> same
  object reference across places
2026-11-06 20:57:08 +01:00
bchanot 6689827a8d feat(editor): kept-mounted tabs, sections and references panel
Each visited tab, Annotations section and the references panel stay
mounted in a KeptPlace (hidden, nested visibility). Composed canvases
detach while hidden. One JSON.parse per document text. Focus requests
reach only their owning place.

Rewritten assertions (R-24):
- editor-route.test.tsx:127: annotations testid toBeNull -> not.toBeVisible
- editor-sections.test.tsx: place('annotations.drawing') toBeNull -> not.toBeVisible
- editor-journey.spec.ts:311: page-wide getByLabel('Nom (FR)') -> scoped to place 'general'
- editor-tabs-lists.test.tsx: ReferencesPanel `open` prop dropped (the wrapper hides it)
- editor-annotations-tab, editor-focus-request, editor-sections tests: props gain `visited`
No assertion removed.
2026-11-06 20:50:40 +01:00
bchanot ca184da4d9 refactor(editor): split B1 navigation hooks, category count on the overview card 2026-11-06 20:31:26 +01:00
bchanot bc2dba7c14 feat(editor): four tabs, Annotations sections, references from the header
U1 Lot B1. Four tabs (Général, Annotations, Constats, Vérification); views,
categories and regions become full-width Annotations sections opened from the
overview panel; references move to a header-toggled panel (minimal, Lot D
completes it); « Aller à » goes through EditorTarget and the navigation hook.
EditorWorkspace owns the navigation; DraftHeader split in HeaderActions and
SaveLine; EditorTabs split in TabList and MoreTabs.

R-24, assertions removed or rewritten (file: old -> new):
unit
- editor-route.test: seven tab names -> four; « Plus » at 800 px with
  Références clicked -> no « Plus »; below 640 px five others -> Général,
  Constats, and Constats opens the findings tab; + references panel cases
- editor-route-recovery.test: tab Références + editor-tab-references label ->
  header button + editor-references-panel labelled by its heading
- editor-mode.test: small tier `more` of five -> [general, findings]
- editor-focus-request.test: {key,serial} -> {target,serial}; ReferencesTab and
  VertebraeTab -> ReferencesPanel and RegionsSection; issueTarget tab/key ->
  target place/section/key (vertebrae tab -> annotations/regions); consumed
  context (serial) -> (serial, outcome); annotation case adds heading focus
- editor-verification.test: onGoTo('annotations', key) -> navigate(targetOfKey
  (key), opener); props onSelectTab/onGoTo -> navigate
- editor-annotations-tab.test: props onSelectTab -> navigate + section props;
  no_category text « (onglet Général) » -> « (Annotations, section
  Catégories) »
- editor-tabs-general.test: categories cases render GeneralTab ->
  CategoriesSection(doc); + Général holds no categories editor
- editor-tabs-lists.test: tab imports -> panel and section; read-only
  references « no button » -> only « Fermer les références »
- editor-tabs-views, editor-drawing-upload, editor-repair.test: ViewsTab ->
  ViewsSection import, assertions kept; editor-findings.test: navigate prop
e2e
- support/editor selectTab: exact name -> pattern (error badge in the name);
  + place, openSection, showDrawing, backToDrawing, openReferences, TABS
- support/warm-up: seven tabs -> four + sections + references panel
- editor-access: seven-tab axe loops -> four tabs + three sections + panel
  (edit and read-only); narrow widths add panel overflow and axe
- editor-drawings: tab Vues -> openSection views; tab Annotations ->
  showDrawing
- editor-structures: tab Général (categories) -> openSection categories, axe
  label « general tab » -> « categories section »; tab Références ->
  openReferences/closeReferences; tab Vertèbres -> openSection regions; tab
  Annotations -> showDrawing
- editor-geometry: three tab Vues -> openSection views
- editor-equine: tab Général (categories add) -> openSection categories; five
  tabs loop -> two tabs + sections + panel; tab Annotations -> showDrawing
- editor-journey: tab Vues, tab Général (category), tab Annotations ->
  openSection views/categories, showDrawing; frozen axe scrolls to the header
- lan/trial-lan (not run): tab Vues -> Annotations tab + views entry

Verified: typecheck, lint, vitest 107 files / 1125 tests, whole shell suite on
the sandbox 151 passed, 49 skipped, 0 failed.
2026-11-06 20:25:35 +01:00
bchanot 95b1b7e461 feat(editor): navigation model for the four-tab shell 2026-11-06 18:25:21 +01:00
bchanot a69eba569b fix(editor): free paths never reshaped on attach, category zone chosen explicitly 2026-11-04 22:14:59 +01:00
bchanot 5e0aa625a8 fix(editor): submission note sent as typed, copies purged again after sign-out 2026-11-04 20:50:16 +01:00
bchanot 9c21fd3f86 fix(editor): repair dialog limits, pending drafts block apply, dialog wording 2026-11-04 20:17:51 +01:00
bchanot 3776a33b79 feat(editor): repair out-of-frame annotations when attaching a drawing 2026-11-04 20:10:07 +01:00
bchanot bd4ba338af feat(app): sign-out warns before losing editor work, local copies purged 2026-11-04 19:58:21 +01:00
bchanot be4f468790 fix(editor): plurals, trimmed names, default tab, parent drawing confirmation 2026-11-04 19:40:43 +01:00
bchanot 05c9b3e10b fix(editor): read-only undo, upload session check, restore and submit guards 2026-11-04 18:06:40 +01:00
bchanot d10ba5d5dd fix(editor): verifier gaps: ratified wordings, copy messages, real SVG journeys 2026-11-04 17:27:45 +01:00
bchanot 4cc27a8231 test(editor): lot K review fixes, filled-document save proof 2026-11-04 15:52:15 +01:00
bchanot bb99edd2dd fix(editor): load the core's defaults-filled document, trial guide fixes 2026-11-04 15:35:19 +01:00
bchanot 5097fd7484 test(editor): V1-2.6 browser journeys on the sandbox, touch drag and findings fixes 2026-11-04 15:27:35 +01:00
bchanot 3d589e1556 fix(app): a focus request is consumed once, not replayed on tab return 2026-11-04 14:09:30 +01:00
bchanot 4f223e04cd feat(app): Aller à selects the element in its tab, reload after submit 2026-11-04 14:06:09 +01:00
bchanot 3f15762d95 fix(app): annotations tab split, editor-wide undo keys, keyboard point fits, typed radius message 2026-11-04 14:00:57 +01:00
bchanot 447d0a4272 feat(app): editor Vérification tab and review submission 2026-11-04 13:59:16 +01:00
bchanot 91d06c9817 feat(app): Constats description, vet referral and citations, keyboard focus after collapse and delete 2026-11-04 13:50:20 +01:00
bchanot 26097852ff feat(app): editor Annotations tab, core-decided placement, repair rules 2026-11-04 13:49:41 +01:00
bchanot 92c595caa1 feat(app): editor Constats tree with review states and reorder 2026-11-04 13:45:34 +01:00
bchanot 7ea9619aa0 refactor(app): split the crop group hook, closed reason in drawing refusals 2026-11-04 13:36:09 +01:00
bchanot 1bbf97e65b fix(app): closed hash and canonical-form drawing messages, split crop and drawing views 2026-11-04 13:34:02 +01:00
bchanot 8343528be9 feat(app): editor views tab, drawing upload and cleaning, guarded crops 2026-11-04 13:02:30 +01:00
bchanot d163b2ce9a feat(app): editor Général, Références and Vertèbres tabs, delete with dependents 2026-11-04 12:46:55 +01:00
bchanot 6aba9711f0 feat(app): sheet draft editor route, modes, recovery offer and conflict dialog 2026-11-04 12:35:33 +01:00
bchanot b14509f221 fix(app): editor store keeps an unanswered copy across mode changes, refuses unsaved submit 2026-11-04 12:17:41 +01:00
bchanot 7f1d44065b feat(app): editor store, undo, recovery copy and geometry accept rules 2026-11-04 12:13:10 +01:00
bchanot bc43a1b86b fix(app): roll the preview back on a throwing accept or a non-trap failure 2026-11-04 11:50:59 +01:00
bchanot 173be5949a feat(app): editable sheet preview, edit wrappers, cleaning preview and ids 2026-11-04 11:48:01 +01:00
bchanot 2f824a947c feat(supabase): add draft_last_save to the sheet admin read (M8, sandbox only) 2026-11-04 11:40:22 +01:00
bchanot 51225cacf6 fix(app): grant expiry ends the chosen day in Paris; species order 0..9999 (V1-2.5 L2)
Owner checkpoint 2026-11-02: expiry 23:59:59.999 Europe/Paris (picker, validation, display), tests under non-Paris zones and DST days; M7 redefines create_species and update_inactive_species with the range check; pgTAP 015 and 022; « Relecteur ou relectrice »; object_conflict EN; setup key selectable, no Copy.
2026-11-02 21:29:33 +01:00
bchanot 4111efa1d1 fix(app): unreadable permissions show a retry, never the form (V1-2.5 L1)
Owner checkpoint 2026-11-02: creation page checks loading, server refusal, failed read, then the editor rule; Administration home shows the same notice. reloadAccess re-reads roles and grants without wiping held state; refreshAccount (no caller) removed. Zone panel live region always mounted. Unit and e2e for reviewer-only and editor.
2026-11-02 21:21:59 +01:00
bchanot 5db85ff19f fix(app): a failed account reload clears the own grant rows
Delta verifier note: the catch kept earlier catalogGrants beside status failed, against the field's doc; now emptied, test extended.
2026-11-02 19:49:19 +01:00
bchanot e39f69ee6d fix(app): a failed account load no longer leaves own grants loading
Delta verifier: when the profile or roles read failed, the grant read never ran and the creation page waited forever; the catch now marks the grants failed (form shown, server decides). Store transition tests (ready, loading on change and sign-out, failed), red without the fix. Contract clarification states the failed-read behaviour for the owner.
2026-11-02 18:41:32 +01:00
bchanot f04bfdd040 fix(app): creation page waits for own grants; e2e never prints setup keys
Delta verifier: two remaining setup-key assertions now booleans. Its observation: the editor rule read grants before they loaded; authStore.catalogGrantsStatus (loading, ready, failed): the page waits, and a failed read leaves the decision to the server. App 654, e2e:ui 227, admin shell spec 14 + 6 skipped.
2026-11-02 18:33:57 +01:00
bchanot 02625a76b6 fix(app): sheet creation form only for editors; review findings (V1-2.5 K)
Verifier C4: /app/admin/sheets/new shows Accès non autorisé without sheet_editor (display rule, server unchanged), tests. Security: M7 restates get_sheet_version grants; e2e enrolment check never prints the setup key. Contract clarifications: phone skips, run evidence, one intermittent e2e failure tracked.
2026-11-02 18:18:54 +01:00
bchanot 0176b3184d feat(app): administration screens and anatomical catalogue (V1-2.5 G, H, I)
Administration page (board 10), species, rights, official sheets list with filters, creation from the core's empty document, overview with the working-copy action; catalogue list (search by sheet name), sheet and version pages through PreviewSheet with zoom and pan. App 650, typecheck, lint, build green.
2026-11-02 17:18:27 +01:00
bchanot 4744e28986 feat(app): admin and catalogue entries, step-up guard, MFA in Mon compte (V1-2.5 E, F)
Nav hint from own grants and roles (never a control); RequireCatalog, RequireAdmin (no admin read before aal2), Accès non autorisé page, placeholder routes; TOTP factor list, enrolment with QR and one-time secret, removal, inline step-up for aal2 actions, step-up in password reset; auth kind aal2_required. App 601, e2e:ui 227.
2026-11-02 16:49:37 +01:00
bchanot bbab0e61cb feat(domain): sheet.empty free op for a new sheet's document (V1-2.5 C)
Wraps create_empty_sheet_document; refusals invalid_shape / invalid_json; ts-rs SheetEmptyInput, core-wasm proof, app wrapper emptySheetDocument.
2026-11-02 16:19:49 +01:00
bchanot 9c606aa567 fix(anatomy): V1-2.2 the visible wins on the editor canvas
Owner decision 2026-11-01. The canvas paints and hits every point hitbox,
then every zone and trigger, then every visible twin, which captures on
what it paints; a junction's disc is no longer taken by the zone drawn
after it. The PDF view keeps the document order and its bytes. Click
spec: the five fixme run unmarked, six projects incl. a 320 px phone.
2026-11-01 00:56:11 +01:00
bchanot 4f52f5e1c4 fix(anatomy): V1-2.2 marker layer and halo outside the drawing's group
Owner-approved lot B (brief 2026-11-01). The composition root is the
engine's (namespaces and frame); the drawing's root becomes a group and
the marker layer and halo are its siblings, so no root property reaches
a marker. Point hitboxes declare stroke none and visibleFill. Census over
the reader's whole allowlist; R3 references compared under the declared
transform; click proofs in three engines.
2026-11-01 00:39:57 +01:00