Commit Graph
92 Commits
Author SHA1 Message Date
bchanot 3bea19f16b test(app): e2e cleanup checks the seeded name before archiving
D4 identity check: the integrity spec reads each own sheet's name by its
captured id and archives it only when it is exactly the seeded name.
seedGrant checks the account id as a captured id, now shared from
records.ts.
2026-11-17 01:04:27 +01:00
bchanot 1e5058577f fix(app): failure row fits Réessayer and Consulter side by side
Board 30: in a three-column card at 1280 px the two buttons wrapped by a
few pixels. The failure row narrows their padding only there; the wrap
stays as the fallback. The network e2e now checks both on one row.
2026-11-17 01:04:03 +01:00
bchanot dadd8e5d29 test(app): catalogue card integrity and retry on the sandbox 2026-11-17 00:24:14 +01:00
bchanot a50796b89f fix(app): closed filters panel has no height; e2e asserts it at 375 px 2026-11-16 20:47:34 +01:00
bchanot 6d2ba0dbf2 test(app): phone filters panel on the sandbox sheet list spec 2026-11-16 20:31:36 +01:00
bchanot ea5512af02 test(app): sheet list spec binds its SQL values, pins UTC, checks Escape
- the three fixture statements pass every value through literal(); the
  sheet, draft and actor ids are refused unless they have the uuid shape
- test.use({ timezoneId: 'UTC' }): a row still in Paris time proves the
  page sets the zone itself, whatever the host's
- the home ordering loop first asserts one <time> per item
- ratifiedDate escapes the dictionary text (escaped, now exported by
  support/admin.ts)
- the long-search check types the text again and presses Escape: field
  empty and focused, count back (Chromium's native type=search included)

R-24: no assertion removed or rewritten. Added: 'one date per home item'
(toHaveLength) before the unchanged ordering loop; the Escape block after
the unchanged button block. ratifiedDate builds the same pattern for the
current dictionaries (no RegExp character in them).

Run: admin-sheets-list 4 passed (fr, en x desktop, 375).
2026-11-16 18:10:13 +01:00
bchanot b4a5254068 test(app): shell proof of the sheet list search, sort and dates
admin-sheets-list.spec.ts (sandbox, fr and en, desktop and 375 px): three
draft sheets of this run, the oldest saved last; search, count line against
the list answer of the same load, order by last modification then by name,
the Paris date format, a search cut at 100 characters and its clearing, axe
and no sideways scroll on the searched list, the empty state and
/app/admin; the home's latest changes. Teardown soft-deletes only the ids
this run created (D7).

allSheetsLink (e2e/support/admin.ts): the sheets card link named
admin.home.all_sheets or admin.home.see_all with any number.

R-24, locators rewritten (assertions unchanged):
- admin.spec.ts A1: areaCard(...).getByRole('link', { name:
  dict['admin.home.all_sheets'] }) -> allSheetsLink(areaCard(...), dict)
- admin.spec.ts access per right: sheets.getByRole('link', { name:
  dict['admin.home.all_sheets'] }) -> allSheetsLink(sheets, dict)
- editor-journey.spec.ts createSheetFromAdmin: section locator
  .getByRole('link', { name: dict['admin.home.all_sheets'] }) ->
  allSheetsLink(section locator, dict)
2026-11-16 17:34:43 +01:00
bchanot 52d5613fe5 test(editor): keyboard-only cite and save restores in one undo 2026-11-15 20:50:49 +01:00
bchanot 1d119c3684 fix(editor): stale cite choice reset, pending line under the add row 2026-11-15 20:00:28 +01:00
bchanot 70eb2fcbb4 feat(editor): a reference made in the citations draft saves with it 2026-11-15 19:55:41 +01:00
bchanot 8c3fcca0b9 feat(editor): « Citer » button and family labels in references 2026-11-15 19:40:47 +01:00
bchanot 2579d4c7ae test(editor): e2e on the references dialog's edit mode 2026-11-15 16:46:05 +01:00
bchanot d9dbcf1609 fix(editor): dialog trigger for references, Task 11 review minors 2026-11-15 16:25:32 +01:00
bchanot da755f9768 fix(editor): Plus rows hover tint, axe on an active row, line limits 2026-11-15 16:21:01 +01:00
bchanot 2c4c771269 test(editor): e2e on the references dialog instead of the sheet
Helpers citationsDialog, closeCitations by the dialog's ✕. Owner journey
with tap at 375, keyboard and axe; geometry checks now dialog in viewport
with focus inside; refused « Tout afficher » over a dirty form.
2026-11-15 16:15:43 +01:00
bchanot ff21b0315e feat(editor): one tab order, vertical Plus list with the error count 2026-11-15 15:52:28 +01:00
bchanot 50256b19f1 fix(editor): sub-pixel tolerance on the 375 px sheet width check 2026-11-14 19:11:39 +01:00
bchanot 96e301ab69 fix(editor): e2e for Back over the sheet and the leave over it 2026-11-14 19:09:09 +01:00
bchanot 0ea94602d1 fix(editor): e2e setup retries a GoTrue 500 step-up, drops late replays 2026-11-14 19:01:21 +01:00
bchanot 791fc03a0d fix(editor): Task 8 round 2, cascade closes the sheet 2026-11-14 15:13:38 +01:00
bchanot 579d8afff4 fix(editor): Task 8 round 1, sync tag, cascaded leave ask 2026-11-14 15:01:23 +01:00
bchanot 07bebbc855 feat(editor): session tag in history, confirm before leaving 2026-11-14 14:47:43 +01:00
bchanot 085c56877c fix(editor): deletion undo and Back, Plus focus to the panel 2026-11-14 14:24:06 +01:00
bchanot f0e49fd447 feat(editor): cite references from the finding edit form only 2026-11-14 14:11:13 +01:00
bchanot 3a7ffa2f8b fix(editor): Plus Escape focus return, sheet width rounding 2026-11-13 23:58:59 +01:00
bchanot 6bf9290da7 fix(editor): final review round, history, dialogs, Plus and limits
I1 scroll restored at once on a Back into layers; I2 Aller a opens the target dialog in one push; M1-M9, criteria 8 and 17 (left-draft notice), entry caps, no exhaustive-deps disables, locals within 5.
2026-11-13 23:42:32 +01:00
bchanot ca5804a8b7 feat(editor): Plus dropdown overlay with back request, sticky sidebar 2026-11-13 22:32:51 +01:00
bchanot 3bb3603115 fix(editor): Task 3 round 1, literal journey, pin, limits, notice 2026-11-13 20:38:04 +01:00
bchanot 8b42816270 test(editor): reference dialog, filter and the owner journey, specs follow the dialog 2026-11-13 20:27:01 +01:00
bchanot e2d020bd3d test(editor): fix typecheck of the history entry and dialog helpers 2026-11-13 19:54:06 +01:00
bchanot af300de04c fix(editor): Task 2 round 3, lint, locals, stale comment 2026-11-13 19:51:03 +01:00
bchanot b703333b20 fix(editor): Task 2 review round 1, trace calls, form hooks, keyboard proof 2026-11-13 19:39:29 +01:00
bchanot c893dec60b feat(editor): « Aller à » opens the finding dialog, spec races fixed
« Aller à » a finding shows its row and opens its dialog in view mode.
E2e helpers wait for the history to settle after a layer or section
pop; the layout walk waits out the write budget. Label rows for the
nine new keys.
2026-11-13 19:23:48 +01:00
bchanot 4731a3376a feat(editor): sheet landings, history and e2e for the finding layers
« Tout afficher » clears the search and keeps the sort. A landing waits
for the dialogs a move closed and for their focus restore. Helpers and
shell specs move to the dialog and sheet flow; new finding dialog spec
(entries, guards, flip, gone rule, Back and Forward over the layers).
2026-11-13 19:03:21 +01:00
bchanot 8e4f02620a fix(editor): Task 1 review round 1, section back pops, scroll proof 2026-11-13 18:12:19 +01:00
bchanot 792394d3b2 feat(editor): browser history for tabs, sections and Aller a
EditorView held by the navigation reducer (restore_view), a history
adapter hook mounted in EditorWorkspace (push, replace, back, mount
rule, ownership, write budget, scroll map, refused POP), a guard stack
by layer, an announcer queue joined after open dialogs.
2026-11-13 17:57:52 +01:00
bchanot 69e225ca7a style(tests): format c4-measure annotation (residual 9c) 2026-11-13 17:57:47 +01:00
bchanot 346a8fd8f1 test(tests): typed draft before Escape in the add e2e, prettier on C4 spec 2026-11-13 14:49:18 +01:00
bchanot 78fb2d076e test(tests): C4 round 4, deterministic touch proof 2026-11-13 14:42:29 +01:00
bchanot f7f0aa675d test(tests): C4 review round 3, helper locals 2026-11-13 14:18:36 +01:00
bchanot 776692922e test(tests): C4 review round 2, calibration guard 2026-11-13 14:16:30 +01:00
bchanot 817f74ba18 test(tests): C4 review round 1, worst-case touch distance 2026-11-13 14:13:03 +01:00
bchanot 969a5f360f test(tests): prove the citations trigger is reachable by touch at 667 x 375 2026-11-13 14:05:07 +01:00
bchanot b1fd8962ff fix(editor): say when a pinned tile is outside the search
A shown tile the search misses carries « Ne correspond pas à la
recherche » under its header (aria-describedby). The no-result notice
now needs no shown tile at all. Flip test watchers are stopped in
afterEach, so a failing assertion never leaves the setters patched.
2026-11-13 13:49:46 +01:00
bchanot d1779928a9 feat(editor): cancel adding a reference by button or Escape
Draft tile gets « Annuler l'ajout »; Escape cancels from non-text targets and
from a pristine text field, never while composing or already handled. Nothing
reaches the document, history untouched, focus back on the add button.
2026-11-13 12:39:57 +01:00
bchanot 3303530717 fix(editor): never drop a refused draft silently on a read-only flip
Drop slot is tile-local state; the edit view cleanup reports every pending
field (FIELDS order) only when some are pending. The tile shows a warning
note and says it once in the live region; it ends on toggle, Terminer or a
newer drop. LeaveGuard returns all refused fields (forced panel close names
them all). Pin follows editingKey through read-only; reset re-pins it.
Read-only toggle ends edit and collapses. Flip focus goes to the tile header.

R-24 mapping:
- view test "keeps its index ... read-only (M3)": renamed, same assertion
- view test "is suspended in read-only ...": rewritten as "stays pinned in
  read-only" (pin kept, tile still shown after a search); toggle test added
- reset test extended: tile in edit stays pinned through the reset
- new editor-references-flip.test.tsx covers (a)-(g); (h) is a stated limit
2026-11-13 11:11:51 +01:00
bchanot 1bf27014b3 fix(editor): one history entry per reference edit, focus kept
Final review fixes. « Terminer » and every panel close re-committed the
edited field against a stale value, adding a second identical history
entry so the first « Défaire » seemed to do nothing: the tile now reads
the latest applied value (tests assert the undo-length delta). A tile
leaving the search on « Terminer » stays pinned until the next view
change and keeps focus; « Ajouter la référence » resets search and sort
and focuses the new tile. Also: refused draft dropped on a read-only
flip is announced; arrow keys respect a refused tab switch; pinned
index kept across read-only; the panel announces « Références citées »;
search text inserted literally; « Aller à » names its citer; the edit
header's name starts with « Terminer. »; undo removing the focused panel
tile moves focus per P20; no-result announced once; docs corrected.

Gates: typecheck, lint, test:run (app 1510), build, e2e:ui 251;
e2e:shell 16 specs (admin and editor-equine excluded): 117 passed / 108
skipped / 1 failed (crossing:211 stuck on the MFA step-up screen before
the editor), rerun alone 11 passed; full-row guard: no pre-existing row
changed in any table.
2026-11-13 01:08:00 +01:00
bchanot 4b7d2542fd test(tests): R2 non-regression sweep fixes
openTab waits for the shown place on every tab again (the former
goToTab waited for the annotations place). editor-equine.spec opens the
citations panel again on a finding of the equine copy, « Suture
sagittale (entre les deux pariétaux) » (unique, cited, reached in five
expansions: openCitations takes an optional expansion budget, default
4); updated for typecheck only, never run (owner rule).

Sweep: e2e:shell all 21 specs except editor-equine on db:sandbox: 219
passed / 116 skipped / 3 failed, the three in admin.spec, « Target
crashed » during axe on admin screens that render every accumulated
grant (not R2); new specs run twice (sweep + 33 passed after these
fixes); full-row guard: no pre-existing row changed in any table.
R-24 audit of 49867ba..HEAD: 58 mapped, 17 justified, 0 lost.
Gates: typecheck, lint, test:run (app 1488), build, e2e:ui 251.
2026-11-12 22:42:20 +01:00
bchanot 8db6f4287f feat(editor): contextual citations panel of a finding (board 25)
The panel opens only from a finding's « {n} références » trigger: 34 rem
at most, never wider than the room, a scrim, slide in 180 ms and out
140 ms (motion/react; none under reduced motion, callbacks still fire).
It lists the finding's references as tiles with « Modifier », « Retirer
de ce constat » (one « Défaire » restores it and the review status) and
« Aller à »; dangling ids read « Référence introuvable »; zero left
reads « Ce constat ne cite plus aucune référence. ». « Tout afficher
dans l'onglet Références » resets search and sort, keeps open tiles and
edits. Every close (✕, Escape outside fields, scrim, tab, « Aller à »,
« Tout afficher », element gone) records one pending move applied
after the exit, page inert until then; focus back to the trigger, else
the active tab button. A refused draft cancels a user close; a forced
close drops it and announces « Saisie non appliquée : {field} ». Places
keeps a permanent dvh min-height; the panel fits the visible viewport
at every scroll position, document size unchanged.

Gates: typecheck, lint, test:run (app 1488), build, e2e:ui 251;
e2e:shell 16 specs on db:sandbox (admin and editor-equine excluded):
117 passed / 107 skipped / 0 failed, rerun after the fix rounds: 118
passed / 108 skipped / 0 failed; layout spec 13 passed after round 2;
full-row guard: no pre-existing row changed in any table. Known limit:
landscape 667 x 375 at scroll 0 leaves ~13 px of panel (the trigger is
below the fold there).

## R-24 (removed or rewritten assertions)

| file | old | new |
|---|---|---|
| editor-references-panel.test.tsx (whole file) | R2.1 interim-panel tests, synchronous closes | rewritten: 39 tests (opening, motion, close matrix in both modes, exit, Retirer, P22'', library + history) |
| same, opening | heading `Références` focused right after the click | heading `Références citées` focused after the enter (`waitFor`), `aria-expanded` only after click |
| same | chip `references-filter-chip` « Citées par « Node A » (2) » | REMOVED (REVUE: path line + count line « 2 références citées par ce constat ») |
| same | `listitem` cards « Citée 2 fois » | tiles (`ul > li`) with the same counts, in the finding's order |
| same | field id `#panel-reference-0-ref-a-citation` present at once | tile opened + « Modifier » first (tiles since R2.2) |
| same | « Tout afficher (3) », sync | « Tout afficher dans l'onglet Références », after exit, heading focus asserted |
| same | Escape / ✕ / scrim / tab / vanish: sync null panel | all `await closed()` + `document.activeElement` checks, `describe.each` normal / reduced motion |
| same | « makes the tab panels inert while open, header usable » | split: inert page + inert panel until the exit ends then lifted; « Défaire / Refaire usable »; the `Enregistrer` enabled check dropped (covered by the focus-moved-off test) |
| same | Ctrl+Z test on an always-open field | open tile + Modifier first |
| same | read-only: no Supprimer, no textbox | open tile: no Modifier, no Retirer, no textbox |
| same | P6 under « Plus »: sync | in the close matrix, awaited |
| editor-escape.test.tsx (2 tests) | `expect(citations()).toBeNull()` right after Escape | `await waitFor(...)`; trigger `aria-expanded` false after exit |
| editor-keep-alive.test.tsx | « Escape in a citations panel field commits the text before the panel closes » | REPLACED by « Escape in a field of a panel tile neither closes nor commits » (A5, P27) |
| same | scrim click closes the panel after committing, sync, id on a closed tile | tile opened in edit first, close awaited, commit asserted before the exit |
| editor-focus-request.test.tsx | `ReferenceLibrary` with `resetSignal`; `ownedBy(ref,'citations')` undefined | `ReferencesTab` (+ `reloadSheet`); the `'citations'` assertion removed with the type |
| editor-references-tab / -view.test.tsx | `ReferenceLibrary`, `resetSignal` | `ReferencesTab`, `libraryReset` (+ `reloadSheet`) |
| e2e support `openCitations` | waited for the panel visible | also waits for the heading focus (slide over) |

New unit coverage: editor-citations-exit.test.tsx (hook, fake timers), editor-findings (aria-expanded per finding),
`useDecisionsOpen` gate, panel file (Retirer + status + one undo, P20 chain, zero state, dangling id, P4 reset, P6 after undo,
P22'' four paths, reduced motion, inert/exit, second close, tab replace, focus-moved-off).

## i18n (FR / EN)

Added: `editor.references.panel_title` Références citées / Cited references; `panel_count_one|other` « {count} référence citée par
ce constat » / « {count} références citées par ce constat » and « {count} reference cited by this finding » / « … references … »;
`panel_show_all` Tout afficher dans l'onglet Références / Show all in the References tab; `panel_empty` Ce constat ne cite plus
aucune référence. / This finding no longer cites any reference.; `remove_citation` Retirer de ce constat / Remove from this finding;
`this_finding` ce constat / this finding; `missing` Référence introuvable / Reference not found; `draft_dropped`
Saisie non appliquée : {field} / Entry not applied: {field}.
Changed: none. Removed: `editor.references.cited_by` (« Citées par « {name} » ({count}) » / « Cited by « {name} » ({count}) »),
`editor.references.show_all` (« Tout afficher ({count}) » / « Show all ({count}) »). R10 grep over src, tests and e2e including
editor-equine: no reader left. `editor-equine` has no panel reference: « updated, not run » (nothing to update). The three
provisional FR labels are exactly as listed in the brief; `…` = the refused field's label.
2026-11-12 22:27:32 +01:00
bchanot 3baac4dbb5 feat(editor): search, sort, count and add in the Références tab
Search (citation, DOI, URL) with « Effacer la recherche » and Escape;
« Trier par » sheet order, citation (locale collator), citation count,
type (business order); every sort stable on stored order, display only:
document, stored order, ids and history unchanged (unit + e2e). Count
« {n} références » / « {n} sur {total} » counts matching references
only. « Monter » / « Descendre » only in sheet order without search
(A1). « Ajouter une référence » resets search and sort and appends a
draft tile in edit; a tile in edit stays pinned while sorted or
searched; tile state pruned of absent ids. Reset path ready for « Tout
afficher » (R2.4).

Gates: typecheck, lint, test:run (app 1452), build, e2e:ui 251;
e2e:shell 16 specs on db:sandbox (editor-equine never listed): 115
passed / 102 skipped / 2 failed: editor-structures (test-side, fixed,
rerun with editor-references 12 passed / 11 skipped) and admin.spec A0
« Target crashed » during axe on the rights screen (not R2: that
screen renders every grant, 1 282 accumulated e2e fixtures; reported as
an open risk); full-row guard: no pre-existing row changed in any table.

## R-24 (removed or rewritten assertions)
| file | old | new |
|---|---|---|
| editor-references-tab.test.tsx | `#tab-reference-new-citation` present on load | null until « Ajouter une référence » |
| same | no match text « Aucune référence ne correspond. » | notice « Aucune référence ne contient « zzz ». » |
| same | add: form always visible, add clears the search, `getByText('Nouvelle source')` | click « Ajouter une référence » first; new tile header open, focused, search empty, 4 tiles |
| same | « a refused add keeps the search » | REMOVED (P24: add resets the search at once); replaced by « draft opens with citation focused, refused add keeps the draft, no write » |
| editor-tabs-lists.test.tsx | add form directly | click « Ajouter une référence » before the form assertions (same assertions after) |
| editor-keep-alive.test.tsx | form survives tab round trip | same, after opening the draft |
| editor-no-loss.test.tsx | reference form keeps typed text | same, after opening the draft |
| e2e editor-shell.spec (2), editor-shell-crossing.spec, editor-structures.spec | fill `#tab-reference-new-*` directly; `getByText(citation)` visible | open the draft first; structures asserts the new header is focused |
| e2e editor-references.spec keyboard walk | focus search, Tab reaches header 0 | focus « Ajouter une référence » (search, sort, add precede the headers) |
Other readers of `editor.reference.add`/new ids: grep of src, tests, e2e incl. editor-equine found none left unlisted. editor-equine is not affected ("updated, not run": nothing to update).

## i18n (fr / en)
Added: `editor.references.add` Ajouter une référence / Add a reference; `add_help` Type et citation obligatoires. / Type and citation required.; `clear_search` Effacer la recherche / Clear the search; `sort_by` Trier par / Sort by; `sort.sheet|citation|count|type` Ordre de la fiche, Citation (A → Z), Nombre de citations, Type / Sheet order, Citation (A → Z), Number of citations, Type; `count_one|other` {count} référence(s) / reference(s); `count_of_one|other` {count} référence(s) sur {total} / {count} reference(s) of {total}; `reorder_hint` Pour réorganiser, affichez l'ordre de la fiche sans recherche. / To reorder, show the sheet order without a search.; `no_result` Aucune référence ne contient « {q} ». / No reference contains “{q}”.; `no_result_scope` La recherche porte sur la citation, le DOI et l'URL. / The search covers the citation, the DOI and the URL. (REVUE sentence split in two keys so the first half is bold).
Changed: none. Removed: none (`editor.references.no_match` kept, the panel's EmptyLine still uses it).
2026-11-12 21:18:56 +01:00