Commit Graph
240 Commits
Author SHA1 Message Date
bchanot 0ea94602d1 fix(editor): e2e setup retries a GoTrue 500 step-up, drops late replays 2026-11-14 19:01:21 +01:00
bchanot bb35e86dbb fix(editor): five locals in stepHistory and MoreTabs, sync tag in tests 2026-11-14 18:52:41 +01:00
bchanot 08fab77d0e fix(editor): the delete hint names « Modifier » before « Retirer » 2026-11-14 18:51:38 +01:00
bchanot 28e298ac56 fix(editor): a sign-out with a dirty dialog is said at the next sign-in 2026-11-14 18:50:42 +01:00
bchanot 7ecaf1998e fix(editor): salt the session record's fingerprint with its tag 2026-11-14 18:49:09 +01:00
bchanot 2ad720b34e fix(editor): ask only the layers a Back removes, clear the sheet first 2026-11-14 18:47:24 +01:00
bchanot 791fc03a0d fix(editor): Task 8 round 2, cascade closes the sheet 2026-11-14 15:13:38 +01:00
bchanot 579d8afff4 fix(editor): Task 8 round 1, sync tag, cascaded leave ask 2026-11-14 15:01:23 +01:00
bchanot 07bebbc855 feat(editor): session tag in history, confirm before leaving 2026-11-14 14:47:43 +01:00
bchanot 4018344ffc fix(editor): Task 7 round 1, reveal reset, forced-colors ring 2026-11-14 14:28:20 +01:00
bchanot 085c56877c fix(editor): deletion undo and Back, Plus focus to the panel 2026-11-14 14:24:06 +01:00
bchanot 270444e2ec fix(editor): Task 6 round 1, draft store tests, dead rescue 2026-11-14 14:15:11 +01:00
bchanot f0e49fd447 feat(editor): cite references from the finding edit form only 2026-11-14 14:11:13 +01:00
bchanot 3a7ffa2f8b fix(editor): Plus Escape focus return, sheet width rounding 2026-11-13 23:58:59 +01:00
bchanot 021685f6b3 fix(editor): category creation dialog title key 2026-11-13 23:45:59 +01:00
bchanot d6e501ef04 fix(editor): final review round, prettier on shell chrome files 2026-11-13 23:42:32 +01:00
bchanot 6bf9290da7 fix(editor): final review round, history, dialogs, Plus and limits
I1 scroll restored at once on a Back into layers; I2 Aller a opens the target dialog in one push; M1-M9, criteria 8 and 17 (left-draft notice), entry caps, no exhaustive-deps disables, locals within 5.
2026-11-13 23:42:32 +01:00
bchanot dfc8965844 fix(editor): Task 4 round 1, swallow release, menu tests 2026-11-13 22:36:23 +01:00
bchanot ca5804a8b7 feat(editor): Plus dropdown overlay with back request, sticky sidebar 2026-11-13 22:32:51 +01:00
bchanot 8a60128311 fix(editor): Task 3 round 2, usePin split, comment wrap 2026-11-13 20:40:52 +01:00
bchanot 3bb3603115 fix(editor): Task 3 round 1, literal journey, pin, limits, notice 2026-11-13 20:38:04 +01:00
bchanot 8b42816270 test(editor): reference dialog, filter and the owner journey, specs follow the dialog 2026-11-13 20:27:01 +01:00
bchanot 7a64daf251 feat(i18n): reference dialog and filter labels, label rows 2026-11-13 20:27:00 +01:00
bchanot 8031e0078f feat(editor): reference dialog, reading tiles and finding filter in the history
R2F-5 and R2F-6: the reference dialog is a view layer above the References tab or the citations sheet (local draft, one command per changed save, creation entry becomes the reference's own). Tiles only read. « Tout afficher » filters the library by the finding, « Revenir au constat » pops or pushes. Inline tile edit, draft tile and their guards removed.
2026-11-13 20:27:00 +01:00
bchanot e2d020bd3d test(editor): fix typecheck of the history entry and dialog helpers 2026-11-13 19:54:06 +01:00
bchanot af300de04c fix(editor): Task 2 round 3, lint, locals, stale comment 2026-11-13 19:51:03 +01:00
bchanot 20905adf72 refactor(editor): Task 2 round 2, locals and line limits 2026-11-13 19:45:50 +01:00
bchanot b703333b20 fix(editor): Task 2 review round 1, trace calls, form hooks, keyboard proof 2026-11-13 19:39:29 +01:00
bchanot c893dec60b feat(editor): « Aller à » opens the finding dialog, spec races fixed
« Aller à » a finding shows its row and opens its dialog in view mode.
E2e helpers wait for the history to settle after a layer or section
pop; the layout walk waits out the write budget. Label rows for the
nine new keys.
2026-11-13 19:23:48 +01:00
bchanot 4731a3376a feat(editor): sheet landings, history and e2e for the finding layers
« Tout afficher » clears the search and keeps the sort. A landing waits
for the dialogs a move closed and for their focus restore. Helpers and
shell specs move to the dialog and sheet flow; new finding dialog spec
(entries, guards, flip, gone rule, Back and Forward over the layers).
2026-11-13 19:03:21 +01:00
bchanot 18085cecf8 feat(editor): finding dialog and citations side sheet in the history
Constats opens each element in one modal dialog (view, edit with a
local draft, creation) driven by the editor view layer of the browser
history. The citations panel becomes a modal side sheet stacked over
it; its geometry, exit machinery and page inertness are removed.
Back and Forward restore the layers, a dirty form asks first.
2026-11-13 18:51:35 +01:00
bchanot 8e4f02620a fix(editor): Task 1 review round 1, section back pops, scroll proof 2026-11-13 18:12:19 +01:00
bchanot 792394d3b2 feat(editor): browser history for tabs, sections and Aller a
EditorView held by the navigation reducer (restore_view), a history
adapter hook mounted in EditorWorkspace (push, replace, back, mount
rule, ownership, write budget, scroll map, refused POP), a guard stack
by layer, an announcer queue joined after open dialogs.
2026-11-13 17:57:52 +01:00
bchanot 69e225ca7a style(tests): format c4-measure annotation (residual 9c) 2026-11-13 17:57:47 +01:00
bchanot 553a0e57b2 feat(ui): harden modal dialogs, add afterModalsClosed
Re-show a natively closed dialog only when its consumer answered
'kept'; returnFocus; ignore a held Escape; Dialog honours reduced
motion; useBeforeUnload extracted; focusRow reports found only when
the row holds focus.
2026-11-13 17:57:47 +01:00
bchanot cb1ad47cb0 fix(editor): announce a draft dropped with its tile
An undo or redo that removes a reference unmounted its tile with the edit view, so the
tile's announce effect never ran. The drop now speaks from onDrop itself; the citations
panel, unmounting after a forced close that already named the fields, stays quiet.
2026-11-13 15:25:22 +01:00
bchanot 346a8fd8f1 test(tests): typed draft before Escape in the add e2e, prettier on C4 spec 2026-11-13 14:49:18 +01:00
bchanot 94f8a8bf27 fix(editor): focus the first refused field with its own error
A user leave with several refused fields focused the first one while
the last refusal owned the single error slot. The leave now focuses
the first refused field, then re-applies it so its message shows (I1).
The add flow no longer re-pins the tile finish() just ended (M3).
2026-11-13 14:49:17 +01:00
bchanot 78fb2d076e test(tests): C4 round 4, deterministic touch proof 2026-11-13 14:42:29 +01:00
bchanot f7f0aa675d test(tests): C4 review round 3, helper locals 2026-11-13 14:18:36 +01:00
bchanot 776692922e test(tests): C4 review round 2, calibration guard 2026-11-13 14:16:30 +01:00
bchanot 817f74ba18 test(tests): C4 review round 1, worst-case touch distance 2026-11-13 14:13:03 +01:00
bchanot 969a5f360f test(tests): prove the citations trigger is reachable by touch at 667 x 375 2026-11-13 14:05:07 +01:00
bchanot b1fd8962ff fix(editor): say when a pinned tile is outside the search
A shown tile the search misses carries « Ne correspond pas à la
recherche » under its header (aria-describedby). The no-result notice
now needs no shown tile at all. Flip test watchers are stopped in
afterEach, so a failing assertion never leaves the setters patched.
2026-11-13 13:49:46 +01:00
bchanot c8109af719 fix(editor): C2 review round 1, i18n format, flip test observer
Restore i18n files from base and add only add_cancel. The flip test counted
announcements with a happy-dom MutationObserver whose callback sits in a
WeakRef (lost on GC); count the DOM setters instead.
2026-11-13 13:09:09 +01:00
bchanot d1779928a9 feat(editor): cancel adding a reference by button or Escape
Draft tile gets « Annuler l'ajout »; Escape cancels from non-text targets and
from a pristine text field, never while composing or already handled. Nothing
reaches the document, history untouched, focus back on the add button.
2026-11-13 12:39:57 +01:00
bchanot 1e19479853 fix(editor): C1 review round 1, note endings tested, tile hook, pin guard
Tests: note ends on another tile's Modifier, on Ajouter une reference, and is
replaced (announced again) by a newer drop; long titles shortened.
Read-only toggle deletes the key from openKeys explicitly. Drop slot and tile
wrappers moved to useTileActions. pinEdited pins nothing for an absent key.
2026-11-13 11:25:50 +01:00
bchanot 3303530717 fix(editor): never drop a refused draft silently on a read-only flip
Drop slot is tile-local state; the edit view cleanup reports every pending
field (FIELDS order) only when some are pending. The tile shows a warning
note and says it once in the live region; it ends on toggle, Terminer or a
newer drop. LeaveGuard returns all refused fields (forced panel close names
them all). Pin follows editingKey through read-only; reset re-pins it.
Read-only toggle ends edit and collapses. Flip focus goes to the tile header.

R-24 mapping:
- view test "keeps its index ... read-only (M3)": renamed, same assertion
- view test "is suspended in read-only ...": rewritten as "stays pinned in
  read-only" (pin kept, tile still shown after a search); toggle test added
- reset test extended: tile in edit stays pinned through the reset
- new editor-references-flip.test.tsx covers (a)-(g); (h) is a stated limit
2026-11-13 11:11:51 +01:00
bchanot 1bf27014b3 fix(editor): one history entry per reference edit, focus kept
Final review fixes. « Terminer » and every panel close re-committed the
edited field against a stale value, adding a second identical history
entry so the first « Défaire » seemed to do nothing: the tile now reads
the latest applied value (tests assert the undo-length delta). A tile
leaving the search on « Terminer » stays pinned until the next view
change and keeps focus; « Ajouter la référence » resets search and sort
and focuses the new tile. Also: refused draft dropped on a read-only
flip is announced; arrow keys respect a refused tab switch; pinned
index kept across read-only; the panel announces « Références citées »;
search text inserted literally; « Aller à » names its citer; the edit
header's name starts with « Terminer. »; undo removing the focused panel
tile moves focus per P20; no-result announced once; docs corrected.

Gates: typecheck, lint, test:run (app 1510), build, e2e:ui 251;
e2e:shell 16 specs (admin and editor-equine excluded): 117 passed / 108
skipped / 1 failed (crossing:211 stuck on the MFA step-up screen before
the editor), rerun alone 11 passed; full-row guard: no pre-existing row
changed in any table.
2026-11-13 01:08:00 +01:00
bchanot 4b7d2542fd test(tests): R2 non-regression sweep fixes
openTab waits for the shown place on every tab again (the former
goToTab waited for the annotations place). editor-equine.spec opens the
citations panel again on a finding of the equine copy, « Suture
sagittale (entre les deux pariétaux) » (unique, cited, reached in five
expansions: openCitations takes an optional expansion budget, default
4); updated for typecheck only, never run (owner rule).

Sweep: e2e:shell all 21 specs except editor-equine on db:sandbox: 219
passed / 116 skipped / 3 failed, the three in admin.spec, « Target
crashed » during axe on admin screens that render every accumulated
grant (not R2); new specs run twice (sweep + 33 passed after these
fixes); full-row guard: no pre-existing row changed in any table.
R-24 audit of 49867ba..HEAD: 58 mapped, 17 justified, 0 lost.
Gates: typecheck, lint, test:run (app 1488), build, e2e:ui 251.
2026-11-12 22:42:20 +01:00