refactor(editor): rename the reference panel's place to citations

Frees the name « references » for the fifth tab (R2.1). The panel's
data-place, PlaceName and ids become citations; no visible change.
EditorTarget, move kind, i18n keys and domain fields keep their names
(removed in R2.1).

R-24 (no assertion removed or weakened): unit editor-route, no-loss,
references-panel, route-recovery ids editor-references-* -> editor-citations-*;
keep-alive inPlace/place('references') -> 'citations'; focus-request
ownedBy 'references' -> 'citations'. e2e support openReferences /
closeReferences, crossing 204/271, journeys 247, layout 234/305,
deselect 229, shell 135 -> place 'citations'; crossing 205 searchbox and
structures 95 « citée 0 fois » -> libraryRoot(page) (new helper).

Gates: typecheck, lint, test:run (app 1382), build, e2e:ui 251 passed,
e2e:shell 7 specs 63 passed / 63 skipped on db:sandbox (editor-equine
not listed); full-row guard: no pre-existing row changed in any table.
This commit is contained in:
bchanot committed 2026-11-12 20:01:47 +01:00
1 parent 65a8fd37b8
commit fc3fec7654
18 files changed
+46 -40

No files matched your search

@@ -89,13 +89,13 @@ function Places({ nav, readOnly, reloadSheet }: PlacesProps) {
<div className={`relative ${open ? 'min-h-[calc(100dvh-3.5rem)]' : ''}`}>
{state.referencesMounted && (
<KeptPlace
name="references"
name="citations"
visible={open}
className="absolute bottom-0 right-0 top-0 z-20 w-[min(27rem,100%)]"
>
<ReferencesPanel
readOnly={readOnly}
focus={ownedBy(state.focus, 'references')}
focus={ownedBy(state.focus, 'citations')}
onClose={nav.closeReferences}
citedBy={state.references.citedBy}
onShowAll={nav.showAllReferences}
@@ -41,7 +41,7 @@ export default function HeaderActions(props: Props) {
type="button"
variant="secondary"
aria-expanded={props.referencesOpen}
aria-controls="editor-references-panel"
aria-controls="editor-citations-panel"
onClick={(event) => props.onToggleReferences(event.currentTarget)}
>
<Icon name="book" size={16} className="mr-2" />
@@ -69,7 +69,7 @@ function PanelHeader({ onClose }: { onClose: () => void }) {
return (
<div className="flex items-center justify-between gap-2">
<h2
id="editor-references-title"
id="editor-citations-title"
tabIndex={-1}
data-place-heading
className="flex items-center gap-2 outline-none font-serif text-xl"
@@ -237,9 +237,9 @@ export default function ReferencesPanel(props: Props) {
}
return (
<section
id="editor-references-panel"
data-testid="editor-references-panel"
aria-labelledby="editor-references-title"
id="editor-citations-panel"
data-testid="editor-citations-panel"
aria-labelledby="editor-citations-title"
onKeyDown={onKeyDown}
className="sticky top-14 h-[calc(100dvh-3.5rem)] space-y-3 overflow-y-auto border-l border-[var(--color-border)] bg-[var(--color-surface)] p-4 shadow-xl"
>
+2 -2
View File
@@ -19,10 +19,10 @@ export type FocusOutcome = 'found' | 'kept' | 'none'
export type PlaceName =
| EditorTabId
| `annotations.${AnnotationSection}`
| 'references'
| 'citations'
export function placeOf(target: EditorTarget): PlaceName {
if (target.place === 'references') return 'references'
if (target.place === 'references') return 'citations'
if (target.tab !== 'annotations') return target.tab
return `annotations.${target.section ?? 'drawing'}`
}
+1 -1
View File
@@ -198,7 +198,7 @@ function referencesBack(opener: HTMLElement | null): HTMLElement | null {
/** Where the focus lands after a programmatic move; never `body`. */
function landingOf(move: Move, state: NavigationState): HTMLElement | null {
if (move.kind === 'references') return headingOf('references')
if (move.kind === 'references') return headingOf('citations')
const place = state.focus ? placeOf(state.focus.target) : shownPlace(state)
return headingOf(place) ?? tabButton(state.tab)
}