diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 06f5d67a..3db9b654 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -738,9 +738,10 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] Task 1 card failure line (board 30): f061111 Notice warning tone, `icon`, `live` + `wifi-off`; 6ad8d83 `cardFailure`, `useCardDetails` `{ state, retry }`, `CardFailure`, A10 key; `Card` `aria-busy` (outside file list, accepted). App 1771 tests in 138 files; typecheck, lint, build exit 0. Review approved (0 C, 0 I) - [x] Task 2 browser proof dadd8e5: `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky (twice: once with temporary screenshot lines, once as committed); `catalogue.spec.ts` alone 8 passed. Guard: 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants); 8 R4 sheets archived, 4 grants revoked by id, read back. Review approved (0 C, 0 I) - [x] Task 3 documents as built: U1_CORRECTIONS §R4 « As built 2026-11-17 » and §5 row C closed, OWNER_TRIAL §4.16 (db:sandbox trial), review Part II class C row (R-8), CHANGELOG, BROWSER_TESTS, design README deviation. Read-only sandbox census: 164 catalogue entries, 160 ok and main view composed, 4 `fingerprint_mismatch` = the four « Cheval sandbox » (anomaly A, stored `'a'.repeat(64)`), no other kind. No `shortcut:` in the R4 diff (`git diff b895ecf..HEAD`) - - [ ] Closing gates (controller): design review vs board 30, final code review, security review, fresh verifier on the contract, `pnpm check:all` (not yet run) + - [x] Closing gates (controller): design review vs board 30 (CONFORME but one écart, fixed in the wave), final code review (0 C, 1 I, fixed), security PASS (1 LOW fixed), re-review of the wave (16/16 addressed), verifier ECARTS(5) → two tests added `83f2d8b`, contract oracle 9 and scope rulings `2c9d837`, gates.sh MET; `pnpm check:all` at `2c9d837` exit 0 (core-wasm 66, supabase 182, app 1780, e2e:ui 253; e2e:shell not run by check:all). Second verifier pass: see below + - [ ] STOP owner trial R4 on `pnpm db:sandbox trial` (OWNER_TRIAL §4.16), no merge - [ ] Owner trial §4.16 on `pnpm db:sandbox trial` - - [x] Final fix wave (FX1-FX16, `.superpowers/sdd/2026-11-16-r4-card-integrity-2337/final-fix-list.md`): b378cf0 retry ending with no retry left keeps the polite region and moves focus to « Consulter », busy look on « Réessayer », engine stopped for good in the error tone, one attempt for two calls in one tick, rendered tests (engine stopped, two cards on the core, no blob URL after unmount); 2930f49 lines over 100 columns wrapped; 1e50585 board 30 deviation fixed (failure row `*:px-3`, both buttons on one row at 1280 and 375, e2e checks it); 3bea19f spec reads each own sheet's name by id before archiving, `seedGrant` account id through `capturedId`. App 1775 tests in 138 files; typecheck, lint, build exit 0. `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky (twice: once with temporary screenshot lines, once as committed); `catalogue.spec.ts` alone 8 passed. Guard: 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants), the runs' own; 8 R4 sheets archived, 4 grants revoked, read back. `pnpm check:all` not yet run + - [x] Final fix wave (FX1-FX16, `.superpowers/sdd/2026-11-16-r4-card-integrity-2337/final-fix-list.md`): b378cf0 retry ending with no retry left keeps the polite region and moves focus to « Consulter », busy look on « Réessayer », engine stopped for good in the error tone, one attempt for two calls in one tick, rendered tests (engine stopped, two cards on the core, no blob URL after unmount); 2930f49 lines over 100 columns wrapped; 1e50585 board 30 deviation fixed (failure row `*:px-3`, both buttons on one row at 1280 and 375, e2e checks it); 3bea19f spec reads each own sheet's name by id before archiving, `seedGrant` account id through `capturedId`. App 1775 tests in 138 files; typecheck, lint, build exit 0. `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky (twice: once with temporary screenshot lines, once as committed); `catalogue.spec.ts` alone 8 passed. Guard: 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants), the runs' own; 8 R4 sheets archived, 4 grants revoked, read back. `pnpm check:all` then run at `2c9d837` (line above) - [ ] Follow-up: seed owner row in `private.catalog_write_budgets` is R4's own (none before R4; its first run created it, later runs update that same row, 4 archives per run; 8 of 300 per hour after the final wave, outside the data guard); `catalogue.spec.ts` still leaves its published sheets listed, warm-up its sheet and `sheet_editor` grant per invocation (BLK-015, RR-13) - [ ] owner arbitrations A1-A15 (`V1-2-6_U1_CORRECTIONS.md` §6, `TRIAL_STACK.md` §6) - [ ] Test anomaly A (owner 2026-11-09, separate from U1/U2): fictitious fingerprints `'a'.repeat(64)` from worker stand-ins (`packages/supabase/tests/sandbox/sheet-fixtures.ts:115` openRound, `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`); 7 published/deprecated sandbox versions fail `check_published`. Fix: real fingerprint through the core (as e2e `fingerprintOf`, `apps/app/e2e/support/catalogue.ts:88`); never weaken the publish gate or the reader check. Needs its own go. Census 2026-11-17 (R4 Task 3, read-only): 4 of 164 catalogue entries fail, the four current « Cheval sandbox » versions (2 at v1, 2 at v2), all `fingerprint_mismatch`; R4 cards show them with the integrity line. diff --git a/CHANGELOG.md b/CHANGELOG.md index 0d4bbf3f..7074bcc5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,7 @@ RR-9). ### Changed (2026-11-17, V1-2.6 R4 on `feature/v1-2-anatomical-sheets`: not merged into `develop`, sandbox only) - A catalogue card whose version fails no longer stays silent. A version the core's integrity check refuses (fingerprint, drawing hash, missing drawing, unreadable document) shows « Contrôle d'intégrité échoué : cette version ne peut pas être affichée. » in the card (EN « Integrity check failed: this version cannot be displayed. »), with no « Réessayer »; a version over the size limits shows « Cette version dépasse les limites de taille d'une fiche. », also without retry. A load that failed for another reason (network, session, access, rate, server, engine) shows its own line and « Réessayer » for that card only, with a « no network » glyph for the network. A version that passes but whose main view cannot be drawn keeps its counts and says so in a neutral line. The card keeps its name, « Publiée », its version and « Consulter » in every case. The check itself, the sheet page and its notice are unchanged. The lines are not live regions; a retry that fails again is said once by a polite region (also when it ends on a failure with no retry, which moves the focus to « Consulter »), and a successful one moves the focus to « Consulter ». During an attempt « Réessayer » is greyed with a wait cursor; once the engine stopped for good the card's engine line has no retry and the error tone. « Réessayer » and « Consulter » sit side by side as on the board, desktop included. Board 30, wording A10. -- New browser spec `e2e/shell/catalogue-integrity.spec.ts` on the sandbox: at `dadd8e5`, 6 passed, 0 failed, 0 skipped, 0 flaky, twice (once with temporary screenshot lines, once as committed); after the final fix wave, the same twice again (once with temporary screenshot lines, once as committed at `3bea19f`), and `catalogue.spec.ts` alone 8 passed. It archives its own sheets, each only after its name read by id matches the name it seeded, and revokes its own grant by id at the end. App unit suite 1775 passed (138 files); `pnpm typecheck`, `pnpm lint`, `pnpm build` exit 0. `pnpm check:all` not yet run at this entry. The four « Cheval sandbox » entries of the sandbox now show the integrity line: their stored fingerprint is the fictitious value of test anomaly A, still open. Details: `docs/development/V1-2-6_U1_CORRECTIONS.md` §R4. +- New browser spec `e2e/shell/catalogue-integrity.spec.ts` on the sandbox: at `dadd8e5`, 6 passed, 0 failed, 0 skipped, 0 flaky, twice (once with temporary screenshot lines, once as committed); after the final fix wave, the same twice again (once with temporary screenshot lines, once as committed at `3bea19f`), and `catalogue.spec.ts` alone 8 passed. It archives its own sheets, each only after its name read by id matches the name it seeded, and revokes its own grant by id at the end. App unit suite 1780 passed (138 files); `pnpm typecheck`, `pnpm lint`, `pnpm build` exit 0. `pnpm check:all` at `2c9d837`: exit 0 (e2e:ui 253 passed; e2e:shell not run by check:all). The four « Cheval sandbox » entries of the sandbox now show the integrity line: their stored fingerprint is the fictitious value of test anomaly A, still open. Details: `docs/development/V1-2-6_U1_CORRECTIONS.md` §R4. ### Added (2026-11-16, V1-2.6 R3 on `feature/v1-2-anatomical-sheets`: not merged into `develop`, sandbox and trial stack only) diff --git a/docs/development/V1-2-6_OWNER_TRIAL.md b/docs/development/V1-2-6_OWNER_TRIAL.md index 0afbd56b..c3b33131 100644 --- a/docs/development/V1-2-6_OWNER_TRIAL.md +++ b/docs/development/V1-2-6_OWNER_TRIAL.md @@ -614,7 +614,8 @@ pnpm db:sandbox trial-grant vous@example.com catalog_reader Lancez l'application comme à l'étape 3 (`pnpm db:sandbox trial`, adresse en `:5193`) et connectez-vous. La double authentification n'est pas nécessaire pour le catalogue. Ouvrez « Fiches anatomiques » dans le menu. La page est -lente à se remplir : la sandbox compte 164 fiches au catalogue et chaque carte charge sa version et son illustration +lente à se remplir : la sandbox comptait 164 fiches au catalogue lors du relevé (172 le 17 novembre au soir, les +tests du catalogue en ajoutent à chaque passage) et chaque carte charge sa version et son illustration au moment où elle s'affiche. Ce qui vient des données, pas de R4. Un relevé en lecture seule du 17 novembre 2026 a passé les 164 fiches du diff --git a/docs/development/V1-2-6_U1_CORRECTIONS.md b/docs/development/V1-2-6_U1_CORRECTIONS.md index 74b22193..785a26f7 100644 --- a/docs/development/V1-2-6_U1_CORRECTIONS.md +++ b/docs/development/V1-2-6_U1_CORRECTIONS.md @@ -868,7 +868,8 @@ Results (exact; nothing that failed is called green): | Final fix wave: `catalogue.spec.ts` alone (`seedGrant` changed) | 8 passed, 0 failed, 0 skipped, 0 flaky | | Final fix wave: data guard (read-only, before and after its three runs) | 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants), all the runs' own: 8 « R4 … » sheets read back archived (name checked before each archive), 4 own grants revoked (`e2e cleanup`), the rest from `catalogue.spec.ts` and the warm-up as before | | Catalogue census of the sandbox (read-only, 2026-11-17, below) | 164 entries: 160 pass and compose their main view, 4 `fingerprint_mismatch` (anomaly A) | -| `pnpm check:all` | not yet run | +| Verifier gap: two tests added (`83f2d8b`: the glyph each line draws; focus after a retry settling on `body` or elsewhere) | app unit suite 1780 tests in 138 files passed; typecheck, lint exit 0 | +| `pnpm check:all` at `2c9d837` (2026-11-17) | exit 0, « all checks passed »: core-wasm 66, supabase 182, app 1780, e2e:ui 253 passed, app image, worker test and runtime image; e2e:shell not run by check:all (the spec runs above are the browser proof) | Sandbox catalogue census (P1, read-only): every catalogue entry (active official sheet whose current version is published) read by SQL under `default_transaction_read_only`, its drawings fetched from Storage by GET, then the