chore(memory): R2 closure — L1 refusal (BDR-051), LRN-055, EVAL-021, journal, TODO, L1 verify contract
This commit is contained in:
1 parent
8d7a56fbf8
commit
f768e94c5a
6 files changed
+87
-2
No files matched your search
@@ -400,3 +400,9 @@ Status: active; `chore/dev-lan-access` awaiting the owner's LAN validation; R2 n
|
||||
Built on review rev 2 + Annex C; plan `.claude/tasks/plans/2026-10-13-rust-r2-domain-core.md` rev 2 (3 challengers, 45 findings, 1 BLOCKER folded). Choices: (1) JSON read text → `serde_json::Value` (JSON.parse dup-key semantics) → typed; lone surrogate escape → U+FFFD pre-pass (L1, owner to confirm); (2) Zod reproduced by field helpers: `js::present` (optional: absent ok, null refused, skipped), `js::nullable` (required key), `JsInt` (any integer-valued number, JS print), hand-written patterns (no regex crate), `url` crate for `.url()`; unions = untagged enums + literal tag fields at Zod position → byte-equal with `JSON.stringify(Zod.parse(x),null,2)`; PDF label fields in engine dict order → frozen envelopes round-trip byte-equal; (3) quirks ported site by site (Map last-wins, find first-wins, JS truthiness, `??=`, malformed map entry still fails the read); (4) `SheetIndexData` minimal (positions, names, spineIds, nodeKeys as JSON `[zone,...path]`), TS `SheetIndex` = accessors only + `ops`; (5) one core call per user action; form-value observation edits (comment, severity, free text, finding removal) stay Zustand assignments (no per-keystroke wasm, D-R7); store actions answer `{ok}`, callers stop on failure; `hydrateReport` deleted; (6) runtime: sync calls, trap → poison → offline recovery from kept compiled module + pre-imported spare glue record, cap 3, per-generation sheet handles, retry clears all caches; `pkg/` shipped vs `pkg-proofs/`; BUILD_STAMP refuses stale module in tests; (7) quarantine only on content kinds, newest-only keys, source removed after successful copy, pre-rebase raw kept when unresolved > 0; editor never redirects in degraded states; (8) Home and /new read availability from the bundle, core loads at submit / import / editor; (9) import = TS byte scan (until R4) → core `archive.import` (read + rebase one call); export = core `archive.snapshot` → frozen TS engine; (10) publish gate takes the core validator (DI), fails closed; (11) report:compare CLI keeps the frozen domain (R4); practitioner prefill keeps a small Zod schema (D-R7, core not loaded on /new mount); (12) app image wasm stage + gzip_static; DEPLOY: CSP keyword before an R2 image, never built on VPS.
|
||||
Alt rejected: mutation corpus with full outputs (simplicity challenge: drift-free verdict table + characterisation instead); `report.replace_observation` per keystroke; serde internally tagged enums (tag first breaks byte equality); Web Worker for every call (async races in the click chain); unify duplicate-id policies (behaviour change).
|
||||
Status: active; R2 delivered on feature/rust-r2-domain-core, awaiting owner validation, no merge.
|
||||
|
||||
## BDR-051 | 2026-10-14 | L1 resolved: lone UTF-16 surrogate refused whole, never replaced (supersedes BDR-050 choice 1 on this point)
|
||||
|
||||
Owner refused U+FFFD replacement of lone surrogate escapes (silent alteration of historical user data). Chosen (owner, 2026-10-14): refusal + quarantine. `js::parse_json` no pre-pass; serde_json refuses escape like any error; failure classified by strict escape scan (on failure only) → `JsonReadError::LoneSurrogate` → closed kind `lone_surrogate` (parse_input, sheet.check, draft.restore, archive.import). App: draft → `osteo:quarantine:draft` verbatim + existing `editor.draft_quarantined`; session archive → `osteo:quarantine:archive`; import → `ImportError('lone_surrogate')` + new `home.import.error_lone_surrogate` (owner-chosen detailed wording FR/EN, file untouched); editor action → refused, report unchanged, `core.action_failed`; publish gate → `invalid_shape`. Oracles untouched: L1 cases now assert TS kept surrogate + Rust refuses; test loader spells lone escapes out as literal text (never U+FFFD).
|
||||
Alt rejected: faithful preservation (own JSON reader + lossless WTF-16 string type over ~150 contract fields + serialiser, oracles re-frozen; multi-day, for corrupted/pasted-UTF-16 data only; door stays open since nothing is lost); in-band tunnel (placeholder code points mapped back at facade output; collisions with sheet strings, UTF-16 length drift, every output path must be post-processed: hacky).
|
||||
Status: active; merged with R2.
|
||||
@@ -157,3 +157,10 @@ Method: plan + contract written first (`.claude/tasks/plans/2026-10-13-rust-r2-d
|
||||
Result: challengers 45 findings incl. 1 BLOCKER (degraded editor redirect could overwrite an unread draft) → plan rev 2 before any app code; contracts byte-equal to Zod on first run; forks merged with zero conflicts (one stub replaced); fork D found 2 real src bugs (Node source path under happy-dom, failed quarantine reported as success) → fixed with tests. Verifier: 12/12 MET, ECARTS(2) = floor DELETED_TEST (zoneInteraction suite ported to cargo; R0 skip helper replaced by a stricter global setup) → human micro-gate for the owner. Security: PASS (3 MEDIUM nginx false positives pre-existing, 5 LOW) → by-reference deserialisation (also −134 KB raw / −31 KB gzip module) + literal delete paths. Final: cargo core 135, worker+wasm 32, Node 906 (app 313), pgTAP PGlite 12 files / real stack 446, CSP proof 15/15, check:all green ×3, module 1,046,498 B raw / 340,929 B gzip.
|
||||
Anomalies: worktree base stale (BLK-010); harness decodes `\u` escapes in tool inputs (LRN-054); my first runtime test helper reused the pattern Vite rewrites; the CSP proof first failed on its own harness (EN locale, disclaimer modal, caught compile error logs nothing) — proof scripts need the same dry-run discipline as oracles; a security LOW fix improved size, measure before assuming a cost.
|
||||
Action: owner manual LAN validation, L1 decision, approve the 2 deleted test files (floor), then merge go; R3 next, not started.
|
||||
|
||||
## EVAL-021 | 2026-10-14 | R2 closure — L1 refusal, deletions proof, fresh verifier + security
|
||||
|
||||
Method: owner asked to fix L1 (no silent U+FFFD) + prove the 2 approved deletions + checks before merge. Mapped every JSON entry into the core (TS side always `JSON.stringify` → escapes reach Rust as ASCII); preservation costed (own JSON reader + lossless string type ~150 fields) → AskUserQuestion: refusal + quarantine chosen, detailed import wording chosen. Stale-module proof run before `wasm:build` (suites throw `pkg is stale`). Worktrees checked blob by blob vs branch history (60/66 identical, 6 = stub, merged mod lists, 2 lifted `#[ignore]`). Contract `2026-10-14-rust-r2-l1-verify.md` (13 criteria, each dry-run) → fresh verifier; fresh security-auditor on 36316cf..HEAD.
|
||||
Result: verifier CONFORME 13/13 (floor 2 = the approved deletions, authorised by REQUEST); security PASS, 6 LOW: wasm-bindgen `&str` would re-encode a raw lone surrogate (unreachable, JSON.stringify callers; documented invariant), `pretty_json` proof op refuses as invalid_json, scanner not string-aware (classification only), newest-only quarantine slot, archive quarantine failure under full storage lets a later reset remove it (pre-existing R2, reported to owner), semgrep partial parse. Final: core 142, Node 915 (app 320, supabase 40, core-wasm 26), PGlite pgTAP 12 files, real stack 446/446, types no drift, check:all green 1 min 32 s, module 1,040,784 B raw / 339,933 B gzip.
|
||||
Anomalies: refusal broke a test loader (oracle file freezes TS outputs with lone escapes) → loader spells escapes out, never normalises (LRN-055); `cargo deny advisories` (warn-only) shows RUSTSEC-2026-0346/0347/0348 on rustls 0.23.45 (worker, none applicable: no brotli, built-in session cache, no ECH) → bump follow-up; `supabase/.temp/cli-latest` tracked by mistake, rewritten by the CLI, restored; `export PATH=…` denied → absolute `~/.cargo/bin/cargo`; first commit with chained `git config` denied → plain commit OK.
|
||||
Action: gitflow finish into develop (owner authorised after L1 + checks), worktree cleanup (BLK-010), R3 summary only.
|
||||
@@ -251,3 +251,7 @@ Owner: R1 10/10 validated, identity final (Faunosteo, faunosteo.com), env DEV/ST
|
||||
## 2026-10-14 (Rust R2 delivered)
|
||||
|
||||
Owner: LAN validated, R2 go (brief 2026-10-13), 4 new strings validated (recommended wording). feature/rust-r2-domain-core off develop 1a7ee7d. Plan + 3 challengers (45 findings, 1 blocker) → rev 2. Freeze first (envelopes, N-1 copy, Zod oracles, characterisation 84 + verdicts 765 + editor 49 + conformance 26), contracts byte-equal, rules by 3 worktree forks, runtime (lazy, poison, offline recovery, BUILD_STAMP), app switched (sheet, store, click chain, pickers, import, export snapshot, publish gate fail-closed), quarantine, degraded states, Docker wasm stage + gzip_static, CSP proof on the image 15/15. Verifier 12/12 + floor 2 (deleted tests, owner micro-gate); security PASS → by-ref deserialisation (module 341 KB gzip). check:all green. BDR-050, LRN-054, BLK-010, EVAL-020. Stop: owner validation, no merge, R3 not started, release 0.2.0 untouched.
|
||||
|
||||
## 2026-10-14 (R2 closure)
|
||||
|
||||
Owner: manual 10/10 validated, R2 accepted (architecture, migrations, contracts, perf); L1 refused (silent U+FFFD). Costed preservation (own JSON reader + lossless string type) → owner chose refusal + quarantine, detailed import wording. Fixed: core refuses lone surrogate as `lone_surrogate` (draft/archive quarantined verbatim, import refused with message, action refused, gate invalid_shape). Deletions proven covered (12+1 Rust tests + 49 oracle cases; stale module fails suites). Worktrees verified recoverable-free. Gates: verifier CONFORME 13/13, security PASS 6 LOW; check:all green. BDR-051, LRN-055, EVAL-021. Next: finish into develop, worktree cleanup, R3 summary (not started).
|
||||
@@ -421,3 +421,8 @@ Apply: any exposure work on this machine; staging compose (bind explicitly there
|
||||
- `isolation: worktree` forks started at an old commit (605ee7c, not HEAD): each fork had to move its temp branch; brief forks to check `git log -1` first. `git worktree remove` / `git branch -d` on those temp branches refused by the auto-mode classifier → leftover worktrees (3.2 GB) for the owner to remove.
|
||||
- Forks with full context + disjoint file ownership + "no commit, I collect the diff" merged with zero conflicts (one deliberate stub replaced).
|
||||
Apply: R3/R4/R5 ports (same oracle stack), any wasm loaded by Vite, any agent fan-out.
|
||||
|
||||
## LRN-055 | 2026-10-14 | Lossy normalisation pre-pass hides user-data alteration; classify parser refusal instead
|
||||
|
||||
Context: R2 rewrote lone surrogate escapes to U+FFFD before serde_json so JS-era texts still parsed (L1). Owner refused: silent change of historical data. Fix: drop pre-pass; serde_json already refuses; scan text only after failure to name kind (zero cost on valid input, exact refusal kind for UI message + quarantine). Trap found by fix: oracle file freezing TS outputs carried lone escapes → whole-file parse failed; test loader must spell escapes out as literal text (evidence kept), never re-normalise. Also: `u32::from_str_radix` accepts leading `+` → escape scanner checks hex digits explicitly.
|
||||
Apply: any reader of user data (R3 SVG, R4 PDF reader, R5 pipeline) → refuse with closed kind + keep original, never repair silently; a leniency step needs explicit owner decision and declared-difference test.
|
||||
Reference in new issue
Block a user