docs(docs): RUST.md §10.10 R4.8 record (deleted, replaced, kept with reasons, census, non-regression table, risks, R5 prerequisites); CLAUDE.md, README, WORKSPACE, packages/README, TEST_STRATEGY, PDF-FORMAT, DEPLOY rollback R4 note and module size, hardening §5 pdf-lib closed, fixtures README, CHANGELOG R4 entry; TODO R4.8 closed; memory BDR-064, journal
This commit is contained in:
1 parent
e88769a707
commit
f36dbdd4ae
13 files changed
+238
-62
No files matched your search
@@ -481,3 +481,9 @@ Status: active; owner checkpoint R4.6 pending.
|
||||
Context: owner decision 2026-10-19 on the R4.6 report (RUST.md §10.8). Chromium per-export RSS growth on L (≈ 20 MiB, same in TS control, plateau after 8) accepted provisionally: not a leak validation, kept as open reserve; reports must split wasm linear memory / browser global / canvas-blob-URL retention / transient vs persistent; thresholds never changed, no FAIL turned PASS. J1 + J2 on real devices mandatory before any merge; NON TESTÉ kept. R4.7 per plan, no scope widening; S2 export worker not engaged without proof + new decision.
|
||||
Decision (R4.7 design): `pdf::compare` pure module behind feature `cli` (= pdf-read + pdf-write, never in wasm), `Files` trait for fs; binary `src/bin/report_compare.rs` only std::fs file; seed sheet read at run time from `CARGO_MANIFEST_DIR/../../supabase/seed/.../draft` (no drawing); root `report:compare` → `scripts/report-compare.sh` (rust-env + cargo run --release --features cli). A.3 closed lines chosen: `report document invalid: <serde detail>` (ZodError dumps), `attachment refused: lone UTF-16 surrogate escape at byte N` (surrogates kept/overwritten), `report version null cannot be read` (overflow → null, incl. envelopeVersion overflow where TS printed a rejected-envelope header). Alternatives dropped: `include_str!` of the seed (bakes content, rebuild on seed change); spawning the binary per O10 row in tests (230 spawns, slow): in-process `run` + 8 spawns instead.
|
||||
Status: active; owner checkpoint R4.7 pending.
|
||||
|
||||
## BDR-064 | 2026-10-19 | R4.7 validated; R4.8 deletions: test read-back on own PDF reader, N-1 scanner exported, in-process import helper
|
||||
|
||||
Context: owner validated R4.7 (three A.3 lines accepted, 25 s first compile accepted, no prebuilt binary). R4.8 brief: delete packages/pdf, pdf-lib, TS CLI, redundant tests, generators; keep frozen oracles, goldens, reference PDFs, fixtures; `packages/anatomy` render until R5; audit consumers first; non-regression proofs; checks must fail on missing Rust component; no merge, no R5.
|
||||
Decision: vitest read-back of the app export without pdf-lib = `tests/helpers/pdfFile.ts`, a reader of the writer's own format (objects, inline dicts, Flate via node:zlib, Kids order, Info, annots, XObjects) + `buildPdfWithAttachment` for the rejection inputs; view goldens from the SVGs captured at the mocked rasteriser (request order = engine order; the bundled partner SVG logo comes first with real branding); `importReportFromPdf` for tests = module `SheetHandle.import_pdf` on a throwaway handle + worker's `pdfImportOf` (`tests/helpers/pdfImport.ts`; `GlueSheetHandle.free()` added to the interface); envelope + N-1 suites read attachments with the frozen O11 scanner, exported through `@faunosteo/core-wasm/n-1` (index re-export only, copies untouched); `pdf.export.app` deleted (re-export from envelope = cargo `export_from_envelope`, no sheet/branding in signature); `@faunosteo/domain` dropped from apps/app (two incidental test uses → core types / N-1 Zod); ledger script reads frozen cases from the committed TSV. Alternatives dropped: keep pdf-lib as test-only devDependency (review R4 row forbids it in apps/app lockfile); move all content-stream checks to cargo (loses app-path coverage of non-fixture reports); `importPdf` on main-thread SheetOps (breaks OD-1).
|
||||
Status: active; owner checkpoint R4.8 pending.
|
||||
@@ -294,3 +294,4 @@ Owner validated R4.0 plan with conditions (BDR-057, plan §A.6, LRN-059/060). R3
|
||||
- 2026-10-18 R4.5 done (d420f67..b44dd80): content emitter (60 streams byte-equal, numberToString 703 + V8 pow10 quirk), PNG gate + UPNG decoder (O6 108/108), own object writer (pdf-writer dropped: numberToString everywhere, no dep), serialiser, export + self-check, from_envelope; O2 14 runs equal (streams after B3, planes, links, Info, attachment), qpdf clean, poppler 0 px, O11 + N-1 + TS reader read R4 PDFs, wasm = native digests; Node TS→Rust demo 198→36 ms, L 772→57, CAP 5.7 s→0.22 s; writer linked 531.6 KB gzip (proofs build), shipped 426 KB. Gate PASS 4 LOW → hardenings. Open: one-shot path holds PNGs twice (R4.6 session must stream), L real rasters 5 s native (deflate 6), E3 judged at R4.6. STOP before R4.6.
|
||||
- 2026-10-19 owner validated R4.5; R4.6 go (BDR-062). R4.6 done (9e688b6..): ExportSession (decode on arrival, chunked never-realloc file 1→8 MiB, catalog last, parts → Blob, self-check on attachment chunk), views.rs (compose_highlight requests, raster_size_of O4 57/57), wasm ExportSession + CoreExportSession, app export.ts on session (abort on unmount, User Timing), labels.ts; app suites read content streams (pdfRead.ts), app-path bytes = R4 digests (re-frozen: object order B2, hex upper-case B4), Step 6 goldens via app path, 14 O2 runs through module = digests, request SVG = TS compose text, export Rust → import Rust / TS reader / N-1 ok. E3 Chromium demo 0.67, L 0.74 (Firefox 0.66/0.67, WebKit 0.91/0.95); E4 CAP completes 3 engines (TS stopped by ceiling); peaks lower (L Chromium 805→470 MiB). Linear memory L real 62 MiB flat over 7 exports; Chromium per-export RSS growth ≈ 20 MiB on L same as TS control, plateau after 8. Shipped 519.7 KB gzip (W1). rust-check 0, pnpm check 1,099 tests, ledger 11 pending (R4.7). J2 kit + procedure. STOP before R4.7.
|
||||
- 2026-10-19 owner accepted R4.6 provisionally (Chromium series = open reserve); R4.7 go (BDR-063). R4.7 done: `pdf::compare` (feature `cli`), `report-compare` bin, `scripts/report-compare.sh` behind root `report:compare`, cargo `pdf_compare` 15 tests: O10 230 rows (158 exact, 72 declared A.3 → 62 `report document invalid`, 7 surrogate refusals, 3 `version null`), 11 scenario cases = ledger targets (301 rows, 0 pending), binary spawned 8×. Release binary 7 ms/PDF, 6 MiB RSS; module unchanged 1,535,289 B / 519,795 gzip. RUST.md §10.9, CLAUDE.md, PDF-FORMAT. STOP before R4.8.
|
||||
- 2026-10-19 owner validated R4.7; R4.8 go (BDR-064). R4.8 done: packages/pdf (70 files, 12,010 lines TS), TS CLI, TS import path, generators, ts-engine comparison deleted; deps pdf-lib / @pdf-lib / resvg / @faunosteo/pdf / tsx / @faunosteo/domain (app) gone, xmldom only under anatomy; test read-back on own `pdfFile.ts` reader, view goldens from captured session SVGs, N-1 scanner exported via core-wasm/n-1, in-process import helper on module reader; `r4.census` suite (8); ledger 301 rows from frozen TSV, 0 pending; app 427 tests, core-wasm 58; docs RUST.md §10.10, CLAUDE.md, README, PDF-FORMAT, DEPLOY rollback R4, CHANGELOG R4 entry, hardening §5 pdf-lib closed. STOP before R4.9.
|
||||
@@ -255,7 +255,12 @@ feat/findings-tree-v2 merged (FindingsTreePicker tracked in HEAD); all work belo
|
||||
- [x] R4.7b `src/bin/report_compare.rs` (feature `cli`, the only std::fs file): seed sheet from `supabase/seed/anatomical-sheets/equine/draft` (ref, document, map; no asset), arguments relative to `INIT_CWD`, folders expanded, size pre-check, exit code; `scripts/report-compare.sh` (rust-env + cargo run --release --features cli) behind the root `report:compare`; rust-check feature lists widened to `cli`
|
||||
- [x] R4.7c cargo `tests/pdf_compare.rs`: the 230 O10 invocations in-process (158 undeclared rows exact: stdout, stderr, exit; 72 declared rows against the Rust wording per A.3 class), scenario PDF digests = `inputs`, the 11 scenario cases named for the ledger, one spawn of the real binary (usage, INIT_CWD, output = in-process); ledger rows 135–145 targets filled, `scripts/r4-ledger.mjs` regenerated
|
||||
- [x] R4.7d (done 2026-10-19; STOP before R4.8) docs: RUST.md §10.9 (binary, parity 158/72, A.3 lines as printed, timing), CLAUDE.md (command, map), fixtures README if touched, memory journal; rust-check + pnpm check green; report, STOP before R4.8
|
||||
- [ ] R4.8 deletions + docs + ledger census
|
||||
- [ ] R4.8 deletions + docs + ledger census (owner go 2026-10-19, R4.7 validated; stop before R4.9)
|
||||
- [x] R4.8a test read-back without pdf-lib and without the TS engine: `tests/helpers/pdfFile.ts` (reader of the writer's own files: objects, dicts, Flate streams via zlib, pages in order, Info, annots, XObject sizes), `pdfRead.ts` on it, `goldens.ts` (`readLinks` on it; `snapshotView` from the session's request SVGs captured at the rasteriser; `recordDrawing` dropped), `tests/helpers/pdfImport.ts` (`importReportFromPdf` = the module's `SheetHandle.import_pdf` + the worker's `pdfImportOf`; `importAttachment` = `sheet.ops.importArchive`), `@faunosteo/core-wasm/n-1` exports the frozen O11 scanner (`readAttachmentBytes`); suites rewritten: pdf.goldens (2×1 PNG decode read from the XObject), pdf.roundtrip (foreign PDFs = the r4/read fixtures), archive.envelopes + n-1.reader (N-1 scanner), migration.leaves, goldenReports, helpers/sheet (labels from `@/pdf/labels`), core-wasm pdf-export.session (request SVG vs the frozen R3 compose oracle)
|
||||
- [x] R4.8b deletions after the consumer audit (grep census per package): `packages/pdf/**` (engine, tests, R3/R4 oracle generators, helpers), `apps/app/src/pdf/import.ts`, `apps/app/scripts/compare-reports.ts` + `compare/*`, `tests/unit/{scripts.compare,pdf.import,pdf.export.app,r4.compare-oracles,r4.tolerance-oracles,r4.writer-oracles}.test.ts`, `tests/helpers/r4-draw.ts` (what survives moves), `packages/core-wasm/tests/pdf-export.ts-engine.test.ts`; deps: `@faunosteo/pdf` (app, core-wasm), `pdf-lib` + `tsx` + app `report:compare` script (app), Dockerfile COPY line; `pnpm install` → lockfile without pdf-lib, @pdf-lib/*, @resvg/resvg-js; `@xmldom/xmldom` only under packages/anatomy (R5); `packages/anatomy` render untouched
|
||||
- [x] R4.8c ledger: `scripts/r4-ledger.mjs` reads the frozen 301 cases from the committed TSV (no vitest run of deleted suites), re-derives dispositions (deleted suites → `deleted` with their cargo / vitest target, N-1 switch noted, read-back notes), census: every cargo target in `cargo test --list`, every vitest target in the live report, counts = 301; TSV regenerated
|
||||
- [x] R4.8d non-regression proofs (owner §3): grep census test (no `@faunosteo/pdf`, `pdf-lib`, `@faunosteo/domain` import under apps/app/src, packages/core-wasm/src; the import worker path, the export session path and the root `report:compare` script named by a test), wasm:build, rust-check, pnpm check, pnpm check:all (app image, worker test + image), N-1 reader suites, O2/O3/O7/O8 fixtures still read, 612 leaves, rescue copies and quarantine suites
|
||||
- [x] R4.8e (done 2026-10-19; STOP before R4.9) docs: RUST.md §10.10 (deleted files and packages, dependencies removed, Rust-only features, TS still legitimate with reasons, tests, risks, R5 prerequisites), CLAUDE.md (stack table, map, PDF conventions, workflow lines), DEPLOY.md (module size, rollback), PDF-FORMAT, PDF_IMPORT_HARDENING §5, TEST_STRATEGY, WORKSPACE, packages/README, fixtures README, CHANGELOG (Unreleased), README; memory (BDR, journal); report, STOP before R4.9
|
||||
- [ ] R4.9 verifier + security + owner final acceptance → merge on owner signal
|
||||
- [ ] outside R4 (owner 2026-10-17, non-blocking): worker container ignores SIGTERM (Docker kill after 10 s; chore, e.g. `init: true`); README test counter stale (367 vs 1,015)
|
||||
- [ ] R5 curation pipeline + importer + upload tool: seed golden regenerated once (new `documentSha256`, D-R5), `packages/anatomy` + `packages/domain` deleted, docs map; all before Step 13
|
||||
|
||||
Reference in new issue
Block a user